rspec-matchers-controller_filters 0.0.2 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9b46a7e5fce634af5c3ed5117755a502fa9a0593
-  data.tar.gz: 6fc3d2728a1b707fd7781496acf9335930b7dda1
+  metadata.gz: 6d4924b4b93e05fc59c0e0a60597759e267db63e
+  data.tar.gz: 7f1f530bcfe4bfbe3f8c4f7abf8f2fb05e68f569
 SHA512:
-  metadata.gz: d29ed4e300b76461d678fe85777debc91674f2429e82a40eb0e09732776e4d2db7623638fdfe530356f0b7ea3da1d551b3752d1ee02c28df6104f9b3b3d6a700
-  data.tar.gz: f87f201db6ac2760be2713afdfb2e52bf52eeb273ff14de7c8945b666a7bfdd12e27a0a296353a3cfd195a287ac0473d221b09805941297e40d3c5e10b60b0a1
+  metadata.gz: 3fa04ed7362a952287691533e53d457b7029222eefbf37b8e890292d3d35563deb12ffb67ec9fd3b8b5fe7c8bc3489ec58a672e0409dc18ed4d9baac16a18a52
+  data.tar.gz: 04e7a558f2a2d31967829b4a99692cf76e6f90c433410e438bfb26ce15b3da5ada5a3fb691eb287a37ef064831e5ba4a9a5cb9ba5c50dd3864936cd702042146

data/README.md

@@ -1,6 +1,8 @@
 # Rspec::Matchers::ControllerFilters
 
 Use this gem to test execution of before/around/after filters of controller actions with RSpec.
+
+Here's the general idea of the gem:
 http://www.arubystory.com/2014/10/testing-execution-of-beforefilter-with.html
 
 ## Installation
@@ -24,9 +26,9 @@ Or install it yourself as:
 In your controller specs you may use the new matchers:
 
 ```ruby
-it { should execute_before_filter :your_filter, :on => :your_action, :with => { :parameter_name => 'parameter_value'} }
-it { should_not execute_around_filter :your_filter, :on => :your_action, :with => { :parameter_name => 'parameter_value'} }
-it { should execute_after_filter :your_filter, :on => :your_action, :with => { :parameter_name => 'parameter_value'} }
+it { should execute_before_action :your_filter, :on => :your_action, :with => { :parameter_name => 'parameter_value'} }
+it { should_not execute_around_action :your_filter, :on => :your_action, :with => { :parameter_name => 'parameter_value'} }
+it { should execute_after_action :your_filter, :on => :your_action, :with => { :parameter_name => 'parameter_value'} }
 ```
 
 The **with** parameter is optional.
@@ -39,9 +41,6 @@ The **with** parameter is optional.
 4. Push to the branch (`git push origin my-new-feature`)
 5. Create a new Pull Request
 
-## Important note
-This is my first gem so please:
-1. Use it at your own risk
-2. Any feedback is welcome!
+## License
 
-##### [**Lazarus Lazaridis**](http://twitter.com/arubystory)
+This gem is open source under the [MIT License](https://opensource.org/licenses/MIT) terms.

data/lib/rspec/matchers/controller_filters.rb

@@ -99,6 +99,7 @@ module RSpec
           RSpec::Matchers::ControllerFilters.resolve_failure_message :before, actual, expected, @routing_error, @unexpected_error, true
         end
       end
+      RSpec::Matchers.alias_matcher :execute_before_action, :execute_before_filter
 
       RSpec::Matchers.define :execute_after_filter do |filter_name, options = {}|
         match do |controller|
@@ -143,6 +144,7 @@ module RSpec
           RSpec::Matchers::ControllerFilters.resolve_failure_message :after, actual, expected, @routing_error, @unexpected_error, true
         end
       end
+      RSpec::Matchers.alias_matcher :execute_after_action, :execute_after_filter
 
       RSpec::Matchers.define :execute_around_filter do |filter_name, options = {}|
         match do |controller|
@@ -169,11 +171,11 @@ module RSpec
 
           send(options[:via] || :get, options[:on], options[:with])
           @filter_executed && @action_executed
-        rescue ROUTING_ERROR_CLASS
-          @routing_error = true
-          negated
         rescue RSpec::Matchers::ControllerFilters::FilterFailureError
           false
+        rescue ROUTING_ERROR_CLASS => e
+          @routing_error = e.message
+          negated
         rescue => e
           @unexpected_error = e.message
           negated
@@ -187,6 +189,7 @@ module RSpec
           RSpec::Matchers::ControllerFilters.resolve_failure_message :around, actual, expected, @routing_error, @unexpected_error, true
         end
       end
+      RSpec::Matchers.alias_matcher :execute_around_action, :execute_around_filter
     end
   end
 end

data/lib/rspec/matchers/controller_filters/version.rb

@@ -1,7 +1,7 @@
 module Rspec
   module Matchers
     module ControllerFilters
-      VERSION = '0.0.2'
+      VERSION = '1.0.0'
     end
   end
 end

data/rspec-matchers-controller_filters.gemspec

@@ -7,8 +7,8 @@ Gem::Specification.new do |spec|
   spec.name          = 'rspec-matchers-controller_filters'
   spec.version       = Rspec::Matchers::ControllerFilters::VERSION
   spec.authors       = ['Lazarus Lazaridis']
-  spec.summary       = 'Test execution of before/around/after filters with RSpec'
-  spec.description   = 'This gem defines custom filters that can be used to test execution of filters before, around or after controller actions.'
+  spec.summary       = 'Test execution of before/around/after action filters with RSpec'
+  spec.description   = 'This gem defines custom matchers that can be used to test execution of filters before, around or after controller actions.'
   spec.homepage      = 'https://github.com/iridakos/rspec-matchers-controller_filters'
   spec.license       = 'MIT'
 

data/spec/spec_helper.rb

@@ -4,8 +4,6 @@ Bundler.setup
 require 'action_view'
 require 'action_controller'
 require 'rails'
-require 'rspec/rails/adapters'
-require 'rspec/rails/view_rendering'
-require 'rspec/rails/example/rails_example_group'
-require 'rspec/rails/example/controller_example_group'
+#require 'rspec/rails/adapters'
+#require 'rspec/rails/view_rendering'
 require 'rspec/matchers/controller_filters'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rspec-matchers-controller_filters
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 1.0.0
 platform: ruby
 authors:
 - Lazarus Lazaridis
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-08 00:00:00.000000000 Z
+date: 2016-03-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -58,7 +58,7 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '3.1'
-description: This gem defines custom filters that can be used to test execution of
+description: This gem defines custom matchers that can be used to test execution of
   filters before, around or after controller actions.
 email: 
 executables: []
@@ -95,10 +95,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.6
 signing_key: 
 specification_version: 4
-summary: Test execution of before/around/after filters with RSpec
+summary: Test execution of before/around/after action filters with RSpec
 test_files:
 - spec/rspec/matchers/controller_filters/controller_filters_spec.rb
 - spec/spec_helper.rb