rspec-interactive 0.9.4 → 0.9.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 58b63742b50c16f44d1cf19e2957e29ed07ef4a19c3ee91debed0624f519684a
-  data.tar.gz: 0217f523599d1ee0a104718bd3c2bd79aeaf9366d18a22f5abfdadb2ce1fc229
+  metadata.gz: 19e7c3fad7abad85f3523490ddfcfd3d6091e042d99fd940c6a9a19991e7dc06
+  data.tar.gz: 02d25e506765d4f0c40b8b3e64ae751f6da34e06af9e845830bdc05071fc8112
 SHA512:
-  metadata.gz: 7d5dbf2e0ec74668264fee718f5e2edaa60f0bff510433f376ac8264a64afb61b2a3538e8604f3c8cc4e0c1e48b409bb4bccfaedb25e0b587145d7b9f4abbb11
-  data.tar.gz: 86bba6bf0ad9728ba06d9374a3efb7b74cb4736fb24f5a81799e7ed4d54c499c012153ca2e90096caf0ab3965098c38cccc28b2b9c0d031723e7cc698b0a4fcc
+  metadata.gz: 89b49ff9d0e888b8304e0c70a2fded4dd780381750fed960af5f282246accc6ae6d52eb71c5402d2be31bfb9a827c64e04cffcb7f4935d12d97e3d632843a8bf
+  data.tar.gz: 36320560582c44d1459e0590aa469f56e70b5411d8c3c88a499ca9f46c5075163aa3778869f65bb5cfd85dc3fc7dd196fff65c87733b5b0057352353583215c6

data/.gitignore

@@ -2,3 +2,5 @@ rspec-interactive-*.gem
 .rspec_interactive_history
 .rspec_interactive_config
 .idea
+vendor
+.bundle

data/Gemfile

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-ruby '3.0.0'
-
 source "https://rubygems.org"
 
 gemspec

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    rspec-interactive (0.9.3)
+    rspec-interactive (0.9.6)
       listen
       pry
       rspec-core
@@ -13,6 +13,7 @@ GEM
     coderay (1.1.3)
     diff-lcs (1.4.4)
     ffi (1.15.5)
+    ffi (1.15.5-java)
     listen (3.7.1)
       rb-fsevent (~> 0.10, >= 0.10.3)
       rb-inotify (~> 0.9, >= 0.9.10)
@@ -20,6 +21,10 @@ GEM
     pry (0.14.1)
       coderay (~> 1.1)
       method_source (~> 1.0)
+    pry (0.14.1-java)
+      coderay (~> 1.1)
+      method_source (~> 1.0)
+      spoon (~> 0.0)
     rb-fsevent (0.11.1)
     rb-inotify (0.10.1)
       ffi (~> 1.0)
@@ -38,16 +43,16 @@ GEM
     rspec-support (3.9.4)
     rspec-teamcity (1.0.0)
       rspec (>= 2.99, >= 2.14.2, < 4)
+    spoon (0.0.6)
+      ffi
 
 PLATFORMS
+  universal-java-11
   x86_64-darwin-20
 
 DEPENDENCIES
   rspec-expectations
   rspec-interactive!
 
-RUBY VERSION
-   ruby 3.0.0p0
-
 BUNDLED WITH
    2.2.17

data/lib/rspec-interactive/client_output.rb

@@ -6,7 +6,15 @@ module RSpec
       end
 
       def print(str = "")
-        @client.print(str&.to_s || '')
+        @client.print(str.to_s)
+      end
+
+      def write(str = "")
+        @client.print(str.to_s)
+      end
+
+      def puts(str = "")
+        @client.print(str.to_s + "\n")
       end
 
       def string

data/lib/rspec-interactive/pry.rb

@@ -4,7 +4,7 @@ class Pry
   alias_method :old_eval, :eval
 
   def eval(line, options = {})
-    RSpec::Interactive.eval do
+    RSpec::Interactive.eval(line, options) do
       old_eval(line, options)
     end
   end

data/lib/rspec-interactive/stdio.rb

@@ -1,10 +1,18 @@
 module RSpec
   module Interactive
     class Stdio
-      def self.capture(output)
+      def self.capture2(stdout:, stderr:)
+        old_stdout, old_stderr = $stdout, $stderr
+        $stdout, $stderr = stdout, stderr
+        yield
+      ensure
+        $stdout, $stderr = old_stdout, old_stderr
+      end
+
+      def self.capture(stdout:, stderr:)
         raise ArgumentError, 'missing block' unless block_given?
 
-        stdout, stderr = STDOUT.dup, STDERR.dup
+        old_stdout, old_stderr = STDOUT.dup, STDERR.dup
 
         IO.pipe do |stdout_read, stdout_write|
           IO.pipe do |stderr_read, stderr_write|
@@ -16,13 +24,13 @@ module RSpec
 
             stdout_thread = Thread.new do
               while line = stdout_read.gets do
-                output.print(line)
+                stdout.print(line)
               end
             end
 
             stderr_thread = Thread.new do
               while line = stderr_read.gets do
-                output.print(line)
+                stderr.print(line)
               end
             end
 
@@ -30,8 +38,8 @@ module RSpec
               yield
             ensure
               # TODO: should the threads be killed here?
-              STDOUT.reopen stdout
-              STDERR.reopen stderr
+              STDOUT.reopen old_stdout
+              STDERR.reopen old_stderr
             end
 
             stdout_thread.join

data/lib/rspec-interactive/string_output.rb

@@ -0,0 +1,23 @@
+module RSpec
+  module Interactive
+    class StringOutput
+      attr_reader :string
+
+      def initialize
+        @string = ''
+      end
+
+      def write(name, str = "")
+        @string += str.to_s
+      end
+
+      def puts(str = "")
+        @string += str.to_s + "\n"
+      end
+
+      def print(str = "")
+        @string += str.to_s
+      end
+    end
+  end
+end

data/lib/rspec-interactive/version.rb

@@ -2,6 +2,6 @@
 
 module RSpec
   module Interactive
-    VERSION = "0.9.4"
+    VERSION = "0.9.7"
   end
 end

data/lib/rspec-interactive.rb

@@ -18,6 +18,7 @@ require 'rspec-interactive/rspec_core_example'
 require 'rspec-interactive/rubo_cop_command'
 require 'rspec-interactive/runner'
 require 'rspec-interactive/stdio'
+require 'rspec-interactive/string_output'
 
 module RSpec
   module Interactive
@@ -56,29 +57,30 @@ module RSpec
       load config_file if config_file
 
       check_rails
-      trap_interrupt
+      maybe_trap_interrupt
       configure_pry
-      load_rspec_configuration
 
-      start_file_watcher
-
-      if server
-        @output_stream.puts "listening on port #{port}"
-        server_thread = Thread.start do
-          server = TCPServer.new port
-
-          while client = server.accept
-            request = client.gets
-            args = Shellwords.split(request)
-            rspec_for_server(client, args)
-            client.close
+      @startup_thread = Thread.start do
+        @config_cache.record_configuration { @configuration.configure_rspec.call }
+        start_file_watcher
+
+        if server
+          @server_thread = Thread.start do
+            server = TCPServer.new port
+
+            while client = server.accept
+              request = client.gets
+              args = Shellwords.split(request)
+              rspec_for_server(client, args)
+              client.close
+            end
           end
         end
       end
 
       Pry.start
       @listener.stop if @listener
-      server_thread.exit if server_thread
+      @server_thread.exit if @server_thread
       0
     end
 
@@ -90,7 +92,17 @@ module RSpec
       end
     end
 
-    def self.trap_interrupt
+    def self.maybe_trap_interrupt
+      return unless RbConfig::CONFIG['ruby_install_name'] == 'jruby'
+
+      # When on JRuby, Pry traps interrupts and raises an Interrupt exception.
+      # Unfortunately, raising Interrupt is not enough when RSpec is running since it
+      # will only cause the current example to fail. We want to kill RSpec entirely
+      # if it is running so here we disable Pry's handling and rewrite it to include
+      # special handling for RSpec.
+
+      Pry.config.should_trap_interrupts = false
+
       trap('INT') do
         if @runner
           # We are on a different thread. There is a race here. Ignore nil.
@@ -113,24 +125,7 @@ module RSpec
       @listener.start
     end
 
-    def self.load_rspec_configuration
-      start_time = Process.clock_gettime(Process::CLOCK_MONOTONIC)
-      config_thread = Thread.start do
-        @config_cache.record_configuration { @configuration.configure_rspec.call }
-      end
-      unless config_thread.join(3)
-        @output_stream.puts "executing configure_rspec hook..."
-      end
-      config_thread.join
-
-      end_time = Process.clock_gettime(Process::CLOCK_MONOTONIC)
-      @output_stream.puts "configure_rspec hook took #{(end_time - start_time).round} seconds" if end_time - start_time > 5
-    end
-
     def self.configure_pry
-      # Prevent Pry from trapping too. It will break ctrl-c handling.
-      Pry.config.should_trap_interrupts = false
-
       # Set up IO.
       Pry.config.input = Readline
       Pry.config.output = @output_stream
@@ -161,14 +156,24 @@ module RSpec
     end
 
     def self.parse_args(args)
-      args.flat_map do |arg|
-        if arg.match(/[\*\?\[]/)
-          glob = Dir.glob(arg)
-          glob.empty? ? [arg] : glob
+      i = 0
+      parsed_args = []
+      until i == args.length
+        case args[i]
+        when /[\*\?\[]/
+          glob = Dir.glob(args[i])
+          parsed_args.concat(glob.empty? ? args[i] : glob)
+        when '--pattern'
+          # RubyMine passes --pattern when running all specs in a dir.
+          # We don't want to expand this since it is used as a glob by RSpec.
+          parsed_args.concat(args[i..(i + 1)])
+          i += 1
         else
-          [arg]
+          parsed_args << args[i]
         end
+        i += 1
       end
+      parsed_args
     end
 
     def self.rspec(args)
@@ -187,7 +192,8 @@ module RSpec
       end
 
       # Run.
-      exit_code = @runner.run
+      @runner.run
+    ensure
       @runner = nil
 
       # Reenable history
@@ -197,18 +203,17 @@ module RSpec
       RSpec.clear_examples
       RSpec.reset
       @config_cache.replay_configuration
-    ensure
-      @runner = nil
     end
 
     def self.rspec_for_server(client, args)
       @command_mutex.synchronize do
-        # Prevent the debugger from being used. The server isn't interactive.
+        output = ClientOutput.new(client)
         disable_pry = ENV['DISABLE_PRY']
-        ENV['DISABLE_PRY'] = 'true'
 
-        output = ClientOutput.new(client)
-        Stdio.capture(ClientOutput.new(client)) do
+        Stdio.capture(stdout: output, stderr: output) do
+          # Prevent the debugger from being used. The server isn't interactive.
+          ENV['DISABLE_PRY'] = 'true'
+
           @runner = RSpec::Interactive::Runner.new(parse_args(args))
 
           refresh
@@ -232,15 +237,16 @@ module RSpec
           RSpec.configuration.formatter = Spec::Runner::Formatter::TeamcityFormatter
 
           # Run.
-          exit_code = @runner.run
+          @runner.run
+        ensure
+          @runner = nil
+          ENV['DISABLE_PRY'] = disable_pry
 
           # Reset
           RSpec.clear_examples
           RSpec.reset
           @config_cache.replay_configuration
         end
-      ensure
-        ENV['DISABLE_PRY'] = disable_pry
       end
     end
 
@@ -252,12 +258,19 @@ module RSpec
       end
     end
 
-    def self.eval(&block)
-      if Thread.current.thread_variable_get('holding_lock')
+    def self.eval(line, options, &block)
+      if line.nil? || Thread.current.thread_variable_get('holding_lock')
         yield
       else
         @command_mutex.synchronize do
           Thread.current.thread_variable_set('holding_lock', true)
+          if @startup_thread
+            if @startup_thread.alive?
+              @output_stream.puts 'waiting for configure_rspec...'
+            end
+            @startup_thread.join
+            @startup_thread = nil
+          end
           yield
         ensure
           Thread.current.thread_variable_set('holding_lock', false)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rspec-interactive
 version: !ruby/object:Gem::Version
-  version: 0.9.4
+  version: 0.9.7
 platform: ruby
 authors:
 - Nick Dower
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-02-25 00:00:00.000000000 Z
+date: 2022-02-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec-core
@@ -102,6 +102,7 @@ files:
 - lib/rspec-interactive/rubo_cop_command.rb
 - lib/rspec-interactive/runner.rb
 - lib/rspec-interactive/stdio.rb
+- lib/rspec-interactive/string_output.rb
 - lib/rspec-interactive/version.rb
 - lib/teamcity/spec/runner/formatter/teamcity/formatter.rb
 - rspec-interactive.gemspec