rspec-hive 0.4.2 → 0.6.0

data/spec/lib/rspec/hive/db_name_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 RSpec.describe RSpec::Hive::DbName do
@@ -5,8 +7,8 @@ RSpec.describe RSpec::Hive::DbName do
     subject { described_class.random_name }
 
     before do
-      allow(described_class).to receive(:timestamp) { 'timestamp' }
-      allow(described_class).to receive(:random_key) { 'randomKey' }
+      allow(described_class).to receive(:timestamp).and_return('timestamp')
+      allow(described_class).to receive(:random_key).and_return('randomKey')
     end
 
     it { is_expected.to eq('timestamp_randomKey') }

data/spec/lib/rspec/hive/matchers_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'rspec/hive/query_builder_helper'
 

data/spec/lib/rspec/hive/query_builder/row_transformer_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 RSpec.describe RSpec::Hive::QueryBuilder::RowTransformer do
@@ -13,7 +15,7 @@ RSpec.describe RSpec::Hive::QueryBuilder::RowTransformer do
   let(:missing_column_strategy) { double }
 
   describe '#transform' do
-    subject { transformer.transform(row) }
+    subject(:transformed_rows) { transformer.transform(row) }
 
     let(:row) { {col1: real_value} }
     let(:real_value) { 'col1' }
@@ -23,15 +25,15 @@ RSpec.describe RSpec::Hive::QueryBuilder::RowTransformer do
     before { allow(missing_column_strategy).to receive(:missing).with(column).and_return(fake_value) }
 
     it 'fills missing fields' do
-      expect(subject[1]).to eq(fake_value)
+      expect(transformed_rows[1]).to eq(fake_value)
     end
 
     it 'uses defined fields' do
-      expect(subject[0]).to eq(real_value)
+      expect(transformed_rows[0]).to eq(real_value)
     end
 
     it 'returns valid Rows' do
-      expect(subject).to eq(expected_row)
+      is_expected.to eq(expected_row)
     end
   end
 end

data/spec/lib/rspec/hive/query_builder_helper_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 RSpec.describe RSpec::Hive::QueryBuilderHelper do
@@ -17,20 +19,22 @@ RSpec.describe RSpec::Hive::QueryBuilderHelper do
     end
 
     context 'when RBhive connection has been given' do
+      subject { dummy_class.into_hive(schema) }
+
       let(:dummy_class) { double(connection: connection) }
 
       before do
         allow(connection).to receive(:is_a?).with(RBHive::TCLIConnection).and_return(true)
       end
 
-      subject { dummy_class.into_hive(schema) }
-
       it 'returns a query_builder' do
-        expect(subject).to be_a_kind_of(RSpec::Hive::QueryBuilder)
+        is_expected.to be_a_kind_of(RSpec::Hive::QueryBuilder)
       end
     end
 
     context 'when ConnectionDelegator has been given' do
+      subject { dummy_class.into_hive(schema) }
+
       let(:dummy_class) { double(connection: connection) }
 
       before do
@@ -38,10 +42,8 @@ RSpec.describe RSpec::Hive::QueryBuilderHelper do
         allow(connection).to receive(:is_a?).with(RSpec::Hive::ConnectionDelegator).and_return(true)
       end
 
-      subject { dummy_class.into_hive(schema) }
-
       it 'returns a query_builder' do
-        expect(subject).to be_a_kind_of(RSpec::Hive::QueryBuilder)
+        is_expected.to be_a_kind_of(RSpec::Hive::QueryBuilder)
       end
     end
   end

data/spec/lib/rspec/hive/query_builder_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 RSpec.describe RSpec::Hive::QueryBuilder do
@@ -7,7 +9,7 @@ RSpec.describe RSpec::Hive::QueryBuilder do
   let(:schema) { double }
 
   describe '#execute' do
-    subject { builder.execute }
+    subject(:execute) { builder.execute }
 
     context 'when has no partition' do
       before do
@@ -28,7 +30,7 @@ RSpec.describe RSpec::Hive::QueryBuilder do
           let(:expected_rows) { [row1] }
 
           it 'loads single row' do
-            subject
+            execute
           end
         end
 
@@ -38,7 +40,7 @@ RSpec.describe RSpec::Hive::QueryBuilder do
           let(:expected_rows) { [row1 << '\N'] }
 
           it 'fills missing columns with \N' do
-            subject
+            execute
           end
         end
 
@@ -49,7 +51,7 @@ RSpec.describe RSpec::Hive::QueryBuilder do
           let(:expected_rows) { [row1, row2] }
 
           it 'loads multiple rows' do
-            subject
+            execute
           end
         end
 
@@ -59,7 +61,7 @@ RSpec.describe RSpec::Hive::QueryBuilder do
           let(:expected_rows) { [['col1', '\N']] }
 
           it 'fills missing columns with \N' do
-            subject
+            execute
           end
         end
 
@@ -70,7 +72,7 @@ RSpec.describe RSpec::Hive::QueryBuilder do
           let(:expected_rows) { [['col1', '\N'], ['\N', 345]] }
 
           it 'fills missing columns with \N for each row' do
-            subject
+            execute
           end
         end
       end
@@ -82,7 +84,7 @@ RSpec.describe RSpec::Hive::QueryBuilder do
           let(:expected_rows) { [row1] }
 
           it 'loads single row' do
-            subject
+            execute
           end
         end
 
@@ -92,7 +94,7 @@ RSpec.describe RSpec::Hive::QueryBuilder do
           let(:expected_rows) { [row1 << a_string_matching(/\d+/)] }
 
           it 'fills missing column with data matching column type' do
-            subject
+            execute
           end
         end
 
@@ -103,7 +105,7 @@ RSpec.describe RSpec::Hive::QueryBuilder do
           let(:expected_rows) { [row1, row2] }
 
           it 'loads multiple rows' do
-            subject
+            execute
           end
         end
 
@@ -113,7 +115,7 @@ RSpec.describe RSpec::Hive::QueryBuilder do
           let(:expected_rows) { [['col1', a_string_matching(/\d+/)]] }
 
           it 'fills missing columns with data matching column type' do
-            subject
+            execute
           end
         end
 
@@ -124,7 +126,7 @@ RSpec.describe RSpec::Hive::QueryBuilder do
           let(:expected_rows) { [['col1', a_string_matching(/\d+/)], [a_string_matching(/\S+/), 345]] }
 
           it 'fills missing columns with data matching column type for each row' do
-            subject
+            execute
           end
         end
       end
@@ -139,11 +141,6 @@ RSpec.describe RSpec::Hive::QueryBuilder do
         end
       end
 
-      before do
-        expect(connection_delegator).
-          to receive(:load_into_table).with(schema, expected_rows, partitions)
-      end
-
       context 'when no data stubbing' do
         context 'when single row is passed' do
           let(:builder) { query_builder.insert(row1).partition(partitions) }
@@ -152,7 +149,8 @@ RSpec.describe RSpec::Hive::QueryBuilder do
           let(:expected_rows) { [row1] }
 
           it 'loads single row' do
-            subject
+            expect(connection_delegator).to receive(:load_into_table).with(schema, expected_rows, partitions)
+            execute
           end
         end
       end

data/spec/lib/rspec/hive_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 RSpec.describe RSpec::Hive do
@@ -10,15 +12,15 @@ RSpec.describe RSpec::Hive do
   describe '.configure' do
     let(:expected_host) { '127.0.0.1' }
     let(:expected_port) { '10000' }
-    let(:expected_host_shared_directory_path) do
-      '/Users/Shared/tmp/spec-files'
-    end
+    let(:expected_host_shared_directory_path) { '/Users/Shared/tmp/spec-files' }
     let(:expected_docker_shared_directory_path) { '/tmp/spec-tmp-files' }
 
     context 'when file name is provided' do
+      subject(:configure) { described_class.configure(file_name) }
+
       let(:file_name) { 'test.yaml' }
       let(:configuration_mock) do
-        double(
+        instance_double(
           described_class::Configuration,
           host: expected_host,
           port: expected_port,
@@ -27,21 +29,16 @@ RSpec.describe RSpec::Hive do
         )
       end
 
-      before do
-        expect(described_class).to receive(:new_configuration).
-          with(file_name) { configuration_mock }
-      end
-
-      subject { described_class.configure(file_name) }
+      before { allow(RSpec::Hive::Configuration).to receive(:new).with(file_name) { configuration_mock } }
 
+      specify do
+        expect(described_class).to receive(:new_configuration).with(file_name) { configuration_mock }
+        configure
+      end
       its(:host) { is_expected.to eq(expected_host) }
       its(:port) { is_expected.to eq(expected_port) }
-      its(:host_shared_directory_path) do
-        is_expected.to eq(expected_host_shared_directory_path)
-      end
-      its(:docker_shared_directory_path) do
-        is_expected.to eq(expected_docker_shared_directory_path)
-      end
+      its(:host_shared_directory_path) { is_expected.to eq(expected_host_shared_directory_path) }
+      its(:docker_shared_directory_path) { is_expected.to eq(expected_docker_shared_directory_path) }
     end
 
     context 'when block is given' do
@@ -58,12 +55,8 @@ RSpec.describe RSpec::Hive do
 
       its(:host) { is_expected.to eq(expected_host) }
       its(:port) { is_expected.to eq(expected_port) }
-      its(:host_shared_directory_path) do
-        is_expected.to eq(expected_host_shared_directory_path)
-      end
-      its(:docker_shared_directory_path) do
-        is_expected.to eq(expected_docker_shared_directory_path)
-      end
+      its(:host_shared_directory_path) { is_expected.to eq(expected_host_shared_directory_path) }
+      its(:docker_shared_directory_path) { is_expected.to eq(expected_docker_shared_directory_path) }
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rspec-hive
 version: !ruby/object:Gem::Version
-  version: 0.4.2
+  version: 0.6.0
 platform: ruby
 authors:
 - Wojtek Mielczarek
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-15 00:00:00.000000000 Z
+date: 2017-10-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -20,7 +20,7 @@ dependencies:
         version: '10.0'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '12.0'
+        version: '13.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -30,21 +30,21 @@ dependencies:
         version: '10.0'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '12.0'
+        version: '13.0'
 - !ruby/object:Gem::Dependency
   name: colorize
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.7'
+        version: 0.8.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.7'
+        version: 0.8.0
 - !ruby/object:Gem::Dependency
   name: faker
   requirement: !ruby/object:Gem::Requirement
@@ -65,14 +65,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.0.3
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.0.3
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -93,154 +93,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: '1.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.0.0
-- !ruby/object:Gem::Dependency
-  name: bundler
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.7'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.7'
-- !ruby/object:Gem::Dependency
-  name: rspec-its
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.2'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.2'
-- !ruby/object:Gem::Dependency
-  name: rubocop
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.39'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.39'
-- !ruby/object:Gem::Dependency
-  name: rubocop-rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.4'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.4'
-- !ruby/object:Gem::Dependency
-  name: guard
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.6'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.6'
-- !ruby/object:Gem::Dependency
-  name: guard-rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '4.3'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '4.3'
-- !ruby/object:Gem::Dependency
-  name: guard-rubocop
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.2'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.2'
-- !ruby/object:Gem::Dependency
-  name: codeclimate-test-reporter
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.4'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.4'
-- !ruby/object:Gem::Dependency
-  name: pry
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: pry-byebug
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.0'
 description: |-
   RSpecHive let you test your hive queries
                           connecting to hive instance installed on docker
@@ -255,7 +115,7 @@ files:
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
-- ".rubocop_u2i.yml"
+- ".rubocop_todo.yml"
 - ".ruby-version"
 - ".travis.yml"
 - Gemfile
@@ -265,6 +125,7 @@ files:
 - README.md
 - Rakefile
 - docker/Dockerfile
+- docker/hive-site.xml
 - examples/lib/query.rb
 - examples/rspec-hive.yml.example
 - examples/spec/query_spec.rb
@@ -287,7 +148,6 @@ files:
 - lib/rspec/hive/version.rb
 - lib/rspec/hive/with_hive_connection.rb
 - rspec-hive.gemspec
-- spec/.rubocop.yml
 - spec/lib/rspec/hive/configuration_spec.rb
 - spec/lib/rspec/hive/connection_delegator_spec.rb
 - spec/lib/rspec/hive/connector_spec.rb
@@ -318,12 +178,11 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.3
+rubygems_version: 2.6.13
 signing_key: 
 specification_version: 4
 summary: RSpec addition to test hive queries
 test_files:
-- spec/.rubocop.yml
 - spec/lib/rspec/hive/configuration_spec.rb
 - spec/lib/rspec/hive/connection_delegator_spec.rb
 - spec/lib/rspec/hive/connector_spec.rb