rspec-expectations 3.9.0 → 3.9.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d8cb915ab51f5b587fcbaa864e697cc291ff3c1f49afd8d829837c1a9c4c4f6b
-  data.tar.gz: 6aa770883cacbfcf2921074a98506a0a789b4557ee6a7ea79738f008107e582d
+  metadata.gz: 18fe83413ef95c1cba358df490f7a8df578da2fd556853a7b043f45b5a28f301
+  data.tar.gz: '0486c1b3cc729a742b7630c28c299053a9eddae5bdc71092a40d285e9f14780b'
 SHA512:
-  metadata.gz: fc2669ca822767874cc62c9e7cef32040f90da7cd0d4c13b1bd97fde68230f7f7019a8b717e2ebfcd223da5b9e25aaa60270c0797ba4d304def5e4ae3bb63f03
-  data.tar.gz: e9d7a9e1b186c1eee547c315f177181992f5be9e35c61a16a041d97901537d054943a779e0d6bd7f2502e51a1fcbf95f0f6a10eab46fcdd85bebd8be1170a369
+  metadata.gz: 1b9d208174a3a192557c3f14b54a2ca2074d48b50e532a260008168a7aa504b8c9dc7af09dca75093d4f95f32a38c2e805fb561f56cc1d1416d35753de37fc85
+  data.tar.gz: 02360020651abb0aa4beb421415e3b23d4df072b20e8b5ae5dee16830f503a5c81741c72e336b9491915e896dd04eb57f32445e46f96a68702f73978226bc0a2

data/Changelog.md

@@ -1,5 +1,13 @@
-### 3.9.0 / 2019-10-02
-[Full Changelog](http://github.com/rspec/rspec-expectations/compare/v3.8.5...v3.9.0)
+### 3.9.1 / 2020-03-13
+[Full Changelog](http://github.com/rspec/rspec-expectations/compare/v3.9.0...v3.9.1)
+
+Bug Fixes:
+
+* Issue an improved warning when using `respond_to(...).with(n).arguments` and ignore
+  the warning when using with `have_attributes(...)`. (Jon Rowe, #1164)
+
+### 3.9.0 / 2019-10-08
+[Full Changelog](http://github.com/rspec/rspec-expectations/compare/v3.8.6...v3.9.0)
 
 Enhancements:
 

data/lib/rspec/expectations/version.rb

@@ -2,7 +2,7 @@ module RSpec
   module Expectations
     # @private
     module Version
-      STRING = '3.9.0'
+      STRING = '3.9.1'
     end
   end
 end

data/lib/rspec/matchers/built_in/have_attributes.rb

@@ -93,7 +93,7 @@ module RSpec
         end
 
         def respond_to_matcher
-          @respond_to_matcher ||= RespondTo.new(*expected.keys).with(0).arguments
+          @respond_to_matcher ||= RespondTo.new(*expected.keys).with(0).arguments.tap { |m| m.ignoring_method_signature_failure! }
         end
 
         def respond_to_failure_message_or

data/lib/rspec/matchers/built_in/respond_to.rb

@@ -1,5 +1,7 @@
 RSpec::Support.require_rspec_support "method_signature_verifier"
 
+# TODO: Refactor this file to be under our class length
+# rubocop:disable ClassLength
 module RSpec
   module Matchers
     module BuiltIn
@@ -11,6 +13,7 @@ module RSpec
           @names = names
           @expected_arity = nil
           @expected_keywords = []
+          @ignoring_method_signature_failure = false
           @unlimited_arguments = nil
           @arbitrary_keywords = nil
         end
@@ -100,6 +103,12 @@ module RSpec
           "respond to #{pp_names}#{with_arity}"
         end
 
+        # @api private
+        # Used by other matchers to suppress a check
+        def ignoring_method_signature_failure!
+          @ignoring_method_signature_failure = true
+        end
+
       private
 
         def find_failing_method_names(actual, filter_method)
@@ -109,7 +118,7 @@ module RSpec
           end
         end
 
-        def matches_arity?(actual, name)
+        def setup_method_signature_expectation
           expectation = Support::MethodSignatureExpectation.new
 
           if @expected_arity.is_a?(Range)
@@ -123,10 +132,25 @@ module RSpec
           expectation.expect_unlimited_arguments = @unlimited_arguments
           expectation.expect_arbitrary_keywords  = @arbitrary_keywords
 
+          expectation
+        end
+
+        def matches_arity?(actual, name)
+          expectation = setup_method_signature_expectation
+
           return true if expectation.empty?
 
-          Support::StrictSignatureVerifier.new(method_signature_for(actual, name)).
-            with_expectation(expectation).valid?
+          begin
+            Support::StrictSignatureVerifier.new(method_signature_for(actual, name)).
+              with_expectation(expectation).valid?
+          rescue NameError
+            return true if @ignoring_method_signature_failure
+            raise ArgumentError, "The #{matcher_name} matcher requires that " \
+                                 "the actual object define the method(s) in " \
+                                 "order to check arity, but the method " \
+                                 "`#{name}` is not defined. Remove the arity " \
+                                 "check or define the method to continue."
+          end
         end
 
         def method_signature_for(actual, name)
@@ -172,3 +196,4 @@ module RSpec
     end
   end
 end
+# rubocop:enable ClassLength

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rspec-expectations
 version: !ruby/object:Gem::Version
-  version: 3.9.0
+  version: 3.9.1
 platform: ruby
 authors:
 - Steven Baker
@@ -45,7 +45,7 @@ cert_chain:
   ZsVDj6a7lH3cNqtWXZxrb2wO38qV5AkYj8SQK7Hj3/Yui9myUX3crr+PdetazSqQ
   F3MdtaDehhjC
   -----END CERTIFICATE-----
-date: 2019-10-07 00:00:00.000000000 Z
+date: 2020-03-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec-support
@@ -202,7 +202,7 @@ licenses:
 - MIT
 metadata:
   bug_tracker_uri: https://github.com/rspec/rspec-expectations/issues
-  changelog_uri: https://github.com/rspec/rspec-expectations/blob/v3.9.0/Changelog.md
+  changelog_uri: https://github.com/rspec/rspec-expectations/blob/v3.9.1/Changelog.md
   documentation_uri: https://rspec.info/documentation/
   mailing_list_uri: https://groups.google.com/forum/#!forum/rspec
   source_code_uri: https://github.com/rspec/rspec-expectations
@@ -222,8 +222,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.6
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
-summary: rspec-expectations-3.9.0
+summary: rspec-expectations-3.9.1
 test_files: []