rspec-expectations 3.8.2 → 3.8.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6894036d2c3468b781a1a264a637930e11a60362003dd6ecaf05905bb9d3ed44
-  data.tar.gz: 43fce45f3193b59a1559b08125a602d5ad12089e5fdd321b5dbc3d149f88b7cc
+  metadata.gz: 35a04d20c51a45fbf58b5bf8ccdcd5d86f4e2c106aee9906afd3d3bb8e417b62
+  data.tar.gz: 3c8218a13a68549fc5df77a74584d87fa71d954058f61bd1710bc8aeeddc2bfd
 SHA512:
-  metadata.gz: a50144ac2b3dd7e620766173e25ffe5ff6bcd5f8b71c65eacfb3d4c975eb6c2a80c47be786e3727b316b53883a3e4c47db4a0adff8cc20befeb0d0ecb98fe941
-  data.tar.gz: a964fb2ed34b703b6cb2f17efe3153c1422a45202376f4cdd5b2e3bd4847065de186464684c3aaf9d83a746eede227be226e3de5b0c5267f11b791d3499efaf2
+  metadata.gz: f196ef51fc2f48e4d5dd5a685b0847f797c5ef8e0de9b294873dbcadbcb2f2fb1574ef1662052f2e127083195a149ae604a95f5725cd879f912d586be2b37d8f
+  data.tar.gz: 93a6786e1205e5baddad562b0162de3452b9659a73f7a566e40a1c7c7b93d60637b64db27a366056b93a1a6187436feddd3a0eb80507ed69a37b8a6747bc23e2

data/Changelog.md

@@ -1,3 +1,19 @@
+### Development
+[Full Changelog](http://github.com/rspec/rspec-expectations/compare/v3.8.3...3-8-maintenance)
+
+### 3.8.3 / 2019-04-20
+[Full Changelog](http://github.com/rspec/rspec-expectations/compare/v3.8.2...v3.8.3)
+
+Bug Fixes:
+
+* Prevent composed `all` matchers from leaking into their siblings leading to duplicate
+  failures. (Jamie English, #1086)
+* Prevent objects which change their hash on comparison from failing change checks.
+  (Phil Pirozhkov, #1110)
+* Issue an `ArgumentError` rather than a `NoMethodError` when `be_an_instance_of` and
+  `be_kind_of` matchers encounter objects not supporting those methods.
+  (Taichi Ishitani, #1107)
+
 ### 3.8.2 / 2018-10-09
 [Full Changelog](http://github.com/rspec/rspec-expectations/compare/v3.8.1...v3.8.2)
 

data/lib/rspec/expectations/version.rb

@@ -2,7 +2,7 @@ module RSpec
   module Expectations
     # @private
     module Version
-      STRING = '3.8.2'
+      STRING = '3.8.3'
     end
   end
 end

data/lib/rspec/matchers/built_in/all.rb

@@ -73,6 +73,7 @@ module RSpec
 
         def initialize_copy(other)
           @matcher = @matcher.clone
+          @failed_objects = @failed_objects.clone
           super
         end
 

data/lib/rspec/matchers/built_in/be_instance_of.rb

@@ -14,7 +14,17 @@ module RSpec
       private
 
         def match(expected, actual)
-          actual.instance_of? expected
+          if actual_object_respond_to?(actual, :instance_of?)
+            actual.instance_of?(expected)
+          else
+            raise ::ArgumentError, "The #{matcher_name} matcher requires that " \
+                                   "the actual object responds to #instance_of? method " \
+                                   "but it does not respond to the method."
+          end
+        end
+
+        def actual_object_respond_to?(actual, method)
+          ::Kernel.instance_method(:respond_to?).bind(actual).call(method)
         end
       end
     end

data/lib/rspec/matchers/built_in/be_kind_of.rb

@@ -8,7 +8,19 @@ module RSpec
       private
 
         def match(expected, actual)
-          actual.kind_of? expected
+          if actual_object_respond_to?(actual, :kind_of?)
+            actual.kind_of?(expected)
+          elsif actual_object_respond_to?(actual, :is_a?)
+            actual.is_a?(expected)
+          else
+            raise ::ArgumentError, "The #{matcher_name} matcher requires that " \
+                                   "the actual object responds to either #kind_of? or #is_a? methods "\
+                                   "but it responds to neigher of two methods."
+          end
+        end
+
+        def actual_object_respond_to?(actual, method)
+          ::Kernel.instance_method(:respond_to?).bind(actual).call(method)
         end
       end
     end

data/lib/rspec/matchers/built_in/change.rb

@@ -373,6 +373,7 @@ module RSpec
           event_proc.call
 
           @actual_after = evaluate_value_proc
+          @actual_hash = @actual_after.hash
           true
         end
 
@@ -387,8 +388,9 @@ module RSpec
           #
           # Note that it is not sufficient to only check the hashes; it is
           # possible for two values to be unequal (and of different classes)
-          # but to return the same hash value.
-          @actual_before != @actual_after || @before_hash != @actual_after.hash
+          # but to return the same hash value. Also, some objects may change
+          # their hash after being compared with `==`/`!=`.
+          @actual_before != @actual_after || @before_hash != @actual_hash
         end
 
         def actual_delta

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rspec-expectations
 version: !ruby/object:Gem::Version
-  version: 3.8.2
+  version: 3.8.3
 platform: ruby
 authors:
 - Steven Baker
@@ -45,7 +45,7 @@ cert_chain:
   ZsVDj6a7lH3cNqtWXZxrb2wO38qV5AkYj8SQK7Hj3/Yui9myUX3crr+PdetazSqQ
   F3MdtaDehhjC
   -----END CERTIFICATE-----
-date: 2018-10-09 00:00:00.000000000 Z
+date: 2019-04-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec-support
@@ -200,7 +200,12 @@ files:
 homepage: https://github.com/rspec/rspec-expectations
 licenses:
 - MIT
-metadata: {}
+metadata:
+  bug_tracker_uri: https://github.com/rspec/rspec-expectations/issues
+  changelog_uri: https://github.com/rspec/rspec-expectations/blob/v3.8.3/Changelog.md
+  documentation_uri: https://rspec.info/documentation/
+  mailing_list_uri: https://groups.google.com/forum/#!forum/rspec
+  source_code_uri: https://github.com/rspec/rspec-expectations
 post_install_message: 
 rdoc_options:
 - "--charset=UTF-8"
@@ -217,9 +222,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
-summary: rspec-expectations-3.8.2
+summary: rspec-expectations-3.8.3
 test_files: []