rspec-expectations 2.13.0 → 2.99.0

data/spec/rspec/matchers/raise_error_spec.rb

@@ -1,5 +1,18 @@
 require 'spec_helper'
 
+module WrapDeprecationCallSite
+  def expect_deprecation_with_call_site(file, line)
+    actual_call_site = nil
+    allow(RSpec.configuration.reporter).to receive(:deprecation) do |options|
+      actual_call_site = options[:call_site]
+    end
+
+    yield
+
+    expect(actual_call_site).to match([file, line].join(':'))
+  end
+end
+
 describe "expect { ... }.to raise_error" do
   it_behaves_like("an RSpec matcher", :valid_value => lambda { raise "boom" },
                                       :invalid_value => lambda { }) do
@@ -10,6 +23,25 @@ describe "expect { ... }.to raise_error" do
     expect {raise}.to raise_error
   end
 
+  it "passes if an error instance is expected" do
+    s = StandardError.new
+    expect {raise s}.to raise_error(s)
+  end
+
+  it "fails if a different error instance is thrown from the one that is expected" do
+    s = StandardError.new("Error 1")
+    to_raise = StandardError.new("Error 2")
+    expect do
+      expect {raise to_raise}.to raise_error(s)
+    end.to fail_with(Regexp.new("expected #{s.inspect}, got #{to_raise.inspect} with backtrace"))
+  end
+
+  it "passes if an error class is expected and an instance of that class is thrown" do
+    s = StandardError.new :bees
+
+    expect { raise s }.to raise_error(StandardError)
+  end
+
   it "fails if nothing is raised" do
     expect {
       expect {}.to raise_error
@@ -29,7 +61,7 @@ describe "expect { ... }.to raise_error {|err| ... }" do
     expect { non_existent_method }.to raise_error {|e|
       ran = true
     }
-    expect(ran).to be_true
+    expect(ran).to be_truthy
   end
 
   it "passes the error to the block" do
@@ -41,36 +73,53 @@ describe "expect { ... }.to raise_error {|err| ... }" do
   end
 end
 
-describe "expect { ... }.to_not raise_error" do
-  it "passes if nothing is raised" do
-    expect {}.to_not raise_error
-  end
+describe "expect { ... }.not_to raise_error" do
 
-  it "fails if anything is raised" do
-    expect {
-      expect { raise RuntimeError, "example message" }.to_not raise_error
-    }.to fail_with(/expected no Exception, got #<RuntimeError: example message>/)
+  context "with a specific error class" do
+    it "is deprecated" do
+      RSpec.should_receive :deprecate
+      expect {"bees"}.not_to raise_error(RuntimeError)
+    end
   end
 
-  it 'includes the backtrace of the error that was raised in the error message' do
-    expect {
-      expect { raise "boom" }.not_to raise_error
-    }.to raise_error { |e|
-      backtrace_line = "#{File.basename(__FILE__)}:#{__LINE__ - 2}"
-      expect(e.message).to include("with backtrace", backtrace_line)
-    }
-  end
+  context "with no specific error class" do
+    it "is not deprecated" do
+      run = nil
+      allow(RSpec).to receive(:deprecate) { run = true }
+      expect {"bees"}.not_to raise_error
+      expect(run).to be_nil
+    end
 
-  it 'formats the backtrace using the configured backtrace formatter' do
-    RSpec::Matchers.configuration.backtrace_formatter.
-                    stub(:format_backtrace).
-                    and_return("formatted-backtrace")
+    it "passes if nothing is raised" do
+      expect {}.not_to raise_error
+    end
 
-    expect {
-      expect { raise "boom" }.not_to raise_error
-    }.to raise_error { |e|
-      expect(e.message).to include("with backtrace", "formatted-backtrace")
-    }
+    it "fails if anything is raised" do
+      expect {
+        expect { raise RuntimeError, "example message" }.not_to raise_error
+      }.to fail_with(/expected no Exception, got #<RuntimeError: example message>/)
+    end
+
+    it 'includes the backtrace of the error that was raised in the error message' do
+      expect {
+        expect { raise "boom" }.not_to raise_error
+      }.to raise_error { |e|
+        backtrace_line = "#{File.basename(__FILE__)}:#{__LINE__ - 2}"
+        expect(e.message).to include("with backtrace", backtrace_line)
+      }
+    end
+
+    it 'formats the backtrace using the configured backtrace formatter' do
+      RSpec::Matchers.configuration.backtrace_formatter.
+        stub(:format_backtrace).
+        and_return("formatted-backtrace")
+
+      expect {
+        expect { raise "boom" }.not_to raise_error
+      }.to raise_error { |e|
+        expect(e.message).to include("with backtrace", "formatted-backtrace")
+      }
+    end
   end
 end
 
@@ -109,24 +158,46 @@ describe "expect { ... }.to raise_error(message)" do
   end
 end
 
-describe "expect { ... }.to_not raise_error(message)" do
+describe "expect { ... }.not_to raise_error(message)" do
+  include WrapDeprecationCallSite
+
+  before do
+    allow(RSpec).to receive(:deprecate)
+  end
+
+  it "is deprecated" do
+    expect(RSpec).to receive(:deprecate).with(
+      /not_to raise_error\(message\)/,
+      :replacement =>"`expect { }.not_to raise_error` (with no args)"
+    )
+    expect {raise 'blarg'}.not_to raise_error('blah')
+  end
+
+  it 'reports the line number of the deprecated syntax' do
+    allow(RSpec).to receive(:deprecate).and_call_original
+
+    expect_deprecation_with_call_site(__FILE__, __LINE__ + 1) do
+      expect {raise 'blarg'}.not_to raise_error('blah')
+    end
+  end
+
   it "passes if RuntimeError error is raised with the different message" do
-    expect {raise 'blarg'}.to_not raise_error('blah')
+    expect {raise 'blarg'}.not_to raise_error('blah')
   end
 
   it "passes if any other error is raised with the wrong message" do
-    expect {raise NameError.new('blarg')}.to_not raise_error('blah')
+    expect {raise NameError.new('blarg')}.not_to raise_error('blah')
   end
 
   it "fails if RuntimeError is raised with message" do
     expect do
-      expect {raise 'blah'}.to_not raise_error('blah')
+      expect {raise 'blah'}.not_to raise_error('blah')
     end.to fail_with(/expected no Exception with "blah", got #<RuntimeError: blah>/)
   end
 
   it "fails if any other error is raised with message" do
     expect do
-      expect {raise NameError.new('blah')}.to_not raise_error('blah')
+      expect {raise NameError.new('blah')}.not_to raise_error('blah')
     end.to fail_with(/expected no Exception with "blah", got #<NameError: blah>/)
   end
 end
@@ -155,18 +226,39 @@ describe "expect { ... }.to raise_error(NamedError)" do
   end
 end
 
-describe "expect { ... }.to_not raise_error(NamedError)" do
+describe "expect { ... }.not_to raise_error(NamedError)" do
+  include WrapDeprecationCallSite
+
+  before do
+    allow(RSpec).to receive(:deprecate)
+  end
+
+  it "is deprecated" do
+    expect(RSpec).to receive(:deprecate).with(
+      /not_to raise_error\(SpecificErrorClass\)/,
+      :replacement =>"`expect { }.not_to raise_error` (with no args)"
+    )
+    expect { }.not_to raise_error(NameError)
+  end
+
+  it 'reports the line number of the deprecated syntax' do
+    allow(RSpec).to receive(:deprecate).and_call_original
+    expect_deprecation_with_call_site(__FILE__, __LINE__ + 1) do
+      expect { }.not_to raise_error(NameError)
+    end
+  end
+
   it "passes if nothing is raised" do
-    expect { }.to_not raise_error(NameError)
+    expect { }.not_to raise_error(NameError)
   end
 
   it "passes if another error is raised" do
-    expect { raise }.to_not raise_error(NameError)
+    expect { raise }.not_to raise_error(NameError)
   end
 
   it "fails if named error is raised" do
     expect {
-      expect { 1 + 'b' }.to_not raise_error(TypeError)
+      expect { 1 + 'b' }.not_to raise_error(TypeError)
     }.to fail_with(/expected no TypeError, got #<TypeError: String can't be/)
   end
 end
@@ -195,6 +287,100 @@ describe "expect { ... }.to raise_error(NamedError, error_message) with String"
   end
 end
 
+describe "expect { ... }.not_to raise_error(NamedError, error_message) with String" do
+  include WrapDeprecationCallSite
+
+  before do
+    allow(RSpec).to receive(:deprecate)
+  end
+
+  it "is deprecated" do
+    expect(RSpec).to receive(:deprecate).with(
+      /not_to raise_error\(SpecificErrorClass, message\)/,
+      :replacement =>"`expect { }.not_to raise_error` (with no args)"
+    )
+    expect {}.not_to raise_error(RuntimeError, "example message")
+  end
+
+  it 'reports the line number of the deprecated syntax' do
+    allow(RSpec).to receive(:deprecate).and_call_original
+    expect_deprecation_with_call_site(__FILE__, __LINE__ + 1) do
+      expect {}.not_to raise_error(RuntimeError, "example message")
+    end
+  end
+
+  it "passes if nothing is raised" do
+    expect {}.not_to raise_error(RuntimeError, "example message")
+  end
+
+  it "passes if a different error is raised" do
+    expect { raise }.not_to raise_error(NameError, "example message")
+  end
+
+  it "passes if same error is raised with different message" do
+    expect { raise RuntimeError.new("not the example message") }.not_to raise_error(RuntimeError, "example message")
+  end
+
+  it "fails if named error is raised with same message" do
+    expect {
+      expect { raise "example message" }.not_to raise_error(RuntimeError, "example message")
+    }.to fail_with(/expected no RuntimeError with \"example message\", got #<RuntimeError: example message>/)
+  end
+end
+
+describe "expect { ... }.to raise_error(NamedError, error_message) with Regexp" do
+  it "passes if named error is raised with matching message" do
+    expect { raise "example message" }.to raise_error(RuntimeError, /ample mess/)
+  end
+
+  it "fails if nothing is raised" do
+    expect {
+      expect {}.to raise_error(RuntimeError, /ample mess/)
+    }.to fail_with(/expected RuntimeError with message matching \/ample mess\/ but nothing was raised/)
+  end
+
+  it "fails if incorrect error is raised" do
+    expect {
+      expect { raise RuntimeError, "example message" }.to raise_error(NameError, /ample mess/)
+    }.to fail_with(/expected NameError with message matching \/ample mess\/, got #<RuntimeError: example message>/)
+  end
+
+  it "fails if correct error is raised with incorrect message" do
+    expect {
+      expect { raise RuntimeError.new("not the example message") }.to raise_error(RuntimeError, /less than ample mess/)
+    }.to fail_with(/expected RuntimeError with message matching \/less than ample mess\/, got #<RuntimeError: not the example message>/)
+  end
+end
+
+describe "expect { ... }.not_to raise_error(NamedError, error_message) with Regexp" do
+  before do
+    allow(RSpec).to receive(:deprecate)
+  end
+
+  it "is deprecated" do
+    expect(RSpec).to receive(:deprecate)
+    expect {}.not_to raise_error(RuntimeError, /ample mess/)
+  end
+
+  it "passes if nothing is raised" do
+    expect {}.not_to raise_error(RuntimeError, /ample mess/)
+  end
+
+  it "passes if a different error is raised" do
+    expect { raise }.not_to raise_error(NameError, /ample mess/)
+  end
+
+  it "passes if same error is raised with non-matching message" do
+    expect { raise RuntimeError.new("non matching message") }.not_to raise_error(RuntimeError, /ample mess/)
+  end
+
+  it "fails if named error is raised with matching message" do
+    expect {
+      expect { raise "example message" }.not_to raise_error(RuntimeError, /ample mess/)
+    }.to fail_with(/expected no RuntimeError with message matching \/ample mess\/, got #<RuntimeError: example message>/)
+  end
+end
+
 describe "expect { ... }.to raise_error(NamedError, error_message) { |err| ... }" do
   it "yields exception if named error is raised with same message" do
     ran = false
@@ -223,8 +409,8 @@ describe "expect { ... }.to raise_error(NamedError, error_message) { |err| ... }
       }
     }.to fail_with(/expected: 4/m)
 
-    expect(ran).to    be_true
-    expect(passed).to be_false
+    expect(ran).to    be_truthy
+    expect(passed).to be_falsey
   end
 
   it "does NOT yield exception if no error was thrown" do
@@ -268,11 +454,20 @@ describe "expect { ... }.to raise_error(NamedError, error_message) { |err| ... }
   end
 end
 
-describe "expect { ... }.to_not raise_error(NamedError, error_message) { |err| ... }" do
+describe "expect { ... }.not_to raise_error(NamedError, error_message) { |err| ... }" do
+  before do
+    allow(RSpec).to receive(:deprecate)
+  end
+
+  it "is deprecated" do
+    expect(RSpec).to receive(:deprecate)
+    expect {}.not_to raise_error(RuntimeError, "example message") { |err| }
+  end
+
   it "passes if nothing is raised" do
     ran = false
 
-    expect {}.to_not raise_error(RuntimeError, "example message") { |err|
+    expect {}.not_to raise_error(RuntimeError, "example message") { |err|
       ran = true
     }
 
@@ -282,7 +477,7 @@ describe "expect { ... }.to_not raise_error(NamedError, error_message) { |err| .
   it "passes if a different error is raised" do
     ran = false
 
-    expect { raise }.to_not raise_error(NameError, "example message") { |err|
+    expect { raise }.not_to raise_error(NameError, "example message") { |err|
       ran = true
     }
 
@@ -294,7 +489,7 @@ describe "expect { ... }.to_not raise_error(NamedError, error_message) { |err| .
 
     expect {
       raise RuntimeError.new("not the example message")
-    }.to_not raise_error(RuntimeError, "example message") { |err|
+    }.not_to raise_error(RuntimeError, "example message") { |err|
       ran = true
     }
 
@@ -307,7 +502,7 @@ describe "expect { ... }.to_not raise_error(NamedError, error_message) { |err| .
     expect {
       expect {
         raise "example message"
-      }.to_not raise_error(RuntimeError, "example message") { |err|
+      }.not_to raise_error(RuntimeError, "example message") { |err|
         ran = true
       }
     }.to fail_with(/expected no RuntimeError with \"example message\", got #<RuntimeError: example message>/)
@@ -330,66 +525,11 @@ describe "expect { ... }.to_not raise_error(NamedError, error_message) { |err| .
   end
 end
 
-describe "expect { ... }.to_not raise_error(NamedError, error_message) with String" do
-  it "passes if nothing is raised" do
-    expect {}.to_not raise_error(RuntimeError, "example message")
-  end
-
-  it "passes if a different error is raised" do
-    expect { raise }.to_not raise_error(NameError, "example message")
-  end
-
-  it "passes if same error is raised with different message" do
-    expect { raise RuntimeError.new("not the example message") }.to_not raise_error(RuntimeError, "example message")
-  end
-
-  it "fails if named error is raised with same message" do
-    expect {
-      expect { raise "example message" }.to_not raise_error(RuntimeError, "example message")
-    }.to fail_with(/expected no RuntimeError with \"example message\", got #<RuntimeError: example message>/)
-  end
-end
-
-describe "expect { ... }.to raise_error(NamedError, error_message) with Regexp" do
-  it "passes if named error is raised with matching message" do
-    expect { raise "example message" }.to raise_error(RuntimeError, /ample mess/)
-  end
-
-  it "fails if nothing is raised" do
-    expect {
-      expect {}.to raise_error(RuntimeError, /ample mess/)
-    }.to fail_with(/expected RuntimeError with message matching \/ample mess\/ but nothing was raised/)
-  end
-
-  it "fails if incorrect error is raised" do
-    expect {
-      expect { raise RuntimeError, "example message" }.to raise_error(NameError, /ample mess/)
-    }.to fail_with(/expected NameError with message matching \/ample mess\/, got #<RuntimeError: example message>/)
-  end
-
-  it "fails if correct error is raised with incorrect message" do
-    expect {
-      expect { raise RuntimeError.new("not the example message") }.to raise_error(RuntimeError, /less than ample mess/)
-    }.to fail_with(/expected RuntimeError with message matching \/less than ample mess\/, got #<RuntimeError: not the example message>/)
-  end
-end
-
-describe "expect { ... }.to_not raise_error(NamedError, error_message) with Regexp" do
-  it "passes if nothing is raised" do
-    expect {}.to_not raise_error(RuntimeError, /ample mess/)
-  end
-
-  it "passes if a different error is raised" do
-    expect { raise }.to_not raise_error(NameError, /ample mess/)
-  end
-
-  it "passes if same error is raised with non-matching message" do
-    expect { raise RuntimeError.new("non matching message") }.to_not raise_error(RuntimeError, /ample mess/)
-  end
-
-  it "fails if named error is raised with matching message" do
+describe "misuse of raise_error, with (), not {}" do
+  it "fails with warning" do
+    ::Kernel.should_receive(:warn).with(/`raise_error` was called with non-proc object 1\.7/)
     expect {
-      expect { raise "example message" }.to_not raise_error(RuntimeError, /ample mess/)
-    }.to fail_with(/expected no RuntimeError with message matching \/ample mess\/, got #<RuntimeError: example message>/)
+      expect(Math.sqrt(3)).to raise_error
+    }.to fail_with(/nothing was raised/)
   end
 end

data/spec/rspec/matchers/respond_to_spec.rb

@@ -148,7 +148,7 @@ describe "expect(...).to respond_to(:sym).with(2).arguments" do
   end
 end
 
-describe "expect(...).to_not respond_to(:sym)" do
+describe "expect(...).not_to respond_to(:sym)" do
   it "passes if target does not respond to :sym" do
     expect(Object.new).not_to respond_to(:some_method)
   end
@@ -160,7 +160,7 @@ describe "expect(...).to_not respond_to(:sym)" do
   end
 end
 
-describe "expect(...).to_not respond_to(:sym).with(1).argument" do
+describe "expect(...).not_to respond_to(:sym).with(1).argument" do
   it "fails if target responds to :sym with 1 arg" do
     obj = Object.new
     def obj.foo(arg); end
@@ -209,7 +209,7 @@ describe "expect(...).to_not respond_to(:sym).with(1).argument" do
   end
 end
 
-describe "expect(...).to_not respond_to(message1, message2)" do
+describe "expect(...).not_to respond_to(message1, message2)" do
   it "passes if target does not respond to either message1 or message2" do
     expect(Object.new).not_to respond_to(:some_method, :some_other_method)
   end
@@ -233,7 +233,7 @@ describe "expect(...).to_not respond_to(message1, message2)" do
   end
 end
 
-describe "expect(...).to_not respond_to(:sym).with(2).arguments" do
+describe "expect(...).not_to respond_to(:sym).with(2).arguments" do
   it "fails if target responds to :sym with 2 args" do
     obj = Object.new
     def obj.foo(a1, a2); end

data/spec/rspec/matchers/satisfy_spec.rb

@@ -28,7 +28,7 @@ describe "expect(...).to satisfy { block }" do
   end
 end
 
-describe "expect(...).to_not satisfy { block }" do
+describe "expect(...).not_to satisfy { block }" do
   it "passes if block returns false" do
     expect(false).not_to satisfy { |val| val }
     expect(false).not_to satisfy do |val|

data/spec/rspec/matchers/start_with_end_with_spec.rb

@@ -56,7 +56,7 @@ describe "expect(...).to start_with" do
   end
 end
 
-describe "expect(...).to_not start_with" do
+describe "expect(...).not_to start_with" do
   context "with a string" do
     it "passes if it does not match the start of the actual string" do
       expect("this string").not_to start_with "that str"
@@ -149,7 +149,7 @@ describe "expect(...).to end_with" do
 
 end
 
-describe "expect(...).to_not end_with" do
+describe "expect(...).not_to end_with" do
   context "with a sting" do
     it "passes if it does not match the end of the actual string" do
       expect("this string").not_to end_with "stringy"

data/spec/rspec/matchers/throw_symbol_spec.rb

@@ -11,13 +11,13 @@ module RSpec::Matchers::BuiltIn
       before(:each) { @matcher = throw_symbol }
 
       it "matches if any Symbol is thrown" do
-        expect(@matcher.matches?(lambda{ throw :sym })).to be_true
+        expect(@matcher.matches?(lambda{ throw :sym })).to be_truthy
       end
       it "matches if any Symbol is thrown with an arg" do
-        expect(@matcher.matches?(lambda{ throw :sym, "argument" })).to be_true
+        expect(@matcher.matches?(lambda{ throw :sym, "argument" })).to be_truthy
       end
       it "does not match if no Symbol is thrown" do
-        expect(@matcher.matches?(lambda{ })).to be_false
+        expect(@matcher.matches?(lambda{ })).to be_falsey
       end
       it "provides a failure message" do
         @matcher.matches?(lambda{})
@@ -33,16 +33,16 @@ module RSpec::Matchers::BuiltIn
       before(:each) { @matcher = throw_symbol(:sym) }
 
       it "matches if correct Symbol is thrown" do
-        expect(@matcher.matches?(lambda{ throw :sym })).to be_true
+        expect(@matcher.matches?(lambda{ throw :sym })).to be_truthy
       end
       it "matches if correct Symbol is thrown with an arg" do
-        expect(@matcher.matches?(lambda{ throw :sym, "argument" })).to be_true
+        expect(@matcher.matches?(lambda{ throw :sym, "argument" })).to be_truthy
       end
       it "does not match if no Symbol is thrown" do
-        expect(@matcher.matches?(lambda{ })).to be_false
+        expect(@matcher.matches?(lambda{ })).to be_falsey
       end
       it "does not match if correct Symbol is thrown" do
-        expect(@matcher.matches?(lambda{ throw :other_sym })).to be_false
+        expect(@matcher.matches?(lambda{ throw :other_sym })).to be_falsey
       end
       it "provides a failure message when no Symbol is thrown" do
         @matcher.matches?(lambda{})
@@ -58,7 +58,7 @@ module RSpec::Matchers::BuiltIn
       end
       it "only matches NameErrors raised by uncaught throws" do
         expect {
-          expect(@matcher.matches?(lambda{ sym })).to be_false
+          expect(@matcher.matches?(lambda{ sym })).to be_falsey
         }.to raise_error(NameError)
       end
     end
@@ -67,19 +67,19 @@ module RSpec::Matchers::BuiltIn
       before(:each) { @matcher = throw_symbol(:sym, "a") }
 
       it "matches if correct Symbol and args are thrown" do
-        expect(@matcher.matches?(lambda{ throw :sym, "a" })).to be_true
+        expect(@matcher.matches?(lambda{ throw :sym, "a" })).to be_truthy
       end
       it "does not match if nothing is thrown" do
-        expect(@matcher.matches?(lambda{ })).to be_false
+        expect(@matcher.matches?(lambda{ })).to be_falsey
       end
       it "does not match if other Symbol is thrown" do
-        expect(@matcher.matches?(lambda{ throw :other_sym, "a" })).to be_false
+        expect(@matcher.matches?(lambda{ throw :other_sym, "a" })).to be_falsey
       end
       it "does not match if no arg is thrown" do
-        expect(@matcher.matches?(lambda{ throw :sym })).to be_false
+        expect(@matcher.matches?(lambda{ throw :sym })).to be_falsey
       end
       it "does not match if wrong arg is thrown" do
-        expect(@matcher.matches?(lambda{ throw :sym, "b" })).to be_false
+        expect(@matcher.matches?(lambda{ throw :sym, "b" })).to be_falsey
       end
       it "provides a failure message when no Symbol is thrown" do
         @matcher.matches?(lambda{})
@@ -103,7 +103,7 @@ module RSpec::Matchers::BuiltIn
       end
       it "only matches NameErrors raised by uncaught throws" do
         expect {
-          expect(@matcher.matches?(lambda{ sym })).to be_false
+          expect(@matcher.matches?(lambda{ sym })).to be_falsey
         }.to raise_error(NameError)
       end
       it "raises other errors" do