rspec-core 3.13.5 → 4.0.0.beta1

data/lib/rspec/core/configuration.rb

@@ -2,6 +2,7 @@ RSpec::Support.require_rspec_core "backtrace_formatter"
 RSpec::Support.require_rspec_core "ruby_project"
 RSpec::Support.require_rspec_core "formatters/deprecation_formatter"
 RSpec::Support.require_rspec_core "output_wrapper"
+RSpec::Support.require_rspec_support 'ruby_features'
 
 module RSpec
   module Core
@@ -137,27 +138,6 @@ module RSpec
       # Default: `$stderr`.
       add_setting :error_stream
 
-      # Indicates if the DSL has been exposed off of modules and `main`.
-      # Default: true
-      # @return [Boolean]
-      def expose_dsl_globally?
-        Core::DSL.exposed_globally?
-      end
-
-      # Use this to expose the core RSpec DSL via `Module` and the `main`
-      # object. It will be set automatically but you can override it to
-      # remove the DSL.
-      # Default: true
-      def expose_dsl_globally=(value)
-        if value
-          Core::DSL.expose_globally!
-          Core::SharedExampleGroup::TopLevelDSL.expose_globally!
-        else
-          Core::DSL.remove_globally!
-          Core::SharedExampleGroup::TopLevelDSL.remove_globally!
-        end
-      end
-
       # Determines where deprecation warnings are printed.
       # Defaults to `$stderr`.
       # @return [IO, String] IO or filename to write to
@@ -168,10 +148,10 @@ module RSpec
       def deprecation_stream=(value)
         if @reporter && !value.equal?(@deprecation_stream)
           warn "RSpec's reporter has already been initialized with " \
-            "#{deprecation_stream.inspect} as the deprecation stream, so your change to "\
-            "`deprecation_stream` will be ignored. You should configure it earlier for " \
-            "it to take effect, or use the `--deprecation-out` CLI option. " \
-            "(Called from #{CallerFilter.first_non_rspec_line})"
+               "#{deprecation_stream.inspect} as the deprecation stream, so your change to " \
+               "`deprecation_stream` will be ignored. You should configure it earlier for " \
+               "it to take effect, or use the `--deprecation-out` CLI option. " \
+               "(Called from #{CallerFilter.first_non_rspec_line})"
         else
           @deprecation_stream = value
         end
@@ -223,11 +203,10 @@ module RSpec
           @fail_fast = value.to_i
 
           if value.to_i == 0
-            # TODO: in RSpec 4, consider raising an error here.
-            RSpec.warning "Cannot set `RSpec.configuration.fail_fast`" \
-              " to `#{value.inspect}`. Only `true`, `false`, `nil` and integers" \
-              " are valid values."
-            @fail_fast = true
+            raise ArgumentError, "Cannot set `RSpec.configuration.fail_fast` " \
+                                 "to `#{value.inspect}`. Only `true`, `" \
+                                 "`false`, `nil` and integers are valid " \
+                                 "values."
           end
         end
       end
@@ -274,9 +253,9 @@ module RSpec
       def output_stream=(value)
         if @reporter && !value.equal?(@output_stream)
           warn "RSpec's reporter has already been initialized with " \
-            "#{output_stream.inspect} as the output stream, so your change to "\
-            "`output_stream` will be ignored. You should configure it earlier for " \
-            "it to take effect. (Called from #{CallerFilter.first_non_rspec_line})"
+               "#{output_stream.inspect} as the output stream, so your change to " \
+               "`output_stream` will be ignored. You should configure it earlier for " \
+               "it to take effect. (Called from #{CallerFilter.first_non_rspec_line})"
         else
           @output_stream = value
           output_wrapper.output = @output_stream
@@ -322,13 +301,6 @@ module RSpec
       attr_writer :profile_examples
       define_predicate :profile_examples
 
-      # @macro add_setting
-      # Run all examples if none match the configured filters
-      # (default: `false`).
-      # @deprecated Use {#filter_run_when_matching} instead for the specific
-      #   filters that you want to be ignored if none match.
-      add_setting :run_all_when_everything_filtered
-
       # @macro add_setting
       # Color to use to indicate success.  Defaults to `:green` but can be set
       # to one of the following: `[:black, :white, :red, :green, :yellow,
@@ -377,71 +349,6 @@ module RSpec
       # return [Boolean]
       add_setting :silence_filter_announcements
 
-      # @deprecated This config option was added in RSpec 2 to pave the way
-      #   for this being the default behavior in RSpec 3. Now this option is
-      #   a no-op.
-      def treat_symbols_as_metadata_keys_with_true_values=(_value)
-        RSpec.deprecate(
-          "RSpec::Core::Configuration#treat_symbols_as_metadata_keys_with_true_values=",
-          :message => "RSpec::Core::Configuration#treat_symbols_as_metadata_keys_with_true_values= " \
-                      "is deprecated, it is now set to true as default and " \
-                      "setting it to false has no effect."
-        )
-      end
-
-      # @macro define_reader
-      # Configures how RSpec treats metadata passed as part of a shared example
-      # group definition. For example, given this shared example group definition:
-      #
-      #     RSpec.shared_context "uses DB", :db => true do
-      #       around(:example) do |ex|
-      #         MyORM.transaction(:rollback => true, &ex)
-      #       end
-      #     end
-      #
-      # ...there are two ways RSpec can treat the `:db => true` metadata, each
-      # of which has a corresponding config option:
-      #
-      # 1. `:trigger_inclusion`: this shared context will be implicitly included
-      #    in any groups (or examples) that have `:db => true` metadata.
-      # 2. `:apply_to_host_groups`: the metadata will be inherited by the metadata
-      #    hash of all host groups and examples.
-      #
-      # `:trigger_inclusion` is the legacy behavior from before RSpec 3.5 but should
-      # be considered deprecated. Instead, you can explicitly include a group with
-      # `include_context`:
-      #
-      #     RSpec.describe "My model" do
-      #       include_context "uses DB"
-      #     end
-      #
-      # ...or you can configure RSpec to include the context based on matching metadata
-      # using an API that mirrors configured module inclusion:
-      #
-      #     RSpec.configure do |rspec|
-      #       rspec.include_context "uses DB", :db => true
-      #     end
-      #
-      # `:apply_to_host_groups` is a new feature of RSpec 3.5 and will be the only
-      # supported behavior in RSpec 4.
-      #
-      # @overload shared_context_metadata_behavior
-      #   @return [:trigger_inclusion, :apply_to_host_groups] the configured behavior
-      # @overload shared_context_metadata_behavior=(value)
-      #   @param value [:trigger_inclusion, :apply_to_host_groups] sets the configured behavior
-      define_reader :shared_context_metadata_behavior
-      # @see shared_context_metadata_behavior
-      def shared_context_metadata_behavior=(value)
-        case value
-        when :trigger_inclusion, :apply_to_host_groups
-          @shared_context_metadata_behavior = value
-        else
-          raise ArgumentError, "Cannot set `RSpec.configuration." \
-            "shared_context_metadata_behavior` to `#{value.inspect}`. Only " \
-            "`:trigger_inclusion` and `:apply_to_host_groups` are valid values."
-        end
-      end
-
       # Record the start time of the spec suite to measure load time.
       # return [Time]
       add_setting :start_time
@@ -477,6 +384,12 @@ module RSpec
         @pending_failure_output = mode
       end
 
+      # @macro force_line_number_for_spec_rerun
+      # Display the line number (`my_spec.rb:10`), as opposed to the example id (`my_spec.rb[1:1:1]`)
+      # for shared or nested examples (defaults to `false`).
+      # return [Boolean]
+      add_setting :force_line_number_for_spec_rerun
+
       # Determines which bisect runner implementation gets used to run subsets
       # of the suite during a bisection. Your choices are:
       #
@@ -500,18 +413,15 @@ module RSpec
       def bisect_runner=(value)
         if @bisect_runner_class && value != @bisect_runner
           raise "`config.bisect_runner = #{value.inspect}` can no longer take " \
-            "effect as the #{@bisect_runner.inspect} bisect runnner is already " \
-            "in use. This config setting must be set in a file loaded by a " \
-            "`--require` option (passed at the CLI or in a `.rspec` file) for " \
-            "it to have any effect."
+                "effect as the #{@bisect_runner.inspect} bisect runnner is already " \
+                "in use. This config setting must be set in a file loaded by a " \
+                "`--require` option (passed at the CLI or in a `.rspec` file) for " \
+                "it to have any effect."
         end
 
         @bisect_runner = value
       end
 
-      # @private
-      # @deprecated Use {#color_mode} = :on, instead of {#color} with {#tty}
-      add_setting :tty
       # @private
       attr_writer :files_to_run
       # @private
@@ -530,9 +440,9 @@ module RSpec
         @start_time = $_rspec_core_load_started_at || ::RSpec::Core::Time.now
         # rubocop:enable Style/GlobalVars
         @expectation_frameworks = []
-        @include_modules = FilterableItemRepository::QueryOptimized.new(:any?)
-        @extend_modules  = FilterableItemRepository::QueryOptimized.new(:any?)
-        @prepend_modules = FilterableItemRepository::QueryOptimized.new(:any?)
+        @include_modules = FilterableItemRepository::QueryOptimized.new
+        @extend_modules  = FilterableItemRepository::QueryOptimized.new
+        @prepend_modules = FilterableItemRepository::QueryOptimized.new
 
         @bisect_runner = RSpec::Support::RubyFeatures.fork_supported? ? :fork : :shell
         @bisect_runner_class = nil
@@ -543,7 +453,6 @@ module RSpec
         @mock_framework = nil
         @files_or_directories_to_run = []
         @loaded_spec_files = Set.new
-        @color = false
         @color_mode = :automatic
         @pattern = '**{,/*/**}/*_spec.rb'
         @exclude_pattern = ''
@@ -573,13 +482,22 @@ module RSpec
         @profile_examples = false
         @requires = []
         @libs = []
-        @derived_metadata_blocks = FilterableItemRepository::QueryOptimized.new(:any?)
+        @derived_metadata_blocks = FilterableItemRepository::QueryOptimized.new
         @threadsafe = true
         @max_displayed_failure_line_count = 10
         @full_cause_backtrace = false
         @world = World::Null
-        @shared_context_metadata_behavior = :trigger_inclusion
         @pending_failure_output = :full
+        @force_line_number_for_spec_rerun = false
+        @warnings = nil
+
+        if warnings?
+          # Turn on all warnings if warnings already configured
+          self.warnings = :all
+        else
+          # Turn on Ruby deprecations by default
+          self.warnings = :deprecations_only
+        end
 
         define_built_in_hooks
       end
@@ -865,8 +783,8 @@ module RSpec
 
             # Tag this exception class so our exception formatting logic knows
             # that it satisfies the `MultipleExceptionError` interface.
-            ::RSpec::Expectations::MultipleExpectationsNotMetError.__send__(
-              :include, MultipleExceptionError::InterfaceTag
+            ::RSpec::Expectations::MultipleExpectationsNotMetError.include(
+              MultipleExceptionError::InterfaceTag
             )
 
             ::RSpec::Matchers
@@ -909,20 +827,6 @@ module RSpec
         @backtrace_formatter.full_backtrace = true_or_false
       end
 
-      # Enables color output if the output is a TTY.  As of RSpec 3.6, this is
-      # the default behavior and this option is retained only for backwards
-      # compatibility.
-      #
-      # @deprecated No longer recommended because of complex behavior. Instead,
-      #   rely on the fact that TTYs will display color by default, or set
-      #   {#color_mode} to :on to display color on a non-TTY output.
-      # @see color_mode
-      # @see color_enabled?
-      # @return [Boolean]
-      def color
-        value_for(:color) { @color }
-      end
-
       # The mode for determining whether to display output in color. One of:
       #
       # - :automatic - the output will be in color if the output is a TTY (the
@@ -945,20 +849,13 @@ module RSpec
         when :on then true
         when :off then false
         else # automatic
-          output_to_tty?(output) || (color && tty?)
+          output_to_tty?(output)
         end
       end
 
       # Set the color mode.
       attr_writer :color_mode
 
-      # Toggle output color.
-      #
-      # @deprecated No longer recommended because of complex behavior. Instead,
-      #   rely on the fact that TTYs will display color by default, or set
-      #   {:color_mode} to :on to display color on a non-TTY output.
-      attr_writer :color
-
       # @private
       def libs=(libs)
         libs.map do |lib|
@@ -1201,18 +1098,14 @@ module RSpec
       #   RSpec.describe User, :type => :model do
       #   end
       #
-      # @note The defined aliased will also be added to the top level
-      #       (e.g. `main` and from within modules) if
-      #       `expose_dsl_globally` is set to true.
       # @see #alias_example_to
-      # @see #expose_dsl_globally=
       def alias_example_group_to(new_name, *args)
         extra_options = Metadata.build_hash_from(args)
         RSpec::Core::ExampleGroup.define_example_group_method(new_name, extra_options)
       end
 
-      # Define an alias for it_should_behave_like that allows different
-      # language (like "it_has_behavior" or "it_behaves_like") to be
+      # Define an alias for it_behaves_like that allows different
+      # language (like "it_has_behavior" or "it_is_able_to") to be
       # employed when including shared examples.
       #
       # @example
@@ -1234,13 +1127,10 @@ module RSpec
       #   #     ...sortability examples here
       #
       # @note Use with caution. This extends the language used in your
-      #   specs, but does not add any additional documentation. We use this
-      #   in RSpec to define `it_should_behave_like` (for backward
-      #   compatibility), but we also add docs for that method.
+      #   specs, but does not add any additional documentation.
       def alias_it_behaves_like_to(new_name, report_label='')
         RSpec::Core::ExampleGroup.define_nested_shared_group_method(new_name, report_label)
       end
-      alias_method :alias_it_should_behave_like_to, :alias_it_behaves_like_to
 
       # Adds key/value pairs to the `inclusion_filter`. If `args`
       # includes any symbols that are not part of the hash, each symbol
@@ -1273,7 +1163,7 @@ module RSpec
       #
       #     filter_run_including :foo # same as filter_run_including :foo => true
       def filter_run_including(*args)
-        meta = Metadata.build_hash_from(args, :warn_about_example_group_filtering)
+        meta = Metadata.build_hash_from(args)
         filter_manager.include_with_low_priority meta
         static_config_filter_manager.include_with_low_priority Metadata.deep_hash_dup(meta)
       end
@@ -1302,7 +1192,7 @@ module RSpec
       # This overrides any inclusion filters/tags set on the command line or in
       # configuration files.
       def inclusion_filter=(filter)
-        meta = Metadata.build_hash_from([filter], :warn_about_example_group_filtering)
+        meta = Metadata.build_hash_from([filter])
         filter_manager.include_only meta
       end
 
@@ -1347,7 +1237,7 @@ module RSpec
       #
       #     filter_run_excluding :foo # same as filter_run_excluding :foo => true
       def filter_run_excluding(*args)
-        meta = Metadata.build_hash_from(args, :warn_about_example_group_filtering)
+        meta = Metadata.build_hash_from(args)
         filter_manager.exclude_with_low_priority meta
         static_config_filter_manager.exclude_with_low_priority Metadata.deep_hash_dup(meta)
       end
@@ -1360,7 +1250,7 @@ module RSpec
       # This overrides any exclusion filters/tags set on the command line or in
       # configuration files.
       def exclusion_filter=(filter)
-        meta = Metadata.build_hash_from([filter], :warn_about_example_group_filtering)
+        meta = Metadata.build_hash_from([filter])
         filter_manager.exclude_only meta
       end
 
@@ -1521,43 +1411,41 @@ module RSpec
         end
       end
 
-      if RSpec::Support::RubyFeatures.module_prepends_supported?
-        # Tells RSpec to prepend example groups with `mod`. Methods defined in
-        # `mod` are exposed to examples (not example groups). Use `filters` to
-        # constrain the groups in which to prepend the module.
-        #
-        # Similar to `include`, but module is included before the example group's class
-        # in the ancestor chain.
-        #
-        # @example
-        #
-        #     module OverrideMod
-        #       def override_me
-        #         "overridden"
-        #       end
-        #     end
-        #
-        #     RSpec.configure do |config|
-        #       config.prepend(OverrideMod, :method => :prepend)
-        #     end
-        #
-        #     describe "overriding example's class", :method => :prepend do
-        #       it "finds the user" do
-        #         self.class.class_eval do
-        #           def override_me
-        #           end
-        #         end
-        #         override_me # => "overridden"
-        #         # ...
-        #       end
-        #     end
-        #
-        # @see #include
-        # @see #extend
-        def prepend(mod, *filters)
-          define_mixed_in_module(mod, filters, @prepend_modules, :prepend) do |group|
-            safe_prepend(mod, group)
-          end
+      # Tells RSpec to prepend example groups with `mod`. Methods defined in
+      # `mod` are exposed to examples (not example groups). Use `filters` to
+      # constrain the groups in which to prepend the module.
+      #
+      # Similar to `include`, but module is included before the example group's class
+      # in the ancestor chain.
+      #
+      # @example
+      #
+      #     module OverrideMod
+      #       def override_me
+      #         "overridden"
+      #       end
+      #     end
+      #
+      #     RSpec.configure do |config|
+      #       config.prepend(OverrideMod, :method => :prepend)
+      #     end
+      #
+      #     describe "overriding example's class", :method => :prepend do
+      #       it "finds the user" do
+      #         self.class.class_eval do
+      #           def override_me
+      #           end
+      #         end
+      #         override_me # => "overridden"
+      #         # ...
+      #       end
+      #     end
+      #
+      # @see #include
+      # @see #extend
+      def prepend(mod, *filters)
+        define_mixed_in_module(mod, filters, @prepend_modules, :prepend) do |group|
+          safe_prepend(mod, group)
         end
       end
 
@@ -1614,16 +1502,14 @@ module RSpec
 
       # @private
       def configure_mock_framework
-        RSpec::Core::ExampleGroup.__send__(:include, mock_framework)
-        conditionally_disable_mocks_monkey_patching
+        RSpec::Core::ExampleGroup.include(mock_framework)
       end
 
       # @private
       def configure_expectation_framework
         expectation_frameworks.each do |framework|
-          RSpec::Core::ExampleGroup.__send__(:include, framework)
+          RSpec::Core::ExampleGroup.include(framework)
         end
-        conditionally_disable_expectations_monkey_patching
       end
 
       # @private
@@ -1756,11 +1642,37 @@ module RSpec
       # @private
       delegate_to_ordering_manager :seed_used?, :ordering_registry
 
-      # Set Ruby warnings on or off.
+      # Set Ruby warnings. `:deprecations_only` is recommended, but may be too
+      # noisy due to dependencies.
+      # Can be set to `:all` or `:none` to show all warnings or none of them.
       def warnings=(value)
-        $VERBOSE = !!value
+        case value
+        when :none
+          @warnings = :none
+          $VERBOSE = false
+          ::Warning[:deprecated] = false
+        when :all
+          @warnings = :all
+          $VERBOSE = true
+          ::Warning[:deprecated] = true
+        when :deprecations_only
+          @warnings = :deprecations_only
+          $VERBOSE = false
+          ::Warning[:deprecated] = true
+        else
+          raise "Unsupported value for `warnings` (#{value.inspect}). " \
+                "Only `:none`, `:all` and `:deprecations_only` are supported."
+        end
+      end
+
+      # @return [Boolean] Whether or not ruby deprecations are enabled.
+      def deprecation_warnings?
+        ::Warning[:deprecated]
       end
 
+      # @return [Symbol] The configured warning level
+      attr_reader :warnings
+
       # @return [Boolean] Whether or not ruby warnings are enabled.
       def warnings?
         $VERBOSE
@@ -1811,6 +1723,7 @@ module RSpec
       def expose_current_running_example_as(method_name)
         ExposeCurrentExample.module_exec do
           extend RSpec::SharedContext
+
           let(method_name) { |ex| ex }
         end
 
@@ -1834,52 +1747,6 @@ module RSpec
         self.deprecation_stream = Formatters::DeprecationFormatter::RaiseErrorStream.new
       end
 
-      # Enables zero monkey patching mode for RSpec. It removes monkey
-      # patching of the top-level DSL methods (`describe`,
-      # `shared_examples_for`, etc) onto `main` and `Module`, instead
-      # requiring you to prefix these methods with `RSpec.`. It enables
-      # expect-only syntax for rspec-mocks and rspec-expectations. It
-      # simply disables monkey patching on whatever pieces of RSpec
-      # the user is using.
-      #
-      # @note It configures rspec-mocks and rspec-expectations only
-      #   if the user is using those (either explicitly or implicitly
-      #   by not setting `mock_with` or `expect_with` to anything else).
-      #
-      # @note If the user uses this options with `mock_with :mocha`
-      #   (or similar) they will still have monkey patching active
-      #   in their test environment from mocha.
-      #
-      # @example
-      #
-      #   # It disables all monkey patching.
-      #   RSpec.configure do |config|
-      #     config.disable_monkey_patching!
-      #   end
-      #
-      #   # Is an equivalent to
-      #   RSpec.configure do |config|
-      #     config.expose_dsl_globally = false
-      #
-      #     config.mock_with :rspec do |mocks|
-      #       mocks.syntax = :expect
-      #       mocks.patch_marshal_to_support_partial_doubles = false
-      #     end
-      #
-      #     config.expect_with :rspec do |expectations|
-      #       expectations.syntax = :expect
-      #     end
-      #   end
-      def disable_monkey_patching!
-        self.expose_dsl_globally = false
-        self.disable_monkey_patching = true
-        conditionally_disable_mocks_monkey_patching
-        conditionally_disable_expectations_monkey_patching
-      end
-
-      # @private
-      attr_accessor :disable_monkey_patching
-
       # Defines a callback that can assign derived metadata values.
       #
       # @param filters [Array<Symbol>, Hash] metadata filters that determine
@@ -1898,7 +1765,7 @@ module RSpec
       #     end
       #   end
       def define_derived_metadata(*filters, &block)
-        meta = Metadata.build_hash_from(filters, :warn_about_example_group_filtering)
+        meta = Metadata.build_hash_from(filters)
         @derived_metadata_blocks.append(block, meta)
       end
 
@@ -1921,7 +1788,7 @@ module RSpec
       #     end
       #   end
       def when_first_matching_example_defined(*filters)
-        specified_meta = Metadata.build_hash_from(filters, :warn_about_example_group_filtering)
+        specified_meta = Metadata.build_hash_from(filters)
 
         callback = lambda do |example_or_group_meta|
           # Example groups do not have `:example_group` metadata
@@ -1977,12 +1844,6 @@ module RSpec
         handle_suite_hook(scope, meta) do
           @before_suite_hooks << Hooks::BeforeHook.new(block, {})
         end || begin
-          # defeat Ruby 2.5 lazy proc allocation to ensure
-          # the methods below are passed the same proc instances
-          # so `Hook` equality is preserved. For more info, see:
-          # https://bugs.ruby-lang.org/issues/14045#note-5
-          block.__id__
-
           add_hook_to_existing_matching_groups(meta, scope) { |g| g.before(scope, *meta, &block) }
           super(scope, *meta, &block)
         end
@@ -2007,12 +1868,6 @@ module RSpec
         handle_suite_hook(scope, meta) do
           @before_suite_hooks.unshift Hooks::BeforeHook.new(block, {})
         end || begin
-          # defeat Ruby 2.5 lazy proc allocation to ensure
-          # the methods below are passed the same proc instances
-          # so `Hook` equality is preserved. For more info, see:
-          # https://bugs.ruby-lang.org/issues/14045#note-5
-          block.__id__
-
           add_hook_to_existing_matching_groups(meta, scope) { |g| g.prepend_before(scope, *meta, &block) }
           super(scope, *meta, &block)
         end
@@ -2032,12 +1887,6 @@ module RSpec
         handle_suite_hook(scope, meta) do
           @after_suite_hooks.unshift Hooks::AfterHook.new(block, {})
         end || begin
-          # defeat Ruby 2.5 lazy proc allocation to ensure
-          # the methods below are passed the same proc instances
-          # so `Hook` equality is preserved. For more info, see:
-          # https://bugs.ruby-lang.org/issues/14045#note-5
-          block.__id__
-
           add_hook_to_existing_matching_groups(meta, scope) { |g| g.after(scope, *meta, &block) }
           super(scope, *meta, &block)
         end
@@ -2062,12 +1911,6 @@ module RSpec
         handle_suite_hook(scope, meta) do
           @after_suite_hooks << Hooks::AfterHook.new(block, {})
         end || begin
-          # defeat Ruby 2.5 lazy proc allocation to ensure
-          # the methods below are passed the same proc instances
-          # so `Hook` equality is preserved. For more info, see:
-          # https://bugs.ruby-lang.org/issues/14045#note-5
-          block.__id__
-
           add_hook_to_existing_matching_groups(meta, scope) { |g| g.append_after(scope, *meta, &block) }
           super(scope, *meta, &block)
         end
@@ -2077,12 +1920,6 @@ module RSpec
       #
       # See {Hooks#around} for full `around` hook docs.
       def around(scope=nil, *meta, &block)
-        # defeat Ruby 2.5 lazy proc allocation to ensure
-        # the methods below are passed the same proc instances
-        # so `Hook` equality is preserved. For more info, see:
-        # https://bugs.ruby-lang.org/issues/14045#note-5
-        block.__id__
-
         add_hook_to_existing_matching_groups(meta, scope) { |g| g.around(scope, *meta, &block) }
         super(scope, *meta, &block)
       end
@@ -2172,12 +2009,10 @@ module RSpec
         return nil unless scope == :suite
 
         unless meta.empty?
-          # TODO: in RSpec 4, consider raising an error here.
-          # We warn only for backwards compatibility.
-          RSpec.warn_with "WARNING: `:suite` hooks do not support metadata since " \
-                          "they apply to the suite as a whole rather than " \
-                          "any individual example or example group that has metadata. " \
-                          "The metadata you have provided (#{meta.inspect}) will be ignored."
+          raise ArgumentError, "WARNING: `:suite` hooks do not support metadata since " \
+                               "they apply to the suite as a whole rather than " \
+                               "any individual example or example group that has metadata. " \
+                               "The metadata you have provided (#{meta.inspect}) will be ignored."
         end
 
         yield
@@ -2202,7 +2037,7 @@ module RSpec
       end
 
       def get_files_to_run(paths)
-        files = FlatMap.flat_map(paths_to_check(paths)) do |path|
+        files = paths_to_check(paths).flat_map do |path|
           path = path.gsub(File::ALT_SEPARATOR, File::SEPARATOR) if File::ALT_SEPARATOR
           File.directory?(path) ? gather_directories(path) : extract_location(path)
         end.uniq
@@ -2308,29 +2143,6 @@ module RSpec
         output.respond_to?(:tty?) && output.tty?
       end
 
-      def conditionally_disable_mocks_monkey_patching
-        return unless disable_monkey_patching && rspec_mocks_loaded?
-
-        RSpec::Mocks.configuration.tap do |config|
-          config.syntax = :expect
-          config.patch_marshal_to_support_partial_doubles = false
-        end
-      end
-
-      def conditionally_disable_expectations_monkey_patching
-        return unless disable_monkey_patching && rspec_expectations_loaded?
-
-        RSpec::Expectations.configuration.syntax = :expect
-      end
-
-      def rspec_mocks_loaded?
-        defined?(RSpec::Mocks.configuration)
-      end
-
-      def rspec_expectations_loaded?
-        defined?(RSpec::Expectations.configuration)
-      end
-
       def update_pattern_attr(name, value)
         if @spec_files_loaded
           RSpec.warning "Configuring `#{name}` to #{value} has no effect since " \
@@ -2375,33 +2187,19 @@ module RSpec
       end
 
       def metadata_applies_to_group?(meta, group)
-        meta.empty? || MetadataFilter.apply?(:any?, meta, group.metadata)
+        meta.empty? || MetadataFilter.apply?(meta, group.metadata)
       end
 
-      if RSpec::Support::RubyFeatures.module_prepends_supported?
-        def safe_prepend(mod, host)
-          host.__send__(:prepend, mod) unless host < mod
-        end
+      def safe_prepend(mod, host)
+        host.prepend(mod) unless host < mod
       end
 
-      if RUBY_VERSION.to_f >= 1.9
-        def safe_include(mod, host)
-          host.__send__(:include, mod) unless host < mod
-        end
-
-        def safe_extend(mod, host)
-          host.extend(mod) unless host.singleton_class < mod
-        end
-      else # for 1.8.7
-        # :nocov:
-        def safe_include(mod, host)
-          host.__send__(:include, mod) unless host.included_modules.include?(mod)
-        end
+      def safe_include(mod, host)
+        host.include(mod) unless host < mod
+      end
 
-        def safe_extend(mod, host)
-          host.extend(mod) unless (class << host; self; end).included_modules.include?(mod)
-        end
-        # :nocov:
+      def safe_extend(mod, host)
+        host.extend(mod) unless host.singleton_class < mod
       end
 
       def define_mixed_in_module(mod, filters, mod_list, config_method, &block)
@@ -2409,7 +2207,7 @@ module RSpec
           raise TypeError, "`RSpec.configuration.#{config_method}` expects a module but got: #{mod.inspect}"
         end
 
-        meta = Metadata.build_hash_from(filters, :warn_about_example_group_filtering)
+        meta = Metadata.build_hash_from(filters)
         mod_list.append(mod, meta)
         on_existing_matching_groups(meta, &block)
       end