rspec-core 3.1.7 → 3.2.0

data/lib/rspec/core/configuration_options.rb

@@ -84,15 +84,22 @@ module RSpec
         # set before it.
         :default_path,
 
-        # These must be set before `requires` to support checking `config.files_to_run`
-        # from within `spec_helper.rb` when a `-rspec_helper` option is used.
+        # These must be set before `requires` to support checking
+        # `config.files_to_run` from within `spec_helper.rb` when a
+        # `-rspec_helper` option is used.
         :files_or_directories_to_run, :pattern, :exclude_pattern,
 
-        # In general, we want to require the specified files as early as possible.
-        # The `--require` option is specifically intended to allow early requires.
-        # For later requires, they can just put the require in their spec files, but
-        # `--require` provides a unique opportunity for users to instruct RSpec to
-        # load an extension file early for maximum flexibility.
+        # Necessary so that the `--seed` option is applied before requires,
+        # in case required files do something with the provided seed.
+        # (such as seed global randomization with it).
+        :order,
+
+        # In general, we want to require the specified files as early as
+        # possible. The `--require` option is specifically intended to allow
+        # early requires. For later requires, they can just put the require in
+        # their spec files, but `--require` provides a unique opportunity for
+        # users to instruct RSpec to load an extension file early for maximum
+        # flexibility.
         :requires
       ]
 

data/lib/rspec/core/dsl.rb

@@ -8,7 +8,7 @@ module RSpec
     # By default the methods `describe`, `context` and `example_group`
     # are exposed. These methods define a named context for one or
     # more examples. The given block is evaluated in the context of
-    # a generated subclass of {RSpec::Core::ExampleGroup}
+    # a generated subclass of {RSpec::Core::ExampleGroup}.
     #
     # ## Examples:
     #
@@ -35,6 +35,8 @@ module RSpec
 
       # @private
       def self.expose_example_group_alias(name)
+        return if example_group_aliases.include?(name)
+
         example_group_aliases << name
 
         (class << RSpec; self; end).__send__(:define_method, name) do |*args, &example_group_block|
@@ -49,7 +51,7 @@ module RSpec
         attr_accessor :top_level
       end
 
-      # Adds the describe method to Module and the top level binding
+      # Adds the describe method to Module and the top level binding.
       # @api private
       def self.expose_globally!
         return if exposed_globally?
@@ -61,7 +63,7 @@ module RSpec
         @exposed_globally = true
       end
 
-      # Removes the describe method from Module and the top level binding
+      # Removes the describe method from Module and the top level binding.
       # @api private
       def self.remove_globally!
         return unless exposed_globally?
@@ -76,6 +78,7 @@ module RSpec
       # @private
       def self.expose_example_group_alias_globally(method_name)
         change_global_dsl do
+          remove_method(method_name) if method_defined?(method_name)
           define_method(method_name) { |*a, &b| ::RSpec.__send__(method_name, *a, &b) }
         end
       end
@@ -89,5 +92,5 @@ module RSpec
   end
 end
 
-# capture main without an eval
+# Capture main without an eval.
 ::RSpec::Core::DSL.top_level = self

data/lib/rspec/core/example.rb

@@ -44,14 +44,15 @@ module RSpec
     class Example
       # @private
       #
-      # Used to define methods that delegate to this example's metadata
+      # Used to define methods that delegate to this example's metadata.
       def self.delegate_to_metadata(key)
         define_method(key) { @metadata[key] }
       end
 
       # @return [ExecutionResult] represents the result of running this example.
       delegate_to_metadata :execution_result
-      # @return [String] the relative path to the file where this example was defined.
+      # @return [String] the relative path to the file where this example was
+      #   defined.
       delegate_to_metadata :file_path
       # @return [String] the full description (including the docstrings of
       #   all parent example groups).
@@ -59,22 +60,22 @@ module RSpec
       # @return [String] the exact source location of this example in a form
       #   like `./path/to/spec.rb:17`
       delegate_to_metadata :location
-      # @return [Boolean] flag that indicates that the example is not expected to pass.
-      #   It will be run and will either have a pending result (if a failure occurs)
-      #   or a failed result (if no failure occurs).
+      # @return [Boolean] flag that indicates that the example is not expected
+      #   to pass. It will be run and will either have a pending result (if a
+      #   failure occurs) or a failed result (if no failure occurs).
       delegate_to_metadata :pending
       # @return [Boolean] flag that will cause the example to not run.
       #   The {ExecutionResult} status will be `:pending`.
       delegate_to_metadata :skip
 
       # Returns the string submitted to `example` or its aliases (e.g.
-      # `specify`, `it`, etc).  If no string is submitted (e.g. `it { is_expected.to
-      # do_something }`) it returns the message generated by the matcher if
-      # there is one, otherwise returns a message including the location of the
-      # example.
+      # `specify`, `it`, etc). If no string is submitted (e.g.
+      # `it { is_expected.to do_something }`) it returns the message generated
+      # by the matcher if there is one, otherwise returns a message including
+      # the location of the example.
       def description
         description = if metadata[:description].to_s.empty?
-                        "example at #{location}"
+                        location_description
                       else
                         metadata[:description]
                       end
@@ -82,10 +83,28 @@ module RSpec
         RSpec.configuration.format_docstrings_block.call(description)
       end
 
+      # Returns a description of the example that always includes the location.
+      def inspect_output
+        inspect_output = "\"#{description}\""
+        unless metadata[:description].to_s.empty?
+          inspect_output << " (#{location})"
+        end
+        inspect_output
+      end
+
+      # Returns the argument that can be passed to the `rspec` command to rerun this example.
+      def rerun_argument
+        loaded_spec_files = RSpec.configuration.loaded_spec_files
+
+        Metadata.ascending(metadata) do |meta|
+          return meta[:location] if loaded_spec_files.include?(meta[:absolute_file_path])
+        end
+      end
+
       # @attr_reader
       #
       # Returns the first exception raised in the context of running this
-      # example (nil if no exception is raised)
+      # example (nil if no exception is raised).
       attr_reader :exception
 
       # @attr_reader
@@ -105,10 +124,14 @@ module RSpec
       attr_accessor :clock
 
       # Creates a new instance of Example.
-      # @param example_group_class [Class] the subclass of ExampleGroup in which this Example is declared
-      # @param description [String] the String passed to the `it` method (or alias)
-      # @param user_metadata [Hash] additional args passed to `it` to be used as metadata
-      # @param example_block [Proc] the block of code that represents the example
+      # @param example_group_class [Class] the subclass of ExampleGroup in which
+      #   this Example is declared
+      # @param description [String] the String passed to the `it` method (or
+      #   alias)
+      # @param user_metadata [Hash] additional args passed to `it` to be used as
+      #   metadata
+      # @param example_block [Proc] the block of code that represents the
+      #   example
       # @api private
       def initialize(example_group_class, description, user_metadata, example_block=nil)
         @example_group_class = example_group_class
@@ -137,6 +160,8 @@ module RSpec
       # @param example_group_instance the instance of an ExampleGroup subclass
       def run(example_group_instance, reporter)
         @example_group_instance = example_group_instance
+        hooks.register_global_singleton_context_hooks(self, RSpec.configuration.hooks)
+        RSpec.configuration.configure_example(self)
         RSpec.current_example = self
 
         start(reporter)
@@ -146,7 +171,7 @@ module RSpec
           if skipped?
             Pending.mark_pending! self, skip
           elsif !RSpec.configuration.dry_run?
-            with_around_example_hooks do
+            with_around_and_singleton_context_hooks do
               begin
                 run_before_example
                 @example_group_instance.instance_exec(self, &@example_block)
@@ -171,7 +196,7 @@ module RSpec
         rescue Exception => e
           set_exception(e)
         ensure
-          @example_group_instance.instance_variables.each do |ivar|
+          ExampleGroup.each_instance_variable_for_example(@example_group_instance) do |ivar|
             @example_group_instance.instance_variable_set(ivar, nil)
           end
           @example_group_instance = nil
@@ -194,7 +219,7 @@ module RSpec
       #         if ex.metadata[:key] == :some_value && some_global_condition
       #           raise "some message"
       #         end
-      #         ex.run         # run delegates to ex.call
+      #         ex.run         # run delegates to ex.call.
       #       end
       #     end
       #
@@ -223,7 +248,8 @@ module RSpec
         end
         alias run call
 
-        # Provides a wrapped proc that will update our `executed?` state when executed.
+        # Provides a wrapped proc that will update our `executed?` state when
+        # executed.
         def to_proc
           method(:call).to_proc
         end
@@ -250,21 +276,6 @@ module RSpec
         end
       end
 
-      # @private
-      def any_apply?(filters)
-        MetadataFilter.any_apply?(filters, metadata)
-      end
-
-      # @private
-      def all_apply?(filters)
-        MetadataFilter.all_apply?(filters, metadata) || @example_group_class.all_apply?(filters)
-      end
-
-      # @private
-      def around_example_hooks
-        @around_example_hooks ||= example_group.hooks.around_example_hooks_for(self)
-      end
-
       # @private
       #
       # Used internally to set an exception in an after hook, which
@@ -303,7 +314,7 @@ module RSpec
       # @private
       #
       # Used internally to skip without actually executing the example when
-      # skip is used in before(:context)
+      # skip is used in before(:context).
       def skip_with_exception(reporter, exception)
         start(reporter)
         Pending.mark_skipped! self, exception.argument
@@ -324,12 +335,12 @@ module RSpec
 
     private
 
-      def with_around_example_hooks(&block)
-        if around_example_hooks.empty?
-          yield
-        else
-          @example_group_class.hooks.run(:around, :example, self, Procsy.new(self, &block))
-        end
+      def hooks
+        example_group_instance.singleton_class.hooks
+      end
+
+      def with_around_example_hooks
+        hooks.run(:around, :example, self) { yield }
       rescue Exception => e
         set_exception(e, "in an `around(:example)` hook")
       end
@@ -365,15 +376,21 @@ module RSpec
 
       def run_before_example
         @example_group_instance.setup_mocks_for_rspec
-        @example_group_class.hooks.run(:before, :example, self)
+        hooks.run(:before, :example, self)
+      end
+
+      def with_around_and_singleton_context_hooks
+        singleton_context_hooks_host = example_group_instance.singleton_class
+        singleton_context_hooks_host.run_before_context_hooks(example_group_instance)
+        with_around_example_hooks { yield }
+      ensure
+        singleton_context_hooks_host.run_after_context_hooks(example_group_instance)
       end
 
       def run_after_example
-        @example_group_class.hooks.run(:after, :example, self)
+        assign_generated_description if defined?(::RSpec::Matchers)
+        hooks.run(:after, :example, self)
         verify_mocks
-        assign_generated_description if RSpec.configuration.expecting_with_rspec?
-      rescue Exception => e
-        set_exception(e, "in an `after(:example)` hook")
       ensure
         @example_group_instance.teardown_mocks_for_rspec
       end
@@ -383,6 +400,7 @@ module RSpec
       rescue Exception => e
         if pending?
           execution_result.pending_fixed = false
+          execution_result.pending_exception = e
           @exception = nil
         else
           set_exception(e)
@@ -394,16 +412,25 @@ module RSpec
       end
 
       def assign_generated_description
-        if metadata[:description].empty? && (description = RSpec::Matchers.generated_description)
+        if metadata[:description].empty? && (description = generate_description)
           metadata[:description] = description
           metadata[:full_description] << description
         end
-      rescue Exception => e
-        set_exception(e, "while assigning the example description")
       ensure
         RSpec::Matchers.clear_generated_description
       end
 
+      def generate_description
+        RSpec::Matchers.generated_description
+      rescue Exception => e
+        location_description + " (Got an error when generating description " \
+          "from matcher: #{e.class}: #{e.message} -- #{e.backtrace.first})"
+      end
+
+      def location_description
+        "example at #{location}"
+      end
+
       def skip_message
         if String === skip
           skip
@@ -448,6 +475,15 @@ module RSpec
 
         alias pending_fixed? pending_fixed
 
+        # @return [Boolean] Indicates if the example was completely skipped
+        #   (typically done via `:skip` metadata or the `skip` method). Skipped examples
+        #   will have a `:pending` result. A `:pending` result can also come from examples
+        #   that were marked as `:pending`, which causes them to be run, and produces a
+        #   `:failed` result if the example passes.
+        def example_skipped?
+          status == :pending && !pending_exception
+        end
+
         # @api private
         # Records the finished status of the example.
         def record_finished(status, finished_at)
@@ -493,7 +529,7 @@ module RSpec
         super(AnonymousExampleGroup, "", {})
       end
 
-      # To ensure we don't silence errors...
+      # To ensure we don't silence errors.
       def set_exception(exception, _context=nil)
         raise exception
       end

data/lib/rspec/core/example_group.rb

@@ -3,7 +3,7 @@ RSpec::Support.require_rspec_support 'recursive_const_methods'
 module RSpec
   module Core
     # ExampleGroup and {Example} are the main structural elements of
-    # rspec-core.  Consider this example:
+    # rspec-core. Consider this example:
     #
     #     describe Thing do
     #       it "does something" do
@@ -17,13 +17,13 @@ module RSpec
     #
     # Example group bodies (e.g. `describe` or `context` blocks) are evaluated
     # in the context of a new subclass of ExampleGroup. Individual examples are
-    # evaluated in the context of an instance of the specific ExampleGroup subclass
-    # to which they belong.
+    # evaluated in the context of an instance of the specific ExampleGroup
+    # subclass to which they belong.
     #
     # Besides the class methods defined here, there are other interesting macros
-    # defined in {Hooks}, {MemoizedHelpers::ClassMethods} and {SharedExampleGroup}.
-    # There are additional instance methods available to your examples defined in
-    # {MemoizedHelpers} and {Pending}.
+    # defined in {Hooks}, {MemoizedHelpers::ClassMethods} and
+    # {SharedExampleGroup}. There are additional instance methods available to
+    # your examples defined in {MemoizedHelpers} and {Pending}.
     class ExampleGroup
       extend Hooks
 
@@ -32,10 +32,11 @@ module RSpec
       include Pending
       extend SharedExampleGroup
 
-      unless respond_to?(:define_singleton_method)
-        # @private
-        def self.define_singleton_method(*a, &b)
-          (class << self; self; end).__send__(:define_method, *a, &b)
+      # @private
+      def self.idempotently_define_singleton_method(name, &definition)
+        (class << self; self; end).module_exec do
+          remove_method(name) if method_defined?(name)
+          define_method(name, &definition)
         end
       end
 
@@ -44,7 +45,21 @@ module RSpec
       # The [Metadata](Metadata) object associated with this group.
       # @see Metadata
       def self.metadata
-        @metadata if defined?(@metadata)
+        @metadata ||= nil
+      end
+
+      # Temporarily replace the provided metadata.
+      # Intended primarily to allow an example group's singleton class
+      # to return the metadata of the example that it exists for. This
+      # is necessary for shared example group inclusion to work properly
+      # with singleton example groups.
+      # @private
+      def self.with_replaced_metadata(meta)
+        orig_metadata = metadata
+        @metadata = meta
+        yield
+      ensure
+        @metadata = orig_metadata
       end
 
       # @private
@@ -56,7 +71,7 @@ module RSpec
       # @private
       def self.delegate_to_metadata(*names)
         names.each do |name|
-          define_singleton_method(name) { metadata.fetch(name) }
+          idempotently_define_singleton_method(name) { metadata.fetch(name) }
         end
       end
 
@@ -77,7 +92,6 @@ module RSpec
       #       end
       #     end
       #
-      #
       def described_class
         self.class.described_class
       end
@@ -89,9 +103,20 @@ module RSpec
       # @private
       # @macro [attach] define_example_method
       #   @!scope class
-      #   @param name [String]
-      #   @param extra_options [Hash]
-      #   @param implementation [Block]
+      #   @overload $1
+      #   @overload $1(&example_implementation)
+      #     @param example_implementation [Block] The implementation of the example.
+      #   @overload $1(doc_string, *metadata_keys, metadata={})
+      #     @param doc_string [String] The example's doc string.
+      #     @param metadata [Hash] Metadata for the example.
+      #     @param metadata_keys [Array<Symbol>] Metadata tags for the example.
+      #       Will be transformed into hash entries with `true` values.
+      #   @overload $1(doc_string, *metadata_keys, metadata={}, &example_implementation)
+      #     @param doc_string [String] The example's doc string.
+      #     @param metadata [Hash] Metadata for the example.
+      #     @param metadata_keys [Array<Symbol>] Metadata tags for the example.
+      #       Will be transformed into hash entries with `true` values.
+      #     @param example_implementation [Block] The implementation of the example.
       #   @yield [Example] the example object
       #   @example
       #     $1 do
@@ -100,6 +125,9 @@ module RSpec
       #     $1 "does something" do
       #     end
       #
+      #     $1 "does something", :slow, :uses_js do
+      #     end
+      #
       #     $1 "does something", :with => 'additional metadata' do
       #     end
       #
@@ -107,7 +135,7 @@ module RSpec
       #       # ex is the Example object that contains metadata about the example
       #     end
       def self.define_example_method(name, extra_options={})
-        define_singleton_method(name) do |*all_args, &block|
+        idempotently_define_singleton_method(name) do |*all_args, &block|
           desc, *args = *all_args
 
           options = Metadata.build_hash_from(args)
@@ -134,25 +162,25 @@ module RSpec
       #  end
       define_example_method :specify
 
-      # Shortcut to define an example with `:focus => true`
+      # Shortcut to define an example with `:focus => true`.
       # @see example
       define_example_method :focus,    :focus => true
-      # Shortcut to define an example with `:focus => true`
+      # Shortcut to define an example with `:focus => true`.
       # @see example
       define_example_method :fexample, :focus => true
-      # Shortcut to define an example with `:focus => true`
+      # Shortcut to define an example with `:focus => true`.
       # @see example
       define_example_method :fit,      :focus => true
-      # Shortcut to define an example with `:focus => true`
+      # Shortcut to define an example with `:focus => true`.
       # @see example
       define_example_method :fspecify, :focus => true
-      # Shortcut to define an example with `:skip => 'Temporarily skipped with xexample'`
+      # Shortcut to define an example with `:skip => 'Temporarily skipped with xexample'`.
       # @see example
       define_example_method :xexample, :skip => 'Temporarily skipped with xexample'
-      # Shortcut to define an example with `:skip => 'Temporarily skipped with xit'`
+      # Shortcut to define an example with `:skip => 'Temporarily skipped with xit'`.
       # @see example
       define_example_method :xit,      :skip => 'Temporarily skipped with xit'
-      # Shortcut to define an example with `:skip => 'Temporarily skipped with xspecify'`
+      # Shortcut to define an example with `:skip => 'Temporarily skipped with xspecify'`.
       # @see example
       define_example_method :xspecify, :skip => 'Temporarily skipped with xspecify'
       # Shortcut to define an example with `:skip => true`
@@ -167,11 +195,17 @@ module RSpec
       # @!group Defining Example Groups
 
       # @private
-      # @macro [attach] alias_example_group_to
+      # @macro [attach] define_example_group_method
       #   @!scope class
-      #   @param name [String] The example group doc string
-      #   @param metadata [Hash] Additional metadata to attach to the example group
-      #   @yield The example group definition
+      #   @overload $1
+      #   @overload $1(&example_group_definition)
+      #     @param example_group_definition [Block] The definition of the example group.
+      #   @overload $1(doc_string, *metadata_keys, metadata={}, &example_implementation)
+      #     @param doc_string [String] The group's doc string.
+      #     @param metadata [Hash] Metadata for the group.
+      #     @param metadata_keys [Array<Symbol>] Metadata tags for the group.
+      #       Will be transformed into hash entries with `true` values.
+      #     @param example_group_definition [Block] The definition of the example group.
       #
       #   Generates a subclass of this example group which inherits
       #   everything except the examples themselves.
@@ -195,7 +229,7 @@ module RSpec
       #
       # @see DSL#describe
       def self.define_example_group_method(name, metadata={})
-        define_singleton_method(name) do |*args, &example_group_block|
+        idempotently_define_singleton_method(name) do |*args, &example_group_block|
           thread_data = RSpec.thread_local_metadata
           top_level   = self == ExampleGroup
 
@@ -230,8 +264,8 @@ module RSpec
 
       define_example_group_method :example_group
 
-      # An alias of `example_group`. Generally used when grouping
-      # examples by a thing you are describing (e.g. an object, class or method).
+      # An alias of `example_group`. Generally used when grouping examples by a
+      # thing you are describing (e.g. an object, class or method).
       # @see example_group
       define_example_group_method :describe
 
@@ -266,12 +300,12 @@ module RSpec
       #
       #   @see SharedExampleGroup
       def self.define_nested_shared_group_method(new_name, report_label="it should behave like")
-        define_singleton_method(new_name) do |name, *args, &customization_block|
-          # Pass :caller so the :location metadata is set properly...
-          # otherwise, it'll be set to the next line because that's
+        idempotently_define_singleton_method(new_name) do |name, *args, &customization_block|
+          # Pass :caller so the :location metadata is set properly.
+          # Otherwise, it'll be set to the next line because that's
           # the block's source_location.
-          group = example_group("#{report_label} #{name}", :caller => caller) do
-            find_and_eval_shared("examples", name, *args, &customization_block)
+          group = example_group("#{report_label} #{name}", :caller => (the_caller = caller)) do
+            find_and_eval_shared("examples", name, the_caller.first, *args, &customization_block)
           end
           group.metadata[:shared_group_name] = name
           group
@@ -287,32 +321,36 @@ module RSpec
 
       # Includes shared content mapped to `name` directly in the group in which
       # it is declared, as opposed to `it_behaves_like`, which creates a nested
-      # group. If given a block, that block is also eval'd in the current context.
+      # group. If given a block, that block is also eval'd in the current
+      # context.
       #
       # @see SharedExampleGroup
       def self.include_context(name, *args, &block)
-        find_and_eval_shared("context", name, *args, &block)
+        find_and_eval_shared("context", name, caller.first, *args, &block)
       end
 
       # Includes shared content mapped to `name` directly in the group in which
       # it is declared, as opposed to `it_behaves_like`, which creates a nested
-      # group. If given a block, that block is also eval'd in the current context.
+      # group. If given a block, that block is also eval'd in the current
+      # context.
       #
       # @see SharedExampleGroup
       def self.include_examples(name, *args, &block)
-        find_and_eval_shared("examples", name, *args, &block)
+        find_and_eval_shared("examples", name, caller.first, *args, &block)
       end
 
       # @private
-      def self.find_and_eval_shared(label, name, *args, &customization_block)
+      def self.find_and_eval_shared(label, name, inclusion_location, *args, &customization_block)
         shared_block = RSpec.world.shared_example_group_registry.find(parent_groups, name)
 
         unless shared_block
           raise ArgumentError, "Could not find shared #{label} #{name.inspect}"
         end
 
-        module_exec(*args, &shared_block)
-        module_exec(&customization_block) if customization_block
+        SharedExampleGroupInclusionStackFrame.with_frame(name, Metadata.relative_path(inclusion_location)) do
+          module_exec(*args, &shared_block)
+          module_exec(&customization_block) if customization_block
+        end
       end
 
       # @!endgroup
@@ -338,10 +376,11 @@ module RSpec
         # Ruby 1.9 has a bug that can lead to infinite recursion and a
         # SystemStackError if you include a module in a superclass after
         # including it in a subclass: https://gist.github.com/845896
-        # To prevent this, we must include any modules in RSpec::Core::ExampleGroup
-        # before users create example groups and have a chance to include
-        # the same module in a subclass of RSpec::Core::ExampleGroup.
-        # So we need to configure example groups here.
+        # To prevent this, we must include any modules in
+        # RSpec::Core::ExampleGroup before users create example groups and have
+        # a chance to include the same module in a subclass of
+        # RSpec::Core::ExampleGroup. So we need to configure example groups
+        # here.
         ensure_example_groups_are_configured
 
         description = args.shift
@@ -353,7 +392,7 @@ module RSpec
         )
 
         hooks.register_globals(self, RSpec.configuration.hooks)
-        RSpec.world.configure_group(self)
+        RSpec.configuration.configure_group(self)
       end
 
       # @private
@@ -368,7 +407,8 @@ module RSpec
 
       # @private
       def self.descendant_filtered_examples
-        @descendant_filtered_examples ||= filtered_examples + children.inject([]) { |a, e| a + e.descendant_filtered_examples }
+        @descendant_filtered_examples ||= filtered_examples +
+          FlatMap.flat_map(children, &:descendant_filtered_examples)
       end
 
       # @private
@@ -378,7 +418,7 @@ module RSpec
 
       # @private
       def self.descendants
-        @_descendants ||= [self] + children.inject([]) { |a, e| a + e.descendants }
+        @_descendants ||= [self] + FlatMap.flat_map(children, &:descendants)
       end
 
       ## @private
@@ -409,47 +449,66 @@ module RSpec
 
       # @private
       def self.store_before_context_ivars(example_group_instance)
-        return if example_group_instance.instance_variables.empty?
-
-        example_group_instance.instance_variables.each do |ivar|
+        each_instance_variable_for_example(example_group_instance) do |ivar|
           before_context_ivars[ivar] = example_group_instance.instance_variable_get(ivar)
         end
       end
 
       # @private
       def self.run_before_context_hooks(example_group_instance)
-        return if descendant_filtered_examples.empty?
-        begin
-          set_ivars(example_group_instance, superclass.before_context_ivars)
+        set_ivars(example_group_instance, superclass_before_context_ivars)
+
+        ContextHookMemoizedHash::Before.isolate_for_context_hook(example_group_instance) do
+          hooks.run(:before, :context, example_group_instance)
+        end
+      ensure
+        store_before_context_ivars(example_group_instance)
+      end
 
-          ContextHookMemoizedHash::Before.isolate_for_context_hook(example_group_instance) do
-            hooks.run(:before, :context, example_group_instance)
+      if RUBY_VERSION.to_f >= 1.9
+        # @private
+        def self.superclass_before_context_ivars
+          superclass.before_context_ivars
+        end
+      else # 1.8.7
+        # @private
+        def self.superclass_before_context_ivars
+          if superclass.respond_to?(:before_context_ivars)
+            superclass.before_context_ivars
+          else
+            # `self` must be the singleton class of an ExampleGroup instance.
+            # On 1.8.7, the superclass of a singleton class of an instance of A
+            # is A's singleton class. On 1.9+, it's A. On 1.8.7, the first ancestor
+            # is A, so we can mirror 1.8.7's behavior here. Note that we have to
+            # search for the first that responds to `before_context_ivars`
+            # in case a module has been included in the singleton class.
+            ancestors.find { |a| a.respond_to?(:before_context_ivars) }.before_context_ivars
           end
-        ensure
-          store_before_context_ivars(example_group_instance)
         end
       end
 
       # @private
       def self.run_after_context_hooks(example_group_instance)
-        return if descendant_filtered_examples.empty?
         set_ivars(example_group_instance, before_context_ivars)
 
         ContextHookMemoizedHash::After.isolate_for_context_hook(example_group_instance) do
           hooks.run(:after, :context, example_group_instance)
         end
+      ensure
+        before_context_ivars.clear
       end
 
-      # Runs all the examples in this group
-      def self.run(reporter)
+      # Runs all the examples in this group.
+      def self.run(reporter=RSpec::Core::NullReporter.new)
         if RSpec.world.wants_to_quit
           RSpec.world.clear_remaining_example_groups if top_level?
           return
         end
         reporter.example_group_started(self)
 
+        should_run_context_hooks = descendant_filtered_examples.any?
         begin
-          run_before_context_hooks(new)
+          run_before_context_hooks(new('before(:context) hook')) if should_run_context_hooks
           result_for_this_group = run_examples(reporter)
           results_for_descendants = ordering_strategy.order(children).map { |child| child.run(reporter) }.all?
           result_for_this_group && results_for_descendants
@@ -459,8 +518,7 @@ module RSpec
           RSpec.world.wants_to_quit = true if fail_fast?
           for_filtered_examples(reporter) { |example| example.fail_with_exception(reporter, ex) }
         ensure
-          run_after_context_hooks(new)
-          before_context_ivars.clear
+          run_after_context_hooks(new('after(:context) hook')) if should_run_context_hooks
           reporter.example_group_finished(self)
         end
       end
@@ -485,7 +543,7 @@ module RSpec
       def self.run_examples(reporter)
         ordering_strategy.order(filtered_examples).map do |example|
           next if RSpec.world.wants_to_quit
-          instance = new
+          instance = new(example.inspect_output)
           set_ivars(instance, before_context_ivars)
           succeeded = example.run(instance, reporter)
           RSpec.world.wants_to_quit = true if fail_fast? && !succeeded
@@ -510,21 +568,11 @@ module RSpec
         RSpec.configuration.fail_fast?
       end
 
-      # @private
-      def self.any_apply?(filters)
-        MetadataFilter.any_apply?(filters, metadata)
-      end
-
-      # @private
-      def self.all_apply?(filters)
-        MetadataFilter.all_apply?(filters, metadata)
-      end
-
       # @private
       def self.declaration_line_numbers
         @declaration_line_numbers ||= [metadata[:line_number]] +
           examples.map { |e| e.metadata[:line_number] } +
-          children.inject([]) { |a, e| a + e.declaration_line_numbers }
+          FlatMap.flat_map(children, &:declaration_line_numbers)
       end
 
       # @private
@@ -536,6 +584,70 @@ module RSpec
       def self.set_ivars(instance, ivars)
         ivars.each { |name, value| instance.instance_variable_set(name, value) }
       end
+
+      if RUBY_VERSION.to_f < 1.9
+        # @private
+        INSTANCE_VARIABLE_TO_IGNORE = '@__inspect_output'.freeze
+      else
+        # @private
+        INSTANCE_VARIABLE_TO_IGNORE = :@__inspect_output
+      end
+
+      # @private
+      def self.each_instance_variable_for_example(group)
+        group.instance_variables.each do |ivar|
+          yield ivar unless ivar == INSTANCE_VARIABLE_TO_IGNORE
+        end
+      end
+
+      def initialize(inspect_output=nil)
+        @__inspect_output = inspect_output || '(no description provided)'
+      end
+
+      # @private
+      def inspect
+        "#<#{self.class} #{@__inspect_output}>"
+      end
+
+      unless method_defined?(:singleton_class) # for 1.8.7
+        # @private
+        def singleton_class
+          class << self; self; end
+        end
+      end
+
+      # Raised when an RSpec API is called in the wrong scope, such as `before`
+      # being called from within an example rather than from within an example
+      # group block.
+      WrongScopeError = Class.new(NoMethodError)
+
+      def self.method_missing(name, *args)
+        if method_defined?(name)
+          raise WrongScopeError,
+                "`#{name}` is not available on an example group (e.g. a " \
+                "`describe` or `context` block). It is only available from " \
+                "within individual examples (e.g. `it` blocks) or from " \
+                "constructs that run in the scope of an example (e.g. " \
+                "`before`, `let`, etc)."
+        end
+
+        super
+      end
+      private_class_method :method_missing
+
+    private
+
+      def method_missing(name, *args)
+        if self.class.respond_to?(name)
+          raise WrongScopeError,
+                "`#{name}` is not available from within an example (e.g. an " \
+                "`it` block) or from constructs that run in the scope of an " \
+                "example (e.g. `before`, `let`, etc). It is only available " \
+                "on an example group (e.g. a `describe` or `context` block)."
+        end
+
+        super
+      end
     end
 
     # @private
@@ -545,11 +657,55 @@ module RSpec
         {}
       end
     end
+
+    # Contains information about the inclusion site of a shared example group.
+    class SharedExampleGroupInclusionStackFrame
+      # @return [String] the name of the shared example group
+      attr_reader :shared_group_name
+      # @return [String] the location where the shared example was included
+      attr_reader :inclusion_location
+
+      def initialize(shared_group_name, inclusion_location)
+        @shared_group_name  = shared_group_name
+        @inclusion_location = inclusion_location
+      end
+
+      # @return [String] The {#inclusion_location}, formatted for display by a formatter.
+      def formatted_inclusion_location
+        @formatted_inclusion_location ||= begin
+          RSpec.configuration.backtrace_formatter.backtrace_line(
+            inclusion_location.sub(/(:\d+):in .+$/, '\1')
+          )
+        end
+      end
+
+      # @return [String] Description of this stack frame, in the form used by
+      #   RSpec's built-in formatters.
+      def description
+        @description ||= "Shared Example Group: #{shared_group_name.inspect} " \
+          "called from #{formatted_inclusion_location}"
+      end
+
+      # @private
+      def self.current_backtrace
+        RSpec.thread_local_metadata[:shared_example_group_inclusions].reverse
+      end
+
+      # @private
+      def self.with_frame(name, location)
+        current_stack = RSpec.thread_local_metadata[:shared_example_group_inclusions]
+        current_stack << new(name, location)
+        yield
+      ensure
+        current_stack.pop
+      end
+    end
   end
 
   # @private
   #
-  # Namespace for the example group subclasses generated by top-level `describe`.
+  # Namespace for the example group subclasses generated by top-level
+  # `describe`.
   module ExampleGroups
     extend Support::RecursiveConstMethods
 
@@ -570,16 +726,20 @@ module RSpec
     def self.base_name_for(group)
       return "Anonymous" if group.description.empty?
 
-      # convert to CamelCase
-      name = ' ' + group.description
-      name.gsub!(/[^0-9a-zA-Z]+([0-9a-zA-Z])/) { Regexp.last_match[1].upcase }
+      # Convert to CamelCase.
+      name = ' ' << group.description
+      name.gsub!(/[^0-9a-zA-Z]+([0-9a-zA-Z])/) do
+        match = ::Regexp.last_match[1]
+        match.upcase!
+        match
+      end
 
-      name.lstrip!         # Remove leading whitespace
-      name.gsub!(/\W/, '') # JRuby, RBX and others don't like non-ascii in const names
+      name.lstrip!                # Remove leading whitespace
+      name.gsub!(/\W/, ''.freeze) # JRuby, RBX and others don't like non-ascii in const names
 
       # Ruby requires first const letter to be A-Z. Use `Nested`
       # as necessary to enforce that.
-      name.gsub!(/\A([^A-Z]|\z)/, 'Nested\1')
+      name.gsub!(/\A([^A-Z]|\z)/, 'Nested\1'.freeze)
 
       name
     end
@@ -597,7 +757,8 @@ module RSpec
     def self.disambiguate(name, const_scope)
       return name unless const_defined_on?(const_scope, name)
 
-      # Add a trailing number if needed to disambiguate from an existing constant.
+      # Add a trailing number if needed to disambiguate from an existing
+      # constant.
       name << "_2"
       name.next! while const_defined_on?(const_scope, name)
       name