rspec-core 2.99.2 → 3.0.0.beta1

data/spec/rspec/core/example_spec.rb

@@ -350,6 +350,45 @@ describe RSpec::Core::Example, :parent_metadata => 'sample' do
         expect(actual.__id__).to eq(exception.__id__)
       end
     end
+
+    context "with --dry-run" do
+      before { RSpec.configuration.dry_run = true }
+
+      it "does not execute any examples or hooks" do
+        executed = []
+
+        RSpec.configure do |c|
+          c.before(:each) { executed << :before_each_config }
+          c.before(:all)  { executed << :before_all_config }
+          c.after(:each)  { executed << :after_each_config }
+          c.after(:all)   { executed << :after_all_config }
+          c.around(:each) { |ex| executed << :around_each_config; ex.run }
+        end
+
+        group = RSpec::Core::ExampleGroup.describe do
+          before(:all)  { executed << :before_all }
+          before(:each) { executed << :before_each }
+          after(:all)   { executed << :after_all }
+          after(:each)  { executed << :after_each }
+          around(:each) { |ex| executed << :around_each; ex.run }
+
+          example { executed << :example }
+
+          context "nested" do
+            before(:all)  { executed << :nested_before_all }
+            before(:each) { executed << :nested_before_each }
+            after(:all)   { executed << :nested_after_all }
+            after(:each)  { executed << :nested_after_each }
+            around(:each) { |ex| executed << :nested_around_each; ex.run }
+
+            example { executed << :nested_example }
+          end
+        end
+
+        group.run
+        expect(executed).to eq([])
+      end
+    end
   end
 
   describe "#pending" do
@@ -462,7 +501,7 @@ describe RSpec::Core::Example, :parent_metadata => 'sample' do
       context { example { values << rand } }
     end.run
 
-    expect(values.uniq).to have(2).values
+    expect(values.uniq.count).to eq(2)
   end
 
   describe "optional block argument" do
@@ -472,21 +511,6 @@ describe RSpec::Core::Example, :parent_metadata => 'sample' do
     end
   end
 
-  %w[example running_example].each do |accessor|
-    describe accessor do
-      before { allow_deprecation }
-
-      it "is deprecated" do
-        expect_warn_deprecation_with_call_site(__FILE__, __LINE__ + 1, /#{accessor}/)
-        send(accessor)
-      end
-
-      it "returns the current running example" do |ex|
-        expect(send(accessor)).to eq ex
-      end
-    end
-  end
-
   describe "setting the current example" do
     it "sets RSpec.current_example to the example that is currently running" do
       group = RSpec::Core::ExampleGroup.describe("an example group")

data/spec/rspec/core/filter_manager_spec.rb

@@ -165,7 +165,7 @@ module RSpec::Core
     describe "#inclusions#description" do
       it 'cleans up the description' do
         project_dir = File.expand_path('.')
-        expect(lambda { }.inspect).to include(project_dir) unless defined?(JRUBY_VERSION) && JRUBY_VERSION =~ /\A1\.7/
+        expect(lambda { }.inspect).to include(project_dir)
         expect(lambda { }.inspect).to include(' (lambda)') if RUBY_VERSION > '1.9'
         expect(lambda { }.inspect).to include('0x')
 
@@ -181,7 +181,7 @@ module RSpec::Core
     describe "#exclusions#description" do
       it 'cleans up the description' do
         project_dir = File.expand_path('.')
-        expect(lambda { }.inspect).to include(project_dir) unless defined?(JRUBY_VERSION) && JRUBY_VERSION =~ /\A1\.7/
+        expect(lambda { }.inspect).to include(project_dir)
         expect(lambda { }.inspect).to include(' (lambda)') if RUBY_VERSION > '1.9'
         expect(lambda { }.inspect).to include('0x')
 

data/spec/rspec/core/formatters/base_formatter_spec.rb

@@ -6,26 +6,6 @@ describe RSpec::Core::Formatters::BaseFormatter do
   let(:output)    { StringIO.new }
   let(:formatter) { RSpec::Core::Formatters::BaseFormatter.new(output) }
 
-  describe "backtrace_line" do
-    it "trims current working directory" do
-      expect(formatter.__send__(:backtrace_line, File.expand_path(__FILE__))).to eq("./spec/rspec/core/formatters/base_formatter_spec.rb")
-    end
-
-    it "leaves the original line intact" do
-      original_line = File.expand_path(__FILE__)
-      formatter.__send__(:backtrace_line, original_line)
-      expect(original_line).to eq(File.expand_path(__FILE__))
-    end
-
-    it "deals gracefully with a security error" do
-      safely do
-        formatter.__send__(:backtrace_line, __FILE__)
-        # on some rubies, this doesn't raise a SecurityError; this test just
-        # assures that if it *does* raise an error, the error is caught inside
-      end
-    end
-  end
-
   describe "read_failed_line" do
     it "deals gracefully with a heterogeneous language stack trace" do
       exception = double(:Exception, :backtrace => [
@@ -84,25 +64,4 @@ describe RSpec::Core::Formatters::BaseFormatter do
 
     end
   end
-
-  describe "#format_backtrace" do
-    let(:rspec_expectations_dir) { "/path/to/rspec-expectations/lib" }
-    let(:rspec_core_dir) { "/path/to/rspec-core/lib" }
-    let(:backtrace) do
-      [
-        "#{rspec_expectations_dir}/rspec/matchers/operator_matcher.rb:51:in `eval_match'",
-        "#{rspec_expectations_dir}/rspec/matchers/operator_matcher.rb:29:in `=='",
-        "./my_spec.rb:5",
-        "#{rspec_core_dir}/rspec/core/example.rb:52:in `run'",
-        "#{rspec_core_dir}/rspec/core/runner.rb:37:in `run'",
-        RSpec::Core::Runner::AT_EXIT_HOOK_BACKTRACE_LINE,
-        "./my_spec.rb:3"
-      ]
-    end
-
-    it "removes lines from rspec and lines that come before the invocation of the at_exit autorun hook" do
-      expect(formatter.format_backtrace(backtrace, double.as_null_object)).to eq(["./my_spec.rb:5"])
-    end
-  end
-
 end

data/spec/rspec/core/formatters/base_text_formatter_spec.rb

@@ -5,16 +5,6 @@ describe RSpec::Core::Formatters::BaseTextFormatter do
   let(:output) { StringIO.new }
   let(:formatter) { RSpec::Core::Formatters::BaseTextFormatter.new(output) }
 
-  context "when closing the formatter", :isolated_directory => true do
-    it 'does not close an already closed output stream' do
-      output = File.new("./output_to_close", "w")
-      formatter = described_class.new(output)
-      output.close
-
-      expect { formatter.close }.not_to raise_error
-    end
-  end
-
   describe "#summary_line" do
     it "with 0s outputs pluralized (excluding pending)" do
       expect(formatter.summary_line(0,0,0)).to eq("0 examples, 0 failures")
@@ -155,50 +145,6 @@ describe RSpec::Core::Formatters::BaseTextFormatter do
         end
       end
     end
-
-    context 'for #share_as' do
-      before { allow(RSpec).to receive(:deprecate) }
-
-      it 'outputs the name and location' do
-
-        group.share_as :FooBar do
-          it("example name") { expect("this").to eq("that") }
-        end
-
-        line = __LINE__.next
-        group.send(:include, FooBar)
-
-        run_all_and_dump_failures
-
-        expect(output.string).to include(
-          'Shared Example Group: "FooBar" called from ' +
-            "./spec/rspec/core/formatters/base_text_formatter_spec.rb:#{line}"
-        )
-      end
-
-      context 'that contains nested example groups' do
-        it 'outputs the name and location' do
-
-          group.share_as :NestedFoo do
-            describe 'nested group' do
-              describe 'hell' do
-                it("example name") { expect("this").to eq("that") }
-              end
-            end
-          end
-
-          line = __LINE__.next
-          group.send(:include, NestedFoo)
-
-          run_all_and_dump_failures
-
-          expect(output.string).to include(
-            'Shared Example Group: "NestedFoo" called from ' +
-              "./spec/rspec/core/formatters/base_text_formatter_spec.rb:#{line}"
-          )
-        end
-      end
-    end
   end
 
   describe "#dump_pending" do
@@ -212,7 +158,7 @@ describe RSpec::Core::Formatters::BaseTextFormatter do
     end
 
     context "with show_failures_in_pending_blocks setting enabled" do
-      before { RSpec.configuration.instance_variable_set(:@show_failures_in_pending_blocks, true) }
+      before { RSpec.configuration.stub(:show_failures_in_pending_blocks?) { true } }
 
       it "preserves formatting" do
         group.example("example name") { pending { expect("this").to eq("that") } }
@@ -294,50 +240,6 @@ describe RSpec::Core::Formatters::BaseTextFormatter do
           end
         end
       end
-
-      context 'for #share_as' do
-        before { allow(RSpec).to receive(:deprecate) }
-
-        it 'outputs the name and location' do
-
-          group.share_as :FooBar2 do
-            it("example name") { pending { expect("this").to eq("that") } }
-          end
-
-          line = __LINE__.next
-          group.send(:include, FooBar2)
-
-          run_all_and_dump_pending
-
-          expect(output.string).to include(
-            'Shared Example Group: "FooBar2" called from ' +
-            "./spec/rspec/core/formatters/base_text_formatter_spec.rb:#{line}"
-          )
-        end
-
-        context 'that contains nested example groups' do
-          it 'outputs the name and location' do
-
-            group.share_as :NestedFoo2 do
-              describe 'nested group' do
-                describe 'hell' do
-                  it("example name") { pending { expect("this").to eq("that") } }
-                end
-              end
-            end
-
-            line = __LINE__.next
-            group.send(:include, NestedFoo2)
-
-            run_all_and_dump_pending
-
-            expect(output.string).to include(
-              'Shared Example Group: "NestedFoo2" called from ' +
-              "./spec/rspec/core/formatters/base_text_formatter_spec.rb:#{line}"
-            )
-          end
-        end
-      end
     end
 
     context "with show_failures_in_pending_blocks setting disabled" do
@@ -456,7 +358,7 @@ describe RSpec::Core::Formatters::BaseTextFormatter do
   describe "custom_colors" do
     it "uses the custom success color" do
       RSpec.configure do |config|
-        config.color = true
+        config.color_enabled = true
         config.tty = true
         config.success_color = :cyan
       end
@@ -466,10 +368,6 @@ describe RSpec::Core::Formatters::BaseTextFormatter do
   end
 
   describe "#colorize" do
-    before do
-      allow(RSpec.configuration).to receive(:color_enabled?) { true }
-    end
-
     it "accepts a VT100 integer code and formats the text with it" do
        expect(formatter.colorize('abc', 32)).to eq "\e[32mabc\e[0m"
     end
@@ -483,25 +381,8 @@ describe RSpec::Core::Formatters::BaseTextFormatter do
     end
   end
 
-  describe "#const_missing name" do
-
-    it "warns of deprecation for VT100_COLORS" do
-      expect_deprecation_with_call_site __FILE__, __LINE__ + 1
-      expect(described_class::VT100_COLORS).to eq RSpec::Core::Formatters::ConsoleCodes::VT100_CODES
-    end
-
-    it "warns of deprecation for VT100_COLOR_CODES" do
-      expect_deprecation_with_call_site __FILE__, __LINE__ + 1
-      expect(described_class::VT100_COLOR_CODES).to eq RSpec::Core::Formatters::ConsoleCodes::VT100_CODES.to_set
-    end
-
-    it "behaves normally for other constants" do
-      expect { described_class::NoSuchConst }.to raise_error(NameError)
-    end
-  end
-
-  RSpec::Core::Formatters::ConsoleCodes::VT100_CODES.each do |name, number|
-    next if name == :black || name == :bold
+  described_class::VT100_COLORS.each do |name, number|
+    next if name == :black
 
     describe "##{name}" do
       before do
@@ -521,4 +402,5 @@ describe RSpec::Core::Formatters::BaseTextFormatter do
       end
     end
   end
+
 end

data/spec/rspec/core/formatters/deprecation_formatter_spec.rb

@@ -4,28 +4,6 @@ require 'tempfile'
 
 module RSpec::Core::Formatters
   describe DeprecationFormatter do
-    let(:deprecation_stream) { StringIO.new }
-    let(:summary_stream)     { StringIO.new }
-    let(:formatter) { DeprecationFormatter.new(deprecation_stream, summary_stream) }
-
-    def with_start_defined_on_kernel
-      return yield if ::Kernel.method_defined?(:start)
-
-      begin
-        ::Kernel.module_eval { def start(*); raise "boom"; end }
-        yield
-      ensure
-        ::Kernel.module_eval { undef start }
-      end
-    end
-
-    it 'does not blow up when `Kernel` defines `start`' do
-      with_start_defined_on_kernel do
-        reporter = ::RSpec::Core::Reporter.new(formatter)
-        reporter.start(3)
-      end
-    end
-
     describe "#deprecation" do
       let(:formatter) { DeprecationFormatter.new(deprecation_stream, summary_stream) }
       let(:summary_stream)     { StringIO.new }
@@ -39,23 +17,6 @@ module RSpec::Core::Formatters
           expect(deprecation_stream.read).to eq "this message\n"
         end
 
-        it "surrounds multiline messages in fenceposts" do
-          multiline_message = <<-EOS.gsub(/^\s+\|/, '')
-            |line one
-            |line two
-          EOS
-          formatter.deprecation(:message => multiline_message)
-          deprecation_stream.rewind
-
-          expected = <<-EOS.gsub(/^\s+\|/, '')
-            |--------------------------------------------------------------------------------
-            |line one
-            |line two
-            |--------------------------------------------------------------------------------
-          EOS
-          expect(deprecation_stream.read).to eq expected
-        end
-
         it "includes the method" do
           formatter.deprecation(:deprecated => "i_am_deprecated")
           deprecation_stream.rewind
@@ -125,27 +86,6 @@ module RSpec::Core::Formatters
         end
       end
 
-      context "with an Error deprecation_stream" do
-        let(:deprecation_stream) { DeprecationFormatter::RaiseErrorStream.new }
-
-        it 'prints a summary of the number of deprecations found' do
-          expect { formatter.deprecation(:deprecated => 'foo') }.to raise_error(RSpec::Core::DeprecationError)
-
-          formatter.deprecation_summary
-
-          expect(summary_stream.string).to eq("\n1 deprecation found.\n")
-        end
-
-        it 'pluralizes the count when it is greater than 1' do
-          expect { formatter.deprecation(:deprecated => 'foo') }.to raise_error(RSpec::Core::DeprecationError)
-          expect { formatter.deprecation(:deprecated => 'bar') }.to raise_error(RSpec::Core::DeprecationError)
-
-          formatter.deprecation_summary
-
-          expect(summary_stream.string).to eq("\n2 deprecations found.\n")
-        end
-      end
-
       context "with an IO deprecation_stream" do
         let(:deprecation_stream) { StringIO.new }
 
@@ -179,38 +119,13 @@ module RSpec::Core::Formatters
             |i_am_deprecated is deprecated. Called from foo.rb:1.
             |i_am_deprecated is deprecated. Called from foo.rb:2.
             |i_am_deprecated is deprecated. Called from foo.rb:3.
-            |Too many uses of deprecated 'i_am_deprecated'. #{DeprecationFormatter::DEPRECATION_STREAM_NOTICE}
-            |
-            |#{DeprecationFormatter::RAISE_ERROR_CONFIG_NOTICE}
-          EOS
-          expect(deprecation_stream.string).to eq expected.chomp
-        end
-
-        it "limits deprecations warnings by optional type" do
-          5.times {|i|
-            formatter.deprecation(
-              :deprecated => "i_am_deprecated #{i}",
-              :call_site => "foo.rb:#{i + 1}",
-              :type => 'i_am_deprecated'
-            )
-          }
-          formatter.deprecation_summary
-
-          expected = <<-EOS.gsub(/^\s+\|/, '')
-            |
-            |Deprecation Warnings:
-            |
-            |i_am_deprecated 0 is deprecated. Called from foo.rb:1.
-            |i_am_deprecated 1 is deprecated. Called from foo.rb:2.
-            |i_am_deprecated 2 is deprecated. Called from foo.rb:3.
-            |Too many uses of deprecated 'i_am_deprecated'. #{DeprecationFormatter::DEPRECATION_STREAM_NOTICE}
+            |Too many uses of deprecated 'i_am_deprecated'. Set config.deprecation_stream to a File for full output.
             |
             |#{DeprecationFormatter::RAISE_ERROR_CONFIG_NOTICE}
           EOS
           expect(deprecation_stream.string).to eq expected.chomp
         end
 
-
         it "limits :message deprecation warnings with different callsites after 3 calls" do
           5.times do |n|
             message = "This is a long string with some callsite info: /path/#{n}/to/some/file.rb:2#{n}3.  And some more stuff can come after."
@@ -224,7 +139,7 @@ module RSpec::Core::Formatters
             |This is a long string with some callsite info: /path/0/to/some/file.rb:203.  And some more stuff can come after.
             |This is a long string with some callsite info: /path/1/to/some/file.rb:213.  And some more stuff can come after.
             |This is a long string with some callsite info: /path/2/to/some/file.rb:223.  And some more stuff can come after.
-            |Too many similar deprecation messages reported, disregarding further reports. #{DeprecationFormatter::DEPRECATION_STREAM_NOTICE}
+            |Too many similar deprecation messages reported, disregarding further reports. Set config.deprecation_stream to a File for full output.
             |
             |#{DeprecationFormatter::RAISE_ERROR_CONFIG_NOTICE}
           EOS