rspec-core 2.9.0.rc2 → 2.9.0

data/Changelog.md

@@ -1,5 +1,5 @@
-### 2.9.0.rc2 / 2012-02-12
-[full changelog](http://github.com/rspec/rspec-core/compare/v2.8.0...v2.9.0.rc2)
+### 2.9.0 / 2012-03-17
+[full changelog](http://github.com/rspec/rspec-core/compare/v2.8.0...v2.9.0)
 
 Enhancements
 
@@ -19,6 +19,7 @@ Bug fixes
 * In "autorun", don't run the specs in the at_exit hook if there was an
   exception (most likely due to a SyntaxError). (sunaku)
 * Don't extend groups with modules already used to extend ancestor groups.
+* `its` correctly memoizes nil or false values (Yamada Masaki)
 
 ### 2.8.0 / 2012-01-04
 

data/lib/rspec/core/subject.rb

@@ -67,6 +67,16 @@ module RSpec
           end
         rescue LoadError
         end
+
+        def _attribute_chain(attribute)
+          attribute.to_s.split('.')
+        end
+
+        def _nested_attribute(subject, attribute)
+          _attribute_chain(attribute).inject(subject) do |subject, attr|
+            subject.send(attr)
+          end
+        end
       end
 
       module ExampleGroupMethods
@@ -122,13 +132,11 @@ module RSpec
             example do
               self.class.class_eval do
                 define_method(:subject) do
-                  @_subject ||= if attribute.is_a?(Array)
-                                  super()[*attribute]
-                                else
-                                  attribute.to_s.split('.').inject(super()) do |target, method|
-                                    target.send(method)
-                                  end
-                                end
+                  if defined?(@_subject)
+                    @_subject
+                  else
+                    @_subject = Array === attribute ? super()[*attribute] : _nested_attribute(super(), attribute)
+                  end
                 end
               end
               instance_eval(&block)

data/lib/rspec/core/version.rb

@@ -1,7 +1,7 @@
 module RSpec
   module Core
     module Version
-      STRING = '2.9.0.rc2'
+      STRING = '2.9.0'
     end
   end
 end

data/spec/rspec/core/subject_spec.rb

@@ -194,6 +194,35 @@ module RSpec::Core
         end
       end
 
+      context "with nil subject" do
+        subject do
+          Class.new do
+            def initialize
+              @counter = -1
+            end
+            def nil_if_first_time
+              @counter += 1
+              @counter == 0 ? nil : true
+            end
+          end.new
+        end
+        its(:nil_if_first_time) { should be(nil) }
+      end
+
+      context "with false subject" do
+        subject do
+          Class.new do
+            def initialize
+              @counter = -1
+            end
+            def false_if_first_time
+              @counter += 1
+              @counter > 0
+            end
+          end.new
+        end
+        its(:false_if_first_time) { should be(false) }
+      end
     end
   end
 end

metadata

@@ -1,15 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: rspec-core
 version: !ruby/object:Gem::Version 
-  hash: -2242269716
-  prerelease: 6
+  hash: 43
+  prerelease: 
   segments: 
   - 2
   - 9
   - 0
-  - rc
-  - 2
-  version: 2.9.0.rc2
+  version: 2.9.0
 platform: ruby
 authors: 
 - Steven Baker
@@ -19,7 +17,7 @@ autorequire:
 bindir: exe
 cert_chain: []
 
-date: 2012-03-12 00:00:00 Z
+date: 2012-03-17 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: cucumber
@@ -363,21 +361,19 @@ required_ruby_version: !ruby/object:Gem::Requirement
 required_rubygems_version: !ruby/object:Gem::Requirement 
   none: false
   requirements: 
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version 
-      hash: 25
+      hash: 3
       segments: 
-      - 1
-      - 3
-      - 1
-      version: 1.3.1
+      - 0
+      version: "0"
 requirements: []
 
 rubyforge_project: rspec
 rubygems_version: 1.8.15
 signing_key: 
 specification_version: 3
-summary: rspec-core-2.9.0.rc2
+summary: rspec-core-2.9.0
 test_files: 
 - features/Autotest.md
 - features/README.md