rspec-core 2.6.0 → 2.7.0.rc1

data/spec/rspec/core/example_group_spec.rb

@@ -28,12 +28,12 @@ module RSpec::Core
 
       it 'processes string args as part of the description' do
         group = ExampleGroup.describe("some", "separate", "strings")
-        group.description.should == "some separate strings"
+        group.description.should eq("some separate strings")
       end
 
       it 'processes symbol args as part of the description' do
         group = ExampleGroup.describe(:some, :separate, :symbols)
-        group.description.should == "some separate symbols"
+        group.description.should eq("some separate symbols")
       end
     end
 
@@ -48,7 +48,7 @@ module RSpec::Core
       end
 
       it 'treats the first argument as part of the description when it is a symbol' do
-        group.description.should == "symbol"
+        group.description.should eq("symbol")
       end
     end
 
@@ -95,7 +95,7 @@ module RSpec::Core
               describe("grandchild 2") {}
             end
           end
-          group.descendants.size.should == 4
+          group.descendants.size.should eq(4)
         end
       end
     end
@@ -104,7 +104,7 @@ module RSpec::Core
       it "is known by parent" do
         parent = ExampleGroup.describe
         child = parent.describe
-        parent.children.should == [child]
+        parent.children.should eq([child])
       end
 
       it "is not registered in world" do
@@ -112,7 +112,7 @@ module RSpec::Core
         parent = ExampleGroup.describe
         world.register(parent)
         child = parent.describe
-        world.example_groups.should == [parent]
+        world.example_groups.should eq([parent])
       end
     end
 
@@ -128,7 +128,7 @@ module RSpec::Core
             group.stub(:world) { world }
             all_examples = [ group.example("first"), group.example("second") ]
 
-            group.filtered_examples.should == all_examples
+            group.filtered_examples.should eq(all_examples)
           end
 
           it "includes examples directly matching filter" do
@@ -140,7 +140,7 @@ module RSpec::Core
             ]
             group.example("third (not-filtered)")
 
-            group.filtered_examples.should == filtered_examples
+            group.filtered_examples.should eq(filtered_examples)
           end
         end
 
@@ -163,7 +163,7 @@ module RSpec::Core
             ]
             unfiltered_example = group.example("third (not-filtered)")
 
-            group.filtered_examples.should == [unfiltered_example]
+            group.filtered_examples.should eq([unfiltered_example])
           end
         end
       end
@@ -239,7 +239,7 @@ module RSpec::Core
           group = ExampleGroup.describe
           group.stub(:world) { world }
           example = group.example("does something")
-          group.filtered_examples.should == [example]
+          group.filtered_examples.should eq([example])
         end
       end
 
@@ -249,7 +249,7 @@ module RSpec::Core
           group = ExampleGroup.describe
           group.stub(:world) { world }
           example = group.example("does something")
-          group.filtered_examples.should == []
+          group.filtered_examples.should eq([])
         end
       end
     end
@@ -258,7 +258,7 @@ module RSpec::Core
 
       context "with a constant as the first parameter" do
         it "is that constant" do
-          ExampleGroup.describe(Object) { }.describes.should == Object
+          ExampleGroup.describe(Object) { }.describes.should eq(Object)
         end
       end
 
@@ -308,7 +308,7 @@ module RSpec::Core
     describe '#description' do
       it "grabs the description from the metadata" do
         group = ExampleGroup.describe(Object, "my desc") { }
-        group.description.should == group.metadata[:example_group][:description]
+        group.description.should eq(group.metadata[:example_group][:description])
       end
     end
 
@@ -318,15 +318,15 @@ module RSpec::Core
       end
 
       it "adds the the file_path to metadata" do
-        ExampleGroup.describe(Object) { }.metadata[:example_group][:file_path].should == __FILE__
+        ExampleGroup.describe(Object) { }.metadata[:example_group][:file_path].should eq(__FILE__)
       end
 
       it "has a reader for file_path" do
-        ExampleGroup.describe(Object) { }.file_path.should == __FILE__
+        ExampleGroup.describe(Object) { }.file_path.should eq(__FILE__)
       end
 
       it "adds the line_number to metadata" do
-        ExampleGroup.describe(Object) { }.metadata[:example_group][:line_number].should == __LINE__
+        ExampleGroup.describe(Object) { }.metadata[:example_group][:line_number].should eq(__LINE__)
       end
     end
 
@@ -454,7 +454,7 @@ module RSpec::Core
 
         group.run
 
-        order.should == [
+        order.should eq([
           :before_all_defined_in_config,
           :top_level_before_all,
           :before_each,
@@ -470,7 +470,7 @@ module RSpec::Core
           :nested_after_all,
           :top_level_after_all,
           :after_all_defined_in_config
-        ]
+        ])
       end
 
       context "after(:all)" do
@@ -509,22 +509,22 @@ module RSpec::Core
       it "treats an error in before(:each) as a failure" do
         group = ExampleGroup.describe
         group.before(:each) { raise "error in before each" }
-        example = group.example("equality") { 1.should == 2}
-        group.run.should == false
+        example = group.example("equality") { 1.should eq(2) }
+        group.run.should be(false)
 
-        example.metadata[:execution_result][:exception].message.should == "error in before each"
+        example.metadata[:execution_result][:exception].message.should eq("error in before each")
       end
 
       it "treats an error in before(:all) as a failure" do
         group = ExampleGroup.describe
         group.before(:all) { raise "error in before all" }
-        example = group.example("equality") { 1.should == 2}
-        group.run.should == false
+        example = group.example("equality") { 1.should eq(2) }
+        group.run.should be_false
 
         example.metadata.should_not be_nil
         example.metadata[:execution_result].should_not be_nil
         example.metadata[:execution_result][:exception].should_not be_nil
-        example.metadata[:execution_result][:exception].message.should == "error in before all"
+        example.metadata[:execution_result][:exception].message.should eq("error in before all")
       end
 
       it "treats an error in before(:all) as a failure for a spec in a nested group" do
@@ -533,7 +533,7 @@ module RSpec::Core
           before(:all) { raise "error in before all" }
 
           describe "nested" do
-            example = it("equality") { 1.should == 2}
+            example = it("equality") { 1.should eq(2) }
           end
         end
         group.run
@@ -541,7 +541,7 @@ module RSpec::Core
         example.metadata.should_not be_nil
         example.metadata[:execution_result].should_not be_nil
         example.metadata[:execution_result][:exception].should_not be_nil
-        example.metadata[:execution_result][:exception].message.should == "error in before all"
+        example.metadata[:execution_result][:exception].message.should eq("error in before all")
       end
 
       context "when an error occurs in an after(:all) hook" do
@@ -552,7 +552,7 @@ module RSpec::Core
         let(:group) do
           ExampleGroup.describe do
             after(:all) { raise "error in after all" }
-            it("equality") { 1.should == 1 }
+            it("equality") { 1.should eq(1) }
           end
         end
 
@@ -561,7 +561,7 @@ module RSpec::Core
           example = group.examples.first
           example.metadata.should_not be_nil
           example.metadata[:execution_result].should_not be_nil
-          example.metadata[:execution_result][:status].should == "passed"
+          example.metadata[:execution_result][:status].should eq("passed")
         end
 
         it "rescues the error and prints it out" do
@@ -576,7 +576,7 @@ module RSpec::Core
         group.before(:all) { running_example = example }
         group.example("no-op") { }
         group.run
-        running_example.should == nil
+        running_example.should be(nil)
       end
 
       it "has access to example options within before(:each)" do
@@ -585,7 +585,7 @@ module RSpec::Core
         group.before(:each) { option = example.options[:data] }
         group.example("no-op", :data => :sample) { }
         group.run
-        option.should == :sample
+        option.should eq(:sample)
       end
 
       it "has access to example options within after(:each)" do
@@ -594,7 +594,7 @@ module RSpec::Core
         group.after(:each) { option = example.options[:data] }
         group.example("no-op", :data => :sample) { }
         group.run
-        option.should == :sample
+        option.should eq(:sample)
       end
 
       it "has no 'running example' within after(:all)" do
@@ -603,7 +603,24 @@ module RSpec::Core
         group.after(:all) { running_example = example }
         group.example("no-op") { }
         group.run
-        running_example.should == nil
+        running_example.should be(nil)
+      end
+    end
+
+    matcher :add_a_pending_example_with do |method_name|
+      match do |group|
+        group = ExampleGroup.describe
+        group.send(method_name, "is pending") { }
+        group.run
+        group.examples.first.should be_pending
+      end
+    end
+
+    %w[pending xit xspecify xexample].each do |method_name|
+      describe "##{method_name}" do
+        it "generates a pending example" do
+          ExampleGroup.describe.should add_a_pending_example_with(method_name)
+        end
       end
     end
 
@@ -612,14 +629,7 @@ module RSpec::Core
       it "allows adding an example using 'it'" do
         group = ExampleGroup.describe
         group.it("should do something") { }
-        group.examples.size.should == 1
-      end
-
-      it "allows adding a pending example using 'xit'" do
-        group = ExampleGroup.describe
-        group.xit("is pending") { }
-        group.run
-        group.examples.first.should be_pending
+        group.examples.size.should eq(1)
       end
 
       it "exposes all examples at examples" do
@@ -635,9 +645,9 @@ module RSpec::Core
         group.it("should 1") { }
         group.it("should 2") { }
         group.it("should 3") { }
-        group.examples[0].description.should == 'should 1'
-        group.examples[1].description.should == 'should 2'
-        group.examples[2].description.should == 'should 3'
+        group.examples[0].description.should eq('should 1')
+        group.examples[1].description.should eq('should 2')
+        group.examples[2].description.should eq('should 3')
       end
 
     end
@@ -650,7 +660,7 @@ module RSpec::Core
         end
 
         it "sets the description to 'A sample nested describe'" do
-          example.example_group.description.should == 'A sample nested group'
+          example.example_group.description.should eq('A sample nested group')
         end
 
         it "has top level metadata from the example_group and its ancestors" do
@@ -670,8 +680,8 @@ module RSpec::Core
 
       it "returns true if all examples pass" do
         group = ExampleGroup.describe('group') do
-          example('ex 1') { 1.should == 1 }
-          example('ex 2') { 1.should == 1 }
+          example('ex 1') { 1.should eq(1) }
+          example('ex 2') { 1.should eq(1) }
         end
         group.stub(:filtered_examples) { group.examples }
         group.run(reporter).should be_true
@@ -679,8 +689,8 @@ module RSpec::Core
 
       it "returns false if any of the examples fail" do
         group = ExampleGroup.describe('group') do
-          example('ex 1') { 1.should == 1 }
-          example('ex 2') { 1.should == 2 }
+          example('ex 1') { 1.should eq(1) }
+          example('ex 2') { 1.should eq(2) }
         end
         group.stub(:filtered_examples) { group.examples }
         group.run(reporter).should be_false
@@ -688,8 +698,8 @@ module RSpec::Core
 
       it "runs all examples, regardless of any of them failing" do
         group = ExampleGroup.describe('group') do
-          example('ex 1') { 1.should == 2 }
-          example('ex 2') { 1.should == 1 }
+          example('ex 1') { 1.should eq(2) }
+          example('ex 2') { 1.should eq(1) }
         end
         group.stub(:filtered_examples) { group.examples }
         group.filtered_examples.each do |example|
@@ -709,11 +719,11 @@ module RSpec::Core
       end
 
       it "can access a before each ivar at the same level" do
-        @before_each_top_level.should == 'before_each_top_level'
+        @before_each_top_level.should eq('before_each_top_level')
       end
 
       it "can access a before all ivar at the same level" do
-        @before_all_top_level.should == 'before_all_top_level'
+        @before_all_top_level.should eq('before_all_top_level')
       end
 
       it "can access the before all ivars in the before_all_ivars hash", :ruby => 1.8 do
@@ -726,11 +736,11 @@ module RSpec::Core
 
       describe "but now I am nested" do
         it "can access a parent example groups before each ivar at a nested level" do
-          @before_each_top_level.should == 'before_each_top_level'
+          @before_each_top_level.should eq('before_each_top_level')
         end
 
         it "can access a parent example groups before all ivar at a nested level" do
-          @before_all_top_level.should == "before_all_top_level"
+          @before_all_top_level.should eq("before_all_top_level")
         end
 
         it "changes to before all ivars from within an example do not persist outside the current describe" do
@@ -739,7 +749,7 @@ module RSpec::Core
 
         describe "accessing a before_all ivar that was changed in a parent example_group" do
           it "does not have access to the modified version" do
-            @before_all_top_level.should == 'before_all_top_level'
+            @before_all_top_level.should eq('before_all_top_level')
           end
         end
       end
@@ -749,12 +759,12 @@ module RSpec::Core
     describe "ivars are not shared across examples" do
       it "(first example)" do
         @a = 1
-        @b.should be_nil
+        defined?(@b).should be_false
       end
 
       it "(second example)" do
         @b = 2
-        @a.should be_nil
+        defined?(@a).should be_false
       end
     end
 
@@ -769,7 +779,7 @@ module RSpec::Core
           end
         end
 
-        group.top_level_description.should == "top"
+        group.top_level_description.should eq("top")
       end
     end
 
@@ -826,7 +836,7 @@ module RSpec::Core
             it "does something" do
               # pass
             end
-            describe ("nested") do
+            describe "nested" do
               it "does something else" do
                 # pass
               end
@@ -843,7 +853,7 @@ module RSpec::Core
             it "does something (wrong - fail)" do
               raise "fail"
             end
-            describe ("nested") do
+            describe "nested" do
               it "does something else" do
                 # pass
               end
@@ -860,7 +870,7 @@ module RSpec::Core
             it "does something" do
               # pass
             end
-            describe ("nested") do
+            describe "nested" do
               it "does something else (wrong -fail)" do
                 raise "fail"
               end
@@ -888,6 +898,15 @@ module RSpec::Core
         end
         group.run.should be_true
       end
+
+      it "raises a helpful error message when shared context is not found" do
+        expect do
+          ExampleGroup.describe do
+            include_context "shared stuff"
+          end
+        end.to raise_error(ArgumentError,%q|Could not find shared context "shared stuff"|)
+      end
+
     end
 
     describe "#include_examples" do
@@ -904,7 +923,124 @@ module RSpec::Core
         end
         group.examples.first.description.should eq("does something")
       end
+
+      it "raises a helpful error message when shared context is not found" do
+        expect do
+          ExampleGroup.describe do
+            include_examples "shared stuff"
+          end
+        end.to raise_error(ArgumentError,%q|Could not find shared examples "shared stuff"|)
+      end
     end
 
+    describe "#it_should_behave_like" do
+      it "creates a nested group" do
+        shared_examples_for("thing") {}
+        group = ExampleGroup.describe('fake group')
+        group.it_should_behave_like("thing")
+        group.should have(1).children
+      end
+
+      it "creates a nested group for a class" do
+        klass = Class.new
+        shared_examples_for(klass) {}
+        group = ExampleGroup.describe('fake group')
+        group.it_should_behave_like(klass)
+        group.should have(1).children
+      end
+
+      it "adds shared examples to nested group" do
+        shared_examples_for("thing") do
+          it("does something")
+        end
+        group = ExampleGroup.describe('fake group')
+        shared_group = group.it_should_behave_like("thing")
+        shared_group.should have(1).examples
+      end
+
+      it "adds shared instance methods to nested group" do
+        shared_examples_for("thing") do
+          def foo; end
+        end
+        group = ExampleGroup.describe('fake group')
+        shared_group = group.it_should_behave_like("thing")
+        shared_group.public_instance_methods.map{|m| m.to_s}.should include("foo")
+      end
+
+      it "adds shared class methods to nested group" do
+        shared_examples_for("thing") do
+          def self.foo; end
+        end
+        group = ExampleGroup.describe('fake group')
+        shared_group = group.it_should_behave_like("thing")
+        shared_group.methods.map{|m| m.to_s}.should include("foo")
+      end
+
+      context "given some parameters" do
+        it "passes the parameters to the shared example group" do
+          passed_params = {}
+
+          shared_examples_for("thing") do |param1, param2|
+            it("has access to the given parameters") do
+              passed_params[:param1] = param1
+              passed_params[:param2] = param2
+            end
+          end
+
+          group = ExampleGroup.describe("group") do
+            it_should_behave_like "thing", :value1, :value2
+          end
+          group.run
+
+          passed_params.should eq({ :param1 => :value1, :param2 => :value2 })
+        end
+
+        it "adds shared instance methods to nested group" do
+          shared_examples_for("thing") do |param1|
+            def foo; end
+          end
+          group = ExampleGroup.describe('fake group')
+          shared_group = group.it_should_behave_like("thing", :a)
+          shared_group.public_instance_methods.map{|m| m.to_s}.should include("foo")
+        end
+
+        it "evals the shared example group only once" do
+          eval_count = 0
+          shared_examples_for("thing") { |p| eval_count += 1 }
+          group = ExampleGroup.describe('fake group')
+          shared_group = group.it_should_behave_like("thing", :a)
+          eval_count.should eq(1)
+        end
+      end
+
+      context "given a block" do
+        it "evaluates the block in nested group" do
+          scopes = []
+          shared_examples_for("thing") do
+            it("gets run in the nested group") do
+              scopes << self.class
+            end
+          end
+          group = ExampleGroup.describe("group") do
+            it_should_behave_like "thing" do
+              it("gets run in the same nested group") do
+                scopes << self.class
+              end
+            end
+          end
+          group.run
+
+          scopes[0].should be(scopes[1])
+        end
+      end
+
+      it "raises a helpful error message when shared context is not found" do
+        expect do
+          ExampleGroup.describe do
+            it_should_behave_like "shared stuff"
+          end
+        end.to raise_error(ArgumentError,%q|Could not find shared examples "shared stuff"|)
+      end
+    end
   end
 end

data/spec/rspec/core/example_spec.rb

@@ -16,9 +16,24 @@ describe RSpec::Core::Example, :parent_metadata => 'sample' do
     end
   end
 
+  describe "#exception" do
+    it "supplies the first exception raised, if any" do
+      example = example_group.example { raise "first" }
+      example_group.after { raise "second" }
+      example_group.run
+      example.exception.message.should eq("first")
+    end
+
+    it "returns nil if there is no exception" do
+      example = example_group.example('example') { }
+      example_group.run
+      example.exception.should be_nil
+    end
+  end
+
   describe "auto-generated example descriptions" do
     let(:generated_description) { "the generated description" }
-    let(:rspec_example) { example_group.specify { 5.should == 5 } }
+    let(:rspec_example) { example_group.specify { 5.should eq(5) } }
     before(:each) { RSpec::Matchers.stub(:generated_description => generated_description) }
 
     def expect_with(*frameworks)
@@ -71,13 +86,13 @@ describe RSpec::Core::Example, :parent_metadata => 'sample' do
 
   describe '#described_class' do
     it "returns the class (if any) of the outermost example group" do
-      described_class.should == RSpec::Core::Example
+      described_class.should eq(RSpec::Core::Example)
     end
   end
 
   describe "accessing metadata within a running example" do
     it "has a reference to itself when running" do
-      example.description.should == "has a reference to itself when running"
+      example.description.should eq("has a reference to itself when running")
     end
 
     it "can access the example group's top level metadata as if it were its own" do
@@ -88,7 +103,7 @@ describe RSpec::Core::Example, :parent_metadata => 'sample' do
 
   describe "accessing options within a running example" do
     it "can look up option values by key", :demo => :data do
-      example.options[:demo].should == :data
+      example.options[:demo].should eq(:data)
     end
   end
 
@@ -105,7 +120,7 @@ describe RSpec::Core::Example, :parent_metadata => 'sample' do
       after_run = false
       group = RSpec::Core::ExampleGroup.describe do
         after(:each) { after_run = true }
-        example('example') { 1.should == 1 }
+        example('example') { 1.should eq(1) }
       end
       group.run
       after_run.should be_true, "expected after(:each) to be run"
@@ -115,7 +130,7 @@ describe RSpec::Core::Example, :parent_metadata => 'sample' do
       after_run = false
       group = RSpec::Core::ExampleGroup.describe do
         after(:each) { after_run = true }
-        example('example') { 1.should == 2 }
+        example('example') { 1.should eq(2) }
       end
       group.run
       after_run.should be_true, "expected after(:each) to be run"
@@ -137,7 +152,7 @@ describe RSpec::Core::Example, :parent_metadata => 'sample' do
         group = RSpec::Core::ExampleGroup.describe do
           after(:each) { after_run = true }
           after(:each) { raise "FOO" }
-          example('example') { 1.should == 1 }
+          example('example') { 1.should eq(1) }
         end
         group.run
         after_run.should be_true, "expected after(:each) to be run"
@@ -146,11 +161,11 @@ describe RSpec::Core::Example, :parent_metadata => 'sample' do
       it "stores the exception" do
         group = RSpec::Core::ExampleGroup.describe
         group.after(:each) { raise "FOO" }
-        example = group.example('example') { 1.should == 1 }
+        example = group.example('example') { 1.should eq(1) }
 
         group.run
 
-        example.metadata[:execution_result][:exception].message.should == "FOO"
+        example.metadata[:execution_result][:exception].message.should eq("FOO")
       end
     end
 
@@ -185,14 +200,15 @@ describe RSpec::Core::Example, :parent_metadata => 'sample' do
           after(:each)  { @after_each = :after_each }
           after(:all)   { @after_all  = :after_all }
         end
-        example = group.example("does something") do
-          @in_example = :in_example
+        group.example("does something") do
+          @before_all.should eq(:before_all)
+          @before_each.should eq(:before_each)
         end
-        example_group_instance = group.new
-        example.run(example_group_instance, double('reporter').as_null_object)
-
-        %w[@before_all @before_each @after_each @after_all].each do |ivar|
-          example_group_instance.instance_variable_get(ivar).should be_nil
+        group.run(double.as_null_object).should be_true
+        group.new do |example|
+          %w[@before_all @before_each @after_each @after_all].each do |ivar|
+            example.instance_variable_get(ivar).should be_nil
+          end
         end
       end
 
@@ -269,4 +285,5 @@ describe RSpec::Core::Example, :parent_metadata => 'sample' do
     end
 
   end
+
 end