rspec-core 2.5.2 → 2.6.0.rc2

data/features/expectation_framework_integration/configure_expectation_framework.feature

@@ -9,6 +9,10 @@ Feature: configure expectation framework
     * minitest assertions in ruby 1.9
   * rspec/expecations _and_ stlib assertions
 
+  Note that when you do not use rspec-expectations, you must explicitly
+  provide a description to every example.  You cannot rely on the generated
+  descriptions provided by rspec-expectations.
+
   Scenario: configure rspec-expectations (explicitly)
     Given a file named "example_spec.rb" with:
       """
@@ -22,7 +26,7 @@ Feature: configure expectation framework
         end
       end
       """
-    When I run "rspec example_spec.rb"
+    When I run `rspec example_spec.rb`
     Then the examples should all pass
 
   Scenario: configure test/unit assertions
@@ -36,10 +40,17 @@ Feature: configure expectation framework
         it "is greater than 4" do
           assert 5 > 4, "expected 5 to be greater than 4"
         end
+
+        specify { assert 5 < 6 }
       end
       """
-    When I run "rspec example_spec.rb"
-    Then the examples should all pass
+    When I run `rspec example_spec.rb`
+    Then the output should contain "2 examples, 1 failure"
+     And the output should contain:
+       """
+            NotImplementedError:
+              Generated descriptions are only supported when you use rspec-expectations.
+       """
 
   Scenario: configure rspec/expecations AND test/unit assertions
     Given a file named "example_spec.rb" with:
@@ -58,5 +69,5 @@ Feature: configure expectation framework
         end
       end
       """
-    When I run "rspec example_spec.rb"
+    When I run `rspec example_spec.rb`
     Then the examples should all pass

data/features/filtering/exclusion_filters.feature

@@ -2,6 +2,9 @@ Feature: exclusion filters
 
   You can exclude examples from a run by declaring an exclusion filter and
   then tagging examples, or entire groups, with that filter.
+
+  If you set the `treat_symbols_as_metadata_keys_with_true_values` config option
+  to `true`, you can specify metadata using only symbols.
   
   Scenario: exclude an example
     Given a file named "spec/sample_spec.rb" with:
@@ -20,7 +23,7 @@ Feature: exclusion filters
         end
       end
       """
-    When I run "rspec ./spec/sample_spec.rb --format doc"
+    When I run `rspec ./spec/sample_spec.rb --format doc`
     Then the output should contain "does one thing"
     And the output should not contain "does another thing"
 
@@ -44,7 +47,7 @@ Feature: exclusion filters
         end
       end
       """
-    When I run "rspec ./spec/sample_spec.rb --format doc"
+    When I run `rspec ./spec/sample_spec.rb --format doc`
     Then the output should contain "group 2 example 1"
     And  the output should not contain "group 1 example 1"
     And  the output should not contain "group 1 example 2"
@@ -77,7 +80,7 @@ Feature: exclusion filters
         end
       end
       """
-    When I run "rspec ./spec/sample_spec.rb --format doc"
+    When I run `rspec ./spec/sample_spec.rb --format doc`
     Then the output should match /No examples were matched. Perhaps \{.*:broken=>true.*\} is excluding everything?/
     And  the examples should all pass
     And  the output should not contain "group 1"
@@ -108,8 +111,29 @@ Feature: exclusion filters
         end
       end
       """
-    When I run "rspec ./spec/before_after_all_exclusion_filter_spec.rb"
+    When I run `rspec ./spec/before_after_all_exclusion_filter_spec.rb`
     Then the output should contain "before all in included group"
      And the output should contain "after all in included group"
      And the output should not contain "before all in excluded group"
      And the output should not contain "after all in excluded group"
+
+  Scenario: Use symbols as metadata
+    Given a file named "symbols_as_metadata_spec.rb" with:
+      """
+      RSpec.configure do |c|
+        c.treat_symbols_as_metadata_keys_with_true_values = true
+        c.filter_run_excluding :broken
+      end
+
+      describe "something" do
+        it "does one thing" do
+        end
+
+        # tag example for exclusion by adding metadata
+        it "does another thing", :broken do
+        end
+      end
+      """
+    When I run `rspec symbols_as_metadata_spec.rb --format doc`
+    Then the output should contain "does one thing"
+    And the output should not contain "does another thing"

data/features/filtering/{implicit_filters.feature → if_and_unless.feature}

@@ -1,4 +1,4 @@
-Feature: implicit filters
+Feature: :if and :unless
 
   The `:if` and `:unless` metadata keys can be used to filter examples without
   needing to configure an exclusion filter.
@@ -24,7 +24,7 @@ Feature: implicit filters
         it("no :if group no :if example") { }
       end
       """
-    When I run "rspec implicit_if_filter_spec.rb --format doc"
+    When I run `rspec implicit_if_filter_spec.rb --format doc`
     Then the output should contain all of these:
       | :if => true group :if => true example  |
       | :if => true group no :if example       |
@@ -58,7 +58,7 @@ Feature: implicit filters
         it("no :unless group no :unless example") { }
       end
       """
-    When I run "rspec implicit_unless_filter_spec.rb --format doc"
+    When I run `rspec implicit_unless_filter_spec.rb --format doc`
     Then the output should contain all of these:
       | :unless => true group :unless => false example  |
       | :unless => false group :unless => false example |
@@ -94,7 +94,7 @@ Feature: implicit filters
         it("unfocused :unless => false example", :unless => false) { }
       end
       """
-    When I run "rspec explicit_inclusion_filter_spec.rb --format doc"
+    When I run `rspec explicit_inclusion_filter_spec.rb --format doc`
     Then the output should contain all of these:
       | focused example                  |
       | focused :if => true example      |
@@ -127,7 +127,7 @@ Feature: implicit filters
         it("excluded :unless => false example", :unless => false) { }
       end
       """
-    When I run "rspec explicit_exclusion_filter_spec.rb --format doc"
+    When I run `rspec explicit_exclusion_filter_spec.rb --format doc`
     Then the output should contain all of these:
       | included example                  |
       | included :if => true example      |
@@ -156,11 +156,13 @@ Feature: implicit filters
         it(":unless => :exclude_me_for_unless example", :unless => :exclude_me_for_unless) { }
       end
       """
-    When I run "rspec override_implicit_filters_spec.rb --format doc"
+    When I run `rspec override_implicit_filters_spec.rb --format doc`
     Then the output should contain all of these:
       | :if => true example      |
       | :if => false example     |
       | :unless => true example  |
       | :unless => false example |
-    And the output should not contain "exclude_me"
+    And the output should not contain any of these:
+      | :if => :exclude_me example                |
+      | :unless => :exclude_me_for_unless example |
 

data/features/filtering/inclusion_filters.feature

@@ -4,6 +4,9 @@ Feature: inclusion filters
   most common use case is to focus on a subset of examples as you're focused on
   a particular problem.
 
+  If you set the `treat_symbols_as_metadata_keys_with_true_values` config option
+  to `true`, you can specify metadata using only symbols.
+
   Background:
     Given a file named "spec/spec_helper.rb" with:
       """
@@ -26,7 +29,7 @@ Feature: inclusion filters
         end
       end
       """
-    When I run "rspec spec/sample_spec.rb --format doc"
+    When I run `rspec spec/sample_spec.rb --format doc`
     Then the output should contain "does another thing"
     And the output should not contain "does one thing"
 
@@ -48,7 +51,7 @@ Feature: inclusion filters
         end
       end
       """
-    When I run "rspec spec/sample_spec.rb --format doc"
+    When I run `rspec spec/sample_spec.rb --format doc`
     Then the output should contain "group 1 example 1"
     And  the output should contain "group 1 example 2"
     And  the output should not contain "group 2 example 1"
@@ -76,8 +79,28 @@ Feature: inclusion filters
         end
       end
       """
-    When I run "rspec ./spec/before_after_all_inclusion_filter_spec.rb"
+    When I run `rspec ./spec/before_after_all_inclusion_filter_spec.rb`
     Then the output should contain "before all in focused group"
      And the output should contain "after all in focused group"
      And the output should not contain "before all in unfocused group"
      And the output should not contain "after all in unfocused group"
+
+  Scenario: Use symbols as metadata
+    Given a file named "symbols_as_metadata_spec.rb" with:
+      """
+      RSpec.configure do |c|
+        c.treat_symbols_as_metadata_keys_with_true_values = true
+        c.filter_run :current_example
+      end
+
+      describe "something" do
+        it "does one thing" do
+        end
+
+        it "does another thing", :current_example do
+        end
+      end
+      """
+    When I run `rspec symbols_as_metadata_spec.rb --format doc`
+    Then the output should contain "does another thing"
+    And the output should not contain "does one thing"

data/features/filtering/run_all_when_everything_filtered.feature

@@ -31,7 +31,7 @@ Feature: run all when everything filtered
         end
       end
       """
-    When I run "rspec spec/sample_spec.rb --format doc"
+    When I run `rspec spec/sample_spec.rb --format doc`
     Then the output should contain "No examples were matched by {:focus=>true}, running all"
     And the examples should all pass
     And the output should contain:

data/features/formatters/custom_formatter.feature

@@ -31,6 +31,6 @@ Feature: custom formatters
         end
       end
       """
-    When I run "rspec example_spec.rb --require ./custom_formatter.rb --format CustomFormatter"
+    When I run `rspec example_spec.rb --require ./custom_formatter.rb --format CustomFormatter`
     Then the output should contain "example: my example"
     And  the exit status should be 0

data/features/formatters/text_formatter.feature

@@ -0,0 +1,45 @@
+Feature: text formatter
+
+  In order to easily see the result of running my specs
+  As an RSpec user
+  I want clear, concise, well-formatted output
+
+  Scenario: Backtrace formatting for failing specs in multiple files
+    Given a file named "string_spec.rb" with:
+      """
+      require 'rspec/core'
+
+      describe String do
+        it "has a failing example" do
+          "foo".reverse.should == "ofo"
+        end
+      end
+      """
+    And a file named "integer_spec.rb" with:
+      """
+      require 'rspec/core'
+
+      describe Integer do
+        it "has a failing example" do
+          (7 + 5).should == 11
+        end
+      end
+      """
+    When I run `ruby ./integer_spec.rb ./string_spec.rb`
+    Then the backtrace-normalized output should contain:
+      """
+      Failures:
+
+        1) Integer has a failing example
+           Failure/Error: (7 + 5).should == 11
+             expected: 11
+                  got: 12 (using ==)
+           # ./integer_spec.rb:5
+
+        2) String has a failing example
+           Failure/Error: "foo".reverse.should == "ofo"
+             expected: "ofo"
+                  got: "oof" (using ==)
+           # ./string_spec.rb:5
+      """
+

data/features/helper_methods/arbitrary_methods.feature

@@ -18,7 +18,7 @@ Feature: arbitrary helper methods
         end
       end
       """
-    When I run "rspec example_spec.rb"
+    When I run `rspec example_spec.rb`
     Then the examples should all pass
 
   Scenario: use a method defined in a parent group
@@ -36,5 +36,5 @@ Feature: arbitrary helper methods
         end
       end
       """
-    When I run "rspec example_spec.rb"
+    When I run `rspec example_spec.rb`
     Then the examples should all pass

data/features/helper_methods/let.feature

@@ -24,7 +24,7 @@ Feature: let and let!
         end
       end
       """
-    When I run "rspec let_spec.rb"
+    When I run `rspec let_spec.rb`
     Then the examples should all pass
 
   Scenario: use let! to define a memoized helper method that is called in a before hook
@@ -46,5 +46,5 @@ Feature: let and let!
         end
       end
       """
-    When I run "rspec let_bang_spec.rb"
+    When I run `rspec let_bang_spec.rb`
     Then the examples should all pass

data/features/helper_methods/modules.feature

@@ -0,0 +1,149 @@
+Feature: Define helper methods in a module
+
+  You can define helper methods in a module and include it in
+  your example groups using the `config.include` configuration
+  option.  `config.extend` can be used to extend the module onto
+  your example groups so that the methods in the module are available
+  in the example groups themselves (but not in the actual examples).
+
+  You can also include or extend the module onto only certain example
+  groups by passing a metadata hash as the last argument.  Only groups
+  that match the given metadata will include or extend the module.
+
+  If you set the `treat_symbols_as_metadata_keys_with_true_values` config option
+  to `true`, you can specify metadata using only symbols.
+
+  Background:
+    Given a file named "helpers.rb" with:
+      """
+      module Helpers
+        def help
+          :available
+        end
+      end
+      """
+
+  Scenario: include a module in all example groups
+    Given a file named "include_module_spec.rb" with:
+      """
+      require './helpers'
+
+      RSpec.configure do |c|
+        c.include Helpers
+      end
+
+      describe "an example group" do
+        it "has access the helper methods defined in the module" do
+          help.should be(:available)
+        end
+      end
+      """
+    When I run `rspec include_module_spec.rb`
+    Then the examples should all pass
+
+  Scenario: extend a module in all example groups
+    Given a file named "extend_module_spec.rb" with:
+      """
+      require './helpers'
+
+      RSpec.configure do |c|
+        c.extend Helpers
+      end
+
+      describe "an example group" do
+        puts "Help is #{help}"
+
+        it "does not have access to the helper methods defined in the module" do
+          expect { help }.to raise_error(NameError)
+        end
+      end
+      """
+    When I run `rspec extend_module_spec.rb`
+    Then the examples should all pass
+    And the output should contain "Help is available"
+
+  Scenario: include a module in only some example groups
+    Given a file named "include_module_in_some_groups_spec.rb" with:
+      """
+      require './helpers'
+
+      RSpec.configure do |c|
+        c.include Helpers, :foo => :bar
+      end
+
+      describe "an example group with matching metadata", :foo => :bar do
+        it "has access the helper methods defined in the module" do
+          help.should be(:available)
+        end
+      end
+
+      describe "an example group without matching metadata" do
+        it "does not have access to the helper methods defined in the module" do
+          expect { help }.to raise_error(NameError)
+        end
+      end
+      """
+    When I run `rspec include_module_in_some_groups_spec.rb`
+    Then the examples should all pass
+
+  Scenario: extend a module in only some example groups
+    Given a file named "extend_module_in_only_some_groups_spec.rb" with:
+      """
+      require './helpers'
+
+      RSpec.configure do |c|
+        c.extend Helpers, :foo => :bar
+      end
+
+      describe "an example group with matching metadata", :foo => :bar do
+        puts "In a matching group, help is #{help}"
+
+        it "does not have access to the helper methods defined in the module" do
+          expect { help }.to raise_error(NameError)
+        end
+      end
+
+      describe "an example group without matching metadata" do
+        puts "In a non-matching group, help is #{help rescue 'not available'}"
+
+        it "does not have access to the helper methods defined in the module" do
+          expect { help }.to raise_error(NameError)
+        end
+      end
+      """
+    When I run `rspec extend_module_in_only_some_groups_spec.rb`
+    Then the examples should all pass
+    And the output should contain "In a matching group, help is available"
+    And the output should contain "In a non-matching group, help is not available"
+
+  Scenario: use symbols as metadata
+    Given a file named "symbols_as_metadata_spec.rb" with:
+      """
+      require './helpers'
+
+      RSpec.configure do |c|
+        c.treat_symbols_as_metadata_keys_with_true_values = true
+        c.include Helpers, :include_helpers
+        c.extend  Helpers, :extend_helpers
+      end
+
+      describe "an example group with matching include metadata", :include_helpers do
+        puts "In a group not matching the extend filter, help is #{help rescue 'not available'}"
+
+        it "has access the helper methods defined in the module" do
+          help.should be(:available)
+        end
+      end
+
+      describe "an example group with matching extend metadata", :extend_helpers do
+        puts "In a group matching the extend filter, help is #{help}"
+
+        it "does not have access to the helper methods defined in the module" do
+          expect { help }.to raise_error(NameError)
+        end
+      end
+      """
+    When I run `rspec symbols_as_metadata_spec.rb`
+    Then the examples should all pass
+    And the output should contain "In a group not matching the extend filter, help is not available"
+    And the output should contain "In a group matching the extend filter, help is available"