rspec-core 2.4.0 → 2.5.0

data/spec/rspec/core/hooks_filtering_spec.rb

@@ -67,6 +67,55 @@ module RSpec::Core
         ]
       end
 
+      it "runs before|after :all hooks on matching nested example groups" do
+        filters = []
+        RSpec.configure do |c|
+          c.before(:all, :match => true) { filters << :before_all }
+          c.after(:all, :match => true)  { filters << :after_all }
+        end
+
+        example_1_filters = example_2_filters = nil
+
+        group = ExampleGroup.describe "group" do
+          it("example 1") { example_1_filters = filters.dup }
+          describe "subgroup", :match => true do
+            it("example 2") { example_2_filters = filters.dup }
+          end
+        end
+        group.run
+
+        example_1_filters.should be_empty
+        example_2_filters.should == [:before_all]
+        filters.should == [:before_all, :after_all]
+      end
+
+      it "runs before|after :all hooks only on the highest level group that matches the filter" do
+        filters = []
+        RSpec.configure do |c|
+          c.before(:all, :match => true) { filters << :before_all }
+          c.after(:all, :match => true)  { filters << :after_all }
+        end
+
+        example_1_filters = example_2_filters = example_3_filters = nil
+
+        group = ExampleGroup.describe "group", :match => true do
+          it("example 1") { example_1_filters = filters.dup }
+          describe "subgroup", :match => true do
+            it("example 2") { example_2_filters = filters.dup }
+            describe "sub-subgroup", :match => true do
+              it("example 3") { example_3_filters = filters.dup }
+            end
+          end
+        end
+        group.run
+
+        example_1_filters.should == [:before_all]
+        example_2_filters.should == [:before_all]
+        example_3_filters.should == [:before_all]
+
+        filters.should == [:before_all, :after_all]
+      end
+
       it "should not be ran if the filter doesn't match the example group's filter" do
         filters = []
         RSpec.configure do |c|

data/spec/rspec/core/rake_task_spec.rb

@@ -144,16 +144,16 @@ module RSpec::Core
         @task = RakeTask.new do |t|
           t.pattern = File.join(@tmp_dir, "*spec.rb")
         end
-        ["first_spec.rb", "second_\"spec.rb", "third_'spec.rb"].each do |file_name|
+        ["first_spec.rb", "second_\"spec.rb", "third_\'spec.rb"].each do |file_name|
           FileUtils.touch(File.join(@tmp_dir, file_name))
         end
       end
 
       it "escapes the quotes" do
-        @task.__send__(:files_to_run).should eq([
+        @task.__send__(:files_to_run).sort.should eq([
           File.join(@tmp_dir, "first_spec.rb"),
           File.join(@tmp_dir, "second_\\\"spec.rb"),
-          File.join(@tmp_dir, "third_\\'spec.rb") 
+          File.join(@tmp_dir, "third_\\\'spec.rb") 
         ])
       end
     end

data/spec/rspec/core/subject_spec.rb

@@ -93,5 +93,86 @@ module RSpec::Core
       end
     end
 
+    describe "#its" do
+      subject do
+        Class.new do
+          def initialize
+            @call_count = 0
+          end
+
+          def call_count
+            @call_count += 1
+          end
+        end.new
+      end
+
+      context "with a call counter" do
+        its(:call_count) { should eq(1) }
+      end
+
+      context "with nil value" do
+        subject do
+          Class.new do
+            def nil_value
+              nil
+            end
+          end.new
+        end
+        its(:nil_value) { should be_nil }
+      end
+
+      context "with nested attributes" do
+        subject do
+          Class.new do
+            def name
+              "John"
+            end
+          end.new
+        end
+        its("name")            { should eq("John") }
+        its("name.size")       { should eq(4) }
+        its("name.size.class") { should eq(Fixnum) }
+      end
+
+      context "when it is a Hash" do
+        subject do
+          { :attribute => 'value',
+            'another_attribute' => 'another_value' }
+        end
+        its([:attribute]) { should == 'value' }
+        its([:attribute]) { should_not == 'another_value' }
+        its([:another_attribute]) { should == 'another_value' }
+        its([:another_attribute]) { should_not == 'value' }
+        its(:keys) { should =~ ['another_attribute', :attribute] }
+        context "when referring to an attribute without the proper array syntax" do
+          context "it raises an error" do
+            its(:attribute) do
+              expect do
+                should eq('value')
+              end.to raise_error(NoMethodError)
+            end
+          end
+        end
+      end
+
+      context "calling and overriding super" do
+        it "calls to the subject defined in the parent group" do
+          group = ExampleGroup.describe(Array) do
+            subject { [1, 'a'] }
+
+            its(:last) { should == 'a' }
+
+            describe '.first' do
+              def subject; super().first; end
+
+              its(:next) { should == 2 }
+            end
+          end
+
+          group.run.should be_true
+        end
+      end
+
+    end
   end
 end

metadata

@@ -1,12 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: rspec-core
 version: !ruby/object:Gem::Version 
+  hash: 27
   prerelease: false
   segments: 
   - 2
-  - 4
+  - 5
   - 0
-  version: 2.4.0
+  version: 2.5.0
 platform: ruby
 authors: 
 - Chad Humphries
@@ -15,7 +16,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-01-02 00:00:00 -06:00
+date: 2011-02-05 00:00:00 -06:00
 default_executable: rspec
 dependencies: []
 
@@ -34,17 +35,16 @@ files:
 - .rspec
 - Gemfile
 - Guardfile
-- History.markdown
 - License.txt
 - README.md
 - Rakefile
-- Upgrade.markdown
 - bin/autospec
 - bin/rspec
 - cucumber.yml
 - features/.nav
+- features/Autotest.md
 - features/Changelog.md
-- features/README.markdown
+- features/README.md
 - features/Upgrade.md
 - features/command_line/README.md
 - features/command_line/configure.feature
@@ -66,6 +66,8 @@ files:
 - features/filtering/inclusion_filters.feature
 - features/filtering/run_all_when_everything_filtered.feature
 - features/formatters/custom_formatter.feature
+- features/helper_methods/arbitrary_methods.feature
+- features/helper_methods/let.feature
 - features/hooks/around_hooks.feature
 - features/hooks/before_and_after_hooks.feature
 - features/hooks/filtering.feature
@@ -135,7 +137,11 @@ files:
 - lib/rspec/monkey.rb
 - lib/rspec/monkey/spork/test_framework/rspec.rb
 - rspec-core.gemspec
+- script/FullBuildRakeFile
 - script/console
+- script/cucumber
+- script/full_build
+- script/spec
 - spec/autotest/discover_spec.rb
 - spec/autotest/failed_results_re_spec.rb
 - spec/autotest/rspec_spec.rb
@@ -195,18 +201,7 @@ has_rdoc: true
 homepage: http://github.com/rspec/rspec-core
 licenses: []
 
-post_install_message: |
-  **************************************************
-  
-    Thank you for installing rspec-core-2.4.0
-  
-    Please be sure to look at the upgrade instructions to see what might have
-    changed since the last release:
-  
-    http://github.com/rspec/rspec-core/blob/master/Upgrade.markdown
-  
-  **************************************************
-
+post_install_message: 
 rdoc_options: 
 - --charset=UTF-8
 require_paths: 
@@ -216,7 +211,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: -2078770965250324300
+      hash: 3
       segments: 
       - 0
       version: "0"
@@ -225,7 +220,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: -2078770965250324300
+      hash: 3
       segments: 
       - 0
       version: "0"
@@ -235,10 +230,11 @@ rubyforge_project: rspec
 rubygems_version: 1.3.7
 signing_key: 
 specification_version: 3
-summary: rspec-core-2.4.0
+summary: rspec-core-2.5.0
 test_files: 
+- features/Autotest.md
 - features/Changelog.md
-- features/README.markdown
+- features/README.md
 - features/Upgrade.md
 - features/command_line/README.md
 - features/command_line/configure.feature
@@ -260,6 +256,8 @@ test_files:
 - features/filtering/inclusion_filters.feature
 - features/filtering/run_all_when_everything_filtered.feature
 - features/formatters/custom_formatter.feature
+- features/helper_methods/arbitrary_methods.feature
+- features/helper_methods/let.feature
 - features/hooks/around_hooks.feature
 - features/hooks/before_and_after_hooks.feature
 - features/hooks/filtering.feature

data/History.markdown

@@ -1,186 +0,0 @@
-## rspec-core release history (incomplete)
-
-### 2.4.0 / 2011-01-02
-
-[full changelog](http://github.com/rspec/rspec-core/compare/v2.3.1...v2.4.0)
-
-* Enhancements
-  * start the debugger on -d so the stack trace is visible when it stops
-    (Clifford Heath)
-  * apply hook filtering to examples as well as groups (Myron Marston)
-  * support multiple formatters, each with their own output
-  * show exception classes in failure messages unless they come from RSpec
-    matchers or message expectations
-  * before(:all) { pending } sets all examples to pending
-
-* Bug fixes
-  * fix bug due to change in behavior of reject in Ruby 1.9.3-dev (Shota Fukumori)
-  * fix bug when running in jruby: be explicit about passing block to super
-    (John Firebaugh)
-  * rake task doesn't choke on paths with quotes (Janmejay Singh)
-  * restore --options option from rspec-1
-  * require 'ostruct' to fix bug with its([key]) (Kim Burgestrand)
-  * --configure option generates .rspec file instead of autotest/discover.rb
-
-### 2.3.1 / 2010-12-16
-
-[full changelog](http://github.com/rspec/rspec-core/compare/v2.3.0...v2.3.1)
-
-* Bug fixes
-  * send debugger warning message to $stdout if RSpec.configuration.error_stream
-    has not been defined yet. 
-  * HTML Formatter _finally_ properly displays nested groups (Jarmo Pertman)
-  * eliminate some warnings when running RSpec's own suite (Jarmo Pertman)
-
-### 2.3.0 / 2010-12-12
-
-[full changelog](http://github.com/rspec/rspec-core/compare/v2.2.1...v2.3.0)
-
-* Enhancements
-  * tell autotest to use "rspec2" if it sees a .rspec file in the project's
-    root directory
-    * replaces the need for ./autotest/discover.rb, which will not work with
-      all versions of ZenTest and/or autotest
-  * config.expect_with
-    * :rspec          # => rspec/expectations
-    * :stdlib         # => test/unit/assertions
-    * :rspec, :stdlib # => both
-
-* Bug fixes
-  * fix dev Gemfile to work on non-mac-os machines (Lake Denman)
-  * ensure explicit subject is only eval'd once (Laszlo Bacsi)
-
-### 2.2.1 / 2010-11-28
-
-[full changelog](http://github.com/rspec/rspec-core/compare/v2.2.0...v2.2.1)
-
-* Bug fixes
-  * alias_method instead of override Kernel#method_missing (John Wilger)
-  * changed --autotest to --tty in generated command (MIKAMI Yoshiyuki) 
-  * revert change to debugger (had introduced conflict with Rails)
-    * also restored --debugger/-debug option
-
-### 2.2.0 / 2010-11-28
-
-[full changelog](http://github.com/rspec/rspec-core/compare/v2.1.0...v2.2.0)
-
-* Deprecations/changes
-  * --debug/-d on command line is deprecated and now has no effect
-  * win32console is now ignored; Windows users must use ANSICON for color support
-    (Bosko Ivanisevic)
-
-* Enhancements
-  * When developing locally rspec-core now works with the rspec-dev setup or your local gems
-  * Raise exception with helpful message when rspec-1 is loaded alongside
-    rspec-2 (Justin Ko)
-  * debugger statements _just work_ as long as ruby-debug is installed
-    * otherwise you get warned, but not fired
-  * Expose example.metadata in around hooks
-  * Performance improvments (see [Upgrade.markdown](https://github.com/rspec/rspec-core/blob/master/Upgrade.markdown))
-
-* Bug fixes
-  * Make sure --fail-fast makes it across drb
-  * Pass -Ilib:spec to rcov
-
-### 2.1.0 / 2010-11-07
-
-[full changelog](http://github.com/rspec/rspec-core/compare/v2.0.1...v2.1.0)
-
-* Enhancments
-  * Add skip_bundler option to rake task to tell rake task to ignore the
-    presence of a Gemfile (jfelchner)
-  * Add gemfile option to rake task to tell rake task what Gemfile to look
-    for (defaults to 'Gemfile')
-  * Allow passing caller trace into Metadata to support extensions (Glenn
-    Vanderburg)
-  * Add deprecation warning for Spec::Runner.configure to aid upgrade from
-    RSpec-1
-  * Add deprecated Spec::Rake::SpecTask to aid upgrade from RSpec-1
-  * Add 'autospec' command with helpful message to aid upgrade from RSpec-1
-  * Add support for filtering with tags on CLI (Lailson Bandeira)
-  * Add a helpful message about RUBYOPT when require fails in bin/rspec
-    (slyphon)
-  * Add "-Ilib" to the default rcov options (Tianyi Cui)
-  * Make the expectation framework configurable (default rspec, of course)
-    (Justin Ko)
-  * Add 'pending' to be conditional (Myron Marston)
-  * Add explicit support for :if and :unless as metadata keys for conditional run
-    of examples (Myron Marston)
-  * Add --fail-fast command line option (Jeff Kreeftmeijer)
-
-* Bug fixes
-  * Eliminate stack overflow with "subject { self }"
-  * Require 'rspec/core' in the Raketask (ensures it required when running rcov)
-
-### 2.0.1 / 2010-10-18
-
-[full changelog](http://github.com/rspec/rspec-core/compare/v2.0.0...v2.0.1)
-
-* Bug fixes
-  * Restore color when using spork + autotest
-  * Pending examples without docstrings render the correct message (Josep M. Bach)
-  * Fixed bug where a failure in a spec file ending in anything but _spec.rb would
-    fail in a confusing way.
-  * Support backtrace lines from erb templates in html formatter (Alex Crichton)
-
-### 2.0.0 / 2010-10-10
-
-[full changelog](http://github.com/rspec/rspec-core/compare/v2.0.0.rc...v2.0.0)
-
-* RSpec-1 compatibility
-  * Rake task uses ENV["SPEC"] as file list if present
-
-* Bug fixes
-  * Bug Fix: optparse --out foo.txt (Leonardo Bessa)
-  * Suppress color codes for non-tty output (except autotest)
-
-### 2.0.0.rc / 2010-10-05
-
-[full changelog](http://github.com/rspec/rspec-core/compare/v2.0.0.beta.22...v2.0.0.rc)
-
-* Enhancements
-  * implicitly require unknown formatters so you don't have to require the
-    file explicitly on the commmand line (Michael Grosser)
-  * add --out/-o option to assign output target
-  * added fail_fast configuration option to abort on first failure
-  * support a Hash subject (its([:key]) { should == value }) (Josep M. Bach)
-
-* Bug fixes
-  * Explicitly require rspec version to fix broken rdoc task (Hans de Graaff)
-  * Ignore backtrace lines that come from other languages, like Java or
-    Javascript (Charles Lowell)
-  * Rake task now does what is expected when setting (or not setting)
-    fail_on_error and verbose
-  * Fix bug in which before/after(:all) hooks were running on excluded nested
-    groups (Myron Marston)
-  * Fix before(:all) error handling so that it fails examples in nested groups,
-    too (Myron Marston)
-
-### 2.0.0.beta.22 / 2010-09-12
-
-[full changelog](http://github.com/rspec/rspec-core/compare/v2.0.0.beta.20...v2.0.0.beta.22)
-
-* Enhancements
-  * removed at_exit hook
-  * CTRL-C stops the run (almost) immediately
-    * first it cleans things up by running the appropriate after(:all) and after(:suite) hooks
-    * then it reports on any examples that have already run
-  * cleaned up rake task
-    * generate correct task under variety of conditions
-    * options are more consistent
-    * deprecated redundant options
-  * run 'bundle exec autotest' when Gemfile is present
-  * support ERB in .rspec options files (Justin Ko)
-  * depend on bundler for development tasks (Myron Marston)
-  * add example_group_finished to formatters and reporter (Roman Chernyatchik)
-
-* Bug fixes
-  * support paths with spaces when using autotest (Andreas Neuhaus)
-  * fix module_exec with ruby 1.8.6 (Myron Marston)
-  * remove context method from top-level
-    * was conflicting with irb, for example
-  * errors in before(:all) are now reported correctly (Chad Humphries)
-
-* Removals
-  * removed -o --options-file command line option
-    * use ./.rspec and ~/.rspec