rspec-core 2.14.8 → 2.99.0.beta1

data/spec/rspec/core/filter_manager_spec.rb

@@ -165,7 +165,7 @@ module RSpec::Core
     describe "#inclusions#description" do
       it 'cleans up the description' do
         project_dir = File.expand_path('.')
-        expect(lambda { }.inspect).to include(project_dir)
+        expect(lambda { }.inspect).to include(project_dir) unless defined?(JRUBY_VERSION) && JRUBY_VERSION == '1.7.4'
         expect(lambda { }.inspect).to include(' (lambda)') if RUBY_VERSION > '1.9'
         expect(lambda { }.inspect).to include('0x')
 
@@ -181,7 +181,7 @@ module RSpec::Core
     describe "#exclusions#description" do
       it 'cleans up the description' do
         project_dir = File.expand_path('.')
-        expect(lambda { }.inspect).to include(project_dir)
+        expect(lambda { }.inspect).to include(project_dir) unless defined?(JRUBY_VERSION) && JRUBY_VERSION == '1.7.4'
         expect(lambda { }.inspect).to include(' (lambda)') if RUBY_VERSION > '1.9'
         expect(lambda { }.inspect).to include('0x')
 

data/spec/rspec/core/formatters/deprecation_formatter_spec.rb

@@ -6,7 +6,7 @@ module RSpec::Core::Formatters
   describe DeprecationFormatter do
     let(:deprecation_stream) { StringIO.new }
     let(:summary_stream)     { StringIO.new }
-    let(:formatter) { DeprecationFormatter.new deprecation_stream, summary_stream }
+    let(:formatter) { DeprecationFormatter.new(deprecation_stream, summary_stream) }
 
     def with_start_defined_on_kernel
       return yield if ::Kernel.method_defined?(:start)
@@ -27,69 +27,173 @@ module RSpec::Core::Formatters
     end
 
     describe "#deprecation" do
-      it "includes the method" do
-        formatter.deprecation(:deprecated => "i_am_deprecated")
-        deprecation_stream.rewind
-        expect(deprecation_stream.read).to match(/i_am_deprecated is deprecated/)
-      end
+      let(:formatter) { DeprecationFormatter.new(deprecation_stream, summary_stream) }
+      let(:summary_stream)     { StringIO.new }
 
-      it "includes the replacement" do
-        formatter.deprecation(:replacement => "use_me")
-        deprecation_stream.rewind
-        expect(deprecation_stream.read).to match(/Use use_me instead/)
-      end
+      context "with a File deprecation_stream" do
+        let(:deprecation_stream) { File.open("#{Dir.tmpdir}/deprecation_summary_example_output", "w+") }
+
+        it "prints a message if provided, ignoring other data" do
+          formatter.deprecation(:message => "this message", :deprecated => "x", :replacement => "y", :call_site => "z")
+          deprecation_stream.rewind
+          expect(deprecation_stream.read).to eq "this message\n"
+        end
 
-      it "includes the call site if provided" do
-        formatter.deprecation(:call_site => "somewhere")
-        deprecation_stream.rewind
-        expect(deprecation_stream.read).to match(/Called from somewhere/)
+        it "includes the method" do
+          formatter.deprecation(:deprecated => "i_am_deprecated")
+          deprecation_stream.rewind
+          expect(deprecation_stream.read).to match(/i_am_deprecated is deprecated/)
+        end
+
+        it "includes the replacement" do
+          formatter.deprecation(:replacement => "use_me")
+          deprecation_stream.rewind
+          expect(deprecation_stream.read).to match(/Use use_me instead/)
+        end
+
+        it "includes the call site if provided" do
+          formatter.deprecation(:call_site => "somewhere")
+          deprecation_stream.rewind
+          expect(deprecation_stream.read).to match(/Called from somewhere/)
+        end
       end
 
-      it "prints a message if provided, ignoring other data" do
-        formatter.deprecation(:message => "this message", :deprecated => "x", :replacement => "y", :call_site => "z")
-        deprecation_stream.rewind
-        expect(deprecation_stream.read).to eq "this message"
+      context "with an IO deprecation stream" do
+        let(:deprecation_stream) { StringIO.new }
+
+        it "prints nothing" do
+          5.times { formatter.deprecation(:deprecated => 'i_am_deprecated') }
+          expect(deprecation_stream.string).to eq ""
+        end
       end
     end
 
     describe "#deprecation_summary" do
-      it "is printed when deprecations go to a file" do
-        file = File.open("#{Dir.tmpdir}/deprecation_summary_example_output", "w")
-        summary_stream = StringIO.new
-        formatter = DeprecationFormatter.new file, summary_stream
-        formatter.deprecation(:deprecated => 'i_am_deprecated')
-        formatter.deprecation_summary
-        summary_stream.rewind
-        expect(summary_stream.read).to match(/1 deprecation logged to .*deprecation_summary_example_output/)
-      end
+      let(:formatter) { DeprecationFormatter.new(deprecation_stream, summary_stream) }
+      let(:summary_stream) { StringIO.new }
 
-      it "pluralizes for more than one deprecation" do
-        file = File.open("#{Dir.tmpdir}/deprecation_summary_example_output", "w")
-        summary_stream = StringIO.new
-        formatter = DeprecationFormatter.new file, summary_stream
-        formatter.deprecation(:deprecated => 'i_am_deprecated')
-        formatter.deprecation(:deprecated => 'i_am_deprecated_also')
-        formatter.deprecation_summary
-        summary_stream.rewind
-        expect(summary_stream.read).to match(/2 deprecations/)
-      end
+      context "with a File deprecation_stream" do
+        let(:deprecation_stream) { File.open("#{Dir.tmpdir}/deprecation_summary_example_output", "w") }
+
+        it "prints a count of the deprecations" do
+          formatter.deprecation(:deprecated => 'i_am_deprecated')
+          formatter.deprecation_summary
+          expect(summary_stream.string).to match(/1 deprecation logged to .*deprecation_summary_example_output/)
+        end
+
+        it "pluralizes the reported deprecation count for more than one deprecation" do
+          formatter.deprecation(:deprecated => 'i_am_deprecated')
+          formatter.deprecation(:deprecated => 'i_am_deprecated_also')
+          formatter.deprecation_summary
+          expect(summary_stream.string).to match(/2 deprecations/)
+        end
+
+        it "is not printed when there are no deprecations" do
+          formatter.deprecation_summary
+          expect(summary_stream.string).to eq ""
+        end
 
-      it "is not printed when there are no deprecations" do
-        file = File.open("#{Dir.tmpdir}/deprecation_summary_example_output", "w")
-        summary_stream = StringIO.new
-        formatter = DeprecationFormatter.new file, summary_stream
-        formatter.deprecation_summary
-        summary_stream.rewind
-        expect(summary_stream.read).to eq ""
+        it 'uses synchronized/non-buffered output to work around odd duplicate output behavior we have observed' do
+          expect {
+            formatter.deprecation(:deprecated => 'foo')
+          }.to change { deprecation_stream.sync }.from(false).to(true)
+        end
+
+        it 'does not print duplicate messages' do
+          3.times { formatter.deprecation(:deprecated => 'foo') }
+          formatter.deprecation_summary
+
+          expect(summary_stream.string).to match(/1 deprecation/)
+          expect(File.read(deprecation_stream.path)).to eq("foo is deprecated.\n#{DeprecationFormatter::RAISE_ERROR_CONFIG_NOTICE}")
+        end
       end
 
-      it "is not printed when deprecations go to an IO instance" do
-        summary_stream = StringIO.new
-        formatter = DeprecationFormatter.new StringIO.new, summary_stream
-        formatter.deprecation(:deprecated => 'i_am_deprecated')
-        formatter.deprecation_summary
-        summary_stream.rewind
-        expect(summary_stream.read).to eq ""
+      context "with an IO deprecation_stream" do
+        let(:deprecation_stream) { StringIO.new }
+
+        it "groups similar deprecations together" do
+          formatter.deprecation(:deprecated => 'i_am_deprecated', :call_site => "foo.rb:1")
+          formatter.deprecation(:deprecated => 'i_am_a_different_deprecation')
+          formatter.deprecation(:deprecated => 'i_am_deprecated', :call_site => "foo.rb:2")
+          formatter.deprecation_summary
+
+          expected = <<-EOS.gsub(/^\s+\|/, '')
+            |
+            |Deprecation Warnings:
+            |
+            |i_am_a_different_deprecation is deprecated.
+            |
+            |i_am_deprecated is deprecated. Called from foo.rb:1.
+            |i_am_deprecated is deprecated. Called from foo.rb:2.
+            |
+            |#{DeprecationFormatter::RAISE_ERROR_CONFIG_NOTICE}
+          EOS
+          expect(deprecation_stream.string).to eq expected.chomp
+        end
+
+        it "limits the deprecation warnings after 3 calls" do
+          5.times { |i| formatter.deprecation(:deprecated => 'i_am_deprecated', :call_site => "foo.rb:#{i + 1}") }
+          formatter.deprecation_summary
+          expected = <<-EOS.gsub(/^\s+\|/, '')
+            |
+            |Deprecation Warnings:
+            |
+            |i_am_deprecated is deprecated. Called from foo.rb:1.
+            |i_am_deprecated is deprecated. Called from foo.rb:2.
+            |i_am_deprecated is deprecated. Called from foo.rb:3.
+            |Too many uses of deprecated 'i_am_deprecated'. Set config.deprecation_stream to a File for full output.
+            |
+            |#{DeprecationFormatter::RAISE_ERROR_CONFIG_NOTICE}
+          EOS
+          expect(deprecation_stream.string).to eq expected.chomp
+        end
+
+        it "limits :message deprecation warnings with different callsites after 3 calls" do
+          5.times do |n|
+            message = "This is a long string with some callsite info: /path/#{n}/to/some/file.rb:2#{n}3.  And some more stuff can come after."
+            formatter.deprecation(:message => message)
+          end
+          formatter.deprecation_summary
+          expected = <<-EOS.gsub(/^\s+\|/, '')
+            |
+            |Deprecation Warnings:
+            |
+            |This is a long string with some callsite info: /path/0/to/some/file.rb:203.  And some more stuff can come after.
+            |This is a long string with some callsite info: /path/1/to/some/file.rb:213.  And some more stuff can come after.
+            |This is a long string with some callsite info: /path/2/to/some/file.rb:223.  And some more stuff can come after.
+            |Too many similar deprecation messages reported, disregarding further reports. Set config.deprecation_stream to a File for full output.
+            |
+            |#{DeprecationFormatter::RAISE_ERROR_CONFIG_NOTICE}
+          EOS
+          expect(deprecation_stream.string).to eq expected.chomp
+        end
+
+        it "prints the true deprecation count to the summary_stream" do
+          5.times { |i| formatter.deprecation(:deprecated => 'i_am_deprecated', :call_site => "foo.rb:#{i + 1}") }
+          5.times do |n|
+            formatter.deprecation(:message => "callsite info: /path/#{n}/to/some/file.rb:2#{n}3.  And some more stuff")
+          end
+          formatter.deprecation_summary
+          expect(summary_stream.string).to match(/10 deprecation warnings total/)
+        end
+
+        it 'does not print duplicate messages' do
+          3.times { formatter.deprecation(:deprecated => 'foo') }
+          formatter.deprecation_summary
+
+          expect(summary_stream.string).to match(/1 deprecation/)
+
+          expected = <<-EOS.gsub(/^\s+\|/, '')
+            |
+            |Deprecation Warnings:
+            |
+            |foo is deprecated.
+            |
+            |#{DeprecationFormatter::RAISE_ERROR_CONFIG_NOTICE}
+          EOS
+
+          expect(deprecation_stream.string).to eq expected.chomp
+        end
       end
     end
   end

data/spec/rspec/core/formatters/html_formatter_spec.rb

@@ -24,7 +24,7 @@ module RSpec
 
         let(:generated_html) do
           options = RSpec::Core::ConfigurationOptions.new(
-            %w[spec/rspec/core/resources/formatter_specs.rb --format html --order default]
+            %w[spec/rspec/core/resources/formatter_specs.rb --format html --order defined]
           )
           options.parse_options
 

data/spec/rspec/core/formatters/text_mate_formatter_spec.rb

@@ -24,7 +24,7 @@ module RSpec
 
         let(:generated_html) do
           options = RSpec::Core::ConfigurationOptions.new(
-            %w[spec/rspec/core/resources/formatter_specs.rb --format textmate --order default]
+            %w[spec/rspec/core/resources/formatter_specs.rb --format textmate --order defined]
           )
           options.parse_options
 
@@ -72,7 +72,6 @@ module RSpec
 
             expect(actual_doc.inner_html).to eq(expected_doc.inner_html)
 
-            expect(backtrace_lines).to_not be_empty
             backtrace_lines.each do |backtrace_line|
               expect(backtrace_line['href']).to include("txmt://open?url=")
             end

data/spec/rspec/core/hooks_spec.rb

@@ -26,6 +26,7 @@ module RSpec::Core
         context "when RSpec.configuration.treat_symbols_as_metadata_keys_with_true_values is set to #{config_value}" do
           before(:each) do
             Kernel.stub(:warn)
+            allow_deprecation unless config_value
             RSpec.configure { |c| c.treat_symbols_as_metadata_keys_with_true_values = config_value }
           end
 
@@ -57,6 +58,7 @@ module RSpec::Core
         [true, false].each do |config_value|
           context "when RSpec.configuration.treat_symbols_as_metadata_keys_with_true_values is set to #{config_value}" do
             before(:each) do
+              allow_deprecation unless config_value
               RSpec.configure { |c| c.treat_symbols_as_metadata_keys_with_true_values = config_value }
             end
 

data/spec/rspec/core/memoized_helpers_spec.rb

@@ -56,6 +56,18 @@ module RSpec::Core
     end
 
     describe "explicit subject" do
+      it "yields the example in which it is eval'd" do
+        example_yielded_to_subject = nil
+        example_yielded_to_example = nil
+
+        group = ExampleGroup.describe
+        group.subject { |e| example_yielded_to_subject = e }
+        group.example { |e| subject; example_yielded_to_example = e }
+        group.run
+
+        expect(example_yielded_to_subject).to eq example_yielded_to_example
+      end
+
       [false, nil].each do |falsy_value|
         context "with a value of #{falsy_value.inspect}" do
           it "is evaluated once per example" do
@@ -70,7 +82,7 @@ module RSpec::Core
               subject
               subject
             end
-            expect(group.run).to be_true, "expected subject block to be evaluated only once"
+            expect(group.run).to be_truthy, "expected subject block to be evaluated only once"
           end
         end
       end
@@ -184,6 +196,18 @@ module RSpec::Core
       end
 
       describe "with a name" do
+        it "yields the example in which it is eval'd" do
+          example_yielded_to_subject = nil
+          example_yielded_to_example = nil
+
+          group = ExampleGroup.describe
+          group.subject(:foo) { |e| example_yielded_to_subject = e }
+          group.example       { |e| foo; example_yielded_to_example = e }
+          group.run
+
+          expect(example_yielded_to_subject).to eq example_yielded_to_example
+        end
+
         it "defines a method that returns the memoized subject" do
           list_value_1 = list_value_2 = subject_value_1 = subject_value_2 = nil
 
@@ -319,152 +343,160 @@ module RSpec::Core
           it { should_not be_not_ok }
         end
 
-        expect(group.run).to be_true
+        expect(group.run).to be_truthy
       end
     end
 
     describe "#its" do
-      subject do
-        Class.new do
-          def initialize
-            @call_count = 0
-          end
-
-          def call_count
-            @call_count += 1
-          end
-        end.new
-      end
-
-      context "with a call counter" do
-        its(:call_count) { should eq(1) }
-      end
+      extend SilenceDSLDeprecations
+      silence_dsl_deprecations do
+        it "should issue deprecation warning" do
+          expect_deprecation_with_call_site(__FILE__, __LINE__+1, '`its` method')
+          RSpec::Core::ExampleGroup.its(nil) {}
+        end
 
-      context "with nil value" do
         subject do
           Class.new do
-            def nil_value
-              nil
+            def initialize
+              @call_count = 0
             end
-          end.new
-        end
-        its(:nil_value) { should be_nil }
-      end
 
-      context "with nested attributes" do
-        subject do
-          Class.new do
-            def name
-              "John"
+            def call_count
+              @call_count += 1
             end
           end.new
         end
-        its("name")            { should eq("John") }
-        its("name.size")       { should eq(4) }
-        its("name.size.class") { should eq(Fixnum) }
-      end
 
-      context "when it responds to #[]" do
-        subject do
-          Class.new do
-            def [](*objects)
-              objects.map do |object|
-                "#{object.class}: #{object.to_s}"
-              end.join("; ")
-            end
+        context "with a call counter" do
+          its(:call_count) { should eq(1) }
+        end
 
-            def name
-              "George"
-            end
-          end.new
+        context "with nil value" do
+          subject do
+            Class.new do
+              def nil_value
+                nil
+              end
+            end.new
+          end
+          its(:nil_value) { should be_nil }
         end
-        its([:a]) { should eq("Symbol: a") }
-        its(['a']) { should eq("String: a") }
-        its([:b, 'c', 4]) { should eq("Symbol: b; String: c; Fixnum: 4") }
-        its(:name) { should eq("George") }
-        context "when referring to an attribute without the proper array syntax" do
-          context "it raises an error" do
-            its(:age) do
-              expect do
-                should eq(64)
-              end.to raise_error(NoMethodError)
+
+        context "with nested attributes" do
+          subject do
+            Class.new do
+              def name
+                "John"
+              end
+            end.new
+          end
+          its("name")            { should eq("John") }
+          its("name.size")       { should eq(4) }
+          its("name.size.class") { should eq(Fixnum) }
+        end
+
+        context "when it responds to #[]" do
+          subject do
+            Class.new do
+              def [](*objects)
+                objects.map do |object|
+                  "#{object.class}: #{object.to_s}"
+                end.join("; ")
+              end
+
+              def name
+                "George"
+              end
+            end.new
+          end
+          its([:a]) { should eq("Symbol: a") }
+          its(['a']) { should eq("String: a") }
+          its([:b, 'c', 4]) { should eq("Symbol: b; String: c; Fixnum: 4") }
+          its(:name) { should eq("George") }
+          context "when referring to an attribute without the proper array syntax" do
+            context "it raises an error" do
+              its(:age) do
+                expect do
+                  should eq(64)
+                end.to raise_error(NoMethodError)
+              end
             end
           end
         end
-      end
 
-      context "when it does not respond to #[]" do
-        subject { Object.new }
+        context "when it does not respond to #[]" do
+          subject { Object.new }
 
-        context "it raises an error" do
-          its([:a]) do
-            expect do
-              should eq("Symbol: a")
-            end.to raise_error(NoMethodError)
+          context "it raises an error" do
+            its([:a]) do
+              expect do
+                should eq("Symbol: a")
+              end.to raise_error(NoMethodError)
+            end
           end
         end
-      end
 
-      context "calling and overriding super" do
-        it "calls to the subject defined in the parent group" do
-          group = ExampleGroup.describe(Array) do
-            subject { [1, 'a'] }
+        context "calling and overriding super" do
+          it "calls to the subject defined in the parent group" do
+            group = ExampleGroup.describe(Array) do
+              subject { [1, 'a'] }
 
-            its(:last) { should eq("a") }
+              its(:last) { should eq("a") }
 
-            describe '.first' do
-              def subject; super().first; end
+              describe '.first' do
+                def subject; super().first; end
 
-              its(:next) { should eq(2) }
+                its(:next) { should eq(2) }
+              end
             end
-          end
 
-          expect(group.run).to be_true
+            expect(group.run).to be_truthy
+          end
         end
-      end
 
-      context "with nil subject" do
-        subject do
-          Class.new do
-            def initialize
-              @counter = -1
-            end
-            def nil_if_first_time
-              @counter += 1
-              @counter == 0 ? nil : true
-            end
-          end.new
+        context "with nil subject" do
+          subject do
+            Class.new do
+              def initialize
+                @counter = -1
+              end
+              def nil_if_first_time
+                @counter += 1
+                @counter == 0 ? nil : true
+              end
+            end.new
+          end
+          its(:nil_if_first_time) { should be(nil) }
         end
-        its(:nil_if_first_time) { should be(nil) }
-      end
 
-      context "with false subject" do
-        subject do
-          Class.new do
-            def initialize
-              @counter = -1
-            end
-            def false_if_first_time
-              @counter += 1
-              @counter > 0
-            end
-          end.new
+        context "with false subject" do
+          subject do
+            Class.new do
+              def initialize
+                @counter = -1
+              end
+              def false_if_first_time
+                @counter += 1
+                @counter > 0
+              end
+            end.new
+          end
+          its(:false_if_first_time) { should be(false) }
         end
-        its(:false_if_first_time) { should be(false) }
-      end
 
-      describe 'accessing `subject` in `before` and `let`' do
-        subject { 'my subject' }
-        before { @subject_in_before = subject }
-        let(:subject_in_let) { subject }
-        let!(:eager_loaded_subject_in_let) { subject }
-
-        # These examples read weird, because we're actually
-        # specifying the behaviour of `its` itself
-        its(nil) { expect(subject).to eq('my subject') }
-        its(nil) { expect(@subject_in_before).to eq('my subject') }
-        its(nil) { expect(subject_in_let).to eq('my subject') }
-        its(nil) { expect(eager_loaded_subject_in_let).to eq('my subject') }
+        describe 'accessing `subject` in `before` and `let`' do
+          subject { 'my subject' }
+          before { @subject_in_before = subject }
+          let(:subject_in_let) { subject }
+          let!(:eager_loaded_subject_in_let) { subject }
+
+          # These examples read weird, because we're actually
+          # specifying the behaviour of `its` itself
+          its(nil) { expect(subject).to eq('my subject') }
+          its(nil) { expect(@subject_in_before).to eq('my subject') }
+          its(nil) { expect(subject_in_let).to eq('my subject') }
+          its(nil) { expect(eager_loaded_subject_in_let).to eq('my subject') }
+        end
       end
     end
 
@@ -516,6 +548,15 @@ module RSpec::Core
       expect(@nil_value_count).to eq(1)
     end
 
+    let(:yield_the_example) do |example_yielded_to_let|
+      @example_yielded_to_let = example_yielded_to_let
+    end
+
+    it "yields the example" do |example_yielded_to_example|
+      yield_the_example
+      expect(@example_yielded_to_let).to equal example_yielded_to_example
+    end
+
     let(:regex_with_capture) { %r[RegexWithCapture(\d)] }
 
     it 'does not pass the block up the ancestor chain' do