rspec-core 2.0.0.beta.22 → 2.6.0

data/spec/rspec/core/example_spec.rb

@@ -9,10 +9,63 @@ describe RSpec::Core::Example, :parent_metadata => 'sample' do
     example_group.example('example description')
   end
 
-  describe "#behaviour" do
-    it "is deprecated" do
-      RSpec.should_receive(:deprecate)
-      example_instance.behaviour
+  it_behaves_like "metadata hash builder" do
+    def metadata_hash(*args)
+      example = example_group.example('example description', *args)
+      example.metadata
+    end
+  end
+
+  describe "auto-generated example descriptions" do
+    let(:generated_description) { "the generated description" }
+    let(:rspec_example) { example_group.specify { 5.should == 5 } }
+    before(:each) { RSpec::Matchers.stub(:generated_description => generated_description) }
+
+    def expect_with(*frameworks)
+      RSpec.configuration.stub(:expecting_with_rspec?).and_return(frameworks.include?(:rspec))
+
+      if frameworks.include?(:stdlib)
+        example_group.class_eval do
+          def assert(val)
+            raise "Expected #{val} to be true" unless val
+          end
+        end
+      end
+    end
+
+    context "when `expect_with :rspec` is configured" do
+      before(:each) { expect_with :rspec }
+
+      it "generates a description for an example with no description" do
+        expect {
+          example_group.run
+        }.to change { rspec_example.metadata[:description] }.from("").to(generated_description)
+      end
+    end
+
+    context "when `expect_with :rspec, :stdlib` is configured" do
+      before(:each) { expect_with :rspec, :stdlib }
+
+      it "generates a description for an example with no description" do
+        expect {
+          example_group.run
+        }.to change { rspec_example.metadata[:description] }.from("").to(generated_description)
+      end
+    end
+
+    context "when `expect_with :stdlib` is configured" do
+      let!(:stdlib_example) { example_group.specify { assert 5 == 5 } }
+      before(:each) { expect_with :stdlib }
+
+      it "does not attempt to get the generated description from RSpec::Matchers" do
+        RSpec::Matchers.should_not_receive(:generated_description)
+        example_group.run
+      end
+
+      it "fails an example with no description" do
+        example_group.run
+        stdlib_example.should have_failed_with(NotImplementedError)
+      end
     end
   end
 
@@ -40,17 +93,12 @@ describe RSpec::Core::Example, :parent_metadata => 'sample' do
   end
 
   describe "#run" do
-    context "with RSpec.wants_to_quit=true" do
-      it "returns without starting the example" do
-        RSpec.stub(:wants_to_quit) { true }
-        group = RSpec::Core::ExampleGroup.describe
-        example = group.example('example') {}
-
-        reporter = double('reporter').as_null_object
-        reporter.should_not_receive(:example_started)
-
-        example.run(group.new,reporter)
+    it "sets its reference to the example group instance to nil" do
+      group = RSpec::Core::ExampleGroup.describe do
+        example('example') { 1.should eq(1) }
       end
+      group.run
+      group.examples.first.instance_variable_get("@example_group_instance").should be_nil
     end
 
     it "runs after(:each) when the example passes" do
@@ -59,7 +107,7 @@ describe RSpec::Core::Example, :parent_metadata => 'sample' do
         after(:each) { after_run = true }
         example('example') { 1.should == 1 }
       end
-      group.run_all
+      group.run
       after_run.should be_true, "expected after(:each) to be run"
     end
 
@@ -69,7 +117,7 @@ describe RSpec::Core::Example, :parent_metadata => 'sample' do
         after(:each) { after_run = true }
         example('example') { 1.should == 2 }
       end
-      group.run_all
+      group.run
       after_run.should be_true, "expected after(:each) to be run"
     end
 
@@ -79,7 +127,7 @@ describe RSpec::Core::Example, :parent_metadata => 'sample' do
         after(:each) { after_run = true }
         example('example') { raise "this error" }
       end
-      group.run_all
+      group.run
       after_run.should be_true, "expected after(:each) to be run"
     end
 
@@ -91,7 +139,7 @@ describe RSpec::Core::Example, :parent_metadata => 'sample' do
           after(:each) { raise "FOO" }
           example('example') { 1.should == 1 }
         end
-        group.run_all
+        group.run
         after_run.should be_true, "expected after(:each) to be run"
       end
 
@@ -100,9 +148,9 @@ describe RSpec::Core::Example, :parent_metadata => 'sample' do
         group.after(:each) { raise "FOO" }
         example = group.example('example') { 1.should == 1 }
 
-        group.run_all
+        group.run
 
-        example.metadata[:execution_result][:exception_encountered].message.should == "FOO"
+        example.metadata[:execution_result][:exception].message.should == "FOO"
       end
     end
 
@@ -119,7 +167,7 @@ describe RSpec::Core::Example, :parent_metadata => 'sample' do
         example { results << "example" }
       end
 
-      group.run_all
+      group.run
       results.should eq([
         "around (before)",
         "before",
@@ -128,17 +176,34 @@ describe RSpec::Core::Example, :parent_metadata => 'sample' do
         "around (after)"
       ])
     end
-  end
 
-  describe "#in_block?" do
-    before do
-      example.should_not be_in_block
-    end
-    it "is only true during the example (but not before or after)" do
-      example.should be_in_block
-    end
-    after do
-      example.should_not be_in_block
+    context "clearing ivars" do
+      it "sets ivars to nil to prep them for GC" do
+        group = RSpec::Core::ExampleGroup.describe do
+          before(:all)  { @before_all  = :before_all }
+          before(:each) { @before_each = :before_each }
+          after(:each)  { @after_each = :after_each }
+          after(:all)   { @after_all  = :after_all }
+        end
+        example = group.example("does something") do
+          @in_example = :in_example
+        end
+        example_group_instance = group.new
+        example.run(example_group_instance, double('reporter').as_null_object)
+
+        %w[@before_all @before_each @after_each @after_all].each do |ivar|
+          example_group_instance.instance_variable_get(ivar).should be_nil
+        end
+      end
+
+      it "does not impact the before_all_ivars which are copied to each example" do
+        group = RSpec::Core::ExampleGroup.describe do
+          before(:all) { @before_all = "abc" }
+          example("first") { @before_all.should_not be_nil }
+          example("second") { @before_all.should_not be_nil }
+        end
+        group.run.should be_true
+      end
     end
   end
 
@@ -148,45 +213,60 @@ describe RSpec::Core::Example, :parent_metadata => 'sample' do
         group = RSpec::Core::ExampleGroup.describe do
           example { pending }
         end
-        group.run_all
+        group.run
         group.examples.first.should be_pending
       end
+
+      it "allows post-example processing in around hooks (see https://github.com/rspec/rspec-core/issues/322)" do
+        blah = nil
+        group = RSpec::Core::ExampleGroup.describe do
+          around do |example|
+            example.run
+            blah = :success
+          end
+          example { pending }
+        end
+        group.run
+        blah.should be(:success)
+      end
     end
       
     context "in before(:each)" do
-      it "sets the example to pending" do
+      it "sets each example to pending" do
         group = RSpec::Core::ExampleGroup.describe do
           before(:each) { pending }
           example {}
+          example {}
         end
-        group.run_all
+        group.run
         group.examples.first.should be_pending
+        group.examples.last.should be_pending
       end
     end
 
-    context "in around(:each)" do
-      it "sets the example to pending" do
+    context "in before(:all)" do
+      it "sets each example to pending" do
         group = RSpec::Core::ExampleGroup.describe do
-          around(:each) { pending }
+          before(:all) { pending }
+          example {}
           example {}
         end
-        group.run_all
+        group.run
         group.examples.first.should be_pending
+        group.examples.last.should be_pending
       end
     end
 
-    context "in before(:all)" do
-      pending "is not supported" do
+    context "in around(:each)" do
+      it "sets the example to pending" do
         group = RSpec::Core::ExampleGroup.describe do
-          before(:all) { pending }
+          around(:each) { pending }
           example {}
         end
-        group.run_all
+        group.run
         group.examples.first.should be_pending
-        expect do
-          group.run_all
-        end.to raise_error(/undefined method `metadata'/)
       end
     end
+
   end
 end

data/spec/rspec/core/formatters/base_formatter_spec.rb

@@ -1,4 +1,5 @@
-require "spec_helper"
+require 'spec_helper'
+require 'rspec/core/formatters/base_formatter'
 
 describe RSpec::Core::Formatters::BaseFormatter do
 
@@ -17,4 +18,63 @@ describe RSpec::Core::Formatters::BaseFormatter do
     end
   end
 
+  describe "read_failed_line" do
+    it "deals gracefully with a heterogeneous language stack trace" do
+      exception = mock(:Exception, :backtrace => [
+        "at Object.prototypeMethod (foo:331:18)",
+        "at Array.forEach (native)",
+        "at a_named_javascript_function (/some/javascript/file.js:39:5)",
+        "/some/line/of/ruby.rb:14"
+      ])
+      example = mock(:Example, :file_path => __FILE__)
+      lambda {
+        formatter.send(:read_failed_line, exception, example)
+      }.should_not raise_error
+    end
+
+    context "when String alias to_int to_i" do
+      before do
+        String.class_eval do
+          alias :to_int :to_i
+        end
+      end
+
+      after do
+        String.class_eval do
+          undef to_int
+        end
+      end
+
+      it "doesn't hang when file exists" do
+        pending("This issue still exists on JRuby, but should be resolved shortly: https://github.com/rspec/rspec-core/issues/295", :if => RUBY_PLATFORM == 'java')
+        exception = mock(:Exception, :backtrace => [ "#{__FILE__}:#{__LINE__}"])
+
+        example = mock(:Example, :file_path => __FILE__)
+        formatter.send(:read_failed_line, exception, example).should
+          eql %Q{        exception = mock(:Exception, :backtrace => [ "\#{__FILE__}:\#{__LINE__}"])\n}
+      end
+
+    end
+  end
+
+  describe "#format_backtrace" do
+    let(:rspec_expectations_dir) { "/path/to/rspec-expectations/lib" }
+    let(:rspec_core_dir) { "/path/to/rspec-core/lib" }
+    let(:backtrace) do
+      [
+        "#{rspec_expectations_dir}/rspec/matchers/operator_matcher.rb:51:in `eval_match'",
+        "#{rspec_expectations_dir}/rspec/matchers/operator_matcher.rb:29:in `=='",
+        "./my_spec.rb:5",
+        "#{rspec_core_dir}/rspec/core/example.rb:52:in `run'",
+        "#{rspec_core_dir}/rspec/core/runner.rb:37:in `run'",
+        RSpec::Core::Runner::AT_EXIT_HOOK_BACKTRACE_LINE,
+        "./my_spec.rb:3"
+      ]
+    end
+
+    it "removes lines from rspec and lines that come before the invocation of the at_exit autorun hook" do
+      formatter.format_backtrace(backtrace, stub.as_null_object).should == ["./my_spec.rb:5"]
+    end
+  end
+
 end

data/spec/rspec/core/formatters/base_text_formatter_spec.rb

@@ -1,4 +1,5 @@
-require "spec_helper"
+require 'spec_helper'
+require 'rspec/core/formatters/base_text_formatter'
 
 module RSpec::Core::Formatters
 
@@ -32,7 +33,7 @@ module RSpec::Core::Formatters
       before { RSpec.configuration.stub(:color_enabled?) { false } }
 
       def run_all_and_dump_failures
-        group.run_all(formatter)
+        group.run(formatter)
         formatter.dump_failures
       end
 
@@ -45,6 +46,39 @@ module RSpec::Core::Formatters
         output.string.should =~ /(\s+)expected \"that\"\n\1     got \"this\"/m
       end
 
+      context "with an exception without a message" do
+        it "does not throw NoMethodError" do
+          exception_without_message = Exception.new()
+          exception_without_message.stub(:message) { nil }
+          group.example("example name") { raise exception_without_message }
+          expect { run_all_and_dump_failures }.not_to raise_error(NoMethodError)
+        end
+      end
+
+      context "with an exception class other than RSpec" do
+        it "does not show the error class" do
+          group.example("example name") { raise NameError.new('foo') }
+          run_all_and_dump_failures
+          output.string.should =~ /NameError/m
+        end
+      end
+
+      context "with a failed expectation (rspec-expectations)" do
+        it "does not show the error class" do
+          group.example("example name") { "this".should eq("that") }
+          run_all_and_dump_failures
+          output.string.should_not =~ /RSpec/m
+        end
+      end
+
+      context "with a failed message expectation (rspec-mocks)" do
+        it "does not show the error class" do
+          group.example("example name") { "this".should_receive("that") }
+          run_all_and_dump_failures
+          output.string.should_not =~ /RSpec/m
+        end
+      end
+
       context 'for #share_examples_for' do
         it 'outputs the name and location' do
 
@@ -133,7 +167,7 @@ module RSpec::Core::Formatters
           group = RSpec::Core::ExampleGroup.describe("group") do
             example("example")
           end
-          group.run_all(double('reporter').as_null_object)
+          group.run(double('reporter').as_null_object)
           group.examples
         end
       end
@@ -145,14 +179,14 @@ module RSpec::Core::Formatters
 
       it "prints the time" do
         formatter.dump_profile
-        output.string.should =~ /0\.\d+ seconds/
+        output.string.should =~ /0(\.\d+)? seconds/
       end
 
       it "prints the path" do
         formatter.dump_profile
         filename = __FILE__.split(File::SEPARATOR).last
 
-        output.string.should =~ /#{filename}\:134/
+        output.string.should =~ /#{filename}\:#{__LINE__ - 21}/
       end
     end
   end

data/spec/rspec/core/formatters/documentation_formatter_spec.rb

@@ -1,4 +1,5 @@
-require "spec_helper"
+require 'spec_helper'
+require 'rspec/core/formatters/documentation_formatter'
 
 module RSpec::Core::Formatters
   describe DocumentationFormatter do
@@ -7,11 +8,11 @@ module RSpec::Core::Formatters
       examples = [
         double("example 1",
                :description => "first example",
-               :execution_result => {:status => 'failed', :exception_encountered => Exception.new }
+               :execution_result => {:status => 'failed', :exception => Exception.new }
               ),
         double("example 2",
                :description => "second example",
-               :execution_result => {:status => 'failed', :exception_encountered => Exception.new }
+               :execution_result => {:status => 'failed', :exception => Exception.new }
               )
       ]
 
@@ -46,9 +47,9 @@ module RSpec::Core::Formatters
       context2.example("nested example 2.1"){}
       context2.example("nested example 2.2"){}
 
-      group.run_all(RSpec::Core::Reporter.new(formatter))
+      group.run(RSpec::Core::Reporter.new(formatter))
 
-      output.string.should eql "
+      output.string.should eql("
 root
   context 1
     nested example 1.1
@@ -59,7 +60,7 @@ root
   context 2
     nested example 2.1
     nested example 2.2
-"
+")
     end
   end
 end

data/spec/rspec/core/formatters/helpers_spec.rb

@@ -1,5 +1,5 @@
 require 'spec_helper'
-require 'stringio'
+require 'rspec/core/formatters/helpers'
 
 describe RSpec::Core::Formatters::Helpers do
   let(:helper) { helper = Object.new.extend(RSpec::Core::Formatters::Helpers) }