rspec-core 2.0.0.beta.20 → 2.0.0.beta.22

data/spec/rspec/core/configuration_options_spec.rb

@@ -95,13 +95,6 @@ describe RSpec::Core::ConfigurationOptions do
     end
   end
 
-  describe "options file" do
-    it "is parsed from --options or -o" do
-      options_from_args("--options", "custom/path").should include(:options_file => "custom/path")
-      options_from_args("-o", "custom/path").should include(:options_file => "custom/path")
-    end
-  end
-
   describe "files_or_directories_to_run" do
     it "parses files from '-c file.rb dir/file.rb'" do
       options_from_args("-c", "file.rb", "dir/file.rb").should include(:files_or_directories_to_run => ["file.rb", "dir/file.rb"])
@@ -159,14 +152,14 @@ describe RSpec::Core::ConfigurationOptions do
 
       it "turns off the debugger option if --drb is specified in the options file" do
         File.stub(:exist?) { true }
-        File.stub(:readlines) { %w[ --drb  ] }
+        IO.stub(:read) { "--drb" }
         config_options_object("--debug").drb_argv.should_not include("--debug")
         config_options_object("-d"     ).drb_argv.should_not include("--debug")
       end
 
       it "turns off the debugger option if --debug is specified in the options file" do
         File.stub(:exist?) { true }
-        File.stub(:readlines) { %w[ --debug  ] }
+        IO.stub(:read) { "--debug" }
         config_options_object("--drb").drb_argv.should_not include("--debug")
         config_options_object("-X"   ).drb_argv.should_not include("--debug")
       end
@@ -197,7 +190,7 @@ describe RSpec::Core::ConfigurationOptions do
     context "--drb specified in the options file" do
       it "renders all the original arguments except --drb" do
         File.stub(:exist?) { true }
-        File.stub(:readlines) { %w[ --drb --color ] }
+        IO.stub(:read) { "--drb --color" }
         config_options_object(*%w[ --format s --line_number 1 --example pattern --profile --backtrace ]).
           drb_argv.should eq(%w[ --color --profile --backtrace --format s --line_number 1 --example pattern ])
       end
@@ -206,7 +199,7 @@ describe RSpec::Core::ConfigurationOptions do
     context "--drb specified in ARGV and the options file" do
       it "renders all the original arguments except --drb" do
         File.stub(:exist?) { true }
-        File.stub(:readlines) { %w[ --drb --color ] }
+        IO.stub(:read) { "--drb --color" }
         config_options_object(*%w[ --drb --format s --line_number 1 --example pattern --profile --backtrace]).
           drb_argv.should eq(%w[ --color --profile --backtrace --format s --line_number 1 --example pattern ])
       end
@@ -215,7 +208,7 @@ describe RSpec::Core::ConfigurationOptions do
     context "--drb specified in ARGV and in as ARGV-specified --options file" do
       it "renders all the original arguments except --drb and --options" do
         File.stub(:exist?) { true }
-        File.stub(:readlines) { %w[ --drb --color ] }
+        IO.stub(:read) { "--drb --color" }
         config_options_object(*%w[ --drb --format s --line_number 1 --example pattern --profile --backtrace]).
           drb_argv.should eq(%w[ --color --profile --backtrace --format s --line_number 1 --example pattern ])
       end
@@ -227,17 +220,7 @@ describe RSpec::Core::ConfigurationOptions do
 
     it "loads automatically" do
       File.stub(:exist?) { true }
-      File.stub(:readlines) { ["--format", "doc"] }
-
-      config_options = RSpec::Core::ConfigurationOptions.new([])
-      config_options.parse_options
-      config_options.configure(config)
-      config.formatter.should == 'doc'
-    end
-
-    it "allows options on one line" do
-      File.stub(:exist?) { true }
-      File.stub(:readlines) { ["--format doc"] }
+      IO.stub(:read) { "--format doc" }
 
       config_options = RSpec::Core::ConfigurationOptions.new([])
       config_options.parse_options
@@ -247,12 +230,12 @@ describe RSpec::Core::ConfigurationOptions do
 
     it "merges options from the global and local .rspec and the command line" do
       File.stub(:exist?){ true }
-      File.stub(:readlines) do |path|
+      IO.stub(:read) do |path|
         case path
         when ".rspec"
-          ["--format", "documentation"]
+          "--format documentation"
         when /\.rspec/
-          ["--line", "37"]
+          "--line 37"
         else
           raise "Unexpected path: #{path}"
         end
@@ -269,12 +252,12 @@ describe RSpec::Core::ConfigurationOptions do
 
     it "prefers local options over global" do
       File.stub(:exist?){ true }
-      File.stub(:readlines) do |path|
+      IO.stub(:read) do |path|
         case path
         when ".rspec"
-          ["--format", "local"]
+          "--format local"
         when /\.rspec/
-          ["--format", "global"]
+          "--format global"
         else
           raise "Unexpected path: #{path}"
         end

data/spec/rspec/core/configuration_spec.rb

@@ -138,7 +138,7 @@ module RSpec::Core
 
     end
 
-    describe "include" do
+    describe "#include" do
 
       module InstanceLevelMethods
         def you_call_this_a_blt?
@@ -172,7 +172,7 @@ module RSpec::Core
 
     end
 
-    describe "extend" do
+    describe "#extend" do
 
       module ThatThingISentYou
         def that_thing
@@ -202,7 +202,7 @@ module RSpec::Core
       end
     end
 
-    describe 'color_enabled=' do
+    describe "#color_enabled=" do
       context "given true" do
         context "on windows" do
           before do
@@ -337,7 +337,7 @@ module RSpec::Core
       end
     end
 
-    describe "full_backtrace=" do
+    describe "#full_backtrace=" do
       it "clears the backtrace clean patterns" do
         config.full_backtrace = true
         config.backtrace_clean_patterns.should == []
@@ -352,14 +352,14 @@ module RSpec::Core
       end
     end
 
-    describe "debug=true" do
+    describe "#debug=true" do
       it "requires 'ruby-debug'" do
         config.should_receive(:require).with('ruby-debug')
         config.debug = true
       end
     end
 
-    describe "debug=false" do
+    describe "#debug=false" do
       it "does not require 'ruby-debug'" do
         config.should_not_receive(:require).with('ruby-debug')
         config.debug = false
@@ -374,14 +374,14 @@ module RSpec::Core
       end
     end
 
-    describe "libs=" do
+    describe "#libs=" do
       it "adds directories to the LOAD_PATH" do
         $LOAD_PATH.should_receive(:unshift).with("a/dir")
         config.libs = ["a/dir"]
       end
     end
 
-    describe "requires=" do
+    describe "#requires=" do
       it "requires paths" do
         config.should_receive(:require).with("a/path")
         config.requires = ["a/path"]

data/spec/rspec/core/example_group_spec.rb

@@ -325,14 +325,15 @@ module RSpec::Core
       end
 
       it "treats an error in before(:all) as a failure" do
-        pending("fix issue 21 - treat error in before all as failure") do
-          group = ExampleGroup.describe
-          group.before(:all) { raise "error in before all" }
-          example = group.example("equality") { 1.should == 2}
-          group.run_all
+        group = ExampleGroup.describe
+        group.before(:all) { raise "error in before all" }
+        example = group.example("equality") { 1.should == 2}
+        group.run_all
 
-          example.metadata[:execution_result][:exception_encountered].message.should == "error in before all"
-        end
+        example.metadata.should_not be_nil
+        example.metadata[:execution_result].should_not be_nil
+        example.metadata[:execution_result][:exception_encountered].should_not be_nil
+        example.metadata[:execution_result][:exception_encountered].message.should == "error in before all"
       end
 
       it "has no 'running example' within before(:all)" do
@@ -584,6 +585,36 @@ module RSpec::Core
     describe "#run" do
       let(:reporter) { double("reporter").as_null_object }
 
+      context "with RSpec.wants_to_quit=true" do
+        before do
+          RSpec.stub(:clear_remaining_example_groups)
+          RSpec.stub(:wants_to_quit) { true }
+        end
+
+        it "returns without starting the group" do
+          group = RSpec::Core::ExampleGroup.describe
+          reporter.should_not_receive(:example_group_started)
+          group.run(reporter)
+        end
+
+        context "at top level" do
+          it "purges remaining groups" do
+            group = RSpec::Core::ExampleGroup.describe
+            RSpec.should_receive(:clear_remaining_example_groups)
+            group.run(reporter)
+          end
+        end
+
+        context "in a nested group" do
+          it "does not purge remaining groups" do
+            group = RSpec::Core::ExampleGroup.describe
+            nested_group = group.describe
+            RSpec.should_not_receive(:clear_remaining_example_groups)
+            nested_group.run(reporter)
+          end
+        end
+      end
+
       context "with all examples passing" do
         it "returns true" do
           group = describe("something") do

data/spec/rspec/core/example_spec.rb

@@ -40,6 +40,19 @@ describe RSpec::Core::Example, :parent_metadata => 'sample' do
   end
 
   describe "#run" do
+    context "with RSpec.wants_to_quit=true" do
+      it "returns without starting the example" do
+        RSpec.stub(:wants_to_quit) { true }
+        group = RSpec::Core::ExampleGroup.describe
+        example = group.example('example') {}
+
+        reporter = double('reporter').as_null_object
+        reporter.should_not_receive(:example_started)
+
+        example.run(group.new,reporter)
+      end
+    end
+
     it "runs after(:each) when the example passes" do
       after_run = false
       group = RSpec::Core::ExampleGroup.describe do
@@ -163,11 +176,13 @@ describe RSpec::Core::Example, :parent_metadata => 'sample' do
     end
 
     context "in before(:all)" do
-      it "is not supported" do
+      pending "is not supported" do
         group = RSpec::Core::ExampleGroup.describe do
           before(:all) { pending }
           example {}
         end
+        group.run_all
+        group.examples.first.should be_pending
         expect do
           group.run_all
         end.to raise_error(/undefined method `metadata'/)

data/spec/rspec/core/formatters/base_formatter_spec.rb

@@ -9,6 +9,12 @@ describe RSpec::Core::Formatters::BaseFormatter do
     it "trims current working directory" do
       formatter.__send__(:backtrace_line, File.expand_path(__FILE__)).should == "./spec/rspec/core/formatters/base_formatter_spec.rb"
     end
+
+    it "leaves the original line intact" do
+      original_line = File.expand_path(__FILE__)
+      formatter.__send__(:backtrace_line, original_line)
+      original_line.should eq(File.expand_path(__FILE__))
+    end
   end
 
 end

data/spec/rspec/core/formatters/base_text_formatter_spec.rb

@@ -3,10 +3,10 @@ require "spec_helper"
 module RSpec::Core::Formatters
 
   describe BaseTextFormatter do
-    describe "#summary_line" do
-      let(:output) { StringIO.new }
-      let(:formatter) { RSpec::Core::Formatters::BaseTextFormatter.new(output) }
+    let(:output) { StringIO.new }
+    let(:formatter) { RSpec::Core::Formatters::BaseTextFormatter.new(output) }
 
+    describe "#summary_line" do
       context "with 0s" do
         it "outputs pluralized (excluding pending)" do
           formatter.summary_line(0,0,0).should eq("0 examples, 0 failures")
@@ -27,18 +27,133 @@ module RSpec::Core::Formatters
     end
 
     describe "#dump_failures" do
-      it "preserves formatting" do
-        output = StringIO.new
-        group = RSpec::Core::ExampleGroup.describe("group name")
-        example = group.example("example name") { "this".should eq("that") }
-        formatter = RSpec::Core::Formatters::BaseTextFormatter.new(output)
-        group.run_all(formatter)
+      let(:group) { RSpec::Core::ExampleGroup.describe("group name") }
+
+      before { RSpec.configuration.stub(:color_enabled?) { false } }
 
-        RSpec.configuration.stub(:color_enabled?) { false }
+      def run_all_and_dump_failures
+        group.run_all(formatter)
         formatter.dump_failures
+      end
+
+      it "preserves formatting" do
+        group.example("example name") { "this".should eq("that") }
+
+        run_all_and_dump_failures
+
         output.string.should =~ /group name example name/m
         output.string.should =~ /(\s+)expected \"that\"\n\1     got \"this\"/m
       end
+
+      context 'for #share_examples_for' do
+        it 'outputs the name and location' do
+
+          share_examples_for 'foo bar' do
+            it("example name") { "this".should eq("that") }
+          end
+
+          line = __LINE__.next
+          group.it_should_behave_like('foo bar')
+
+          run_all_and_dump_failures
+
+          output.string.should include(
+            'Shared Example Group: "foo bar" called from ' +
+              "./spec/rspec/core/formatters/base_text_formatter_spec.rb:#{line}"
+          )
+        end
+
+        context 'that contains nested example groups' do
+          it 'outputs the name and location' do
+            share_examples_for 'foo bar' do
+              describe 'nested group' do
+                it("example name") { "this".should eq("that") }
+              end
+            end
+
+            line = __LINE__.next
+            group.it_should_behave_like('foo bar')
+
+            run_all_and_dump_failures
+
+            output.string.should include(
+              'Shared Example Group: "foo bar" called from ' +
+                "./spec/rspec/core/formatters/base_text_formatter_spec.rb:#{line}"
+            )
+          end
+        end
+      end
+
+      context 'for #share_as' do
+        it 'outputs the name and location' do
+
+          share_as :FooBar do
+            it("example name") { "this".should eq("that") }
+          end
+
+          line = __LINE__.next
+          group.send(:include, FooBar)
+
+          run_all_and_dump_failures
+
+          output.string.should include(
+            'Shared Example Group: "FooBar" called from ' +
+              "./spec/rspec/core/formatters/base_text_formatter_spec.rb:#{line}"
+          )
+        end
+
+        context 'that contains nested example groups' do
+          it 'outputs the name and location' do
+
+            share_as :NestedFoo do
+              describe 'nested group' do
+                describe 'hell' do
+                  it("example name") { "this".should eq("that") }
+                end
+              end
+            end
+
+            line = __LINE__.next
+            group.send(:include, NestedFoo)
+
+            run_all_and_dump_failures
+
+            output.string.should include(
+              'Shared Example Group: "NestedFoo" called from ' +
+                "./spec/rspec/core/formatters/base_text_formatter_spec.rb:#{line}"
+            )
+          end
+        end
+      end
+    end
+
+    describe "#dump_profile" do
+      before do
+        formatter.stub(:examples) do
+          group = RSpec::Core::ExampleGroup.describe("group") do
+            example("example")
+          end
+          group.run_all(double('reporter').as_null_object)
+          group.examples
+        end
+      end
+
+      it "names the example" do
+        formatter.dump_profile
+        output.string.should =~ /group example/m
+      end
+
+      it "prints the time" do
+        formatter.dump_profile
+        output.string.should =~ /0\.\d+ seconds/
+      end
+
+      it "prints the path" do
+        formatter.dump_profile
+        filename = __FILE__.split(File::SEPARATOR).last
+
+        output.string.should =~ /#{filename}\:134/
+      end
     end
   end
 end

data/spec/rspec/core/formatters/documentation_formatter_spec.rb

@@ -25,5 +25,41 @@ module RSpec::Core::Formatters
       output.string.should =~ /first example \(FAILED - 1\)/m
       output.string.should =~ /second example \(FAILED - 2\)/m
     end
+
+    it "represents nested group using hierarchy tree" do
+
+      output = StringIO.new
+      RSpec.configuration.stub(:color_enabled?) { false }
+
+      formatter = RSpec::Core::Formatters::DocumentationFormatter.new(output)
+
+      group = RSpec::Core::ExampleGroup.describe("root")
+      context1 = group.describe("context 1")
+      context1.example("nested example 1.1"){}
+      context1.example("nested example 1.2"){}
+
+      context11 = context1.describe("context 1.1")
+      context11.example("nested example 1.1.1"){}
+      context11.example("nested example 1.1.2"){}
+
+      context2 = group.describe("context 2")
+      context2.example("nested example 2.1"){}
+      context2.example("nested example 2.2"){}
+
+      group.run_all(RSpec::Core::Reporter.new(formatter))
+
+      output.string.should eql "
+root
+  context 1
+    nested example 1.1
+    nested example 1.2
+    context 1.1
+      nested example 1.1.1
+      nested example 1.1.2
+  context 2
+    nested example 2.1
+    nested example 2.2
+"
+    end
   end
 end