rspec-armour 0.1.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3cd64c8d03babf2b9a79453d2c6c2eaa62126ad2880135e73c03fe6d6f56e824
-  data.tar.gz: 91a57cfa13c6a701acc53ee7281a9cf64608c4dd4fe87f96d0290d0a575bf8ca
+  metadata.gz: '09dba2766e980d9fb6994b653dead73b873fa386c5d44355403ccda5b5eace45'
+  data.tar.gz: 53f1869be85a9eec42007ca4f4fb46e54dad828aeb1a168d8ccf5974a4e853f6
 SHA512:
-  metadata.gz: c29cbe69ed17b4e69bfbbf62e3e79545e789c04ee8f8ba827cce9bcb91334bcaae3732a86716d37ad8e89de00aa355a6089b1e805a8415b03d0c34ff34742d88
-  data.tar.gz: 21cf05dc106bf0f06ea4ae60f3625f5a6e61c210e037ba0654670e6f89e3a20c471b159e43e5470e9b4820dadea48e3eff8a86cc5fa4086b92c22776ac89c137
+  metadata.gz: 17ad1f31e987f44686609094ccd8b0dfc67dcd9ede6883198bb0a679b25c4a9b5a67c04442ead64d211edf741a0e7ecdae318b2a54d654b569e99cea53ca4b45
+  data.tar.gz: cff695382727e9ba569a49d6f8573ab8bee7de883d676c045b38a0a04506516d0f99444edf36234e121995501f1d535c53eef5dc494ff09103660b9e1aee1d04

data/CHANGELOG.md

@@ -1,4 +1,10 @@
-## [Unreleased]
+## [0.3.0] - 2026-08-03
+
+- Allow `not_to` [#2](https://github.com/hlascelles/rspec-armour/pull/2)
+
+## [0.2.0] - 2026-07-31
+
+- Add expect_receive_and_call_original [#1](https://github.com/hlascelles/rspec-armour/pull/1)
 
 ## [0.1.0] - 2026-06-04
 

data/README.md

@@ -1,16 +1,20 @@
 # rspec-armour
 
-`rspec-armour` protects your ActiveRecord models from being mocked or stubbed in RSpec tests. It forces you to use real database objects (or factories) for your models, leading to more robust and reliable tests.
+`rspec-armour` is the RSpec ActiveRecord MockUp Restrictor. It protects your ActiveRecord models
+from being mocked or stubbed in RSpec tests. It forces you to use real database objects (or
+factories) for your models, leading to more robust and reliable tests.
 
 ## Installation
 
-Add this line to your application's Gemfile:
+Add `rspec-armour` to the **test group** in your application's `Gemfile`:
 
 ```ruby
-gem 'rspec-armour'
+group :test do
+  gem 'rspec-armour'
+end
 ```
 
-And then execute:
+Then run:
 
     $ bundle install
 
@@ -22,11 +26,29 @@ Or install it yourself as:
 
 Once required, `rspec-armour` automatically prevents mocking of ActiveRecord finders, associations, and persistence methods.
 
-### Examples of restricted methods:
+### Examples of restricted methods
+
+| Category                 | Methods                                                                                                        |
+|--------------------------|----------------------------------------------------------------------------------------------------------------|
+| **Class finders**        | `.find`, `.find_by`, `.find_by!`, `.where`, `.all`, `.first`, `.last`, `.count`, `.pluck`, `.pick`, `.exists?` |
+| **Class persistence**    | `.create`, `.create!`, `.update`, `.update!`, `.destroy_all`, `.delete_all`, `.delete_by`, `.destroy_by`       |
+| **Instance persistence** | `#save`, `#save!`, `#update`, `#update!`, `#destroy`, `#destroy!`, `#delete`, `#touch`, `#reload`              |
+| **Associations**         | `has_many`/`belongs_to` reader, writer, and `_ids` helpers (e.g. `user.posts`, `user.posts=`, `user.post_ids`) |
 
-*   **Class methods:** `.find`, `.where`, `.create`, `.update`, etc.
-*   **Instance methods:** `#save`, `#update`, `#destroy`, `#reload`, etc.
-*   **Associations:** `has_many`, `belongs_to`, and their helper methods (e.g., `user.items`, `user.item_ids`).
+### What it looks like in practice
+
+```ruby
+# BAD — rspec-armour raises RSpec::Armour::MockError for these:
+allow(User).to receive(:find).and_return(user)          # class finder
+allow(User).to receive(:where).and_return([user])       # class finder
+allow(user).to receive(:save).and_return(true)          # instance persistence
+allow(user).to receive(:posts).and_return([post])       # association reader
+
+# GOOD — use real database objects instead:
+user = create(:user)          # FactoryBot / fixtures
+post = create(:post, user:)   # real association in the DB
+result = User.where(active: true)  # real query against test DB
+```
 
 ### Disabling restrictions
 
@@ -38,12 +60,18 @@ RSpec::Armour.without_restrictions do
 end
 ```
 
-Or by using RSpec metadata:
+Or by using RSpec metadata on an individual example or context:
 
 ```ruby
 it "does something specific", :without_rspec_armour do
   allow(User).to receive(:where).and_return([])
 end
+
+context "legacy adapter", :without_rspec_armour do
+  it "stubs the finder" do
+    allow(User).to receive(:find).and_return(double)
+  end
+end
 ```
 
 ## Contributing

data/lib/rspec/armour/checker.rb

@@ -21,9 +21,11 @@ module RSpec
       ].freeze
 
       DISABLED_KEY = :rspec_armour_disabled
+      NEGATIVE_EXPECTATION_KEY = :rspec_armour_negative_expectation
 
       def self.restricted?(target, method_name)
         return false if disabled?
+        return false if negative_expectation?
 
         method_sym = method_name.to_sym
         is_class, klass = resolve_target_info(target)
@@ -34,6 +36,18 @@ module RSpec
                             method_sym) || association_method_on_class?(klass, method_sym)
       end
 
+      def self.negative_expectation?
+        Thread.current[NEGATIVE_EXPECTATION_KEY]
+      end
+
+      def self.as_negative_expectation!
+        previous = Thread.current[NEGATIVE_EXPECTATION_KEY]
+        Thread.current[NEGATIVE_EXPECTATION_KEY] = true
+        yield
+      ensure
+        Thread.current[NEGATIVE_EXPECTATION_KEY] = previous
+      end
+
       def self.resolve_target_info(target)
         if test_double?(target)
           resolve_double_info(target)

data/lib/rspec/armour/expect_and_call_original.rb

@@ -0,0 +1,63 @@
+# frozen_string_literal: true
+
+module RSpec
+  module Armour
+    class ExpectationProxy
+      def initialize(expectation, target)
+        @expectation = expectation
+        @target = target
+      end
+
+      def and_call_original(...)
+        @expectation.and_call_original(...)
+        self
+      end
+
+      def and_return(*)
+        cleanup
+        raise MockError, "Cannot call and_return when using expect_receive_and_call_original"
+      end
+
+      def and_raise(*)
+        cleanup
+        raise MockError, "Cannot call and_raise when using expect_receive_and_call_original"
+      end
+
+      def and_throw(*)
+        cleanup
+        raise MockError, "Cannot call and_throw when using expect_receive_and_call_original"
+      end
+
+      def and_yield(*)
+        cleanup
+        raise MockError, "Cannot call and_yield when using expect_receive_and_call_original"
+      end
+
+      def method_missing(name, ...)
+        if @expectation.respond_to?(name)
+          res = @expectation.public_send(name, ...)
+          res.equal?(@expectation) ? self : res
+        else
+          super
+        end
+      end
+
+      def respond_to_missing?(name, include_private = false)
+        @expectation.respond_to?(name, include_private) || super
+      end
+
+      private def cleanup
+        RSpec::Mocks.space.proxy_for(@target).reset if defined?(::RSpec::Mocks)
+      end
+    end
+
+    module ExampleMethods
+      def expect_receive_and_call_original(target, method_name)
+        expectation = RSpec::Armour.without_restrictions do
+          expect(target).to receive(method_name).and_call_original
+        end
+        ExpectationProxy.new(expectation, target)
+      end
+    end
+  end
+end

data/lib/rspec/armour/receive_patch.rb

@@ -5,6 +5,12 @@ module RSpec
     module Matchers
       # This class is patched to prevent mocking ActiveRecord associations and finders.
       class Receive
+        NEGATIVE_EXPECTATION_METHODS = %i[
+          setup_negative_expectation
+          setup_any_instance_negative_expectation
+          does_not_match?
+        ].freeze
+
         def self.patch_for_armour!
           # rubocop:disable ThreadSafety/ClassInstanceVariable
           @armour_patched ||= false
@@ -31,16 +37,23 @@ module RSpec
 
         def self.patch_method(method)
           original_method = instance_method(method)
+          negative = NEGATIVE_EXPECTATION_METHODS.include?(method)
           define_method(method) do |subject, &block|
             if ENV["RSPEC_ARMOUR_DEBUG"] == "true"
               puts "Checking RSpec::Armour '#{@message}' on #{subject}"
             end
-            if RSpec::Armour::Checker.restricted?(subject, @message)
-              message = "Mocking/stubbing ActiveRecord association or finder `#{@message}` " \
-                        "on `#{subject.inspect}` is restricted by rspec-armour."
-              raise RSpec::Armour::MockError, message
+            if negative
+              RSpec::Armour::Checker.as_negative_expectation! do
+                original_method.bind_call(self, subject, &block)
+              end
+            else
+              if RSpec::Armour::Checker.restricted?(subject, @message)
+                message = "Mocking/stubbing ActiveRecord association or finder `#{@message}` " \
+                          "on `#{subject.inspect}` is restricted by rspec-armour."
+                raise RSpec::Armour::MockError, message
+              end
+              original_method.bind_call(self, subject, &block)
             end
-            original_method.bind_call(self, subject, &block)
           end
         end
       end

data/lib/rspec/armour/version.rb

@@ -2,6 +2,6 @@
 
 module RSpec
   module Armour
-    VERSION = "0.1.0"
+    VERSION = "0.3.0"
   end
 end

data/lib/rspec/armour.rb

@@ -5,6 +5,7 @@ require "rspec/mocks"
 require_relative "armour/version"
 require_relative "armour/checker"
 require_relative "armour/receive_patch"
+require_relative "armour/expect_and_call_original"
 
 module RSpec
   module Armour
@@ -22,6 +23,8 @@ require "rspec/mocks/matchers/receive"
 RSpec::Mocks::Matchers::Receive.patch_for_armour!
 
 RSpec.configure do |config|
+  config.include RSpec::Armour::ExampleMethods
+
   config.around(:each, without_rspec_armour: true) do |example|
     RSpec::Armour.without_restrictions do
       example.run

data/quality.sh

@@ -7,5 +7,3 @@ echo "Running fasterer..."
 bundle exec fasterer
 echo "Running rubocop..."
 bundle exec rubocop
-echo "Running reek..."
-bundle exec reek

data/rspec-armor/Gemfile

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+source "https://rubygems.org"
+
+gemspec
+
+gem "rake", "~> 13.0"

data/rspec-armor/Gemfile.lock

@@ -0,0 +1,92 @@
+PATH
+  remote: .
+  specs:
+    rspec-armor (0.1.0)
+      rspec-armour
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    activemodel (8.1.3)
+      activesupport (= 8.1.3)
+    activerecord (8.1.3)
+      activemodel (= 8.1.3)
+      activesupport (= 8.1.3)
+      timeout (>= 0.4.0)
+    activesupport (8.1.3)
+      base64
+      bigdecimal
+      concurrent-ruby (~> 1.0, >= 1.3.1)
+      connection_pool (>= 2.2.5)
+      drb
+      i18n (>= 1.6, < 2)
+      json
+      logger (>= 1.4.2)
+      minitest (>= 5.1)
+      securerandom (>= 0.3)
+      tzinfo (~> 2.0, >= 2.0.5)
+      uri (>= 0.13.1)
+    base64 (0.3.0)
+    bigdecimal (4.1.2)
+    concurrent-ruby (1.3.7)
+    connection_pool (3.0.2)
+    diff-lcs (1.6.2)
+    drb (2.2.3)
+    i18n (1.15.2)
+      concurrent-ruby (~> 1.0)
+    json (2.21.1)
+    logger (1.7.0)
+    minitest (6.0.6)
+      drb (~> 2.0)
+      prism (~> 1.5)
+    prism (1.9.0)
+    rake (13.4.2)
+    rspec-armour (0.1.0)
+      activerecord
+      rspec-mocks
+    rspec-mocks (3.13.8)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.13.0)
+    rspec-support (3.13.7)
+    securerandom (0.4.1)
+    timeout (0.6.1)
+    tzinfo (2.0.6)
+      concurrent-ruby (~> 1.0)
+    uri (1.1.1)
+
+PLATFORMS
+  ruby
+  x86_64-linux
+
+DEPENDENCIES
+  rake (~> 13.0)
+  rspec-armor!
+
+CHECKSUMS
+  activemodel (8.1.3) sha256=90c05cbe4cef3649b8f79f13016191ea94c4525ce4a5c0fb7ef909c4b91c8219
+  activerecord (8.1.3) sha256=8003be7b2466ba0a2a670e603eeb0a61dd66058fccecfc49901e775260ac70ab
+  activesupport (8.1.3) sha256=21a5e0dfbd4c3ddd9e1317ec6a4d782fa226e7867dc70b0743acda81a1dca20e
+  base64 (0.3.0) sha256=27337aeabad6ffae05c265c450490628ef3ebd4b67be58257393227588f5a97b
+  bigdecimal (4.1.2) sha256=53d217666027eab4280346fba98e7d5b66baaae1b9c3c1c0ffe89d48188a3fbd
+  bundler (4.0.12) sha256=7f8b757d28dfb636e7b24fba2344ac6dd13b5b24f4b46d62573d483f211825ac
+  concurrent-ruby (1.3.7) sha256=4412caec3a5ea2e5fdc52076724c071a81f2c0593d83b2ac8cbb8ca63b3151b0
+  connection_pool (3.0.2) sha256=33fff5ba71a12d2aa26cb72b1db8bba2a1a01823559fb01d29eb74c286e62e0a
+  diff-lcs (1.6.2) sha256=9ae0d2cba7d4df3075fe8cd8602a8604993efc0dfa934cff568969efb1909962
+  drb (2.2.3) sha256=0b00d6fdb50995fe4a45dea13663493c841112e4068656854646f418fda13373
+  i18n (1.15.2) sha256=00f9eb62412fe593b2a65a97daa75300d37abb8f7202ec748e94b6d46a9dd1b5
+  json (2.21.1) sha256=13a43df75d95641443f5702dff350f237164a9d811ff0f2c2800d4d980220583
+  logger (1.7.0) sha256=196edec7cc44b66cfb40f9755ce11b392f21f7967696af15d274dde7edff0203
+  minitest (6.0.6) sha256=153ea36d1d987a62942382b61075745042a2b3123b1cd48f4c3675af9cc7d6f1
+  prism (1.9.0) sha256=7b530c6a9f92c24300014919c9dcbc055bf4cdf51ec30aed099b06cd6674ef85
+  rake (13.4.2) sha256=cb825b2bd5f1f8e91ca37bddb4b9aaf345551b4731da62949be002fa89283701
+  rspec-armor (0.1.0)
+  rspec-armour (0.1.0) sha256=d03542ac9a6a9d61be9ca2be6f0a550ae19c2f56d2a40b65769cdcbd8cb3a31f
+  rspec-mocks (3.13.8) sha256=086ad3d3d17533f4237643de0b5c42f04b66348c28bf6b9c2d3f4a3b01af1d47
+  rspec-support (3.13.7) sha256=0640e5570872aafefd79867901deeeeb40b0c9875a36b983d85f54fb7381c47c
+  securerandom (0.4.1) sha256=cc5193d414a4341b6e225f0cb4446aceca8e50d5e1888743fac16987638ea0b1
+  timeout (0.6.1) sha256=78f57368a7e7bbadec56971f78a3f5ecbcfb59b7fcbb0a3ed6ddc08a5094accb
+  tzinfo (2.0.6) sha256=8daf828cc77bcf7d63b0e3bdb6caa47e2272dcfaf4fbfe46f8c3a9df087a829b
+  uri (1.1.1) sha256=379fa58d27ffb1387eaada68c749d1426738bd0f654d812fcc07e7568f5c57c6
+
+BUNDLED WITH
+  4.0.12

data/rspec-armor/Rakefile

@@ -0,0 +1,3 @@
+# frozen_string_literal: true
+
+require "bundler/gem_tasks"

data/rspec-armor/rspec-armor.gemspec

@@ -0,0 +1,26 @@
+# frozen_string_literal: true
+
+Gem::Specification.new do |spec|
+  spec.name = "rspec-armor"
+  spec.version = "0.1.0"
+  spec.authors = ["Harry Lascelles"]
+  spec.email = ["harry@harryl.com"]
+
+  spec.summary = "American-spelling alias for rspec-armour. Please use rspec-armour instead."
+  spec.description = <<~MSG
+    This gem exists solely to prevent typo-squatting on the American spelling of rspec-armour.
+    It installs rspec-armour (British spelling) and does nothing else.
+    Please depend on rspec-armour directly.
+  MSG
+  spec.homepage = "https://github.com/hlascelles/rspec-armour"
+  spec.license = "MIT"
+  spec.required_ruby_version = ">= 3.2.0"
+  spec.metadata["allowed_push_host"] = "https://rubygems.org"
+  spec.metadata["homepage_uri"] = spec.homepage
+  spec.metadata["source_code_uri"] = spec.homepage
+  spec.metadata["rubygems_mfa_required"] = "true"
+
+  spec.files = ["rspec-armor.gemspec"]
+
+  spec.add_dependency "rspec-armour"
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rspec-armour
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Harry Lascelles
@@ -151,9 +151,14 @@ files:
 - Rakefile
 - lib/rspec/armour.rb
 - lib/rspec/armour/checker.rb
+- lib/rspec/armour/expect_and_call_original.rb
 - lib/rspec/armour/receive_patch.rb
 - lib/rspec/armour/version.rb
 - quality.sh
+- rspec-armor/Gemfile
+- rspec-armor/Gemfile.lock
+- rspec-armor/Rakefile
+- rspec-armor/rspec-armor.gemspec
 homepage: https://github.com/hlascelles/rspec-armour
 licenses:
 - MIT