rspec-api 0.5.0 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9ca5599e96ba26d321698c09c88a338919c4bf8a
-  data.tar.gz: ae0a49475f6343996a3eb2313ecba068e20db34b
+  metadata.gz: b5d13d986f0266551e0dc9cb65d55825b7963cbd
+  data.tar.gz: 5020ab2bc422a5c256b9008e2028209f10f7637a
 SHA512:
-  metadata.gz: c26cdc3ffe743a93ee67be9567a2fcbf70810f54381c866b971626cd4a5961828fcfb56e0dceddeeea3e5a0b5ab08119a8aefb787262f7df3c9bc0aa8aacf4f1
-  data.tar.gz: 26b169c8bbaa0d2e9893b764bcfadcf9a187942a312dc6ca2fb17cb41391b4d153c1f65e94d74063a77a32b8249fe476619874b4f8b665c939a45337af8c4f95
+  metadata.gz: 7db05e3f65bbd82848de2ee0fbfa62be001f535c1e52857ff003baaa91e4d4808f5801898de4539cdba97ef7384b6883aaf3a62e00d477fad7eeead28943ebb9
+  data.tar.gz: 8ed56a2947fd64ec56b1f47795a6d057d1e54ab1f5e66236faa3b87eab736bf67a7c469c63eaa8dc16655f023b774d20d6e61f145ae894799574557cc3499f48

data/README.md

@@ -94,6 +94,7 @@ And you should see all the successful promises matched by the GitHub API:
     Finished in 1 minute 19.74 seconds
     1237 examples, 1 failure, 4 pending
 
+
 How to contribute
 =================
 

data/lib/rspec-api.rb

@@ -1 +1 @@
-require 'rspec-api/dsl'
+require 'rspec-api/resource'

data/lib/rspec-api/resource.rb

@@ -0,0 +1,50 @@
+require 'rspec/core'
+require 'active_support/inflector'
+require 'rspec-api/resource/actions'
+require 'rspec-api/resource/options'
+require 'rspec-api/resource/has_attribute'
+require 'rspec-api/resource/accepts'
+
+module RSpecApi
+  # Provides actions and expectations method to RSpec Example groups, useful to
+  # describe the endpoints and expectations of a web API resource.
+  #
+  # To have these matchers available inside of an RSpec `describe` block,
+  # include that block inside a block with the `:rspec_api` metadata, or
+  # explicitly include the RSpecApi::Resource module.
+  #
+  # @example Tag a `describe` block as `:rspec_api`:
+  #   describe "Artists", rspec_api: true do
+  #     ... # here you can write `get`, `has_attribute`, `host`, etc.
+  #   end
+  #
+  # @example Explicitly include the RSpecApi::Resource module
+  #   describe "Artists" do
+  #     include RSpecApi::Resource
+  #     ... # here you can write `get`, `has_attribute`, `host`, etc.
+  #   end
+  module Resource
+    include Actions
+    include Options
+    include HasAttribute
+    include Accepts
+  end
+end
+RSpec.configuration.extend RSpecApi::Resource, rspec_api: true
+
+# You can also have the methods available in a RSpec Example group using
+# `resource`. This is the only method that RSpecApi adds to the top-level
+# namespace and it's equivalent to a `describe` block with RSpecApi::Resource:
+#
+# @example Describe the resource artist:
+#
+#  resource :artist do
+#     ... # here you can write `get`, `has_attribute`, `host`, etc.
+#  end
+def resource(name, args = {}, &block)
+  describe name.to_s.pluralize.humanize, args do
+    extend RSpecApi::Resource
+    rspec_api_resource[:resource_name] = name
+    instance_exec &block
+  end
+end

data/lib/rspec-api/resource/accepts.rb

@@ -0,0 +1,70 @@
+require 'rspec-api/resource/options'
+
+module RSpecApi
+  module Resource
+    module Accepts
+      def accepts(options = {})
+        add_request_for accepts_sort(options) if options.key? :sort
+        add_request_for accepts_filter(options) if options.key? :filter
+        add_request_for accepts_page(options) if options.key? :page
+        add_request_for accepts_callback(options) if options.key? :callback
+      end
+
+    private
+
+      def add_request_for(opts = {})
+        (rspec_api_resource[:extra_requests] ||= []) << opts
+      end
+
+      def accepts_sort(opts = {})
+        {params: sort_params(opts), expect: sort_expect(opts)}
+      end
+
+      def sort_params(opts = {})
+        {sort: opts[:sort]}.merge(opts.fetch :sort_if, {})
+      end
+
+      def sort_expect(opts = {})
+        {sort: opts.slice(:by, :verse)}
+      end
+
+      def accepts_filter(opts = {})
+        {params: filter_params(opts), expect: filter_expect(opts)}
+      end
+
+      def filter_params(opts = {})
+        {}.tap{|params| params[opts[:filter]] = opts[:value]}
+      end
+
+      def filter_expect(opts = {})
+        {filter: opts.slice(:by, :compare_with, :value)}
+      end
+
+      def accepts_page(opts = {})
+        {params: page_params(opts), expect: page_expect(opts)}
+      end
+
+      def page_params(opts = {})
+        {}.tap{|params| params[opts[:page]] = 2}
+      end
+
+      def page_expect(opts = {})
+        {page_links: true}
+      end
+
+      def accepts_callback(opts = {})
+        # NOTE: This is the only accepts that affects *all* the requests,
+        #       not just the ones that return a collection
+        {params: callback_params(opts), expect: callback_expect(opts), all: true}
+      end
+
+      def callback_params(opts = {})
+        {}.tap{|params| params[opts[:callback]] = 'anyCallback'}
+      end
+
+      def callback_expect(opts = {})
+        {callback: 'anyCallback'}
+      end
+    end
+  end
+end

data/lib/rspec-api/resource/actions.rb

@@ -0,0 +1,40 @@
+require 'rspec-api/requests'
+require 'rspec-api/resource/options'
+
+module RSpecApi
+  module Resource
+    module Actions
+      [:get, :put, :patch, :post, :delete].each do |action|
+        define_method action do |route, rspec_api_options = {}, &block|
+          options = rspec_api_options.merge route: route, action: action
+          options = rspec_api_resource.merge options
+          describe description_for(options), rspec_api_params: options do
+            extend RSpecApi::Requests
+            instance_eval &block if block
+          end
+        end
+      end
+
+    private
+
+      def description_for(params = {})
+        action, name, plural = params.values_at(:action, :resource_name, :collection)
+        [verb_for(action), object_for(name.to_s, plural)].compact.join ' '
+      end
+
+      def verb_for(action)
+        case action
+          when :get then 'Getting'
+          when :put then 'Editing'
+          when :patch then 'Editing'
+          when :post then 'Creating'
+          when :delete then 'Deleting'
+        end
+      end
+
+      def object_for(name, plural)
+        plural ? "a list of #{name.pluralize}" : "one #{name}"
+      end
+    end
+  end
+end

data/lib/rspec-api/resource/has_attribute.rb

@@ -0,0 +1,29 @@
+require 'active_support/core_ext/object/blank'
+require 'rspec-api/resource/options'
+
+module RSpecApi
+  module Resource
+    module HasAttribute
+      def has_attribute(name, options, &block)
+        if block_given?
+          options[:type] = Hash[options[:type], {}]
+          nest_attributes options[:type], &Proc.new
+        end
+        if @attribute_ancestors.present?
+          hash = @attribute_ancestors.last
+          hash.each{|type, _| (hash[type] ||= {})[name] = options}
+        else
+          (rspec_api_resource[:attributes] ||= {})[name] = options
+        end
+      end
+
+    private
+
+      def nest_attributes(hash, &block)
+        (@attribute_ancestors ||= []).push hash
+        yield
+        @attribute_ancestors.pop
+      end
+    end
+  end
+end

data/lib/rspec-api/resource/options.rb

@@ -0,0 +1,27 @@
+module RSpecApi
+  module Resource
+    module Options
+      def adapter(*args)
+        rspec_api_resource[:adapter] = args
+      end
+
+      def host(host)
+        rspec_api_resource[:host] = host
+      end
+
+      def throttle(seconds_to_sleep)
+        rspec_api_resource[:throttle] = seconds_to_sleep
+      end
+
+      def authorize_with(auth_params = {})
+        rspec_api_resource[:authorize_with] = auth_params
+      end
+
+    private
+
+      def rspec_api_resource
+        (metadata[:rspec_api_resource] ||= {})
+      end
+    end
+  end
+end

data/lib/rspec-api/version.rb

@@ -1,3 +1,3 @@
 module RspecApi
-  VERSION = '0.5.0'
+  VERSION = '0.7.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rspec-api
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.7.0
 platform: ruby
 authors:
 - claudiob
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-11-09 00:00:00.000000000 Z
+date: 2013-11-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -25,33 +25,47 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rspec-api-matchers
+  name: rspec-api-requests
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 0.5.0
+        version: 0.7.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 0.5.0
+        version: 0.7.0
 - !ruby/object:Gem::Dependency
   name: rspec-api-expectations
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 0.5.0
+        version: 0.7.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 0.5.0
+        version: 0.7.0
+- !ruby/object:Gem::Dependency
+  name: rspec-api-matchers
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 0.7.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 0.7.0
 - !ruby/object:Gem::Dependency
   name: rack
   requirement: !ruby/object:Gem::Requirement
@@ -87,7 +101,7 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
-  type: :runtime
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
@@ -271,18 +285,11 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- lib/rspec-api/dsl/accepts.rb
-- lib/rspec-api/dsl/actions.rb
-- lib/rspec-api/dsl/attributes.rb
-- lib/rspec-api/dsl/requests.rb
-- lib/rspec-api/dsl/responses.rb
-- lib/rspec-api/dsl.rb
-- lib/rspec-api/fixtures/empty.rb
-- lib/rspec-api/fixtures/local.rb
-- lib/rspec-api/fixtures/remote.rb
-- lib/rspec-api/http_clients/empty.rb
-- lib/rspec-api/http_clients/local.rb
-- lib/rspec-api/http_clients/remote.rb
+- lib/rspec-api/resource/accepts.rb
+- lib/rspec-api/resource/actions.rb
+- lib/rspec-api/resource/has_attribute.rb
+- lib/rspec-api/resource/options.rb
+- lib/rspec-api/resource.rb
 - lib/rspec-api/version.rb
 - lib/rspec-api.rb
 - MIT-LICENSE

data/lib/rspec-api/dsl.rb

@@ -1,45 +0,0 @@
-require 'rspec-api/dsl/accepts'
-require 'rspec-api/dsl/actions'
-require 'rspec-api/dsl/attributes'
-
-module RSpecApi
-  module DSL
-    include Accepts
-    include Actions
-    include Attributes
-    include Fixtures
-  end
-end
-
-# RSpecApi provides methods to test RESTful APIs.
-#
-# To have these methods available in your RSpec ExampleGroups you have to
-# tag the `describe` block with the `:rspec_api` metadata.
-#
-#  describe "Artists", rspec_api: true do
-#     ... # here you can use `get`, `delete`, etc.
-#  end
-RSpec.configuration.extend RSpecApi::DSL, rspec_api: true
-
-# Alternatively, you replace `describe` with `resource`, for the same result:
-#
-#
-#  resource :artist do
-#     ... # same as before, here you can use `get`, `delete`, etc.
-#  end
-#
-#
-# `resource` is indeed the only top-level namespace RSpecApi method.
-def resource(name, args = {}, &block)
-  args.merge! rspec_api: true
-  resources = (@resources ||= [])
-  resource = describe name.to_s.pluralize.humanize, args do
-    @resource = name
-    @resources = resources
-    @expectations = []
-    @expectations << {query_params: {}, status_expect: {status: 200}, body_expect: {attributes: {name: {type: :string}, website: {type: [:null, string: :url]}}}}
-    @attributes = {}
-    instance_exec &block
-  end
-  @resources << resource
-end

data/lib/rspec-api/dsl/accepts.rb

@@ -1,46 +0,0 @@
-module RSpecApi
-  module DSL
-    module Accepts
-
-      def accepts_page(page_parameter)
-        any_page = 2
-        @expectations << {
-          query_params: {}.tap{|qp| qp[page_parameter] = any_page},
-          status_expect: {status: 200},
-          headers_expect: {has_prev_page: true}
-        }
-      end
-
-      def accepts_sort(sort_parameter, options={})
-        @expectations << {
-          query_params: {sort: sort_parameter}.merge(options.fetch(:sort_if, {})),
-          before: create_fixture,
-          after: destroy_fixture,
-          status_expect: {status: 200},
-          body_expect: {sort: options.slice(:by, :verse)}
-        }
-      end
-
-      def accepts_callback(callback_parameter)
-        any_callback = 'a_callback'
-        @expectations << {
-          query_params: {}.tap{|qp| qp[callback_parameter] = any_callback},
-          status_expect: {status: 200},
-          body_expect: {callback: any_callback}
-        }
-      end
-
-      def accepts_filter(filter_parameter, options={})
-        value = existing(options[:by])
-        @expectations << {
-          query_params: {}.tap{|qp| qp[filter_parameter] = value},
-          before: create_fixture,
-          after: destroy_fixture,
-          status_expect: {status: 200},
-          body_expect: {filter: options.slice(:by, :comparing_with).merge(value: value)}
-        }
-      end
-    end
-  end
-end
-

data/lib/rspec-api/dsl/actions.rb

@@ -1,36 +0,0 @@
-require 'rspec-api/dsl/requests'
-
-module RSpecApi
-  module DSL
-    module Actions
-      include RSpecApi::DSL::Fixtures
-      include RSpecApi::DSL::Requests
-
-      def self.define_action(action)
-        define_method action do |route, options = {}, &block|
-          expectations = @expectations
-          attributes = @attributes
-          authorization = @authorization
-          resource = @resource
-          collection = options[:collection]
-          describe "#{action.upcase} #{route}" do
-            @action = action
-            @route = route
-            @expectations = expectations
-            @attributes = attributes
-            @authorization = authorization
-            @collection = collection
-            @resource = resource
-            instance_eval &block
-          end
-        end
-      end
-
-      define_action :get
-      define_action :put
-      define_action :patch
-      define_action :post
-      define_action :delete
-    end
-  end
-end

data/lib/rspec-api/dsl/attributes.rb

@@ -1,13 +0,0 @@
-module RSpecApi
-  module DSL
-    module Attributes
-      def has_attribute(name, options = {}, &block)
-        @attributes[name] = options
-      end
-
-      def attributes_of(resource)
-        @resources.find{|r| r.description == resource.to_s.pluralize.humanize}.instance_variable_get '@attributes'
-      end
-    end
-  end
-end

data/lib/rspec-api/dsl/requests.rb

@@ -1,78 +0,0 @@
-require 'rspec-api/dsl/responses'
-
-module RSpecApi
-  module DSL
-    module Requests
-      def my_collection_request(query_params = {}, &block)
-        @expectations.each do |options|
-          single_request(options.deep_merge(body_expect: {collection: true}, query_params: query_params), &block)
-        end
-      end
-
-      def respond_with(*args) # NOT THE TRUE ONE
-        request_with do
-          respond_with(*args)
-        end
-      end
-
-      def request_with(query_params = {}, &block)
-        if @collection
-          my_collection_request(query_params, &block)
-        else
-          single_request(query_params: query_params, &block)
-        end
-      end
-
-      def single_request(options = {}, &block)
-        query_params = options.fetch(:query_params, {})
-        status_expect = options.fetch(:status_expect, {status: 200})
-        headers_expect = options.fetch(:headers_expect, {type: :json})
-        body_expect = options.fetch(:body_expect, {collection: false}) # Or maybe nothing
-        body_expect = body_expect.merge(attributes: @attributes) if @attributes
-        before_fun = options.fetch(:before, -> {})
-        after_fun = options.fetch(:after, -> {})
-        query = {authorization: @authorization, route_params: {}, action: @action, route: @route, query_params: query_params, status_expect: status_expect, headers_expect: headers_expect, body_expect: body_expect, before: before_fun, after: after_fun}
-
-        query_params.each do |k, v|
-          if v.is_a?(Hash) && v[:proc] && v[:value] # so we avoid getting the hash of the callback called :proc
-            query[:query_params][k] = v[:value]
-            if v[:proc] == :existing
-              query = query.merge before: create_fixture, after: destroy_fixture
-            end
-          end
-        end
-
-        my_real_request(query, &block)
-      end
-
-      def my_real_request(query = {}, &block)
-        query[:before].call
-
-        query.fetch(:query_params, {}).each do |k, v|
-          query[:query_params][k] = v.is_a?(Proc) ? v.call : v
-          if query[:route].match "/:#{k}"
-            query[:route] = query[:route].gsub "/:#{k}", "/#{query[:query_params][k]}"
-            query[:route_params][k] = query[:query_params].delete k
-          end
-        end
-
-        describe "with #{query[:route].is_a?(Proc) ? query[:route].call : query[:route]}#{" and #{query[:query_params]}" if query[:query_params].any?}" do
-          extend RSpecApi::DSL::Responses
-          extend RSpecApi::DSL::HttpClient
-          send_request query[:action], (query[:route].is_a?(Proc) ? query[:route].call : query[:route]), query[:query_params], query[:authorization]
-          @response = last_response
-          @status_expect = query.fetch :status_expect, {}
-          @headers_expect = query.fetch :headers_expect, {}
-          @body_expect = query.fetch :body_expect, {}
-          @route_params = query.fetch :route_params, {}
-          if @body_expect.fetch(:filter, {})[:value].is_a?(Hash) && @body_expect.fetch(:filter, {})[:value][:proc]
-            @body_expect[:filter][:value] = @body_expect[:filter][:value][:value].call
-          end
-          instance_exec &block
-        end
-
-        query[:after].call
-      end
-    end
-  end
-end

data/lib/rspec-api/dsl/responses.rb

@@ -1,37 +0,0 @@
-require 'rspec-api/expectations'
-
-module RSpecApi
-  module DSL
-    module Responses
-      include RSpecApi::Expectations::Resourceful
-
-      def respond_with(*args, &block)
-        if args.first.is_a?(Hash)
-          more_status_expect = args.first
-          more_headers_expect = {}
-          more_body_expect = {}
-        elsif args.first.is_a?(Array)
-          more_status_expect, more_headers_expect, more_body_expect = args
-        else
-          more_status_expect = {status: args.first}
-          more_headers_expect = {}
-          more_body_expect = {}
-        end
-
-        all_expectations = @status_expect.merge(more_status_expect).merge(
-        @headers_expect).merge(more_headers_expect).merge(@body_expect).
-        merge(more_body_expect)
-
-        expect_resourceful(@response, all_expectations)
-        expect_custom(@response, @route_params, &block) if block_given?
-      end
-
-      def expect_custom(response, route_params, &block)
-        context 'matches custom expectations' do
-          # THE ONLY MISSING THING:
-          it { instance_exec response, route_params, &block }
-        end
-      end
-    end
-  end
-end

data/lib/rspec-api/fixtures/empty.rb

@@ -1,35 +0,0 @@
-module RSpecApi
-  module DSL
-    module Fixtures # rename to Fixtures
-      def existing(field)
-        # To be overriden
-      end
-
-      def unknown(field)
-        # To be overriden
-      end
-
-      def apply(method_name, options = {})
-        options[:to].merge(apply: method_name, value: -> { options[:to][:value].call.send method_name })
-      end
-
-      def valid(options = {})
-        # TODO: Here change the description
-        options
-      end
-
-      def invalid(options = {})
-        # TODO: Here change the description
-        options
-      end
-
-      def create_fixture
-        # To be overriden
-      end
-
-      def destroy_fixture
-        # To be overriden
-      end
-    end
-  end
-end

data/lib/rspec-api/fixtures/local.rb

@@ -1,50 +0,0 @@
-module RSpecApi
-  module DSL
-    module Fixtures # rename to Fixtures
-      def existing(field)
-        {field: field, proc: :existing, value: existing_value_for(field)}
-      end
-
-      def unknown(field)
-        {field: field, proc: :unknown, value: missing_value_for(field)}
-      end
-
-      def apply(method_name, options = {})
-        options[:to].merge(apply: method_name, value: -> { options[:to][:value].call.send method_name })
-      end
-
-      def valid(options = {})
-        # TODO: Here change the description
-        options
-      end
-
-      def invalid(options = {})
-        # TODO: Here change the description
-        options
-      end
-
-      def create_fixture
-        # TODO: Random values from attributes
-        -> {
-          model = @resource.to_s.classify.constantize
-          case @resource
-          when :artist then model.create! name: 'Madonna', website: 'http://www.example.com'
-          when :concert then model.create! where: 'Coachella', year: 2010
-          end
-        }
-      end
-
-      def destroy_fixture
-        -> {@resource.to_s.classify.constantize.destroy_all}
-      end
-
-      def existing_value_for(field)
-        -> {@resource.to_s.classify.constantize.pluck(field).first}
-      end
-      
-      def missing_value_for(field)
-        -> {-1}
-      end
-    end
-  end
-end

data/lib/rspec-api/fixtures/remote.rb

@@ -1,82 +0,0 @@
-module RSpecApi
-  module DSL
-    module Fixtures # rename to Fixtures
-      def existing(field)
-        {field: field, proc: :existing, value: existing_value_for(field)}
-      end
-
-      def unknown(field)
-        {field: field, proc: :unknown, value: missing_value_for(field)}
-      end
-
-      def apply(method_name, options = {})
-        options[:to].merge(apply: method_name, value: -> { options[:to][:value].call.send method_name })
-      end
-
-      def valid(options = {})
-        # TODO: Here change the description
-        options
-      end
-
-      def invalid(options = {})
-        # TODO: Here change the description
-        options
-      end
-
-      def create_fixture
-        # TODO: Nothing for now
-        -> { }
-      end
-
-      def destroy_fixture
-        # TODO: Nothing for now
-        -> { }
-      end
-
-      def existing_value_for(field)
-        value = case field
-        when :org then 'rspec-api'
-        when :user, :owner, :assignee then 'rspecapi'
-        when :repo then 'guinea-pig' # has heads, tails, pull, notes
-        when :gist_id then '7175672'
-        when :gist_comment_id then '937901'
-
-        when :blob_sha then 'f32932f7c927d86f57f56d703ac2ed100ceb0e47'
-        when :commit_sha then 'c98a37ea3b2759d0c43fb8abfa9abd3146938790'
-        when :tree_sha then 'ebca91692290192f50acc307af9fe26b2eab4274'
-        when :ref then 'heads/master'
-        when :starred_repo then 'rspec-expectations' # make it different from :repo
-        when :unstarred_repo then 'rspec-core'  # make it different from :repo
-        when :starred_gist_id then 'e202e2fb143c54e5139a'
-        when :unstarred_gist_id then '8f2ef7e69ab79084d833'
-        when :someone_elses_gist_id then '4685e0bebbf05370abd6'
-        when :thread_id then '17915960'
-        when :id then '921225'
-        # NOTE: The following are confusing: they are used for filters, not value
-        # For instance, it's not that we must have an object with the following
-        # updated_at, we just use it for the since filter
-        when :updated_at then '2013-10-31T09:53:00Z' # TODO use helpers
-        # NOTE: Here's the confusion: :unread is used for the :all filter, but
-        # it has the reverse meaning: ?all=false will only show unread='true'
-        when :unread then 'false' # TODO use helpers
-        # NOTE: Here's more confusion: :reason is a string, but this is used for
-        # the boolean parameter participating:
-        # ?participating=true (default), only show reason = 'mention' or 'author'
-        # ?participating=false, show all reasons
-        when :reason then 'true' # TODO use helpers
-        end
-        -> { value }
-      end
-
-      def missing_value_for(field)
-        value = case field
-        when :user, :assignee then 'not-a-valid-user'
-        when :gist_id then 'not-a-valid-gist-id'
-        when :id then 'not-a-valid-id'
-        when :repo then 'not-a-valid-repo'
-        end
-        -> { value }
-      end
-    end
-  end
-end

data/lib/rspec-api/http_clients/empty.rb

@@ -1,14 +0,0 @@
-module RSpecApi
-  module DSL
-    module HttpClient
-      def send_request(verb, route, body, authorization)
-        # To be overriden
-      end
-
-      def last_response
-        # To be overriden. status MUST be a number, headers MUST be a hash
-        OpenStruct.new status: nil, headers: {} # body: nil,
-      end
-    end
-  end
-end

data/lib/rspec-api/http_clients/local.rb

@@ -1,28 +0,0 @@
-require File.expand_path("../../../../spec/dummy/config/environment.rb",  __FILE__)
-require 'rspec/rails'
-require 'rack/test'
-
-def app
-  Rails.application
-end
-
-module RSpecApi
-  module DSL
-    module HttpClient
-      include Rack::Test::Methods
-
-      def ciao
-
-      end
-
-      def send_request(verb, route, body, authorization)
-        header 'Accept', 'application/json'
-        send verb, route, body
-      end
-
-      def response
-        last_response
-      end
-    end
-  end
-end

data/lib/rspec-api/http_clients/remote.rb

@@ -1,40 +0,0 @@
-require 'faraday'
-require 'faraday_middleware' # TODO: use autoload, we only need EncodeJson
-require 'faraday-http-cache'
-require 'logger'
-
-module Authorize
-  def authorize_with(options = {})
-    @authorization = options
-  end
-end
-
-module RSpecApi
-  module DSL
-    module HttpClient
-      def send_request(verb, route, body, authorization)
-        logger = Logger.new 'log/faraday.log'
-
-        conn = Faraday.new 'https://api.github.com/' do |c| # TODO: Pass host as a parameter
-          # NOTE: The order is **important**! Leave HttpCache first
-          c.use Faraday::HttpCache, serializer: Marshal, store: :file_store, store_options: ['/tmp/faraday'], logger: logger
-          c.use FaradayMiddleware::EncodeJson # query params are not JSON(body) but data are
-          c.use Faraday::Response::Logger, logger
-          c.use Faraday::Adapter::NetHttp
-        end
-
-        conn.headers[:user_agent] = 'RSpec API'
-        conn.authorization *authorization.flatten
-        sleep 0.5 # TODO: Pass as a parameter
-
-        @last_response = conn.send verb, route, body do |request|
-          @last_request = request
-        end
-      end
-
-      def last_response
-        @last_response
-      end
-    end
-  end
-end