rspec-activejob 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5ec1b26448aaa3732cc1239e94ed67be18fdd034
-  data.tar.gz: 53d956546e042ad727cc3d02094c5fb9851c24ff
+  metadata.gz: 6ed4f20a431ed47d9bac346276c28f5c66143cf5
+  data.tar.gz: 2ac30436e51224415b3a083acbfb008eeaf7a1c8
 SHA512:
-  metadata.gz: 7dbbdb3029c97cb2c71fe0b57d112fece98190849934e26e861e01cb4f2f9a427921fa541cba527589f341f06a1a5629a7a5afd9fddceb7f59d06ec56fabfddf
-  data.tar.gz: ded3be79382e60bf7fa9c590da4f34a0732ff660c51236cba33153aae22da379b3144bcd7a8cf8b4f4193dc24b47e35fca75a920bde1eebdaae8396719a61ee2
+  metadata.gz: 41552e56407232b5f260b1b8459725916a86b3b5411938bf87a23074f84f62bf58c011195952fac04dad56519bbe3970c06d98bd7c01c7ad9a8ad92135b870f5
+  data.tar.gz: f057e07d01d62994ec8d586f56af964075bafe140c95c3843a29913eb79d46b01f37f2cfd90b984641f133a106042625cc02ba09e806ff42c0a894062bdb7cd9

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+## 0.3.0 - Unreleased
+
+- Added the `deserialize_as` matcher
+
+## 0.2.0 - January 21, 2015
+
+- Added the `global_id` matcher
+
 ## 0.1.0 - January 18, 2015
 
 - Added support for argument matchers (e.g. `instance_of`, `hash_including`), like the `receive` matcher.

data/Gemfile.lock

@@ -1,17 +1,17 @@
 PATH
   remote: .
   specs:
-    rspec-activejob (0.2.0)
+    rspec-activejob (0.3.0)
       activejob (>= 4.2)
       rspec-mocks
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activejob (4.2.0)
-      activesupport (= 4.2.0)
+    activejob (4.2.1)
+      activesupport (= 4.2.1)
       globalid (>= 0.3.0)
-    activesupport (4.2.0)
+    activesupport (4.2.1)
       i18n (~> 0.7)
       json (~> 1.7, >= 1.7.7)
       minitest (~> 5.1)
@@ -19,7 +19,7 @@ GEM
       tzinfo (~> 1.1)
     coderay (1.1.0)
     diff-lcs (1.2.5)
-    globalid (0.3.0)
+    globalid (0.3.3)
       activesupport (>= 4.1.0)
     i18n (0.7.0)
     json (1.8.2)
@@ -29,23 +29,24 @@ GEM
       coderay (~> 1.1.0)
       method_source (~> 0.8.1)
       slop (~> 3.4)
-    rspec (3.1.0)
-      rspec-core (~> 3.1.0)
-      rspec-expectations (~> 3.1.0)
-      rspec-mocks (~> 3.1.0)
-    rspec-core (3.1.7)
-      rspec-support (~> 3.1.0)
-    rspec-expectations (3.1.2)
+    rspec (3.2.0)
+      rspec-core (~> 3.2.0)
+      rspec-expectations (~> 3.2.0)
+      rspec-mocks (~> 3.2.0)
+    rspec-core (3.2.2)
+      rspec-support (~> 3.2.0)
+    rspec-expectations (3.2.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.1.0)
-    rspec-its (1.1.0)
+      rspec-support (~> 3.2.0)
+    rspec-its (1.2.0)
       rspec-core (>= 3.0.0)
       rspec-expectations (>= 3.0.0)
-    rspec-mocks (3.1.3)
-      rspec-support (~> 3.1.0)
-    rspec-support (3.1.2)
+    rspec-mocks (3.2.1)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.2.0)
+    rspec-support (3.2.2)
     slop (3.6.0)
-    thread_safe (0.3.4)
+    thread_safe (0.3.5)
     tzinfo (1.2.2)
       thread_safe (~> 0.1)
 
@@ -53,6 +54,7 @@ PLATFORMS
   ruby
 
 DEPENDENCIES
+  activesupport
   pry
   rspec
   rspec-activejob!

data/README.md

@@ -5,6 +5,8 @@
 config.active_job.queue_adapter = :test
 
 # spec/spec_helper.rb
+require 'rspec/active_job'
+
 RSpec.configure do |config|
   config.include(RSpec::ActiveJob)
 
@@ -27,10 +29,10 @@ end
 
 rspec-activejob expects the current queue adapter to expose an array of `enqueued_jobs`, like the included
 test adapter. The test adapter included in ActiveJob 4.2.0 does not fully serialize its arguments, so you
-will not need to use the GlobalID matcher until ActiveJob 4.2.1. See rails/rails#18266 for the improved
-test adapter.
+will not need to use the GlobalID matcher unless you're using ActiveJob 4.2.1. See rails/rails#18266 for 
+the improved test adapter.
 
-This gem defines two matchers:
+This gem defines three matchers:
 
 * `enqueue_a`: for a block or proc, expects that to enqueue an job to the ActiveJob test adapter. Optionally
   takes the job class as its argument, and can be modified with a `.with(*args)` call to expect specific arguments.
@@ -41,6 +43,8 @@ This gem defines two matchers:
   the serialized version of any instance of that model; if you pass an instance, it will expect the serialized
   version of that specific instance.
 
+* `deserialize_as(hash)`: an argument matcher, matching ActiveJob-serialized versions of hashes (with
+  string/symbol keys, or with indifferent access).
 
 With the `global_id` matcher it's important to note that it's specific to ActiveJob-serialized GlobalIDs.
 ActiveJob serializes them as a hash like `{ '_aj_global_id' => 'gid://my-app/MyModel/ID123' }`, to avoid

data/lib/rspec/active_job.rb

@@ -1,5 +1,6 @@
 require 'rspec/active_job/enqueue_a'
 require 'rspec/active_job/global_id'
+require 'rspec/active_job/deserialize_as'
 
 module RSpec
   module ActiveJob
@@ -10,5 +11,9 @@ module RSpec
     def global_id(expected)
       Matchers::GlobalID.new(expected)
     end
+
+    def deserialize_as(expected)
+      Matchers::DeserializeAs.new(expected)
+    end
   end
 end

data/lib/rspec/active_job/deserialize_as.rb

@@ -0,0 +1,29 @@
+require 'active_job/arguments'
+require 'active_support/core_ext/hash/indifferent_access'
+
+module RSpec
+  module ActiveJob
+    module Matchers
+      class DeserializeAs
+        def initialize(expected)
+          @expected = expected
+        end
+
+        def ===(other)
+          deserialize(other).class == @expected.class &&
+            deserialize(other) == @expected
+        end
+
+        def description
+          "an object deserializing to #{@expected}"
+        end
+
+        private
+
+        def deserialize(argument)
+          ::ActiveJob::Arguments.deserialize([argument]).first
+        end
+      end
+    end
+  end
+end

data/lib/rspec/active_job/version.rb

@@ -1,5 +1,5 @@
 module RSpec
   module ActiveJob
-    VERSION = '0.2.0'.freeze
+    VERSION = '0.3.0'.freeze
   end
 end

data/rspec-activejob.gemspec

@@ -9,7 +9,8 @@ Gem::Specification.new do |s|
   s.summary = 'RSpec matchers to test ActiveJob'
   s.description = <<-EOL
     RSpec matchers for ActiveJob:
-    * expect { method }.to enqueue_a(MyJob).with('some', 'arguments')
+    * expect { method }.to enqueue_a(MyJob).with(global_id(some_model),
+                                                 deserialize_as(other_argument))
   EOL
   s.homepage = 'http://github.com/gocardless/rspec-activejob'
   s.license = 'MIT'
@@ -23,4 +24,5 @@ Gem::Specification.new do |s|
 
   s.add_development_dependency('rspec')
   s.add_development_dependency('rspec-its')
+  s.add_development_dependency('activesupport')
 end

data/spec/rspec/active_job/deserialize_as_spec.rb

@@ -0,0 +1,59 @@
+require 'spec_helper'
+
+RSpec.describe RSpec::ActiveJob::Matchers::DeserializeAs do
+  let(:instance) { described_class.new(expected) }
+  subject(:matches?) { instance === actual }
+
+  context "with an indifferent hash" do
+    let(:actual) do
+      { 'key' => 'value', '_aj_hash_with_indifferent_access' => true }
+    end
+    let(:expected) { ActiveSupport::HashWithIndifferentAccess.new(key: 'value') }
+
+    it { is_expected.to be(true) }
+
+    context "with a non-indifferent hash serialized" do
+      let(:actual) { { 'key' => 'value', '_aj_symbol_keys' => [] } }
+
+      it { is_expected.to be(false) }
+    end
+  end
+
+  context "with a string-keyed hash" do
+    let(:expected) { { 'key' => 'value' } }
+    let(:actual) { { 'key' => 'value', '_aj_symbol_keys' => [] } }
+
+    it { is_expected.to be(true) }
+
+    context "with an indifferent hash serialized" do
+      let(:actual) do
+        { 'key' => 'value', '_aj_hash_with_indifferent_access' => true }
+      end
+      it { is_expected.to be(false) }
+    end
+
+    context "with a symbol keyed hash serialized" do
+      let(:actual) { { 'key' => 'value', '_aj_symbol_keys' => ['key'] } }
+      it { is_expected.to be(false) }
+    end
+  end
+
+  context "with a symbol-keyed hash" do
+    let(:expected) { { key: 'value' } }
+    let(:actual) { { 'key' => 'value', '_aj_symbol_keys' => ['key'] } }
+
+    it { is_expected.to be(true) }
+
+    context "with an indifferent hash serialized" do
+      let(:actual) do
+        { 'key' => 'value', '_aj_hash_with_indifferent_access' => true }
+      end
+      it { is_expected.to be(false) }
+    end
+
+    context "with a string keyed hash serialized" do
+      let(:actual) { { 'key' => 'value', '_aj_symbol_keys' => [] } }
+      it { is_expected.to be(false) }
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rspec-activejob
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Isaac Seymour
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-20 00:00:00.000000000 Z
+date: 2015-03-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activejob
@@ -66,9 +66,24 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: activesupport
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: |2
       RSpec matchers for ActiveJob:
-      * expect { method }.to enqueue_a(MyJob).with('some', 'arguments')
+      * expect { method }.to enqueue_a(MyJob).with(global_id(some_model),
+                                                   deserialize_as(other_argument))
 email:
 - isaac@isaacseymour.co.uk
 executables: []
@@ -82,10 +97,12 @@ files:
 - Gemfile.lock
 - README.md
 - lib/rspec/active_job.rb
+- lib/rspec/active_job/deserialize_as.rb
 - lib/rspec/active_job/enqueue_a.rb
 - lib/rspec/active_job/global_id.rb
 - lib/rspec/active_job/version.rb
 - rspec-activejob.gemspec
+- spec/rspec/active_job/deserialize_as_spec.rb
 - spec/rspec/active_job/enqueue_a_spec.rb
 - spec/rspec/active_job/global_id_spec.rb
 - spec/spec_helper.rb