rspec-abq 1.0.2 → 1.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 47cb306f3ccae9028f66868c94bad15520483ba37a240b91a15c95799c004eea
-  data.tar.gz: 9f9b96ff40ddb02f1d545e4c8f0032b436f099c90e8fc2dc779df79b11e7e8c3
+  metadata.gz: 32d3a96e24adf90ae8f04464daccb1458833022b7888eb9f0eb13d4f735cd186
+  data.tar.gz: 5aa909ff347fb5522a8716028bfc5f187355792e60392143c22bfa097017f4b3
 SHA512:
-  metadata.gz: 5600f59bdb6bf10da3676b3333218d06138df69fd98c6b46b4f63cd6582d7ba41b41513482697279b49844799db3efede34156836f5a30f276f1d1021ec70642
-  data.tar.gz: fbe86282d566d1db465018261ce241aa2a24c70109fd0878cb33a70814d89f1898c7255cd0ed71e6e83eb6d9fdb6eeceb8d8652a64bc2a841cf44155506080fb
+  metadata.gz: 31765589e5cebda9567807ed17bcafa96be05d285b8d757e9611a5a77230a6a60ed5163dae008cfbc4a2d9228218639b7999181b2e67d11dfde6848b1791d604
+  data.tar.gz: 9a983dec557fb2f606bf68480b817cc4e75b3d5e318f9c0ed8af56bbaa1362e11706a27d7107788fd45fd1f9808b47f394ee3813132018916295946ec1595edb

data/README.md

@@ -16,7 +16,7 @@ end
 
 And then execute:
 
-```
+```bash
 bundle
 ```
 
@@ -24,10 +24,16 @@ bundle
 
 Use the included binary with abq:
 
-```
+```bash
 abq test -- bundle exec rspec
 ```
 
+If abq displays "Worker quit before sending protocol version", try adding this line to your application's `spec/spec_helper.rb`:
+
+```ruby
+require 'rspec/abq'
+```
+
 ## Compatibility
 
 This gem is actively tested against rubies 2.6-3.1 and rspecs 3.5-3.12

data/lib/rspec/abq/extensions.rb

@@ -106,14 +106,21 @@ module RSpec
       module Runner
         # Runs the provided example groups.
         #
-        # @param example_groups [Array<RSpec::Core::ExampleGroup>] groups to run
+        # @param _example_groups [Array<RSpec::Core::ExampleGroup>] groups to run.
+        #   Ignored in favor of @world.ordered_example_groups
         # @return [Fixnum] exit status code. 0 if all specs passed,
         #   or the configured failure exit code (1 by default) if specs
         #   failed.
-        def run_specs(example_groups)
+        def run_specs(_example_groups)
           should_quit = RSpec::Abq.setup_after_specs_loaded!
           return 0 if should_quit
 
+          # rspec-abq pulls the ordering from the init-message. Here we ensure the example groups are in the same ordering.
+          # RSpec passes to `run_specs` exactly the world ordered example groups:
+          #   https://github.com/rspec/rspec-core/blob/522b7727d02d9648c090b56fa68bbdc18a21c04d/lib/rspec/core/runner.rb#L85-L92
+          # So this definition is safe.
+          example_groups = @world.ordered_example_groups
+
           examples_count = @world.example_count(example_groups)
           examples_passed = @configuration.reporter.report(examples_count) do |reporter|
             @configuration.with_suite_hooks do

data/lib/rspec/abq/version.rb

@@ -1,6 +1,6 @@
 module RSpec
   module Abq
     # current version!
-    VERSION = "1.0.2"
+    VERSION = "1.0.4"
   end
 end

data/lib/rspec/abq.rb

@@ -41,7 +41,12 @@ module RSpec
     NATIVE_RUNNER_SPECIFICATION = {
       type: "abq_native_runner_specification",
       name: "rspec-abq",
-      version: RSpec::Abq::VERSION
+      version: RSpec::Abq::VERSION,
+      test_framework: "rspec",
+      test_framework_version: RSpec::Core::Version::STRING,
+      language: RUBY_ENGINE,
+      language_version: "#{RUBY_VERSION}p#{RUBY_PATCHLEVEL}",
+      host: RUBY_DESCRIPTION
     }
 
     # The [rpsec-abq spawned message](https://www.notion.so/rwx/ABQ-Worker-Native-Test-Runner-IPC-Interface-0959f5a9144741d798ac122566a3d887#8587ee4fd01e41ec880dcbe212562172).
@@ -101,14 +106,6 @@ module RSpec
       # before abq can start workers, it asks for a manifest
       if !!ENV[ABQ_GENERATE_MANIFEST] # the abq worker will set this env var if it needs a manifest
         RSpec::Abq::Manifest.write_manifest(RSpec.world.ordered_example_groups, RSpec.configuration.seed, RSpec.configuration.ordering_registry)
-        # ... Maybe it's fine to just exit(0)
-        if Gem::Version.new(RSpec::Core::Version::STRING) >= Gem::Version.new("3.10.0")
-          RSpec.world.wants_to_quit = true # ask rspec to exit
-          RSpec.configuration.error_exit_code = 0
-          RSpec.world.non_example_failure = true # exit has nothing to do with tests
-        else
-          exit(0)
-        end
         return true
       end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rspec-abq
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.4
 platform: ruby
 authors:
 - Ayaz Hafiz
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 1980-01-01 00:00:00.000000000 Z
+date: 2022-12-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec-core
@@ -89,7 +89,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.26
+rubygems_version: 3.3.7
 signing_key:
 specification_version: 4
 summary: RSpec::Abq allows for parallel rspec runs using abq