rspec-abq 1.0.0 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c8480f9deacbbe6a9a52019f2a2493e66c9f952a5fce0af85ef1fe942118eb2e
-  data.tar.gz: c3f02272646ac9624c07221cd98e2264d9057caa4138309ada3df3f4913bd75a
+  metadata.gz: 47cb306f3ccae9028f66868c94bad15520483ba37a240b91a15c95799c004eea
+  data.tar.gz: 9f9b96ff40ddb02f1d545e4c8f0032b436f099c90e8fc2dc779df79b11e7e8c3
 SHA512:
-  metadata.gz: c682346cef98977257270d64cdf94705d5d5519665d2b0e8c37769597b58a01c918748dd50975a59200f54df42d82f575a680be1961afec5b2d9ee0f67677d00
-  data.tar.gz: 48f99ff65d5451e08d21e202f10a91dc3efc9cf93c40a0bf52839fd8802e7100f72d30f16feabd82c3d0341b64373b8215089966959698e8d17a7d1dea22d1d7
+  metadata.gz: 5600f59bdb6bf10da3676b3333218d06138df69fd98c6b46b4f63cd6582d7ba41b41513482697279b49844799db3efede34156836f5a30f276f1d1021ec70642
+  data.tar.gz: fbe86282d566d1db465018261ce241aa2a24c70109fd0878cb33a70814d89f1898c7255cd0ed71e6e83eb6d9fdb6eeceb8d8652a64bc2a841cf44155506080fb

data/lib/rspec/abq/extensions.rb

@@ -125,7 +125,16 @@ module RSpec
             end
           end
 
-          exit_code(examples_passed)
+          if Abq.target_test_case != Abq::TestCase.end_marker
+            warn "Hit end of test run without being on end marker. Target test case is #{Abq.target_test_case.inspect}"
+            example_passed = false
+          end
+
+          if Gem::Version.new(RSpec::Core::Version::STRING) >= Gem::Version.new("3.10.0")
+            exit_code(examples_passed)
+          else
+            example_passed ? 0 : @configuration.failure_exit_code
+          end
         end
 
         private

data/lib/rspec/abq/test_case.rb

@@ -37,7 +37,7 @@ module RSpec
       # @param outer [Array<String>] parsed scope
       # @param inner [Array<String>] parsed scope
       def self.scope_leftover(outer, inner)
-        inner[outer.length..-1] || []
+        inner[outer.length..] || []
       end
 
       # @param group [RSpec::Core::ExampleGroup]

data/lib/rspec/abq/version.rb

@@ -1,6 +1,6 @@
 module RSpec
   module Abq
     # current version!
-    VERSION = "1.0.0"
+    VERSION = "1.0.2"
   end
 end

data/lib/rspec/abq.rb

@@ -29,14 +29,30 @@ module RSpec
     ABQ_RSPEC_PID = "ABQ_RSPEC_PID"
 
     # The [ABQ protocol version message](https://www.notion.so/rwx/ABQ-Worker-Native-Test-Runner-IPC-Interface-0959f5a9144741d798ac122566a3d887#8587ee4fd01e41ec880dcbe212562172).
-    # Must be sent to ABQ_SOCKET on startup.
     # @!visibility private
-    PROTOCOL_VERSION_MESSAGE = {
+    PROTOCOL_VERSION = {
       type: "abq_protocol_version",
       major: 0,
       minor: 1
     }
 
+    # The [rspec-abq specification](https://www.notion.so/rwx/ABQ-Worker-Native-Test-Runner-IPC-Interface-0959f5a9144741d798ac122566a3d887#8587ee4fd01e41ec880dcbe212562172).
+    # @!visibility private
+    NATIVE_RUNNER_SPECIFICATION = {
+      type: "abq_native_runner_specification",
+      name: "rspec-abq",
+      version: RSpec::Abq::VERSION
+    }
+
+    # The [rpsec-abq spawned message](https://www.notion.so/rwx/ABQ-Worker-Native-Test-Runner-IPC-Interface-0959f5a9144741d798ac122566a3d887#8587ee4fd01e41ec880dcbe212562172).
+    # Must be sent to ABQ_SOCKET on startup.
+    # @!visibility private
+    NATIVE_RUNNER_SPAWNED_MESSAGE = {
+      type: "abq_native_runner_spawned",
+      protocol_version: PROTOCOL_VERSION,
+      runner_specification: NATIVE_RUNNER_SPECIFICATION
+    }
+
     # The [ABQ initialization success
     # message](https://www.notion.so/rwx/ABQ-Worker-Native-Test-Runner-IPC-Interface-0959f5a9144741d798ac122566a3d887#538582a3049f4934a5cb563d815c1247)
     # Must be sent after receiving the ABQ initialization message.
@@ -113,10 +129,10 @@ module RSpec
       init_message = protocol_read
       protocol_write(INIT_SUCCESS_MESSAGE)
       # TODO: delete the check for empty init_meta when https://github.com/rwx-research/abq/pull/216 is merged
-      unless init_message["fast_exit"]
-        Ordering.setup!(init_message["init_meta"], RSpec.configuration)
-        fetch_next_example
-      end
+      return true if init_message["fast_exit"]
+
+      Ordering.setup!(init_message["init_meta"], RSpec.configuration)
+      fetch_next_example
       nil
     end
 
@@ -124,7 +140,10 @@ module RSpec
     # @!visibility private
     def self.socket
       @socket ||= TCPSocket.new(*ENV[ABQ_SOCKET].split(":")).tap do |socket|
-        protocol_write(PROTOCOL_VERSION_MESSAGE, socket)
+        # Messages sent to/received from the ABQ worker should be done so ASAP.
+        # Since we're on a local network, we don't care about packet reduction here.
+        socket.setsockopt(Socket::IPPROTO_TCP, Socket::TCP_NODELAY, 1)
+        protocol_write(NATIVE_RUNNER_SPAWNED_MESSAGE, socket)
       end
     end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rspec-abq
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.2
 platform: ruby
 authors:
 - Ayaz Hafiz
@@ -31,6 +31,20 @@ dependencies:
     - - "<"
       - !ruby/object:Gem::Version
         version: 3.13.0
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.14.1
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.14.1
 description: RSpec::Abq is an rspec plugin that replaces its ordering with one that
   is controlled by abq. It allows for parallelization of rspec on a single machine
   or across multiple workers.