rsmp_schema 0.8.8 → 0.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c39b6ab3cc486788feee182e2a9ba6332f01ba1597c5218fdc84f0f4f94fdb7e
-  data.tar.gz: daa378692c4caa3fdb08364a6aa109932d8eb1a06ec8be358342ccf781415f56
+  metadata.gz: 86686f176a4c15c90f569c0d60dbeafb56a27c2fe0d06f379791f2314bf1884f
+  data.tar.gz: 5e33a0a3e94483f5fe496168b3de4c704e8ea566f32f217cce4db15829b654c6
 SHA512:
-  metadata.gz: 2e7be3449e7693476a04de6308f7c74b02bd541e3d5cab3ba9fb9a1c8c58b3a48f554e3dafc84405ea41bdefdd9b2d7864a4d8fccc4c73887ead041fc5b0add4
-  data.tar.gz: 541cb7f75d8169442c6c081f56f679e81e66916be07b0d6c77729d08f7bb3d3141db20f1993b2952f90e4815a6f67bf2ae463351d1c3cf23a09280d369f3e81a
+  metadata.gz: 0d579d39429c9b4025794282e3fa45958f05849971b80745c089ca0fb8f79fe35909a1d800e1a6b92ff9aa4976c862e548197cb574b484ff0db5d9d1ed3b4b36
+  data.tar.gz: cb0d7767006fd9aac1ad8d6092df01a33bc089a46eef9d05be21433a0de437034de18cb63a9960bec94c11319735ac7beaf1b16b1841b5ad1c0f71cfa77629b7

data/.devcontainer/devcontainer.json

@@ -0,0 +1,22 @@
+// For format details, see https://aka.ms/devcontainer.json. For config options, see the
+// README at: https://github.com/devcontainers/templates/tree/main/src/ruby
+{
+	"name": "Ruby",
+	// Or use a Dockerfile or Docker Compose file. More info: https://containers.dev/guide/dockerfile
+	"image": "mcr.microsoft.com/devcontainers/ruby:1-3.4-bullseye",
+
+	// Features to add to the dev container. More info: https://containers.dev/features.
+	// "features": {},
+
+	// Use 'forwardPorts' to make a list of ports inside the container available locally.
+	// "forwardPorts": [],
+
+	// Use 'postCreateCommand' to run commands after the container is created.
+	   "postCreateCommand": "bundle install"
+
+	// Configure tool-specific properties.
+	// "customizations": {},
+
+	// Uncomment to connect as root instead. More info: https://aka.ms/dev-containers-non-root.
+	// "remoteUser": "root"
+}

data/.github/copilot-instructions.md

@@ -0,0 +1,196 @@
+# RSMP Schema Ruby Gem
+
+RSMP Schema is a Ruby gem that provides JSON Schema validation for RSMP (Road Side Message Protocol) messages. The schema covers both the core RSMP specification and SXL (Signal Exchange List) for Traffic Light Controllers.
+
+Always reference these instructions first, and fall back to search or bash commands only when you encounter unexpected information that does not match the info here.
+
+## Environment Setup
+
+Bootstrap, build, and test the repository using mise:
+
+```bash
+# Install mise (if not already installed), follow instructions at https://mise.jdx.dev/
+curl https://mise.run | sh
+
+# Install the Ruby version specified in .tool-versions
+mise install
+
+# Install all dependencies.
+# The bundler gem is included by default in the Ruby installation and does not have to be installed first.
+bundle install
+```
+
+## Running Tests
+
+The test suite includes comprehensive RSpec tests covering:
+- Core RSMP message validation
+- Traffic Light Controller SXL validation
+
+
+Run the complete test suite:
+```bash
+# Test command takes approximately 2 seconds
+bundle exec rspec
+```
+
+All tests should pass on a clean repository.
+
+## CLI Tool Usage
+
+The gem provides a CLI tool for converting YAML SXL files to JSON Schema:
+
+```bash
+# Show available commands
+bundle exec exe/rsmp_schema --help
+
+# Convert YAML SXL to JSON Schema
+bundle exec exe/rsmp_schema convert -i <input.yaml> -o <output_directory>
+
+# Example: Convert TLC SXL
+bundle exec exe/rsmp_schema convert -i schemas/tlc/1.2.1/sxl.yaml -o tmp/sxl_1.2.1_schema
+```
+
+## Schema Regeneration
+
+Regenerate all TLC JSON schemas from their YAML sources:
+
+```bash
+# Regenerates all schemas in schemas/tlc/*/sxl.yaml
+bundle exec rake regenerate
+```
+
+**WARNING**: This destructively overwrites all JSON schema files in schemas/tlc/. Core schemas are not affected as they are hand-maintained.
+
+This rake task and the 'convert' CLI command use the same Ruby code to convert YAML to JSON schema files.
+
+
+## Example code
+The file examples/validate.rb shows how to use the gem to validate RSMP messages.
+
+Before committing changes, in addition to checking that all RSpec tests pass, also check that the examples/validate.rb script works and outputs the expected result:
+
+```bash
+# Test validation with corrected example script
+bundle exec ruby examples/validate.rb
+```
+
+Expected output: `ok` (indicates successful validation)
+
+## Repository Structure
+
+Key directories and files:
+- `lib/rsmp_schema/` - Main gem code
+- `lib/rsmp_schema/cli.rb` - CLI tool implementation  
+- `lib/rsmp_schema/convert/` - YAML to JSON Schema conversion
+- `exe/rsmp_schema` - Executable CLI wrapper
+- `spec/` - RSpec test files
+- `schemas/core/` - Hand-maintained core RSMP schemas
+- `schemas/tlc/` - Generated Traffic Light Controller schemas
+- `examples/validate.rb` - Example validation code
+- `Rakefile` - Contains regenerate task
+- `.github/workflows/rspec.yaml` - CI pipeline
+
+## Common File Locations
+
+### Schema Files
+- Core schemas: `schemas/core/<version>/rsmp.json`
+- TLC SXL schemas: `schemas/tlc/<version>/rsmp.json`
+- TLC SXL YAML sources: `schemas/tlc/<version>/sxl.yaml`
+
+### Code Files
+- Main entry: `lib/rsmp_schema.rb`
+- CLI: `lib/rsmp_schema/cli.rb`
+
+### Test Files
+- Core tests: `spec/core/`
+- TLC tests: `spec/tlc/`
+- Helper: `spec/schemer_helper.rb`
+
+## CI Pipeline Validation
+
+The repository uses GitHub Actions with the following requirements:
+- Runs on Ubuntu, macOS, and Windows
+- Tests with different Ruby versions
+- 5-minute timeout for all tests
+- Must pass `bundle exec rspec -f d`
+
+Before committing changes, ensure:
+- Schemas are regenerated if any SXL YAML sources were modified
+- All tests pass: `bundle exec rspec`
+- Ruby syntax is valid for modified files
+
+## Validation Scenarios
+
+After making changes, always test these scenarios:
+
+1. **Schema regeneration**: Run `bundle exec rake regenerate` and verify no unexpected changes.
+2. **Test suite**: Run `bundle exec rspec` and ensure all tests pass.
+3. **Example code**: Ensure the examples in examples/ work correctly.
+4. **CLI functionality**: Test the convert command with actual files.
+5. **No unrelated changes**: No unrelated changes or files should be included in the commit.
+ 
+Example validation workflow:
+
+```bash
+# Ensure we're in root of the repo folder
+cd /path/to/repo
+
+# Regenerate schema files if SXL YAML sources were modified
+# And check that no unexpected changes were introduced
+bundle exec rake regenerate
+git status -- schemas/
+
+# Run test suite
+bundle exec rspec
+
+# Check example code
+bundle exec ruby examples/validate.rb
+
+# Check CLI functionality
+# And check that output contains expected files
+bundle exec exe/rsmp_schema convert -i schemas/tlc/1.2.1/sxl.yaml -o tmp/sxl_1.2.1_schema
+ls -la tmp/sxl_1.2.1_schema  # Should show rsmp.json, alarms/, commands/, statuses/
+
+# Check that no unrelated changes or files were introduced
+git status
+```
+
+
+
+## Dependencies and Versions
+
+See `rsmp_schema.gemspec` for current runtime and development dependencies.
+
+Requires the Ruby version specified in .tool-versions.
+
+## Common Issues and Solutions
+
+**Ruby version or environment issues**:
+- Use mise for automatic Ruby management: `mise install`
+
+**Permission errors during bundle install**:
+- Use mise which handles permissions automatically
+
+**Missing bundler command**:
+- Run `mise install` first, bundler should be available automatically
+
+**JSON Schema validation errors**:
+- Check that schema paths use `schemas/` not `schema/` (common typo in examples)
+- Ensure you're using `bundle exec ruby` for scripts that require gems
+
+**Test failures**:
+- Run `bundle exec rspec` not just `rspec`
+- Ensure you've run `bundle install` first
+- Check Ruby version compatibility (see .tool-versions)
+
+## Timing Expectations
+
+- **NEVER CANCEL**: Bundle install takes 10-15 seconds normally - wait for completion
+- **NEVER CANCEL**: Test suite takes 2 seconds - use 30+ second timeout  
+- **NEVER CANCEL**: Schema regeneration takes 0.75 seconds - very fast but allow buffer
+- Initial gem setup may take up to 60 seconds total including bundler installation
+
+Set timeouts generously:
+- Bundle operations: 60+ seconds
+- Test operations: 30+ seconds  
+- CLI operations: 30+ seconds

data/.gitignore

@@ -1,6 +1,8 @@
 /.bundle/
+/vendor/bundle/
 /pkg/
 /spec/reports/
 /tmp/
 /.DS_Store
 /.rspec_status
+/vendor/bundle/

data/.tool-versions

@@ -1 +1 @@
-ruby 3.3.2
+ruby 3.4

data/Gemfile.lock

@@ -1,15 +1,15 @@
 PATH
   remote: .
   specs:
-    rsmp_schema (0.8.8)
+    rsmp_schema (0.9.0)
       json_schemer (~> 2.3.0)
       thor (~> 1.3.1)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    bigdecimal (3.1.8)
-    diff-lcs (1.5.1)
+    bigdecimal (3.2.3)
+    diff-lcs (1.6.2)
     hana (1.3.7)
     json_schemer (2.3.0)
       bigdecimal
@@ -17,26 +17,22 @@ GEM
       regexp_parser (~> 2.0)
       simpleidn (~> 0.2)
     rake (13.2.1)
-    regexp_parser (2.8.2)
-    rspec (3.13.0)
+    regexp_parser (2.11.3)
+    rspec (3.13.1)
       rspec-core (~> 3.13.0)
       rspec-expectations (~> 3.13.0)
       rspec-mocks (~> 3.13.0)
-    rspec-core (3.13.0)
+    rspec-core (3.13.5)
       rspec-support (~> 3.13.0)
-    rspec-expectations (3.13.0)
+    rspec-expectations (3.13.5)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.13.0)
-    rspec-mocks (3.13.1)
+    rspec-mocks (3.13.5)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.13.0)
-    rspec-support (3.13.1)
-    simpleidn (0.2.1)
-      unf (~> 0.1.4)
-    thor (1.3.1)
-    unf (0.1.4)
-      unf_ext
-    unf_ext (0.0.9.1)
+    rspec-support (3.13.6)
+    simpleidn (0.2.3)
+    thor (1.3.2)
 
 PLATFORMS
   ruby
@@ -48,4 +44,4 @@ DEPENDENCIES
   rspec-expectations (~> 3.13.0)
 
 BUNDLED WITH
-   2.5.11
+   2.7.2

data/examples/validate.rb

@@ -1,4 +1,4 @@
-require 'json_schemer'
+require 'rsmp_schema'
 
 message = {
   "mType" => "rSMsg",
@@ -18,15 +18,13 @@ message = {
   ]
 }
 
-# try validating a message against our schema
-schema = Pathname.new('schema/tlc/1.2.1/rsmp.json')
-schemer = JSONSchemer.schema(schema)
-if schemer.valid? message
+# load schemas
+RSMP::Schema.setup
+
+# validating a message against core and tlc schemas 
+result = RSMP::Schema.validate( message, core: "3.2.1", tlc: "1.2.1" )
+if result == nil
   puts 'ok'
 else
-  schemer.validate(message).each do |item|
-    puts [item['data_pointer'],item['type'],item['details']].compact.join(' ')
-  end
+  puts "failed: #{result.inspect}"
 end
-
-

data/lib/rsmp_schema/convert/export/json_schema.rb

@@ -61,7 +61,7 @@ module RSMP
             "items" => {
               "type" => "object",
               "required" => required,
-              "additionalProperties": false
+              "unevaluatedProperties" => false  # Modern alternative to additionalProperties
             }
           })
           out["items"]["properties"] = {}
@@ -71,16 +71,10 @@ module RSMP
           out
         end
 
-        # with draft-07 and older, using a $ref mean all other properties are ignored.
-        # to avoid this we need to use an allOf.
-        # this is changed from draft-08, but unfortunately, there is still no Ruby validator for that
+        # JSON Schema 2020-12 allows combining $ref with other properties directly
         def self.wrap_refs out
-          if out.keys.include? '$ref'
-            ref = out.delete '$ref'
-            { "allOf" => [out,{"$ref"=>ref}]}
-          else
-            out
-          end
+          # No wrapping needed with modern JSON Schema
+          out
         end
 
         # convert a yaml item with list: true to json schema
@@ -138,37 +132,53 @@ module RSMP
         def self.build_item item, property_key: 'v'
           unless item['arguments']
             json = {
+              "$schema" => "https://json-schema.org/draft/2020-12/schema",
               "description" => item['description'],
             }
             return json
           end
 
-          json = {
-            "description" => item['description'],
-            "allOf" => [
-              {
-               "properties" => { "n" => { "enum" => item['arguments'].keys.sort }},
-              },
+          arguments = item['arguments']
+
+          # For statuses (property_key == 's'), generate a single top-level gate:
+          # if q is undefined/unknown -> no constraints; else -> per-n branches.
+          if property_key == 's'
+            branches = arguments.map do |key, argument|
               {
-                "if" =>
-                {
-                  "required" => ["q"],
-                  "properties" => { "q"=> { "enum" => ["undefined","unknown"] }},
-                },
-                "then" => {},
-                "else" => {
-                  "allOf" => item['arguments'].map do |key,argument|
-                    {
-                      "if" => { "required" => ["n"], "properties" => { "n" => { "const" => key }}},
-                      "then" => { "properties" => { property_key => build_value(argument) }}
-                    }
-                  end
-                }
+                "if" => { "properties" => { "n" => { "const" => key } } },
+                "then" => { "properties" => { property_key => build_value(argument) } }
               }
-            ]
-          }
+            end
+
+            return {
+              "$schema" => "https://json-schema.org/draft/2020-12/schema",
+              "description" => item['description'],
+              "properties" => {
+                "n" => { "enum" => arguments.keys.sort }
+              },
+              # reference shared guard (relative from statuses folder to tlc/defs)
+              "if" => { "$ref" => "../../defs/guards.json#/$defs/q_unknown_or_undefined" },
+              "then" => {},
+              "else" => { "allOf" => branches }
+            }
+          end
+
+          # Default behavior (alarms/commands): keep simple per-n if/then rules without q gating
+          rules = arguments.map do |key, argument|
+            {
+              "if" => { "properties" => { "n" => { "const" => key } } },
+              "then" => { "properties" => { property_key => build_value(argument) } }
+            }
+          end
 
-          json
+          {
+            "$schema" => "https://json-schema.org/draft/2020-12/schema",
+            "description" => item['description'],
+            "properties" => {
+              "n" => { "enum" => arguments.keys.sort }
+            },
+            "allOf" => rules
+          }
         end
 
         # convert alarms to json schema
@@ -180,6 +190,7 @@ module RSMP
             }
           end
           json = {
+            "$schema" => "https://json-schema.org/draft/2020-12/schema",
             "properties" => {
               "aCId" => { "enum" => items.keys.sort },
               "rvs" => { "items" => { "allOf" => list } }
@@ -197,6 +208,19 @@ module RSMP
 
         # convert statuses to json schema
         def self.output_statuses out, items
+          # ensure shared guard is written (relative to version folder)
+          out['../defs/guards.json'] ||= output_json({
+            "$schema" => "https://json-schema.org/draft/2020-12/schema",
+            "$defs" => {
+              "q_unknown_or_undefined" => {
+                "allOf" => [
+                  { "required" => ["q"] },
+                  { "properties" => { "q" => { "enum" => ["undefined", "unknown"] } } }
+                ]
+              }
+            }
+          })
+
           list = [ { "properties" => { "sCI" => { "enum"=> items.keys.sort }}} ]
           items.keys.sort.each do |key|
             list << {
@@ -204,7 +228,10 @@ module RSMP
               "then" => { "$ref" => "#{key}.json" }
             }
           end
-          json = { "properties" => { "sS" => { "items" => { "allOf" => list }}}}
+          json = { 
+            "$schema" => "https://json-schema.org/draft/2020-12/schema",
+            "properties" => { "sS" => { "items" => { "allOf" => list }}}
+          }
           out['statuses/statuses.json'] = output_json json
           items.each_pair { |key,item| output_status out, key, item }
         end
@@ -224,13 +251,22 @@ module RSMP
               "then" => { "$ref" => "#{key}.json" }
             }
           end
-          json = { "items" => { "allOf" => list }}
+          json = { 
+            "$schema" => "https://json-schema.org/draft/2020-12/schema",
+            "items" => { "allOf" => list }
+          }
           out['commands/commands.json'] = output_json json
 
-          json = { "properties" => { "arg" => { "$ref" => "commands.json" }}}
+          json = { 
+            "$schema" => "https://json-schema.org/draft/2020-12/schema",
+            "properties" => { "arg" => { "$ref" => "commands.json" }}
+          }
           out['commands/command_requests.json'] = output_json json
 
-          json = { "properties" => { "rvs" => { "$ref" => "commands.json" }}}
+          json = { 
+            "$schema" => "https://json-schema.org/draft/2020-12/schema",
+            "properties" => { "rvs" => { "$ref" => "commands.json" }}
+          }
           out['commands/command_responses.json'] = output_json json
 
           items.each_pair { |key,item| output_command out, key, item }
@@ -239,13 +275,17 @@ module RSMP
         # convert a command to json schema
         def self.output_command out, key, item
           json = build_item item
-          json["allOf"].first["properties"]['cO'] = { "const" => item['command'] }
+          # Always add the command operation (cO) constraint at the top-level properties
+          json["properties"] ||= {}
+          json["properties"]["cO"] = { "const" => item['command'] }
+          
           out["commands/#{key}.json"] = output_json json
         end
 
         # output the json schema root
         def self.output_root out, meta
           json = {
+            "$schema" => "https://json-schema.org/draft/2020-12/schema",
             "name"=> meta['name'],
             "description"=> meta['description'],
             "version"=> meta['version'],

data/lib/rsmp_schema/version.rb

@@ -1,5 +1,5 @@
 module RSMP
   module Schema
-    VERSION = "0.8.8"
+    VERSION = "0.9.0"
   end
 end

data/lib/rsmp_schema.rb

@@ -1,5 +1,10 @@
 require 'yaml'
 require 'json_schemer'
+
+# Define module hierarchy first
+module RSMP
+end
+
 require 'rsmp_schema/error'
 require 'rsmp_schema/schema'
 require 'rsmp_schema/convert/import/yaml'

data/rsmp_schema.gemspec

@@ -9,8 +9,8 @@ Gem::Specification.new do |spec|
   spec.authors       = ["Emil Tin"]
   spec.email         = ["zf0f@kk.dk"]
 
-  spec.summary       = "Validate RSMP message against RSMP JSON Schema."
-  spec.description   = "Validate RSMP message against RSMP JSON Schema. Support validating against core and different SXL's, in different versions."
+  spec.summary       = "Validate RSMP message using RSMP JSON Schema."
+  spec.description   = "Validate RSMP message using RSMP JSON Schema. Support validating against core and different SXL's, in different versions."
   spec.homepage      = "https://github.com/rsmp-nordic/rsmp_schema"
   spec.licenses      = ['MIT']
   spec.required_ruby_version = '>= 3.0.0'

data/schemas/core/3.3.0/aggregated_status.json

@@ -0,0 +1,90 @@
+{
+  "title" :  "Aggregated Status",
+  "description" :  "Aggregated status message (bits 2 and 8 are unused and must be false in 3.3.0)",
+  "properties" : {
+    "mId" : { "$ref": "../3.1.2/definitions.json#/message_id" },
+    "aSTS" : { "$ref": "../3.1.2/definitions.json#/timestamp" },
+    "fP" : {
+      "description" : "Functional position",
+      "type" : ["string","null"]
+    },
+    "fS" : {
+      "description" : "Functional state",
+      "type" : ["string","null"]
+    },
+    "se" : {
+      "description" : "Aggregated status bits (2 and 8 unused -> always false)",
+      "type" : "array",
+      "minItems": 8,
+      "maxItems": 8,
+      "items": { "type": "boolean" },
+      "enum": [
+        [false,false,false,false,false,false,false,false],
+        [false,false,false,false,false,false,true,false],
+        [false,false,false,false,false,true,false,false],
+        [false,false,false,false,false,true,true,false],
+        [false,false,false,false,true,false,false,false],
+        [false,false,false,false,true,false,true,false],
+        [false,false,false,false,true,true,false,false],
+        [false,false,false,false,true,true,true,false],
+        [false,false,false,true,false,false,false,false],
+        [false,false,false,true,false,false,true,false],
+        [false,false,false,true,false,true,false,false],
+        [false,false,false,true,false,true,true,false],
+        [false,false,false,true,true,false,false,false],
+        [false,false,false,true,true,false,true,false],
+        [false,false,false,true,true,true,false,false],
+        [false,false,false,true,true,true,true,false],
+        [false,false,true,false,false,false,false,false],
+        [false,false,true,false,false,false,true,false],
+        [false,false,true,false,false,true,false,false],
+        [false,false,true,false,false,true,true,false],
+        [false,false,true,false,true,false,false,false],
+        [false,false,true,false,true,false,true,false],
+        [false,false,true,false,true,true,false,false],
+        [false,false,true,false,true,true,true,false],
+        [false,false,true,true,false,false,false,false],
+        [false,false,true,true,false,false,true,false],
+        [false,false,true,true,false,true,false,false],
+        [false,false,true,true,false,true,true,false],
+        [false,false,true,true,true,false,false,false],
+        [false,false,true,true,true,false,true,false],
+        [false,false,true,true,true,true,false,false],
+        [false,false,true,true,true,true,true,false],
+        [true,false,false,false,false,false,false,false],
+        [true,false,false,false,false,false,true,false],
+        [true,false,false,false,false,true,false,false],
+        [true,false,false,false,false,true,true,false],
+        [true,false,false,false,true,false,false,false],
+        [true,false,false,false,true,false,true,false],
+        [true,false,false,false,true,true,false,false],
+        [true,false,false,false,true,true,true,false],
+        [true,false,false,true,false,false,false,false],
+        [true,false,false,true,false,false,true,false],
+        [true,false,false,true,false,true,false,false],
+        [true,false,false,true,false,true,true,false],
+        [true,false,false,true,true,false,false,false],
+        [true,false,false,true,true,false,true,false],
+        [true,false,false,true,true,true,false,false],
+        [true,false,false,true,true,true,true,false],
+        [true,false,true,false,false,false,false,false],
+        [true,false,true,false,false,false,true,false],
+        [true,false,true,false,false,true,false,false],
+        [true,false,true,false,false,true,true,false],
+        [true,false,true,false,true,false,false,false],
+        [true,false,true,false,true,false,true,false],
+        [true,false,true,false,true,true,false,false],
+        [true,false,true,false,true,true,true,false],
+        [true,false,true,true,false,false,false,false],
+        [true,false,true,true,false,false,true,false],
+        [true,false,true,true,false,true,false,false],
+        [true,false,true,true,false,true,true,false],
+        [true,false,true,true,true,false,false,false],
+        [true,false,true,true,true,false,true,false],
+        [true,false,true,true,true,true,false,false],
+        [true,false,true,true,true,true,true,false]
+      ]
+    }
+  },
+  "required" : [ "mId", "aSTS", "fP", "fS", "se" ]
+}

data/schemas/core/3.3.0/aggregated_status_request.json

@@ -0,0 +1,9 @@
+{
+  "title" :  "Aggregated Status Request",
+  "description" :  "Aggregated status request message",
+  "properties" : {
+    "mId" : { "$ref": "../3.1.2/definitions.json#/message_id" },
+    "cId" : { "$ref": "definitions.json#/component_id" }
+  },
+  "required" : [ "mId", "cId" ]
+}