rsmp-validator 0.1.1 → 0.3.2

data/test/site/tlc/invalid_command_spec.rb

@@ -1,4 +1,12 @@
 describe 'Site::Tlc::InvalidCommand' do
+  def expect_message_rejected(result)
+    expect(result).to be_a(RSMP::Result::Failure)
+    return unless result.failure?
+
+    expect(result.failure.code).to eq(:message_rejected)
+    expect(result.failure.source).to eq(:peer)
+  end
+
   # Verify that site_proxy reponds with age=undefined when receiving
   # a command with an unknown component id
   #
@@ -12,17 +20,16 @@ describe 'Site::Tlc::InvalidCommand' do
       command_list = RSMP::CommandList.new(:M0001, :setValue,
                                            securityCode: RSMP::Validator.get_config('secrets', 'security_codes', 2),
                                            status: 'NormalControl',
-                                           timeout: 0,
-                                           intersection: 0).to_a
+                                           timeout: '0',
+                                           intersection: '0').to_a
       result = site_proxy.send_command_and_collect(
         command_list,
         component: 'bad',
         within: RSMP::Validator.get_config('timeouts', 'command_response'),
         validate: false # disable validation of outgoing message
       )
-      expect(result).to be_a(RSMP::Collector)
-      expect(result.status).to eq(:ok)
-      response = result.messages.first
+      exchange = result.value!
+      response = exchange.messages.first
       expect(response).to be_a(RSMP::CommandResponse)
       rvs = response.attributes['rvs']
       expect(rvs).to be_a(Array)
@@ -45,11 +52,10 @@ describe 'Site::Tlc::InvalidCommand' do
       command_list = RSMP::CommandList.new(:M0000, :bad, {}).to_a
       timeout = RSMP::Validator.get_config('timeouts', 'command_response')
 
-      collector = site_proxy.send_command_and_collect(command_list,
-                                                      within: timeout,
-                                                      validate: false) # disable schema validation of outgoing message
-      expect(collector.status).to eq(:cancelled)
-      expect(collector.error).to be_a(RSMP::MessageRejected)
+      result = site_proxy.send_command_and_collect(command_list,
+                                                   within: timeout,
+                                                   validate: false) # disable schema validation of outgoing message
+      expect_message_rejected(result)
     end
   end
 
@@ -69,11 +75,10 @@ describe 'Site::Tlc::InvalidCommand' do
                                            timeout: '0').to_a
       # intentionally not setting 'status'
       timeout = RSMP::Validator.get_config('timeouts', 'command_response')
-      collector = site_proxy.send_command_and_collect(command_list,
-                                                      within: timeout,
-                                                      validate: false) # disable validation of outgoing message
-      expect(collector.status).to eq(:cancelled)
-      expect(collector.error).to be_a(RSMP::MessageRejected)
+      result = site_proxy.send_command_and_collect(command_list,
+                                                   within: timeout,
+                                                   validate: false) # disable validation of outgoing message
+      expect_message_rejected(result)
     end
   end
 
@@ -93,11 +98,10 @@ describe 'Site::Tlc::InvalidCommand' do
                                            intersection: '0',
                                            timeout: '0').to_a
       timeout = RSMP::Validator.get_config('timeouts', 'command_response')
-      collector = site_proxy.send_command_and_collect(command_list,
-                                                      within: timeout,
-                                                      validate: false) # disable validation of outgoing message
-      expect(collector.status).to eq(:cancelled)
-      expect(collector.error).to be_a(RSMP::MessageRejected)
+      result = site_proxy.send_command_and_collect(command_list,
+                                                   within: timeout,
+                                                   validate: false) # disable validation of outgoing message
+      expect_message_rejected(result)
     end
   end
 end

data/test/site/tlc/invalid_status_spec.rb

@@ -1,4 +1,12 @@
 describe 'Site::Tlc::InvalidStatus' do
+  def expect_message_rejected(result)
+    expect(result).to be_a(RSMP::Result::Failure)
+    return unless result.failure?
+
+    expect(result.failure.code).to eq(:message_rejected)
+    expect(result.failure.source).to eq(:peer)
+  end
+
   # Verify that site_proxy reponds with q=undefined when receiving a
   # status request with an unknown component id.
   #
@@ -9,15 +17,14 @@ describe 'Site::Tlc::InvalidStatus' do
   it 'return a command response with age=undefined when component id is unknown' do
     with_site(:connected, core: '>=3.1.3') do |site_proxy|
       log 'Sending M0001 with bad component id'
-      collector = site_proxy.request_status_and_collect(
+      result = site_proxy.request_status_and_collect(
         { S0001: [:signalgroupstatus] },
         component: 'bad',
         within: RSMP::Validator.get_config('timeouts', 'status_response'),
         validate: false
       )
-      collector.ok!
-      expect(collector.status).to eq(:ok)
-      response = collector.messages.first
+      exchange = result.value!
+      response = exchange.messages.first
       expect(response).to be_a(RSMP::StatusResponse)
       ss = response.attributes['sS']
       expect(ss).to be_a(Array)
@@ -37,14 +44,13 @@ describe 'Site::Tlc::InvalidStatus' do
   it 'returns NotAck when status code is unknown' do
     with_site(:connected) do |site_proxy|
       log 'Requesting non-existing status S0000'
-      expect do
-        site_proxy.request_status_and_collect(
-          { S0000: [:status] },
-          component: RSMP::Validator.get_config('main_component'),
-          within: RSMP::Validator.get_config('timeouts', 'status_response'),
-          validate: false
-        ).ok!
-      end.to raise_exception(RSMP::MessageRejected)
+      result = site_proxy.request_status_and_collect(
+        { S0000: [:status] },
+        component: RSMP::Validator.get_config('main_component'),
+        within: RSMP::Validator.get_config('timeouts', 'status_response'),
+        validate: false
+      )
+      expect_message_rejected(result)
     end
   end
 
@@ -57,14 +63,13 @@ describe 'Site::Tlc::InvalidStatus' do
   it 'returns NotAck when status name is unknown' do
     with_site(:connected) do |site_proxy|
       log 'Requesting S0001 with non-existing status name'
-      expect do
-        site_proxy.request_status_and_collect(
-          { S0001: [:bad] },
-          component: RSMP::Validator.get_config('main_component'),
-          within: RSMP::Validator.get_config('timeouts', 'status_response'),
-          validate: false
-        ).ok!
-      end.to raise_exception(RSMP::MessageRejected)
+      result = site_proxy.request_status_and_collect(
+        { S0001: [:bad] },
+        component: RSMP::Validator.get_config('main_component'),
+        within: RSMP::Validator.get_config('timeouts', 'status_response'),
+        validate: false
+      )
+      expect_message_rejected(result)
     end
   end
 end

data/test/site/tlc/modes_spec.rb

@@ -9,7 +9,7 @@ describe 'Site::Tlc::Modes' do
   it 'control mode is read with S0020' do
     with_site(:connected, sxl: '>=1.0.7') do |site_proxy|
       site_proxy.request_status_and_collect({ S0020: %i[controlmode intersection] },
-                                            within: RSMP::Validator.get_config('timeouts', 'status_response')).ok!
+                                            within: RSMP::Validator.get_config('timeouts', 'status_response')).value!
     end
   end
 
@@ -21,21 +21,21 @@ describe 'Site::Tlc::Modes' do
   it 'startup status is read with S0005' do
     with_site(:connected, sxl: '>=1.0.7') do |site_proxy|
       site_proxy.request_status_and_collect({ S0005: [:status] },
-                                            within: RSMP::Validator.get_config('timeouts', 'status_response')).ok!
+                                            within: RSMP::Validator.get_config('timeouts', 'status_response')).value!
     end
   end
 
   # Verify status S0005 traffic controller starting by intersection
-  # statusByIntersection requires core >= 3.2, since it uses the array data type.
+  # statusByIntersection requires core >= 3.2.0, since it uses the array data type.
   #
   # 1. Given the site_proxy is connected
   # 2. Request status
   # 3. Expect status response before timeout
   it 'startup status is read with S0005 by intersection' do
-    skip 'requires core >= 3.2' unless RSMP::Validator.core_matches?('>=3.2')
-    with_site(:connected, sxl: '>=1.2') do |site_proxy|
+    skip 'requires core >= 3.2.0' unless RSMP::Validator.core_matches?('>=3.2.0')
+    with_site(:connected, sxl: '>=1.2.0') do |site_proxy|
       site_proxy.request_status_and_collect({ S0005: [:statusByIntersection] },
-                                            within: RSMP::Validator.get_config('timeouts', 'status_response')).ok!
+                                            within: RSMP::Validator.get_config('timeouts', 'status_response')).value!
     end
   end
 
@@ -47,7 +47,7 @@ describe 'Site::Tlc::Modes' do
   it 'switched on is read with S0007' do
     with_site(:connected, sxl: '>=1.0.7') do |site_proxy|
       site_proxy.request_status_and_collect({ S0007: %i[status intersection] },
-                                            within: RSMP::Validator.get_config('timeouts', 'status_response')).ok!
+                                            within: RSMP::Validator.get_config('timeouts', 'status_response')).value!
     end
   end
 
@@ -57,9 +57,9 @@ describe 'Site::Tlc::Modes' do
   # 2. Request status
   # 3. Expect status response before timeout
   it 'switched on is read with S0007 with source' do
-    with_site(:connected, sxl: '>=1.1') do |site_proxy|
+    with_site(:connected, sxl: '>=1.1.0') do |site_proxy|
       site_proxy.request_status_and_collect({ S0007: %i[status intersection source] },
-                                            within: RSMP::Validator.get_config('timeouts', 'status_response')).ok!
+                                            within: RSMP::Validator.get_config('timeouts', 'status_response')).value!
     end
   end
 
@@ -70,13 +70,13 @@ describe 'Site::Tlc::Modes' do
   # 3. Expect status response before timeout
   it 'manual control is read with S0008' do
     with_site(:connected, sxl: '>=1.0.7') do |site_proxy|
-      status_list = if RSMP::Proxy.version_meets_requirement?(site_proxy.sxl_version, '>=1.1')
+      status_list = if RSMP::Proxy.version_meets_requirement?(site_proxy.sxl_version, '>=1.1.0')
                       { S0008: %i[status intersection source] }
                     else
                       { S0008: %i[status intersection] }
                     end
       site_proxy.request_status_and_collect(status_list,
-                                            within: RSMP::Validator.get_config('timeouts', 'status_response')).ok!
+                                            within: RSMP::Validator.get_config('timeouts', 'status_response')).value!
     end
   end
 
@@ -87,13 +87,13 @@ describe 'Site::Tlc::Modes' do
   # 3. Expect status response before timeout
   it 'fixed time control is read with S0009' do
     with_site(:connected, sxl: '>=1.0.7') do |site_proxy|
-      status_list = if RSMP::Proxy.version_meets_requirement?(site_proxy.sxl_version, '>=1.1')
+      status_list = if RSMP::Proxy.version_meets_requirement?(site_proxy.sxl_version, '>=1.1.0')
                       { S0009: %i[status intersection source] }
                     else
                       { S0009: %i[status intersection] }
                     end
       site_proxy.request_status_and_collect(status_list,
-                                            within: RSMP::Validator.get_config('timeouts', 'status_response')).ok!
+                                            within: RSMP::Validator.get_config('timeouts', 'status_response')).value!
     end
   end
 
@@ -107,8 +107,11 @@ describe 'Site::Tlc::Modes' do
   it 'fixed time control can be activated with M0007' do
     with_site(:connected, sxl: '>=1.0.7') do |site_proxy|
       timeout = RSMP::Validator.get_config('timeouts', 'command')
-      site_proxy.tlc.set_fixed_time('True', within: timeout)
-      site_proxy.tlc.set_fixed_time('False', within: timeout)
+      begin
+        site_proxy.tlc.set_fixed_time!('True', within: timeout)
+      ensure
+        site_proxy.tlc.set_fixed_time!('False', within: timeout)
+      end
     end
   end
 
@@ -119,13 +122,13 @@ describe 'Site::Tlc::Modes' do
   # 3. Expect status response before timeout
   it 'isolated control is read with S0010' do
     with_site(:connected, sxl: '>=1.0.7') do |site_proxy|
-      status_list = if RSMP::Proxy.version_meets_requirement?(site_proxy.sxl_version, '>=1.1')
+      status_list = if RSMP::Proxy.version_meets_requirement?(site_proxy.sxl_version, '>=1.1.0')
                       { S0010: %i[status intersection source] }
                     else
                       { S0010: %i[status intersection] }
                     end
       site_proxy.request_status_and_collect(status_list,
-                                            within: RSMP::Validator.get_config('timeouts', 'status_response')).ok!
+                                            within: RSMP::Validator.get_config('timeouts', 'status_response')).value!
     end
   end
 
@@ -135,9 +138,9 @@ describe 'Site::Tlc::Modes' do
   # 2. Request status
   # 3. Expect status response before timeout
   it 'coordinated control is read with S0032' do
-    with_site(:connected, sxl: '>=1.1') do |site_proxy|
+    with_site(:connected, sxl: '>=1.1.0') do |site_proxy|
       site_proxy.request_status_and_collect({ S0032: %i[status intersection source] },
-                                            within: RSMP::Validator.get_config('timeouts', 'status_response')).ok!
+                                            within: RSMP::Validator.get_config('timeouts', 'status_response')).value!
     end
   end
 
@@ -148,13 +151,13 @@ describe 'Site::Tlc::Modes' do
   # 3. Expect status response before timeout
   it 'yellow flash can be read with S0011' do
     with_site(:connected, sxl: '>=1.0.7') do |site_proxy|
-      status_list = if RSMP::Proxy.version_meets_requirement?(site_proxy.sxl_version, '>=1.1')
+      status_list = if RSMP::Proxy.version_meets_requirement?(site_proxy.sxl_version, '>=1.1.0')
                       { S0011: %i[status intersection source] }
                     else
                       { S0011: %i[status intersection] }
                     end
       site_proxy.request_status_and_collect(status_list,
-                                            within: RSMP::Validator.get_config('timeouts', 'status_response')).ok!
+                                            within: RSMP::Validator.get_config('timeouts', 'status_response')).value!
     end
   end
 
@@ -169,12 +172,15 @@ describe 'Site::Tlc::Modes' do
     with_site(:connected, sxl: '>=1.0.7') do |site_proxy|
       yellow_flash_timeout = RSMP::Validator.get_config('timeouts', 'yellow_flash')
       startup_timeout = RSMP::Validator.get_config('timeouts', 'startup_sequence')
-      site_proxy.tlc.set_functional_position('YellowFlash', within: yellow_flash_timeout)
-      site_proxy.tlc.set_functional_position('NormalControl', within: startup_timeout)
+      begin
+        site_proxy.tlc.set_functional_position!('YellowFlash', within: yellow_flash_timeout)
+      ensure
+        site_proxy.tlc.set_functional_position!('NormalControl', within: startup_timeout)
+      end
     end
   end
 
-  # Verify that we can yellow flash causes all groups to go to state 'c'
+  # Verify that yellow flash causes all groups to go to state 'c'
   #
   # 1. Given the site_proxy is connected
   # 2. Send the control command to switch to Yellow flash
@@ -184,13 +190,16 @@ describe 'Site::Tlc::Modes' do
   it 'yellow flash affects all signal groups' do
     with_site(:connected, sxl: '>=1.0.7') do |site_proxy|
       timeout = RSMP::Validator.get_config('timeouts', 'yellow_flash')
+      startup_timeout = RSMP::Validator.get_config('timeouts', 'startup_sequence')
 
-      site_proxy.tlc.set_functional_position('YellowFlash', within: timeout)
-      site_proxy.tlc.wait_for_groups 'c', timeout: timeout      # c means yellow flash
+      begin
+        site_proxy.tlc.set_functional_position!('YellowFlash', within: timeout)
+        site_proxy.tlc.wait_for_groups! 'c', timeout: timeout # c means yellow flash
+      ensure
+        site_proxy.tlc.set_functional_position!('NormalControl', within: startup_timeout)
+      end
 
-      startup_timeout = RSMP::Validator.get_config('timeouts', 'startup_sequence')
-      site_proxy.tlc.set_functional_position('NormalControl', within: startup_timeout)
-      site_proxy.tlc.wait_for_groups '[^c]', timeout: timeout   # not c, ie. not yellow flash
+      site_proxy.tlc.wait_for_groups! '[^c]', timeout: timeout # not c, ie. not yellow flash
     end
   end
 
@@ -201,13 +210,13 @@ describe 'Site::Tlc::Modes' do
   # 3. Expect status response before timeout
   it 'all red can be read with S0012' do
     with_site(:connected, sxl: '>=1.0.7') do |site_proxy|
-      status_list = if RSMP::Proxy.version_meets_requirement?(site_proxy.sxl_version, '>=1.1')
+      status_list = if RSMP::Proxy.version_meets_requirement?(site_proxy.sxl_version, '>=1.1.0')
                       { S0012: %i[status intersection source] }
                     else
                       { S0012: %i[status intersection] }
                     end
       site_proxy.request_status_and_collect(status_list,
-                                            within: RSMP::Validator.get_config('timeouts', 'status_response')).ok!
+                                            within: RSMP::Validator.get_config('timeouts', 'status_response')).value!
     end
   end
 
@@ -219,7 +228,7 @@ describe 'Site::Tlc::Modes' do
   it 'police key can be read with S0013' do
     with_site(:connected, sxl: '>=1.0.7') do |site_proxy|
       site_proxy.request_status_and_collect({ S0013: [:status] },
-                                            within: RSMP::Validator.get_config('timeouts', 'status_response')).ok!
+                                            within: RSMP::Validator.get_config('timeouts', 'status_response')).value!
     end
   end
 
@@ -234,8 +243,11 @@ describe 'Site::Tlc::Modes' do
     with_site(:connected, sxl: '>=1.0.7') do |site_proxy|
       timeout = RSMP::Validator.get_config('timeouts', 'functional_position')
       startup_timeout = RSMP::Validator.get_config('timeouts', 'startup_sequence')
-      site_proxy.tlc.set_functional_position('Dark', within: timeout)
-      site_proxy.tlc.set_functional_position('NormalControl', within: startup_timeout)
+      begin
+        site_proxy.tlc.set_functional_position!('Dark', within: timeout)
+      ensure
+        site_proxy.tlc.set_functional_position!('NormalControl', within: startup_timeout)
+      end
     end
   end
 
@@ -249,12 +261,16 @@ describe 'Site::Tlc::Modes' do
   it 'can use yellow flash with a timeout of one minute' do
     with_site(:connected, sxl: '>=1.0.7') do |site_proxy|
       startup_timeout = RSMP::Validator.get_config('timeouts', 'startup_sequence')
-      site_proxy.tlc.set_functional_position('NormalControl', within: startup_timeout)
       minutes = 1
       timeout = RSMP::Validator.get_config('timeouts', 'yellow_flash')
-      site_proxy.tlc.set_functional_position('YellowFlash', timeout_minutes: minutes, within: timeout)
       fp_timeout = RSMP::Validator.get_config('timeouts', 'functional_position')
-      wait_normal_control(site_proxy, timeout: (minutes * 60) + fp_timeout)
+      begin
+        site_proxy.tlc.set_functional_position!('NormalControl', within: startup_timeout)
+        site_proxy.tlc.set_functional_position!('YellowFlash', timeout_minutes: minutes, within: timeout)
+        wait_normal_control(site_proxy, timeout: (minutes * 60) + fp_timeout)
+      ensure
+        site_proxy.tlc.set_functional_position!('NormalControl', within: startup_timeout)
+      end
     end
   end
 end

data/test/site/tlc/output_spec.rb

@@ -7,11 +7,11 @@ describe 'Site::Tlc::Output' do
   # 3. We should receive a status updated
   # 4. And the outputstatus attribute should be a digit string
   it 'is read with S0004 with extended output status' do
-    with_site(:connected, sxl: ['>=1.0.7', '<1.2']) do |site_proxy|
+    with_site(:connected, sxl: ['>=1.0.7', '<1.2.0']) do |site_proxy|
       site_proxy.request_status_and_collect(
         { S0004: %i[outputstatus extendedoutputstatus] },
         within: RSMP::Validator.get_config('timeouts', 'status_response')
-      ).ok!
+      ).value!
     end
   end
 
@@ -21,9 +21,9 @@ describe 'Site::Tlc::Output' do
   # 3. We should receive a status updated
   # 4. And the outputstatus attribute should be a digit string
   it 'is read with S0004' do
-    with_site(:connected, sxl: ['>=1.2']) do |site_proxy|
+    with_site(:connected, sxl: ['>=1.2.0']) do |site_proxy|
       site_proxy.request_status_and_collect({ S0004: [:outputstatus] },
-                                            within: RSMP::Validator.get_config('timeouts', 'status_response')).ok!
+                                            within: RSMP::Validator.get_config('timeouts', 'status_response')).value!
     end
   end
 
@@ -34,7 +34,7 @@ describe 'Site::Tlc::Output' do
   it 'forcing is read with S0030' do
     with_site(:connected, sxl: '>=1.0.15') do |site_proxy|
       site_proxy.request_status_and_collect({ S0030: [:status] },
-                                            within: RSMP::Validator.get_config('timeouts', 'status_response')).ok!
+                                            within: RSMP::Validator.get_config('timeouts', 'status_response')).value!
     end
   end
 
@@ -48,10 +48,10 @@ describe 'Site::Tlc::Output' do
       skip('No outputs configured') if outputs.nil? || outputs.empty?
       timeout = RSMP::Validator.get_config('timeouts', 'command_response')
       outputs.each do |output|
-        site_proxy.tlc.force_output(output: output, status: 'True', value: 'True', within: timeout)
-        site_proxy.tlc.force_output(output: output, status: 'True', value: 'False', within: timeout)
+        site_proxy.tlc.force_output!(output: output, status: 'True', value: 'True', within: timeout)
+        site_proxy.tlc.force_output!(output: output, status: 'True', value: 'False', within: timeout)
       ensure
-        site_proxy.tlc.force_output(output: output, status: 'False', value: 'True', within: timeout)
+        site_proxy.tlc.force_output!(output: output, status: 'False', value: 'True', within: timeout)
       end
     end
   end

data/test/site/tlc/signal_groups_spec.rb

@@ -10,7 +10,7 @@ describe 'Site::Tlc::SignalGroups' do
     with_site(:connected, sxl: '>=1.0.8') do |site_proxy|
       component = RSMP::Validator.get_config('components', 'signal_group').keys[0]
       timeout = RSMP::Validator.get_config('timeouts', 'command_response')
-      site_proxy.tlc.order_signal_start(component, within: timeout)
+      site_proxy.tlc.order_signal_start!(component, within: timeout)
     end
   end
 
@@ -21,7 +21,7 @@ describe 'Site::Tlc::SignalGroups' do
     with_site(:connected, sxl: '>=1.0.8') do |site_proxy|
       component = RSMP::Validator.get_config('components', 'signal_group').keys[0]
       timeout = RSMP::Validator.get_config('timeouts', 'command_response')
-      site_proxy.tlc.order_signal_stop(component, within: timeout)
+      site_proxy.tlc.order_signal_stop!(component, within: timeout)
     end
   end
 
@@ -35,7 +35,7 @@ describe 'Site::Tlc::SignalGroups' do
       site_proxy.request_status_and_collect(
         { S0001: %i[signalgroupstatus cyclecounter basecyclecounter stage] },
         within: RSMP::Validator.get_config('timeouts', 'status_response')
-      ).ok!
+      ).value!
     end
   end
 
@@ -59,7 +59,7 @@ describe 'Site::Tlc::SignalGroups' do
         ] },
         component: component,
         within: RSMP::Validator.get_config('timeouts', 'status_response')
-      ).ok!
+      ).value!
     end
   end
 
@@ -71,7 +71,7 @@ describe 'Site::Tlc::SignalGroups' do
   it 'list size is read with S0017' do
     with_site(:connected, sxl: '>=1.0.7') do |site_proxy|
       site_proxy.request_status_and_collect({ S0017: [:number] },
-                                            within: RSMP::Validator.get_config('timeouts', 'status_response')).ok!
+                                            within: RSMP::Validator.get_config('timeouts', 'status_response')).value!
     end
   end
 
@@ -85,12 +85,12 @@ describe 'Site::Tlc::SignalGroups' do
     with_site(:connected) do |site_proxy|
       verify_startup_sequence(site_proxy) do
         timeout = RSMP::Validator.get_config('timeouts', 'yellow_flash')
-        site_proxy.tlc.set_functional_position('YellowFlash', within: timeout)
+        site_proxy.tlc.set_functional_position!('YellowFlash', within: timeout)
         command_timeout = RSMP::Validator.get_config('timeouts', 'command_response')
-        site_proxy.tlc.set_functional_position('NormalControl', within: command_timeout)
+        site_proxy.tlc.set_functional_position!('NormalControl', within: command_timeout)
       end
       command_timeout ||= RSMP::Validator.get_config('timeouts', 'command_response')
-      site_proxy.tlc.set_functional_position('NormalControl', within: command_timeout)
+      site_proxy.tlc.set_functional_position!('NormalControl', within: command_timeout)
     end
   end
 end