rslog 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9c4b16055dfb7a8c71c14c11be24fc7a20aece0d88e375234eca519d820d6ae4
-  data.tar.gz: fefd301fd11a12e10f4e6467ff405fe0e76d3fb3ed2f7c1649f8ea4e175ae4d4
+  metadata.gz: 76f7a375fca0f34c34cbf794f94aef6673ca9c9e5de06881cce494ffee728eff
+  data.tar.gz: e5d35abb7b40dce5e89489ddb360d1e41e7cffc76692fa28ebe323b123619cdd
 SHA512:
-  metadata.gz: 93028f931c8f3125c5685f14b45b322dc201086da4e44c0ae1bf5dbe9735a4f283693928f9a9d90390c2aac355fb7ef21212e1a66df02dd8832f11e6192964e8
-  data.tar.gz: 70a9005d4eabc8dcaf7da8da56cd321594e1a8ae7b4de5af645418bc7445bb6f5a7a4134f4e702682edc9fc92224a2ce043339ff98bb74abcfcbea2c7e4adad8
+  metadata.gz: 9aea32ac29dc370ac5a5d741eaf59cfea3fc13d9cfbcca026e98369eece8d0f81cb3fd20ee1a0aaac1284769c64bbeed5b18cecb4e5d1701d7ac1d20472e7296
+  data.tar.gz: 55d8b0782e7b26495d5190458c60606439047d2c7a484356cbc1cb345b80f97e3f6f6e8f26dfeaa9c408ae2b2643a14adced0dc7d3992aab83e84b059c3c7552

data/lib/rslog.rb

@@ -12,7 +12,7 @@ require_relative 'rslog/presenter'
 # require 'pry'
 
 class RSlog
-  VERSION = '0.0.3'
+  VERSION = '0.0.4'
 
   def self.run
     Container.new.process_all

data/lib/rslog/container.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+# Class to hold data and implement processing
+
 class Container
   attr_accessor(*%i[
                   argv file_name messages errors data options validator types result
@@ -23,6 +25,14 @@ class Container
   def no_errors?
     errors.empty?
   end
+  
+  def add_message(str)
+    self.messages << str
+  end
+
+  def add_error(str)
+    self.errors << str
+  end
 
   def talk
     puts messages.join("\n")

data/lib/rslog/data_parser.rb

@@ -6,6 +6,8 @@ require_relative 'validator'
 
 require 'pry'
 
+# Class to parse data from given array
+#
 class DataParser
   # type = :count (default) -> just count in groups
   # type = :uniq -> uniq entries in groups
@@ -17,11 +19,11 @@ class DataParser
     @container.result =
       @container.data
                 .group_by_index(0)
-                .count_by_groups(type)
+                .send("count_by_groups_#{type.to_s}")
                 .to_a
                 .sort_by { |item| item[1] }
                 .reverse
-                .map { |i| i.map(&:to_s).join(' ') }
+                .map { |elem_arr| elem_arr.map(&:to_s).join(' ') }
     self
   end
 end

data/lib/rslog/extractor.rb

@@ -2,9 +2,12 @@
 
 require_relative 'container'
 
+# Class for extracting data from file
+#
 class Extractor
   def initialize(container)
     @container = container
+    @file_name = container.file_name
   end
 
   def execute
@@ -15,13 +18,13 @@ class Extractor
   private
 
   def check
-    if File.zero?(@container.file_name)
-      @container.messages << 'Empty file'
+    if File.zero?(@file_name)
+      @container.add_message 'Empty file'
     else
-      @container.data = File.open(@container.file_name, 'r').to_a
-      @container.messages << 'Data in place'
+      @container.data = File.open(@file_name, 'r').to_a
+      @container.add_message 'Data in place'
     end
-  rescue StandardError => e
-    @container.errors << e
+  rescue StandardError => error
+    @container.add_error error
   end
 end

data/lib/rslog/input_parser.rb

@@ -1,35 +1,19 @@
 # frozen_string_literal: true
 
 require 'optparse'
+require_relative 'opts'
 
+# Class to parse input filenames and args
+#
 class InputParser
-  OPTS = {
-    version: {
-      descr:  ['-v', '--version', 'Show version and exit'],
-      action: proc do
-        puts "#{File.basename($PROGRAM_NAME)}: #{RSlog::VERSION}"
-        exit
-      end
-    },
-    help:    {
-      descr:  ['-h', '--help', 'Prints this message and exit'],
-      action: proc do |opts|
-        puts opts
-        exit
-      end
-    }
-  }.freeze
+  include Opts
 
   def initialize(container)
     @container = container
-    @argv = container.argv
-    @file_name = container.file_name
-    @options = container.options
-    @errors = container.errors
   end
 
   def execute
-    create_opts
+    @opts = Opts.create_opts
     handle_opts
     handle_args
     self
@@ -39,26 +23,14 @@ class InputParser
 
   attr_accessor :opts
 
-  def create_opts
-    @opts = OptionParser.new do |opts|
-      opts.banner = "Usage: #{File.basename($PROGRAM_NAME)} FILENAME"
-      opts.on(*OPTS[:version][:descr]) do
-        OPTS[:version][:action].call
-      end
-      opts.on(*OPTS[:help][:descr]) do
-        OPTS[:help][:action].call(opts)
-      end
-    end
-  end
-
   def handle_opts
     @opts.parse!(into: @container.options)
-  rescue OptionParser::InvalidOption => e
-    @container.errors << e
+  rescue OptionParser::InvalidOption => error
+    @container.add_error << error
   end
 
   def handle_args
     @container.file_name = ARGV.select { |str| str =~ /.\.log|.\.txt/ }[0] || ''
-    @container.errors << 'No file_name provided' if @container.file_name.empty?
+    @container.add_error 'No file_name provided' if @container.file_name.empty?
   end
 end

data/lib/rslog/presenter.rb

@@ -3,6 +3,8 @@
 require_relative 'tools/hash'
 require_relative 'tools/array'
 
+# Class to present result in needed format
+#
 class Presenter
   DECORATORS = {
     all:  {
@@ -21,21 +23,33 @@ class Presenter
   end
 
   def execute(type, formatter)
-    @container.messages << format_as(type, formatter)
+    @type = type
+    @container.messages << send("format_as_#{formatter}")
     self
   end
 
   private
 
-  def format_as(type, formatter)
-    case formatter
-    when :text
-      [
-        DECORATORS[type][:title],
-        @container.result.to_multiline_string(DECORATORS[type][:suffix]),
-        separator
-      ].join("\n")
-    end
+  attr_reader :title, :suffix
+  
+  def title
+    decorator[:title]
+  end
+  
+  def suffix
+    decorator[:suffix]
+  end
+  
+  def decorator
+    DECORATORS[@type]
+  end
+  
+  def format_as_text
+    [
+      title,
+      @container.result.to_multiline_string(suffix),
+      separator
+    ].join("\n")
   end
 
   def separator

data/lib/rslog/tools/array.rb

@@ -1,15 +1,13 @@
 # frozen_string_literal: true
 
+# Monkey patch for Array class 
+#  
 class Array
   def group_by_index(index = 0)
     group_by { |str| str.split(' ')[index] }
   end
 
   def to_multiline_string(suffix = '')
-    arr = []
-    each do |item|
-      arr << "#{item} #{suffix}"
-    end
-    arr.join("\n")
+    self.map {|item| "#{item} #{suffix}"}.join("\n")
   end
 end

data/lib/rslog/tools/hash.rb

@@ -2,12 +2,21 @@
 
 require 'set'
 
+# Monkey patch for a Hash class to make counts
+#
 class Hash
-  def count_by_groups(type = :all)
+  def count_by_groups_all
     res = {}
     each do |group_key, arr|
-      res[group_key] = arr.size          if type == :all
-      res[group_key] = Set.new(arr).size if type == :uniq
+      res[group_key] = arr.size
+    end
+    res
+  end
+
+  def count_by_groups_uniq
+    res = {}
+    each do |group_key, arr|
+      res[group_key] = Set.new(arr).size
     end
     res
   end

data/lib/rslog/validator.rb

@@ -2,6 +2,8 @@
 
 require_relative 'tools/array'
 
+# Class to validate if we have valid data in lines, for example well formatted IPs
+#
 class Validator
   TEMPLATES = {
     # IP address regex, source https://regexr.com/38odc

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rslog
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Andrey Eremeev