rsim-activerecord-oracle_enhanced-adapter 1.2.0 → 1.2.0.1

data/History.txt

@@ -1,3 +1,8 @@
+== master development branch
+
+* Bug fixes:
+  * return Date (and not DateTime) values for :date column value before year 1970
+
 == 1.2.0 2009-03-22
 
 * Enhancements

data/lib/active_record/connection_adapters/oracle_enhanced_adapter.rb

@@ -137,9 +137,9 @@ module ActiveRecord
         end
       end
 
-      # RSI: convert Time value to Date for :date columns
+      # RSI: convert Time or DateTime value to Date for :date columns
       def self.string_to_date(string)
-        return string.to_date if string.is_a?(Time)
+        return string.to_date if string.is_a?(Time) || string.is_a?(DateTime)
         super
       end
 

data/oracle-enhanced.gemspec

@@ -2,11 +2,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{activerecord-oracle_enhanced-adapter}
-  s.version = "1.2.0"
+  s.version = "1.2.0.1"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Raimonds Simanovskis"]
-  s.date = %q{2009-03-22}
+  s.date = %q{2009-04-07}
   s.description = %q{Oracle enhanced adapter for ActiveRecord}
   s.email = ["raimonds.simanovskis@gmail.com"]
   s.extra_rdoc_files = ["History.txt", "License.txt", "Manifest.txt", "README.txt"]

data/spec/active_record/connection_adapters/oracle_enhanced_data_types_spec.rb

@@ -74,6 +74,13 @@ describe "OracleEnhancedAdapter date type detection based on column names" do
     column.type_cast(Time.now).class.should == Date
   end
 
+  it "should typecast DateTime value to Date value from DATE column if column name contains 'date' and emulate_dates_by_column_name is true" do
+    ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter.emulate_dates_by_column_name = true
+    columns = @conn.columns('test_employees')
+    column = columns.detect{|c| c.name == "hire_date"}
+    column.type_cast(DateTime.new(1900,1,1)).class.should == Date
+  end
+
   describe "/ DATE values from ActiveRecord model" do
     before(:each) do
       ActiveRecord::Base.connection.clear_types_for_columns
@@ -85,9 +92,9 @@ describe "OracleEnhancedAdapter date type detection based on column names" do
       end
     end
     
-    def create_test_employee
-      @today = Date.new(2008,8,19)
-      @now = Time.local(2008,8,19,17,03,59)
+    def create_test_employee(params={})
+      @today = params[:today] || Date.new(2008,8,19)
+      @now = params[:now] || Time.local(2008,8,19,17,03,59)
       @employee = TestEmployee.create(
         :first_name => "First",
         :last_name => "Last",
@@ -114,6 +121,12 @@ describe "OracleEnhancedAdapter date type detection based on column names" do
       @employee.hire_date.class.should == Date
     end
 
+    it "should return Date value from DATE column with old date value if column name contains 'date' and emulate_dates_by_column_name is true" do
+      ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter.emulate_dates_by_column_name = true
+      create_test_employee(:today => Date.new(1900,1,1))
+      @employee.hire_date.class.should == Date
+    end
+
     it "should return Time value from DATE column if column name does not contain 'date' and emulate_dates_by_column_name is true" do
       ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter.emulate_dates_by_column_name = true
       create_test_employee
@@ -129,6 +142,15 @@ describe "OracleEnhancedAdapter date type detection based on column names" do
       @employee.hire_date.class.should == Date
     end
 
+    it "should return Date value from DATE column with old date value if emulate_dates_by_column_name is false but column is defined as date" do
+      class ::TestEmployee < ActiveRecord::Base
+        set_date_columns :hire_date
+      end
+      ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter.emulate_dates_by_column_name = false
+      create_test_employee(:today => Date.new(1900,1,1))
+      @employee.hire_date.class.should == Date
+    end
+
     it "should return Time value from DATE column if emulate_dates_by_column_name is true but column is defined as datetime" do
       class ::TestEmployee < ActiveRecord::Base
         set_datetime_columns :hire_date

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: rsim-activerecord-oracle_enhanced-adapter
 version: !ruby/object:Gem::Version 
-  version: 1.2.0
+  version: 1.2.0.1
 platform: ruby
 authors: 
 - Raimonds Simanovskis
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-03-22 00:00:00 -07:00
+date: 2009-04-07 00:00:00 -07:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency