rservicebus2 0.2.7 → 0.2.12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e5cab110a6dd40b7b80824e669ac85709bbec790bc948d5bdcb954a1b29184a5
-  data.tar.gz: 1bc1c569d5af1d01e79c69c0aef99781498bdac5aac13671fd4cd47a286aa2b1
+  metadata.gz: a3c83b298bb79d2335fa0c00cfc6493249617f0cff9cfbd2f1d21ee6f0e241d0
+  data.tar.gz: 93bd9a061367a3243b99d29c0d9cf18c1aa3d6361d10afba694b775961591eb3
 SHA512:
-  metadata.gz: 64d2065fbd9b061cf17eca6f9c8eea5e8aa4663a9e68a27463417d511496d9e329d2d2d227bd7dc0b677f39e1a0f62b56292394f5b22217517f80f097698b2dc
-  data.tar.gz: 5637363459b8c27057d5d2cba9bbd99f558a3a25fbf4f0d0e2971d4e249e8ab58001f123fee08e82c4ee116c38d849ae9ecafd5452c4416f319277e2c91bbabb
+  metadata.gz: 490c5af6b79552613745e6b8b01f53da8f3a3f861268cf854d905fcaa19f65994a4675b0669ee4174fcd2eb7b0367520651faefbf30fbb7864ab9aa0c40e5376
+  data.tar.gz: '08698a30dc4cb75f00b14b7fa18b2aebcffef02c7a5b86089e18449e472fe978db16e270bb7a3b115e996fa6eeebd26c12e89ceff980f8cd3e45d71ef1af319a'

data/lib/rservicebus2.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Add the currently running directory to the start of the load path
 # $:.unshift File.dirname(__FILE__) + '/../../lib'
 
@@ -19,7 +21,6 @@ require 'rservicebus2/mq'
 require 'rservicebus2/host'
 require 'rservicebus2/config'
 require 'rservicebus2/endpointmapping'
-require 'rservicebus2/stats'
 require 'rservicebus2/statistic_manager'
 require 'rservicebus2/audit'
 
@@ -45,10 +46,10 @@ require 'rservicebus2/monitor_configure'
 
 require 'rservicebus2/agent'
 
-require 'rservicebus2/saga_loader.rb'
-require 'rservicebus2/saga/manager.rb'
-require 'rservicebus2/saga/data.rb'
-require 'rservicebus2/saga/base.rb'
+require 'rservicebus2/saga_loader'
+require 'rservicebus2/saga/manager'
+require 'rservicebus2/saga/data'
+require 'rservicebus2/saga/base'
 
 require 'rservicebus2/saga_storage'
 

data/lib/rservicebus2/agent.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RServiceBus2
   class QueueNotFoundForMsg < StandardError
   end
@@ -22,17 +24,17 @@ module RServiceBus2
     # @param [Object] messageObj The msg to be sent
     # @param [String] queueName the name of the queue to be send the msg to
     # @param [String] returnAddress the name of a queue to send replies to
-    # rubocop:disable Metrics/AbcSize,Metrics/MethodLength
+    # rubocop:disable Metrics/MethodLength
     def send_msg(message_obj, queue_name, return_address = nil)
-      fail QueueNotFoundForMsg, message_obj.class.name if queue_name.nil?
+      raise QueueNotFoundForMsg, message_obj.class.name if queue_name.nil?
 
       msg = RServiceBus2::Message.new(message_obj, return_address)
       if queue_name.index('@').nil?
         q = queue_name
       else
         parts = queueName.split('@')
-        msg.set_remote_queue_name(parts[0])
-        msg.set_remote_host_name(parts[1])
+        msg.remote_queue_name = parts[0]
+        msg.remote_host_name = parts[1]
         q = 'transport-out'
       end
 
@@ -40,6 +42,7 @@ module RServiceBus2
 
       @mq.send(q, serialized_object)
     end
+    # rubocop:enable Metrics/MethodLength
 
     # Gives an agent the means to receive a reply
     #

data/lib/rservicebus2/appresource.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'uri'
 
 module RServiceBus2
@@ -8,7 +10,7 @@ module RServiceBus2
 
     # The method which actually connects to the resource.
     def connect(_uri)
-      fail 'Method, connect, needs to be implemented for resource'
+      raise 'Method, connect, needs to be implemented for resource'
     end
 
     def _connect
@@ -16,7 +18,7 @@ module RServiceBus2
       RServiceBus2.rlog "#{self.class.name}. Connected to, #{@uri}"
     end
 
-    def get_resource
+    def resource
       @connection
     end
 
@@ -44,22 +46,19 @@ module RServiceBus2
       rescue StandardError => e
         puts '** AppResource. An error was raised while closing connection
               to, ' + @uri
-        puts 'Message: ' + e.message
+        puts "Message: #{e.message}"
         puts e.backtrace
       end
       _connect
     end
 
     # Transaction Semantics
-    def begin
-    end
+    def begin; end
 
     # Transaction Semantics
-    def commit
-    end
+    def commit; end
 
     # Transaction Semantics
-    def rollback
-    end
+    def rollback; end
   end
 end

data/lib/rservicebus2/appresource/awss3.rb

@@ -1,16 +1,16 @@
+# frozen_string_literal: true
+
 require 'aws-sdk-s3'
 
 module RServiceBus2
   # AppResourceAWSDynamoDb
   class AppResourceAWSS3 < AppResource
-    # rubocop:disable Metrics/AbcSize,Metrics/MethodLength
     def connect(uri)
       region = uri.host
 
       Aws::S3::Client.new(region: region)
     end
 
-    def finished
-    end
+    def finished; end
   end
 end

data/lib/rservicebus2/appresource/awssqs.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'aws-sdk-sqs'
 require 'aws-sdk-sts'
 

data/lib/rservicebus2/appresource/dir.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RServiceBus2
   # AppResourceDir
   class AppResourceDir < AppResource
@@ -26,5 +28,6 @@ module RServiceBus2
 
       input_dir
     end
+    # rubocop:enable Metrics/AbcSize,Metrics/MethodLength
   end
 end

data/lib/rservicebus2/appresource/file.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RServiceBus2
   # App Resource File
   class AppResourceFile < AppResource

data/lib/rservicebus2/appresource/fluiddb.rb

@@ -1,4 +1,7 @@
+# frozen_string_literal: true
+
 require 'FluidDb/Db'
+
 module RServiceBus2
   # Implementation of an AppResource - FluidDb
   class AppResourceFluidDb < AppResource

data/lib/rservicebus2/appresource/fluiddb2.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'fluiddb2'
 
 module RServiceBus2
@@ -16,8 +18,8 @@ module RServiceBus2
     def commit
       @connection.commit
     end
-
     # Transaction Semantics
+
     def rollback
       @connection.rollback
     end

data/lib/rservicebus2/appresource_configure.rb

@@ -1,12 +1,14 @@
+# frozen_string_literal: true
+
 require 'uri'
 
 module RServiceBus2
   # Configure AppResources for an rservicebus host
   class ConfigureAppResource
-    # rubocop:disable Metrics/AbcSize,Metrics/MethodLength,CyclomaticComplexity
+    # rubocop:disable Metrics/AbcSize,Metrics/MethodLength,Metrics/CyclomaticComplexity,Metrics/PerceivedComplexity
     def get_resources(env, host, state_manager, saga_storage)
-      # rm = resource_manager
       rm = ResourceManager.new(state_manager, saga_storage)
+      # rubocop:disable Metrics/BlockLength
       env.each do |k, v|
         if v.is_a?(String) && k.start_with?('RSBFDB2_')
           uri = URI.parse(v)
@@ -15,8 +17,8 @@ module RServiceBus2
           k = k.sub('RSBFDB2_', '')
           rm.add k, AppResourceFluidDb2.new(host, uri)
         elsif v.is_a?(String) &&
-              (k.start_with?('RSBFDB_') || v.index('fluiddb') == 0)
-          v = v['fluiddb'.length..-1] if v.index('fluiddb') == 0
+              (k.start_with?('RSBFDB_') || v.start_with?('fluiddb'))
+          v = v['fluiddb'.length..-1] if v.start_with?('fluiddb')
           uri = URI.parse(v)
           require 'rservicebus2/appresource/fluiddb'
 
@@ -46,8 +48,10 @@ module RServiceBus2
           end
         end
       end
+      # rubocop:enable Metrics/BlockLength
 
       rm
     end
+    # rubocop:enable Metrics/AbcSize,Metrics/MethodLength,Metrics/CyclomaticComplexity,Metrics/PerceivedComplexity
   end
 end

data/lib/rservicebus2/audit.rb

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 module RServiceBus2
   # Audit Class
   class Audit
-    def initialize(mq)
-      @mq = mq
+    def initialize(message_queue)
+      @mq = message_queue
       audit_queue_name = RServiceBus2.get_value('AUDIT_QUEUE_NAME')
       if audit_queue_name.nil?
         @sent_messages_to = RServiceBus2.get_value('sent_messages_to')

data/lib/rservicebus2/circuitbreaker.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RServiceBus2
   class MessageArrivedWhileCricuitBroken < StandardError
   end
@@ -42,7 +44,7 @@ module RServiceBus2
       message_arrived
 
       ## logFirstFailure
-      if @number_of_failures == 0
+      if @number_of_failures.zero?
         @number_of_failures = 1
         @time_of_first_failure = Time.now
         @time_to_break = @time_of_first_failure + @seconds_to_break
@@ -68,7 +70,7 @@ module RServiceBus2
     def message_arrived
       reset if !@time_to_break.nil? && Time.now > @time_to_break
 
-      fail MessageArrivedWhileCricuitBroken if @broken == true
+      raise MessageArrivedWhileCricuitBroken if @broken == true
     end
 
     def break_circuit

data/lib/rservicebus2/config.rb

@@ -1,5 +1,8 @@
+# frozen_string_literal: true
+
 module RServiceBus2
   # Marshals configuration information for an rservicebus host
+  # rubocop:disable Metrics/ClassLength
   class Config
     attr_reader :app_name, :message_endpoint_mappings, :handler_path_list,
                 :saga_path_list, :error_queue_name, :max_retries,
@@ -19,7 +22,7 @@ module RServiceBus2
     end
 
     def get_value(name, default = nil)
-      value = (ENV[name].nil? || ENV[name] == '') ? default : ENV[name]
+      value = ENV[name].nil? || ENV[name] == '' ? default : ENV[name]
       log "Env value: #{name}: #{value}"
       value
     end
@@ -47,6 +50,7 @@ module RServiceBus2
       self
     end
 
+    # rubocop:disable Metrics/MethodLength
     def load_host_section
       @app_name = get_value('APPNAME', 'RServiceBus2')
       @error_queue_name = get_value('ERROR_QUEUE_NAME', 'error')
@@ -66,6 +70,7 @@ module RServiceBus2
 
       self
     end
+    # rubocop:enable Metrics/MethodLength
 
     def ensure_contract_file_exists(path)
       unless File.exist?(path) || File.exist?("#{path}.rb")
@@ -73,11 +78,11 @@ module RServiceBus2
         puts "*** path, #{path}, provided does not exist as a file"
         abort
       end
-      unless File.extname(path) == '' || File.extname(path) == '.rb'
-        puts 'Error while processing contracts'
-        puts "*** path, #{path}, should point to a ruby file, with extention .rb"
-        abort
-      end
+      return if File.extname(path) == '.rb'
+
+      puts 'Error while processing contracts'
+      puts "*** path, #{path}, should point to a ruby file, with extention .rb"
+      abort
     end
 
     # Marshals paths for contracts
@@ -100,6 +105,16 @@ module RServiceBus2
     # Marshals paths for lib
     # Note. .rb extension is optional
     # Expected format: /one/two/contracts
+    def load_lib(path)
+      log "Loading libs from, #{path}"
+      return path if File.exist?(path)
+
+      puts 'Error while processing libs'
+      puts "*** path, #{path}, should point to a ruby file, with extention .rb, or"
+      puts "*** path, #{path}, should point to a directory than conatins ruby files, that have extention .rb"
+      abort
+    end
+
     def load_libs
       @lib_list = []
 
@@ -107,18 +122,7 @@ module RServiceBus2
       paths = './lib' if paths.nil? && File.exist?('./lib')
       return self if paths.nil?
 
-      paths.split(';').each do |path|
-        log "Loading libs from, #{path}"
-        unless File.exist?(path)
-          puts 'Error while processing libs'
-          puts "*** path, #{path}, should point to a ruby file, with extention
-                .rb, or"
-          puts "*** path, #{path}, should point to a directory than conatins
-                ruby files, that have extention .rb"
-          abort
-        end
-        @lib_list << path
-      end
+      paths.split(';').each { |path| @lib_list << load_lib(path) }
       self
     end
 
@@ -130,38 +134,43 @@ module RServiceBus2
     # Marshals paths for working_dirs
     # Note. trailing slashs will be stripped
     # Expected format: <path 1>;<path 2>
+    def load_working_dir_path(path)
+      path = path.strip.chomp('/')
+      unless Dir.exist?(path.to_s)
+        puts 'Error while processing working directory list'
+        puts "*** path, #{path}, does not exist"
+        abort
+      end
+      @handler_path_list << "#{path}/messagehandler" if Dir.exist?("#{path}/messagehandler")
+      @saga_path_list << "#{path}/saga" if Dir.exist?("#{path}/saga")
+      @contract_list << "#{path}/contract.rb" if File.exist?("#{path}/contract.rb")
+      @lib_list << "#{path}/lib" if File.exist?("#{path}/lib")
+    end
+
     def load_working_dir_list
-      puts "Config.load_working_dir_list.1"
-      puts "Config.load_working_dir_list.2 #{@contract_list}"
       path_list = get_value('WORKING_DIR', './')
       return self if path_list.nil?
 
       path_list.split(';').each do |path|
-        path = path.strip.chomp('/')
-        unless Dir.exist?("#{path}")
-          puts 'Error while processing working directory list'
-          puts "*** path, #{path}, does not exist"
-          abort
-        end
-        @handler_path_list << "#{path}/messagehandler" if Dir.exist?("#{path}/messagehandler")
-        @saga_path_list << "#{path}/saga" if Dir.exist?("#{path}/saga")
-        @contract_list << "#{path}/contract.rb" if File.exist?( "#{path}/contract.rb" )
-        @lib_list << "#{path}/lib" if File.exist?("#{path}/lib")
+        load_working_dir_path(path)
       end
       self
     end
   end
+  # rubocop:enable Metrics/ClassLength
 
   # Class
+  # rubocop:disable Lint/MissingSuper
   class ConfigFromEnv < Config
-    def initialize
-    end
+    def initialize; end
   end
 
   # Class
   class ConfigFromSetter < Config
-    attr_writer :appName, :messageEndpointMappings, :handler_path_list, :errorQueueName, :maxRetries, :forward_received_messages_to, :beanstalkHost
-    def initialize
-    end
+    attr_writer :app_name, :message_endpoint_mappings, :handler_path_list, :error_queue_name, \
+                :max_retries, :forward_received_messages_to, :beanstalk_host
+
+    def initialize; end
   end
+  # rubocop:enable Lint/MissingSuper
 end

data/lib/rservicebus2/cron_manager.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'parse-cron'
 
 module RServiceBus2
@@ -27,7 +29,8 @@ module RServiceBus2
       @msg_names.each do |n|
         list << n if Globber.new(name) =~ n
       end
-      fail NoMatchingMsgForCron, name if list.length == 0
+      raise NoMatchingMsgForCron, name if list.empty?
+
       list
     end
 
@@ -44,6 +47,7 @@ module RServiceBus2
       end
     end
 
+    # rubocop:disable Metrics/MethodLength
     def initialize(host, msg_names = [])
       @bus = host
       @msg_names = msg_names
@@ -61,6 +65,7 @@ module RServiceBus2
         end
       end
     end
+    # rubocop:enable Metrics/MethodLength
 
     def run
       now = Time.now