rservicebus2 0.2.13 → 0.2.19

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 51c1a3dd6e3b22da8216ba061cb1572a5dd29475353c0b10ea470bdda7d7e3f7
-  data.tar.gz: 3952dfc273048ca7cecd3dca0179891d8d9bcc341e137b3212ce611c10523681
+  metadata.gz: 40740ce5d75540b3c751035c3b36e9829c14cae0decfaafeaca9ea02d59c775d
+  data.tar.gz: 52ad2edd143b3b5248a44510412265d86fd64c16cd1777a69d970203ba5be239
 SHA512:
-  metadata.gz: 0ed0ba711726a1641c1c3fab6811843f826633caca5c3061d5d223731313cc0138f182842768bece201041001a081ba899261bbbde5a0415fdeadd4252127ef5
-  data.tar.gz: 3976c2ec0eb733817f5b364bd0ee788a9ce1d13c2ff48c08694c5df916441d38ba6bbbfa6f0e8822a1143f51a00b53fd037ef9194a5e1fde969c8f75b0672aa4
+  metadata.gz: af23a4c627e06a151acee10fc4a1be2582195d0df9f7d38bd127c446802a79dbdbb0e82cf9a22a9d2df2ffd572b6e1654bb42706eb5a2bf4a6c1f4b66d336b26
+  data.tar.gz: 27003eec5f598361137ee0d187a4432fd91e1f1a2c19aebd724ae727adb47cc8018ec25ecd2e0d339d5acefe52fd4035646c52992374a7bf15cd3ffa1cf8643c

data/lib/rservicebus2/appresource.rb

@@ -33,7 +33,7 @@ module RServiceBus2
       finished
     end
 
-    # A notification that ocurs after getResource, to allow cleanup
+    # Allow for cleanup, outside of transaction semantics
     def finished
       @connection.close
     end
@@ -53,12 +53,18 @@ module RServiceBus2
     end
 
     # Transaction Semantics
-    def begin; end
+    def begin
+      RServiceBus2.rlog "#{self.class.name}. Default transaction.begin called"
+    end
 
     # Transaction Semantics
-    def commit; end
+    def commit
+      RServiceBus2.rlog "#{self.class.name}. Default transaction.commit called"
+    end
 
     # Transaction Semantics
-    def rollback; end
+    def rollback
+      RServiceBus2.rlog "#{self.class.name}. Default transaction.rollback called"
+    end
   end
 end

data/lib/rservicebus2/appresource/awsdynamodb.rb

@@ -11,6 +11,8 @@ module RServiceBus2
       Aws::DynamoDB::Client.new(region: region)
     end
 
-    def finished; end
+    def finished
+      RServiceBus2.rlog "#{self.class.name}. Finished"
+    end
   end
 end

data/lib/rservicebus2/appresource/awss3.rb

@@ -11,6 +11,8 @@ module RServiceBus2
       Aws::S3::Client.new(region: region)
     end
 
-    def finished; end
+    def finished
+      RServiceBus2.rlog "#{self.class.name}. Finished"
+    end
   end
 end

data/lib/rservicebus2/appresource/awssqs.rb

@@ -22,6 +22,8 @@ module RServiceBus2
       }
     end
 
-    def finished; end
+    def finished
+      RServiceBus2.rlog "#{self.class.name}. Finished"
+    end
   end
 end

data/lib/rservicebus2/appresource/fluiddb2.rb

@@ -18,8 +18,8 @@ module RServiceBus2
     def commit
       @connection.commit
     end
-    # Transaction Semantics
 
+    # Transaction Semantics
     def rollback
       @connection.rollback
     end

data/lib/rservicebus2/host.rb

@@ -252,18 +252,30 @@ module RServiceBus2
           message_loop = false
         rescue NoMsgToProcess => e
           # This exception is just saying there are no messages to process
-          @queue_for_msgs_to_be_sent_on_complete = []
-          @monitors.each(&:look)
-          send_queued_msgs
-          @queue_for_msgs_to_be_sent_on_complete = nil
-
-          @queue_for_msgs_to_be_sent_on_complete = []
-          @cron_manager.run
-          send_queued_msgs
-          @queue_for_msgs_to_be_sent_on_complete = nil
-
-          @send_at_manager.process
-          @circuit_breaker.success
+          begin
+            @queue_for_msgs_to_be_sent_on_complete = []
+            @monitors.each(&:look)
+            send_queued_msgs
+            @queue_for_msgs_to_be_sent_on_complete = nil
+
+            @queue_for_msgs_to_be_sent_on_complete = []
+            @cron_manager.run
+            send_queued_msgs
+            @queue_for_msgs_to_be_sent_on_complete = nil
+
+            @send_at_manager.process
+            @circuit_breaker.success
+          rescue StandardError => e
+            if e.message == 'SIGTERM' || e.message == 'SIGINT'
+              puts 'Exiting on request ...'
+              message_loop = false
+            else
+              puts '*** This is really unexpected.'
+              message_loop = false
+              puts "Message: #{e.message}"
+              puts e.backtrace
+            end
+          end
         rescue StandardError => e
           if e.message == 'SIGTERM' || e.message == 'SIGINT'
             puts 'Exiting on request ...'

data/lib/rservicebus2/monitor.rb

@@ -36,7 +36,9 @@ module RServiceBus2
     end
 
     # A notification that allows cleanup
-    def finished; end
+    def finished
+      RServiceBus2.rlog "#{self.class.name}. Default Finished"
+    end
 
     # At least called in the Host rescue block, to ensure all network links
     #  are healthy

data/lib/rservicebus2/monitor/beanstalk.rb

@@ -0,0 +1,53 @@
+# frozen_string_literal: true
+
+require 'beanstalk-client'
+require 'cgi'
+
+module RServiceBus2
+  # Monitor S3 Bucket for objects
+  class MonitorBeanstalk < Monitor
+    def deduce_timeout(uri)
+      return 5 if uri.query.nil?
+
+      CGI.parse(u.query)['timeout1']&.first || 5
+    end
+
+    # rubocop:disable Metrics/MethodLength,Metrics/AbcSize
+    def connect(uri)
+      @uri = uri
+      @timeout = deduce_timeout(uri)
+
+      queue_name = uri.path.sub('/', '')
+
+      port ||= 11_300
+      connection_string = "#{uri.host}:#{port}"
+      @beanstalk = Beanstalk::Pool.new([connection_string])
+
+      @beanstalk.watch(queue_name)
+      @message_uri = "beanstalk://#{uri.host}:#{port}/#{queue_name}"
+    rescue StandardError => e
+      puts "Error connecting to Beanstalk, Host string, #{connection_string}"
+      if e.message == 'Beanstalk::NotConnected'
+        puts '***Most likely, beanstalk is not running. Start beanstalk, and try running this again.\n' \
+             "***If you still get this error, check beanstalk is running at, #{connection_string}"
+        abort
+      end
+
+      puts e.message
+      puts e.backtrace
+    end
+    # rubocop:enable Metrics/MethodLength,Metrics/AbcSize
+
+    def look
+      job = @beanstalk.reserve @timeout
+      send(job.body, "#{@message_uri}/#{job.id}")
+      job_body = job.body
+      job.delete
+      job_body
+    rescue StandardError => e
+      return if e.message == 'TIMED_OUT'
+
+      raise e
+    end
+  end
+end

data/lib/rservicebus2/monitor/dir.rb

@@ -9,6 +9,7 @@ module RServiceBus2
 
   # rubocop:disable Metrics/ClassLength
   class MonitorDir < Monitor
+    # rubocop:disable Metrics/MethodLength,Metrics/AbcSize
     def input_dir(uri)
       # Pass the path through the Dir object to check syntax on startup
       return Dir.new(uri.path) if File.writable?(uri.path)
@@ -27,44 +28,48 @@ module RServiceBus2
             "***** eg, rm #{uri.path} && mkdir #{uri.path}"
       abort
     end
+    # rubocop:enable Metrics/MethodLength,Metrics/AbcSize
 
-    def connect(uri)
-      @path = input_dir(uri).path
-      @input_filter = []
-
-      return if uri.query.nil?
+    def initialise_archive(parts)
+      return unless parts.key?('archive')
 
-      parts = CGI.parse(uri.query)
-      @querystringparts = parts
-      if parts.key?('archive')
-        archiveuri = URI.parse(parts['archive'][0])
-        unless File.directory?(archiveuri.path)
-          puts '***** Archive file name templating not yet supported.'
-          puts "***** Directory's only."
-          abort
-        end
-        @archivedir = archiveuri.path
+      archiveuri = URI.parse(parts['archive'][0])
+      unless File.directory?(archiveuri.path)
+        puts '***** Archive file name templating not yet supported.'
+        puts "***** Directory's only."
+        abort
       end
+      @archivedir = archiveuri.path
+    end
 
-      return unless parts.key?('input_filter')
-
+    def initialise_input_filter(parts)
       if parts['input_filter'].count > 1
-        puts 'Too many input_filters specified.'
-        puts '*** ZIP, or GZ are the only valid input_filters.'
+        puts 'Too many input_filters specified.\n*** ZIP, or GZ are the only valid input_filters.'
         abort
       end
 
-      if parts['input_filter'][0] == 'ZIP'
-      elsif parts['input_filter'][0] == 'GZ'
-      elsif parts['input_filter'][0] == 'TAR'
-      else
-        puts 'Invalid input_filter specified.'
-        puts '*** ZIP, or GZ are the only valid input_filters.'
+      unless %w[ZIP GZ TAR].include?(parts['input_filter'][0]).nil?
+        puts 'Invalid input_filter specified.\n' \
+             '*** ZIP, or GZ are the only valid input_filters.'
         abort
       end
+
       @input_filter << parts['input_filter'][0]
     end
 
+    def connect(uri)
+      @path = input_dir(uri).path
+      @input_filter = []
+
+      return if uri.query.nil?
+
+      parts = CGI.parse(uri.query)
+      @querystringparts = parts
+      initialise_archive(parts)
+
+      initialise_input_filter(parts) if parts.key?('input_filter')
+    end
+
     def process_content(content)
       content
     end
@@ -86,13 +91,14 @@ module RServiceBus2
     # rubocop:disable Metrics/MethodLength
     def read_content_from_file(file_path)
       content = ''
-      if @input_filter.length > 0
-        if @input_filter[0] == 'ZIP'
+      if @input_filter.length.positive?
+        case @input_filter[0]
+        when 'ZIP'
           content = read_content_from_zip_file(file_path)
-        elsif @input_filter[0] == 'GZ'
+        when 'GZ'
           content = read_content_from_gz_file(file_path)
-        elsif @input_filter[0] == 'TAR'
-          fail 'TAR reader not implemented'
+        else
+          raise "#{@input_filter[0]} reader not implemented."
         end
 
       else
@@ -101,13 +107,34 @@ module RServiceBus2
 
       content
     end
+    # rubocop:enable Metrics/MethodLength
+
+    def archive_file(file_path, content)
+      basename = File.basename(file_path)
+      new_file_path = "#{@archivedir}/#{basename}.#{Time.now.strftime('%Y%m%d%H%M%S%L')}.zip"
+      RServiceBus2.log "Writing to archive, #{new_file_path}"
+
+      Zip::ZipOutputStream.open(new_file_path) do |zos|
+        zos.put_next_entry(basename)
+        zos.puts content
+      end
+    end
 
     def process_path(file_path)
+      if File.file?(file_path) != true
+        RServiceBus2.log "Skipping directory, #{file_path}"
+        return
+      end
+
+      RServiceBus2.log "Ready to process, #{file_path}"
       content = read_content_from_file(file_path)
       payload = process_content(content)
 
-      send(payload, URI.parse(URI.encode("file://#{file_path}")))
-      content
+      send(payload, URI.parse(CGI.escape("file://#{file_path}")))
+
+      archive_file(file_path, content) unless @archivedir.nil?
+
+      File.unlink(file_path)
     end
 
     def look
@@ -116,28 +143,11 @@ module RServiceBus2
 
       file_list = Dir.glob("#{@path}/*")
       file_list.each do |file_path|
-        if File.file?(file_path) != true
-          RServiceBus2.log "Skipping directory, #{file_path}"
-          next
-        end
-        RServiceBus2.log "Ready to process, #{file_path}"
-        content = process_path(file_path)
-
-        unless @archivedir.nil?
-          basename = File.basename(file_path)
-          new_file_path = "#{@archivedir}/#{basename}.#{Time.now.strftime('%Y%m%d%H%M%S%L')}.zip"
-          RServiceBus2.log "Writing to archive, #{new_file_path}"
-
-          Zip::ZipOutputStream.open(new_file_path) do |zos|
-            zos.put_next_entry(basename)
-            zos.puts content
-          end
-        end
-        File.unlink(file_path)
+        process_path(file_path)
 
         file_processed += 1
-        RServiceBus2.log "Processed #{file_processed} of #{file_list.length}."
-        RServiceBus2.log "Allow system tick #{self.class.name}"
+        RServiceBus2.log "Processed #{file_processed} of #{file_list.length}.\nAllow system tick #{self.class.name}"
+
         break if file_processed >= max_files_processed
       end
     end

data/lib/rservicebus2/monitor/dirnotifier.rb

@@ -9,78 +9,54 @@ module RServiceBus2
   class MonitorDirNotifier < Monitor
     attr_reader :path, :processing_folder, :filter
 
-    def connect(uri)
-      # Pass the path through the Dir object to check syntax on startup
-      begin
-        open_folder uri.path
-        unless File.writable?(uri.path)
-          puts "***** Directory is not writable, #{uri.path}."
-          puts "***** Make the directory, #{uri.path}, writable and try again."
-          abort
-        end
-      rescue Errno::ENOENT
-        puts "***** Directory does not exist, #{uri.path}."
-        puts "***** Create the directory, #{uri.path}, and try again."
-        puts "***** eg, mkdir #{uri.path}"
-        abort
-      rescue Errno::ENOTDIR
-        puts "***** The specified path does not point to a directory,
-              #{uri.path}."
-        puts "***** Either repoint path to a directory, or remove, #{uri.path},
-              and create it as a directory."
-        puts "***** eg, rm #{uri.path} && mkdir #{uri.path}"
-        abort
-      end
+    def validate_directory(path, param_name)
+      open_folder path
+      return if File.writable?(path)
 
-      @path = uri.path
+      puts "***** #{param_name} is not writable, #{path}.\n
+           ***** Make the directory, #{path}, writable and try again."
+      abort
+    rescue Errno::ENOENT
+      puts "***** #{param_name} does not exist, #{path}.\n" \
+           "***** Create the directory, #{path}, and try again.\n" \
+           "***** eg, mkdir #{path}"
+      abort
+    rescue Errno::ENOTDIR
+      puts "***** The specified path does not point to a directory, #{path}.
+           ***** Either repoint path to a directory, or remove, #{path}, and create it as a directory.
+           ***** eg, rm #{path} && mkdir #{path}"
+      abort
+    end
 
+    def validate_processing_directory(uri)
       if uri.query.nil?
-        puts '***** Processing Directory is not specified.'
-        puts '***** Specify the Processing Directory as a query string in the
-              Path URI'
-        puts "***** eg, '/#{uri.path}?processing=*ProcessingDir*"
+        puts '***** Processing Directory is not specified.' \
+             '***** Specify the Processing Directory as a query string in the Path URI' \
+             "***** eg, '/#{uri.path}?processing=*ProcessingDir*'"
         abort
-      else
-        parts = CGI.parse(uri.query)
+      end
 
-        if parts.key? 'processing'
-          processing_uri = URI.parse parts['processing'][0]
-          begin
-            open_folder processing_uri.path
-            unless File.writable?(processing_uri.path)
-              puts "***** 1Processing Directory is not writable,
-                    #{processing_uri.path}."
-              puts "***** Make the directory, #{processing_uri.path},
-                    writable and try again."
-              abort
-            end
-          rescue Errno::ENOENT
-            puts "***** Processing Directory does not exist,
-                  #{processing_uri.path}."
-            puts "***** Create the directory, #{processing_uri.path}, and try
-                  again."
-            puts "***** eg, mkdir #{processing_uri.path}"
-            abort
-          rescue Errno::ENOTDIR
-            puts "***** Processing Directory does not point to a directory,
-                  #{processing_uri.path}."
-            puts "***** Either repoint path to a directory, or remove,
-                  #{processing_uri.path}, and create it as a directory."
-            puts "***** eg, rm #{processing_uri.path} && mkdir
-                  #{processing_uri.path}"
-            abort
-          end
+      parts = CGI.parse(uri.query)
+      return unless parts.key? 'processing'
 
-          @processing_folder = processing_uri.path
-        end
+      processing_uri = URI.parse parts['processing'][0]
+      validate_directory processing_uri.path, 'Processing Directory'
+      @processing_folder = processing_uri.path
+    end
 
-        @filter = '*'
-        @filter = parts['filter'][0] if parts.key? 'filter'
-      end
+    def connect(uri)
+      # Pass the path through the Dir object to check syntax on startup
+
+      validate_directory uri, 'Directory'
+      @path = uri.path
+      validate_processing_directory(uri)
+
+      @filter = '*'
+      @filter = parts['filter'][0] if parts.key? 'filter'
     end
 
     def look
-      file_list = get_files
+      file_list = files
       file_list.each do |file_path|
         new_path = move_file(file_path, @processing_folder)
         send(nil, URI.parse("file://#{new_path}"))
@@ -97,8 +73,8 @@ module RServiceBus2
       Pathname.new(dest).join(filename)
     end
 
-    def get_files
-      Dir.glob(Pathname.new("#{@Path}").join(@Filter) ).select { |f| File.file?(f) }
+    def files
+      Dir.glob(Pathname.new(@path).join(@filter)).select { |f| File.file?(f) }
     end
   end
 end

data/lib/rservicebus2/monitor_configure.rb

@@ -57,6 +57,9 @@ module RServiceBus2
       when 'dirnotifier'
         require 'rservicebus2/monitor/dirnotifier'
         monitor = MonitorDirNotifier.new(@host, name, uri)
+      when 'beanstalk'
+        require 'rservicebus2/monitor/beanstalk'
+        monitor = MonitorBeanstalk.new(@host, name, uri)
       else
         abort("Scheme, #{uri.scheme}, not recognised when configuring
           Monitor, #{key}=#{val}")

data/lib/rservicebus2/mq/aws.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'aws-sdk-sqs'
 require 'aws-sdk-sts'
 require 'rservicebus2/mq'
@@ -6,75 +8,59 @@ module RServiceBus2
   # Beanstalk client implementation.
   class MQAWS < MQ
     # Connect to the broker
-    # rubocop:disable Metrics/AbcSize,Metrics/MethodLength
-    def connect(region, port)
-      begin
-        @max_job_size = 4_194_304
-        @region = region
+    def connect(region, _port)
+      @max_job_size = 4_194_304
+      @region = region
 
-        sts_client = Aws::STS::Client.new(region: region)
-        @caller_identity_account = sts_client.get_caller_identity.account
-      rescue StandardError => e
-        puts 'Error connecting to AWS'
-        puts "Host string, #{region}"
-        puts e.message
-        puts e.backtrace
-        abort
-      end
+      sts_client = Aws::STS::Client.new(region: region)
+      @caller_identity_account = sts_client.get_caller_identity.account
+    rescue StandardError => e
+      puts 'Error connecting to AWS'
+      puts "Host string, #{region}"
+      puts e.message
+      puts e.backtrace
+      abort
     end
 
     def subscribe(queuename)
       # For example:
       # 'https://sqs.us-east-1.amazonaws.com/111111111111/my-queue'
-      @queue_url = 'https://sqs.' + @region + '.amazonaws.com/' +
-        @caller_identity_account + '/' + queuename
+      @queue_url = "https://sqs.#{@region}.amazonaws.com/#{@caller_identity_account}/#{queuename}"
       @sqs_client = Aws::SQS::Client.new(region: @region)
     end
 
     # Get next msg from queue
     def pop
-      begin
-        response = @sqs_client.receive_message(
-          queue_url: @queue_url,
-          max_number_of_messages: 1
-        )
+      response = @sqs_client.receive_message(queue_url: @queue_url, max_number_of_messages: 1)
 
-        if response.messages.count.zero?
-          raise NoMsgToProcess
-        end
+      raise NoMsgToProcess if response.messages.count.zero?
 
-        response.messages.each do |message|
-          @job = message
-        end
-      rescue StandardError => e
-        raise e
+      response.messages.each do |message|
+        @job = message
       end
+    rescue StandardError => e
+      raise e
+    ensure
       @job.body
     end
 
     def return_to_queue
-#      @job.release if @job
       @job = nil
     end
 
     def ack
-      @sqs_client.delete_message({
-        queue_url: @queue_url,
-        receipt_handle: @job.receipt_handle
-      })
+      @sqs_client.delete_message({ queue_url: @queue_url, receipt_handle: @job.receipt_handle })
       @job = nil
     end
 
     def send(queue_name, msg)
       if msg.length > @max_job_size
-        puts '***Attempting to send a msg which will not fit on queue.'
-        puts "***Msg size, #{msg.length}, max msg size, #{@max_job_size}."
-        fail JobTooBigError, "Msg size, #{msg.length}, max msg size,
-              #{@max_job_size}"
+        puts '***Attempting to send a msg which will not fit on queue.' \
+             "***Msg size, #{msg.length}, max msg size, #{@max_job_size}."
+        raise JobTooBigError, "Msg size, #{msg.length}, max msg size, #{@max_job_size}"
       end
 
-      queue_url = 'https://sqs.' + @region + '.amazonaws.com/' +
-        @caller_identity_account + '/' + queue_name
+      queue_url = "https://sqs.#{@region}.amazonaws.com/#{@caller_identity_account}/#{queue_name}"
 
       @sqs_client.send_message(
         queue_url: queue_url,

data/lib/rservicebus2/mq/beanstalk.rb

@@ -16,19 +16,17 @@ module RServiceBus2
         @beanstalk = Beanstalk::Pool.new([string])
         @max_job_size = @beanstalk.stats['max-job-size']
         if @max_job_size < 4_194_304
-          puts "***WARNING: Lowest recommended.max-job-size is 4m, current
-                max-job-size, #{@max_job_size.to_f / (1024 * 1024)}m"
-          puts '***WARNING: Set the job size with the -z switch, eg
-                /usr/local/bin/beanstalkd -z 4194304'
+          puts '***WARNING: Lowest recommended.max-job-size is 4m, current ' \
+                "max-job-size, #{@max_job_size.to_f / (1024 * 1024)}m"
+          puts '***WARNING: Set the job size with the -z switch, eg ' \
+                '/usr/local/bin/beanstalkd -z 4194304'
         end
       rescue StandardError => e
         puts 'Error connecting to Beanstalk'
         puts "Host string, #{string}"
         if e.message == 'Beanstalk::NotConnected'
-          puts '***Most likely, beanstalk is not running. Start beanstalk,
-                  and try running this again.'
-          puts "***If you still get this error, check beanstalk is running
-                  at, #{string}"
+          puts '***Most likely, beanstalk is not running. Start beanstalk, and try running this again.'
+          puts "***If you still get this error, check beanstalk is running at, #{string}"
         else
           puts e.message
           puts e.backtrace

data/lib/rservicebus2/mq/file.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'fileutils'
 require 'rservicebus2/mq'
 
@@ -5,18 +7,10 @@ module RServiceBus2
   # Beanstalk client implementation.
   class MQFile < MQ
     # Connect to the broker
-    # rubocop:disable Metrics/AbcSize,Metrics/MethodLength
-    
+
     def initialize(uri)
-      if uri.is_a? URI
-        @uri = uri
-      else
-        puts 'uri must be a valid URI'
-        abort
-      end
+      super
 
-      FileUtils.mkdir_p(@uri.path)
-      @local_queue_name = RServiceBus2.get_value('APPNAME', 'RServiceBus')
       FileUtils.mkdir_p("#{@uri.path}/#{@local_queue_name}")
       @timeout = RServiceBus2.get_value('QUEUE_TIMEOUT', '5').to_i
     end
@@ -28,24 +22,23 @@ module RServiceBus2
     end
 
     # Get next msg from queue
+    # rubocop:disable Metrics/MethodLength
     def pop
       time = @timeout
-      while time > 0
+      while time.positive?
         files = Dir.glob("#{@uri.path}/#{@local_queue_name}/*.msg")
-        if files.length > 0
-          @file_path = files[0] 
+        if files.positive?
+          @file_path = files[0]
           @body = IO.read(@file_path)
-	  return @body
+          return @body
         end
-	time -= 1
-	sleep(1)
+        time -= 1
+        sleep(1)
       end
-	
-      raise NoMsgToProcess if files.length == 0
-    end
 
-    def return_to_queue
+      raise NoMsgToProcess if files.length.zero?
     end
+    # rubocop:enable Metrics/MethodLength
 
     def ack
       FileUtils.rm @file_path
@@ -53,7 +46,7 @@ module RServiceBus2
 
     def send(queue_name, msg)
       FileUtils.mkdir_p("#{@uri.path}/#{queue_name}")
-      IO.write("#{@uri.path}/#{queue_name}/#{rand()}.msg", msg)
+      IO.write("#{@uri.path}/#{queue_name}/#{rand}.msg", msg)
     end
   end
 end

data/lib/rservicebus2/mq/redis.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'redis'
 require 'rservicebus2/mq'
 
@@ -5,38 +7,31 @@ module RServiceBus2
   # Redis client implementation.
   class MQRedis < MQ
     # Connect to the broker
-    # rubocop:disable Metrics/AbcSize,Metrics/MethodLength
     def connect(host, port)
       port ||= 6379
       string = "#{host}:#{port}"
 
-      begin
-        @redis = Redis.new(:host => host, :port => port)
-
-      rescue Exception => e
-        puts e.message
-        puts 'Error connecting to Redis for mq'
-        puts "Host string, #{string}"
-        abort()
-      end
+      @redis = Redis.new(host: host, port: port)
+    rescue StandardError => e
+      puts e.message
+      puts 'Error connecting to Redis for mq'
+      puts "Host string, #{string}"
+      abort
     end
 
     # Connect to the queue
-    def subscribe( queuename )
+    def subscribe(queuename)
       @queuename = queuename
     end
 
     # Get next msg from queue
     def pop
-      if @redis.llen( @queuename ) == 0 then
+      if @redis.llen(@queuename).zero?
         sleep @timeout
-        raise NoMsgToProcess.new
+        raise NoMsgToProcess
       end
 
-      return @redis.lindex @queuename, 0
-    end
-
-    def returnToQueue
+      @redis.lindex @queuename, 0
     end
 
     # "Commit" queue
@@ -45,9 +40,8 @@ module RServiceBus2
     end
 
     # At least called in the Host rescue block, to ensure all network links are healthy
-    def send( queueName, msg )
-      @redis.rpush queueName, msg
+    def send(queue_name, msg)
+      @redis.rpush queue_name, msg
     end
-
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rservicebus2
 version: !ruby/object:Gem::Version
-  version: 0.2.13
+  version: 0.2.19
 platform: ruby
 authors:
 - Guy Irvine
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-05-13 00:00:00.000000000 Z
+date: 2021-05-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: beanstalk-client
@@ -129,6 +129,7 @@ files:
 - lib/rservicebus2/monitor.rb
 - lib/rservicebus2/monitor/awss3.rb
 - lib/rservicebus2/monitor/awssqs.rb
+- lib/rservicebus2/monitor/beanstalk.rb
 - lib/rservicebus2/monitor/dir.rb
 - lib/rservicebus2/monitor/dirnotifier.rb
 - lib/rservicebus2/monitor/message.rb