rrssb-rails 0.0.1 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e8cc41fed7b1be9c9d1e38b3161ba22804dd1377
-  data.tar.gz: 85a82241971754258abe8b4ef59230574a2cc98a
+  metadata.gz: d88e5025e5bd3ad877194b62c21981ff3ce14698
+  data.tar.gz: bf2fcc9b6d5d1ecc162d7a59ad854f6f83e084d3
 SHA512:
-  metadata.gz: 7b1a23e1bbec4bda803b80d6caa6d65c0788c1cb77f6938a314e614eb59c04d719249b6fd163e78a83d1529e7894677db3946568f13f55401e323de0402c2f49
-  data.tar.gz: 7be4b98801006b0e2763dec5507465a86e3cf1353fdeadab43a97631318bf02997d4c7e7694d0347f39f84db5a172e817867288d4ce75853cd1bd71edb2a4f02
+  metadata.gz: e85de7cf88f12d6b229f99fb4b30da3eb791bd90f18f0da119be3d85ab2b0a7fd74b652b5d296c1ef8491350dad2f14845184c71a9462ed4bebb6bc306d75836
+  data.tar.gz: 2e6db7fe1e8b288fb3c5af2dc502da940263541f85a30b399286e5dac29bcf3120cd7130dd069f373197d8fecd049920171e8af84d973bbcf7b76c4eb16a146f

data/README.md

@@ -49,7 +49,7 @@ You can use the helper `rrssb_tag` to generate and customize your social share b
 
 ```ruby
 rrssb_tag(url: 'http://my_url.com', buttons: %w{facebook twitter google_plus})
-# => Generate 3 responsive social share button for facebook, twitter and google+ in this order
+# => Generate 3 responsive social share buttons for facebook, twitter and google+ in this order
 ```
 
 For more information, see the dummy rails application available in `/test`.

data/app/helpers/rrssb/rails/buttons_helper.rb

@@ -3,7 +3,6 @@ module Rrssb
   	module ButtonsHelper
   	  def rrssb_tag(opts={})
   	  	buttons  = opts[:buttons]  || []
-  	  	url      = opts.delete(:url) { '#' }
   	  	contents = opts[:contents] || {}
 
   	  	html = []
@@ -13,20 +12,20 @@ module Rrssb
   	  	  html << "<li class='rrssb-#{button.gsub(/[_-]/,'')}'>"
   	  	  html << case button
   	  	    when 'email'
-  	  	      label   = content.delete(:label) { button }
-  	  	      subject = content.delete(:subject) { nil }
-  	  	      cc      = content.delete(:cc) { nil }
-  	  	      to      = content.delete(:to) { nil }
+  	  	      label   = content[:label] || button
+  	  	      subject = content[:subject]
+  	  	      cc      = content[:cc]
+  	  	      to      = content[:to]
   	  	      link_content = "<span class='rrssb-icon'>#{image_tag('mail.min.svg')}</span><span class='rrssb-text'>#{label}</span>"	
   	  	      
   	  	      mail_to(to, link_content.html_safe, subject: subject, cc: cc)
   	  	    else
-  	  	      label        = content.delete(:label) { button.humanize }
+  	  	      label        = content[:label] || (button == 'hackernews' ? 'hacker news' : button.humanize)
   	  	      image_name   = "#{button}.min.svg"
   	  	      link_content = "<span class='rrssb-icon'>#{image_tag(image_name)}</span><span class='rrssb-text'>#{label}</span>"	
-  	  	      html_options = { 'class' => 'popup' } 	
+  	  	      html_options = button == 'github' ? {} : { 'class' => 'popup' } 	
 
-  	  	      link_to(link_content.html_safe, social_url(button, url, content), html_options)
+  	  	      link_to(link_content.html_safe, social_url(button, content, opts), html_options)
   	  	  end
   	  	  html << "</li>"	
   	  	end
@@ -35,16 +34,20 @@ module Rrssb
   	  	raw html.join("\n")
   	  end
 
-      # cf. https://github.com/huacnlee/social-share-button
-  	  def social_url(button, url, opts={})
+  	  def social_url(button, content, opts={})
+  	  	title = opts[:title] || ''
+  	  	url   = opts[:url] || '#'
+        img   = content[:img] || ''
+   
   	  	case button
-  	  	when 'facebook' then "https://www.facebook.com/sharer/sharer.php?u=#{url}"
-  	    when 'twitter'
-  	      via  = opts.delete(:via) { nil }
-  	      text = opts.delete(:text) { '' }
-  	      "https://twitter.com/intent/tweet?url=#{url}&text=#{text}&via=#{via}"
-  	    when 'google_plus' then "https://plus.google.com/share?url=#{url}"
-  	  	else url
+  	  	when 'delicious'   then "https://www.delicious.com/save?v=5&url=#{url}&title=#{title}&jump=yes"
+  	  	when 'facebook'    then "https://www.facebook.com/sharer/sharer.php?u=#{url}"
+  	    when 'github'      then url 
+        when 'google_plus' then "https://plus.google.com/share?url=#{url}"
+  	    when 'hackernews'  then "https://news.ycombinator.com/submitlink?u=#{url}&t=#{title}"
+        when 'pinterest'   then "https://www.pinterest.com/pin/create/button/?url=#{url}&media=#{img}&description=#{title}"
+        when 'twitter'     then "https://twitter.com/intent/tweet?url=#{url}&text=#{content[:text]}&via=#{content[:via]}"
+  	  	else image_path('rrssb-rails-404.png')
   	  	end
   	  end
   	end

data/lib/rrssb/rails/version.rb

@@ -1,5 +1,5 @@
 module Rrssb
   module Rails
-    VERSION = "0.0.1"
+    VERSION = "0.1.0"
   end
 end

data/test/helpers/buttons_helper_test.rb

@@ -9,7 +9,71 @@ class Rrssb::Rails::ButtonsHelperTest < ActionView::TestCase
     assert_select doc.root, "ul.rrssb-buttons"
     assert_select doc.root, "li", 2
     assert_select doc.root, "a.popup", 2 do
-      assert_select "[href=?]", /.*#{identifier_url}.*/  # Href property for the 2 includes the given url
+      assert_select "[href=?]", /.*url=#{identifier_url}.*/  # Href property for the 2 includes the given url
+    end
+  end
+
+  test "#rrssb_tag generates a github button than opens a link specified by its url, no popup" do
+    url_to_open = 'https://github.com/dam/rrssb-rails'
+    result = rrssb_tag(url: url_to_open, buttons: ['github']) 
+    doc = HTML::Document.new(result)
+
+    assert_select doc.root, "li.rrssb-github"
+    assert_select doc.root, "a", 1 do
+      assert_select "[href=?]", /.*#{url_to_open}.*/ 
+    end
+  end
+
+  test "#rrssb_tag generates a delicious button" do 
+  	identifier_url = 'http://myurl.com'
+  	title = 'My sharing title'
+    result = rrssb_tag(url: identifier_url, title: title, buttons: ['delicious']) 
+    doc = HTML::Document.new(result)
+
+    assert_select doc.root, "li.rrssb-delicious"
+    assert_select doc.root, "a", 1 do
+      assert_select "[href=?]", /.*url=#{identifier_url}.*/ 
+      assert_select "[href=?]", /.*title=#{title}.*/ 
+    end
+  end
+
+  test "#rrssb_tag generates a google+ button with special content" do 
+    identifier_url = 'http://myurl.com'
+    result = rrssb_tag(url: identifier_url, buttons: ['google_plus']) 
+    doc = HTML::Document.new(result)
+
+    assert_select doc.root, "li.rrssb-googleplus"
+    assert_select doc.root, "a", 1 do
+      assert_select "[href=?]", /.*url=#{identifier_url}.*/ 
+    end
+  end
+
+  test "#rrssb_tag generates a harcker news button to submit a link" do 
+    url_to_link = 'http://myurl.com'
+    title = 'My title'
+    result = rrssb_tag(url: url_to_link, title: title, buttons: ['hackernews']) 
+    doc = HTML::Document.new(result)
+
+    assert_select doc.root, "li.rrssb-hackernews"
+    assert_select doc.root, "a", 1 do
+      assert_select "[href=?]", /.*u=#{url_to_link}.*/ 
+      assert_select "[href=?]", /.*t=#{title}.*/ 
+    end
+  end
+
+  test "#rrssb_tag generates a piterest sharing button" do
+    url_to_link = 'http://myurl.com'
+    title = 'My title'
+    img_url = image_url('rrssb-rails-404.png')
+
+    result = rrssb_tag(url: url_to_link, title: title, buttons: ['pinterest'], contents: { pinterest: { img: img_url } } ) 
+    doc = HTML::Document.new(result)
+    
+    assert_select doc.root, "li.rrssb-pinterest"
+    assert_select doc.root, "a", 1 do
+      assert_select "[href=?]", /.*url=#{url_to_link}.*/
+      assert_select "[href=?]", /.*description=#{title}.*/ 
+      assert_select "[href=?]", /.*media=.*#{img_url}.*/
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rrssb-rails
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.1.0
 platform: ruby
 authors:
 - Damien Imberdis
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-10-01 00:00:00.000000000 Z
+date: 2015-10-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -95,6 +95,7 @@ files:
 - vendor/assets/images/pinterest.min.svg
 - vendor/assets/images/pocket.min.svg
 - vendor/assets/images/reddit.min.svg
+- vendor/assets/images/rrssb-rails-404.png
 - vendor/assets/images/tumblr.min.svg
 - vendor/assets/images/twitter.min.svg
 - vendor/assets/images/vk.min.svg