rroonga 10.0.2 → 12.0.0

data/ext/groonga/rb-grn-table-cursor.c

@@ -1,6 +1,6 @@
 /* -*- coding: utf-8; mode: C; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
 /*
-  Copyright (C) 2009-2013  Kouhei Sutou <kou@clear-code.com>
+  Copyright (C) 2009-2021  Sutou Kouhei <kou@clear-code.com>
 
   This library is free software; you can redistribute it and/or
   modify it under the terms of the GNU Lesser General Public
@@ -18,7 +18,7 @@
 
 #include "rb-grn.h"
 
-#define SELF(object) ((RbGrnTableCursor *)DATA_PTR(object))
+#define SELF(object) ((RbGrnTableCursor *)RTYPEDDATA_DATA(object))
 
 VALUE rb_cGrnTableCursor;
 
@@ -277,7 +277,7 @@ rb_grn_table_cursor_each (VALUE self)
 void
 rb_grn_init_table_cursor (VALUE mGrn)
 {
-    rb_cGrnTableCursor = rb_define_class_under(mGrn, "TableCursor", rb_cData);
+    rb_cGrnTableCursor = rb_define_class_under(mGrn, "TableCursor", rb_cObject);
     rb_define_alloc_func(rb_cGrnTableCursor, rb_grn_object_alloc);
 
     rb_include_module(rb_cGrnTableCursor, rb_mEnumerable);

data/ext/groonga/rb-grn-table-key-support.c

@@ -1,6 +1,6 @@
 /* -*- coding: utf-8; mode: C; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
 /*
-  Copyright (C) 2009-2020  Sutou Kouhei <kou@clear-code.com>
+  Copyright (C) 2009-2021  Sutou Kouhei <kou@clear-code.com>
   Copyright (C) 2014-2016  Masafumi Yokoyama <yokoyama@clear-code.com>
 
   This library is free software; you can redistribute it and/or
@@ -19,7 +19,7 @@
 
 #include "rb-grn.h"
 
-#define SELF(object) ((RbGrnTableKeySupport *)DATA_PTR(object))
+#define SELF(object) ((RbGrnTableKeySupport *)RTYPEDDATA_DATA(object))
 
 VALUE rb_mGrnTableKeySupport;
 
@@ -498,7 +498,7 @@ set_value (RB_BLOCK_CALL_FUNC_ARGLIST(yielded_arg, callback_arg))
                  rb_grn_inspect(rb_name), rb_grn_inspect(data->self));
     }
 
-    rb_grn_object = RB_GRN_OBJECT(DATA_PTR(rb_column));
+    rb_grn_object = RB_GRN_OBJECT(RTYPEDDATA_DATA(rb_column));
     return rb_grn_object_set_raw(rb_grn_object,
                                  data->id, rb_value, GRN_OBJ_SET, data->self);
 }

data/ext/groonga/rb-grn-table.c

@@ -1,6 +1,6 @@
 /* -*- coding: utf-8; mode: C; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
 /*
-  Copyright (C) 2009-2017  Kouhei Sutou <kou@clear-code.com>
+  Copyright (C) 2009-2021  Sutou Kouhei <kou@clear-code.com>
   Copyright (C) 2014-2016  Masafumi Yokoyama <yokoyama@clear-code.com>
   Copyright (C) 2019  Horimoto Yasuhiro <horimoto@clear-code.com>
 
@@ -20,13 +20,6 @@
 
 #include "rb-grn.h"
 
-#define SELF(object) ((RbGrnTable *)DATA_PTR(object))
-
-VALUE rb_cGrnTable;
-
-static ID id_array_reference;
-static ID id_array_set;
-
 /*
  * Document-class: Groonga::Table < Groonga::Object
  *
@@ -35,6 +28,59 @@ static ID id_array_set;
  * are extended from this class.
  */
 
+#define SELF(object) ((RbGrnTable *)RTYPEDDATA_DATA(object))
+
+VALUE rb_cGrnTable;
+
+static ID id_array_reference;
+static ID id_array_set;
+
+static void
+rb_grn_table_mark (void *data)
+{
+    RbGrnObject *rb_grn_object = data;
+    RbGrnTable *rb_grn_table = data;
+    grn_ctx *context;
+    grn_obj *table;
+
+    if (!rb_grn_object)
+        return;
+
+    rb_gc_mark(rb_grn_table->columns);
+
+    context = rb_grn_object->context;
+    table = rb_grn_object->object;
+    if (!context || !table)
+        return;
+
+    rb_grn_context_mark_grn_id(context, table->header.domain);
+    rb_grn_context_mark_grn_id(context, grn_obj_get_range(context, table));
+
+    if (!grn_obj_path(context, table))
+        return;
+
+    if (grn_obj_name(context, table, NULL, 0) == 0)
+        return;
+}
+
+static void
+rb_grn_table_free (void *pointer)
+{
+    rb_grn_object_free(pointer);
+}
+
+static rb_data_type_t data_type = {
+    "Groonga::Table",
+    {
+        rb_grn_table_mark,
+        rb_grn_table_free,
+        NULL,
+    },
+    &rb_grn_object_data_type,
+    NULL,
+    RUBY_TYPED_FREE_IMMEDIATELY
+};
+
 grn_obj *
 rb_grn_table_from_ruby_object (VALUE object, grn_ctx **context)
 {
@@ -101,38 +147,10 @@ rb_grn_table_deconstruct (RbGrnTable *rb_grn_table,
         *columns = rb_grn_table->columns;
 }
 
-static void
-rb_grn_table_mark (void *data)
-{
-    RbGrnObject *rb_grn_object = data;
-    RbGrnTable *rb_grn_table = data;
-    grn_ctx *context;
-    grn_obj *table;
-
-    if (!rb_grn_object)
-        return;
-
-    rb_gc_mark(rb_grn_table->columns);
-
-    context = rb_grn_object->context;
-    table = rb_grn_object->object;
-    if (!context || !table)
-        return;
-
-    rb_grn_context_mark_grn_id(context, table->header.domain);
-    rb_grn_context_mark_grn_id(context, grn_obj_get_range(context, table));
-
-    if (!grn_obj_path(context, table))
-        return;
-
-    if (grn_obj_name(context, table, NULL, 0) == 0)
-        return;
-}
-
 static VALUE
 rb_grn_table_alloc (VALUE klass)
 {
-    return Data_Wrap_Struct(klass, rb_grn_table_mark, rb_grn_object_free, NULL);
+    return TypedData_Wrap_Struct(klass, &data_type, NULL);
 }
 
 static VALUE
@@ -342,7 +360,7 @@ rb_grn_table_define_column (int argc, VALUE *argv, VALUE self)
 
     rb_column = GRNCOLUMN2RVAL(Qnil, context, column, GRN_TRUE);
     rb_ary_push(columns, rb_column);
-    rb_grn_named_object_set_name(RB_GRN_NAMED_OBJECT(DATA_PTR(rb_column)),
+    rb_grn_named_object_set_name(RB_GRN_NAMED_OBJECT(RTYPEDDATA_DATA(rb_column)),
                                  name, name_size);
 
     return rb_column;
@@ -497,7 +515,7 @@ rb_grn_table_define_index_column (int argc, VALUE *argv, VALUE self)
         rb_funcall(rb_column, rb_intern("sources="), 1, rb_sources);
 
     rb_ary_push(columns, rb_column);
-    rb_grn_named_object_set_name(RB_GRN_NAMED_OBJECT(DATA_PTR(rb_column)),
+    rb_grn_named_object_set_name(RB_GRN_NAMED_OBJECT(RTYPEDDATA_DATA(rb_column)),
                                  name, name_size);
 
     return rb_column;
@@ -558,7 +576,7 @@ rb_grn_table_get_column (VALUE self, VALUE rb_name)
         VALUE rb_column = raw_columns[i];
         RbGrnNamedObject *rb_grn_named_object;
 
-        rb_grn_named_object = RB_GRN_NAMED_OBJECT(DATA_PTR(rb_column));
+        rb_grn_named_object = RB_GRN_NAMED_OBJECT(RTYPEDDATA_DATA(rb_column));
         if (name_size == rb_grn_named_object->name_size &&
             memcmp(name, rb_grn_named_object->name, name_size) == 0) {
             return rb_column;
@@ -583,9 +601,9 @@ rb_grn_table_get_column (VALUE self, VALUE rb_name)
     owner = column->header.type == GRN_ACCESSOR;
     rb_column = GRNCOLUMN2RVAL(Qnil, context, column, owner);
     if (owner) {
-        rb_grn_context_register_floating_object(DATA_PTR(rb_column));
+        rb_grn_context_register_floating_object(RTYPEDDATA_DATA(rb_column));
     }
-    rb_grn_named_object_set_name(RB_GRN_NAMED_OBJECT(DATA_PTR(rb_column)),
+    rb_grn_named_object_set_name(RB_GRN_NAMED_OBJECT(RTYPEDDATA_DATA(rb_column)),
                                  name, name_size);
 
     return rb_column;
@@ -688,7 +706,7 @@ rb_grn_table_get_columns (int argc, VALUE *argv, VALUE self)
             RbGrnNamedObject *rb_grn_named_object;
             name_size = grn_column_name(context, column,
                                         name, GRN_TABLE_MAX_KEY_SIZE);
-            rb_grn_named_object = RB_GRN_NAMED_OBJECT(DATA_PTR(rb_column));
+            rb_grn_named_object = RB_GRN_NAMED_OBJECT(RTYPEDDATA_DATA(rb_column));
             rb_grn_named_object_set_name(rb_grn_named_object, name, name_size);
         }
 
@@ -1092,7 +1110,7 @@ rb_grn_table_delete_by_expression (VALUE self)
 
     rb_builder = rb_grn_record_expression_builder_new(self, Qnil);
     rb_expression = rb_grn_record_expression_builder_build(rb_builder);
-    rb_grn_object_deconstruct(RB_GRN_OBJECT(DATA_PTR(rb_expression)),
+    rb_grn_object_deconstruct(RB_GRN_OBJECT(RTYPEDDATA_DATA(rb_expression)),
                               &expression, NULL,
                               NULL, NULL, NULL, NULL);
 
@@ -2394,7 +2412,7 @@ rb_grn_table_select (int argc, VALUE *argv, VALUE self)
       rb_funcall(builder, rb_intern("default_column="), 1, rb_default_column);
       rb_expression = rb_grn_record_expression_builder_build(builder);
     }
-    rb_grn_object_deconstruct(RB_GRN_OBJECT(DATA_PTR(rb_expression)),
+    rb_grn_object_deconstruct(RB_GRN_OBJECT(RTYPEDDATA_DATA(rb_expression)),
                               &expression, NULL,
                               NULL, NULL, NULL, NULL);
 

data/ext/groonga/rb-grn-variable-size-column.c

@@ -1,6 +1,6 @@
 /* -*- coding: utf-8; mode: C; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
 /*
-  Copyright (C) 2009-2016  Kouhei Sutou <kou@clear-code.com>
+  Copyright (C) 2009-2021  Sutou Kouhei <kou@clear-code.com>
   Copyright (C) 2014-2016  Masafumi Yokoyama <yokoyama@clear-code.com>
 
   This library is free software; you can redistribute it and/or
@@ -19,7 +19,7 @@
 
 #include "rb-grn.h"
 
-#define SELF(object) ((RbGrnVariableSizeColumn *)DATA_PTR(object))
+#define SELF(object) ((RbGrnVariableSizeColumn *)RTYPEDDATA_DATA(object))
 
 VALUE rb_cGrnVariableSizeColumn;
 

data/ext/groonga/rb-grn-variable.c

@@ -1,6 +1,6 @@
 /* -*- coding: utf-8; mode: C; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
 /*
-  Copyright (C) 2009  Kouhei Sutou <kou@clear-code.com>
+  Copyright (C) 2009-2021  Sutou Kouhei <kou@clear-code.com>
 
   This library is free software; you can redistribute it and/or
   modify it under the terms of the GNU Lesser General Public
@@ -18,7 +18,7 @@
 
 #include "rb-grn.h"
 
-#define SELF(object) ((RbGrnVariable *)DATA_PTR(object))
+#define SELF(object) ((RbGrnVariable *)RTYPEDDATA_DATA(object))
 
 VALUE rb_cGrnVariable;
 

data/ext/groonga/rb-grn.h

@@ -1,6 +1,6 @@
 /* -*- coding: utf-8; mode: C; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
 /*
-  Copyright (C) 2009-2020  Sutou Kouhei <kou@clear-code.com>
+  Copyright (C) 2009-2021  Sutou Kouhei <kou@clear-code.com>
   Copyright (C) 2015-2017  Masafumi Yokoyama <yokoyama@clear-code.com>
 
   This library is free software; you can redistribute it and/or
@@ -75,7 +75,7 @@ RB_GRN_BEGIN_DECLS
 
 #ifdef __WIN32__
 #  ifdef RB_GRN_COMPILATION
-#    define RB_GRN_VAR __declspec(dllexport)
+#    define RB_GRN_VAR extern __declspec(dllexport)
 #  else
 #    define RB_GRN_VAR extern __declspec(dllimport)
 #  endif
@@ -91,9 +91,9 @@ RB_GRN_BEGIN_DECLS
 
 #define RB_GRN_HAVE_FLOAT32 GRN_VERSION_OR_LATER(10, 0, 2)
 
-#define RB_GRN_MAJOR_VERSION 10
+#define RB_GRN_MAJOR_VERSION 12
 #define RB_GRN_MINOR_VERSION 0
-#define RB_GRN_MICRO_VERSION 2
+#define RB_GRN_MICRO_VERSION 0
 
 #define RB_GRN_OBJECT(object) ((RbGrnObject *)(object))
 #define RB_GRN_NAMED_OBJECT(object) ((RbGrnNamedObject *)(object))
@@ -314,6 +314,8 @@ RB_GRN_VAR VALUE rb_mGrnRequestTimer;
 RB_GRN_VAR VALUE rb_cGrnRequestTimerID;
 RB_GRN_VAR VALUE rb_cGrnColumnCache;
 
+RB_GRN_VAR rb_data_type_t rb_grn_object_data_type;
+
 void           rb_grn_init_utils                    (VALUE mGrn);
 void           rb_grn_init_exception                (VALUE mGrn);
 void           rb_grn_init_encoding                 (VALUE mGrn);
@@ -779,7 +781,8 @@ rb_encoding   *rb_grn_encoding_to_ruby_encoding     (grn_encoding encoding);
 VALUE          rb_grn_encoding_to_ruby_encoding_object
                                                     (grn_encoding encoding);
 
-grn_ctx       *rb_grn_context_from_ruby_object      (VALUE object);
+RbGrnContext  *rb_grn_context_get_struct            (VALUE rb_context);
+grn_ctx       *rb_grn_context_from_ruby_object      (VALUE rb_context);
 VALUE          rb_grn_context_to_ruby_object        (grn_ctx *context);
 VALUE          rb_grn_context_rb_string_new         (grn_ctx *context,
                                                      const char *string,

data/ext/groonga/rb-groonga.c

@@ -1,6 +1,6 @@
 /* -*- coding: utf-8; mode: C; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
 /*
-  Copyright (C) 2009-2020  Sutou Kouhei <kou@clear-code.com>
+  Copyright (C) 2009-2021  Sutou Kouhei <kou@clear-code.com>
   Copyright (C) 2016  Masafumi Yokoyama <yokoyama@clear-code.com>
 
   This library is free software; you can redistribute it and/or
@@ -205,6 +205,10 @@ rb_grn_init_package_label (VALUE mGrn)
 void
 Init_groonga (void)
 {
+#ifdef HAVE_RB_EXT_RACTOR_SAFE
+    rb_ext_ractor_safe(true);
+#endif
+
     VALUE mGrn;
 
     mGrn = rb_define_module("Groonga");

data/lib/groonga/context.rb

@@ -20,6 +20,38 @@ require "groonga/context/command-executor"
 
 module Groonga
   class Context
+    class << self
+      # Opens a new context. If block is given, the opened context is
+      # closed automatically after the given block is evaluated.
+      #
+      # @overload open(*args, &block)
+      #   @param args [::Array<Object>] Passed through to
+      #     {Groonga::Context#initialize}.
+      #   @yieldparam context [Groonga::Context] The newly created context.
+      #   @return [Object] The return value of the given block is the
+      #     return value of the call.
+      #
+      # @overload open(*args)
+      #   @param args [::Array<Object>] Passed through to
+      #     {Groonga::Context#initialize}.
+      #   @yieldparam context [Groonga::Context] The newly created context.
+      #   @return [Groonga::Context] The newly created context.
+      #
+      # @see Groonga::Context#initialize
+      def open(*args, **kwargs)
+        context = new(*args, **kwargs)
+        if block_given?
+          begin
+            yield(context)
+          ensure
+            context.close
+          end
+        else
+          context
+        end
+      end
+    end
+
     # _path_ にある既存のデータベースを開く。ブロックを指定した場
     # 合はブロックに開いたデータベースを渡し、ブロックを抜けると
     # きに閉じる。

data/rroonga-build.rb

@@ -1,4 +1,4 @@
-# Copyright (C) 2009-2018  Kouhei Sutou <kou@clear-code.com>
+# Copyright (C) 2009-2021  Kouhei Sutou <kou@clear-code.com>
 # Copyright (C) 2015-2017  Masafumi Yokoyama <yokoyama@clear-code.com>
 #
 # This library is free software; you can redistribute it and/or
@@ -16,11 +16,12 @@
 
 module RroongaBuild
   module RequiredGroongaVersion
-    MAJOR = 9
+    MAJOR = 11
     MINOR = 0
-    MICRO = 2
+    MICRO = 0
     VERSION = [MAJOR, MINOR, MICRO]
-    RELEASED_DATE = Time.utc(2019, 4, 29)
+    STRING = VERSION.join(".")
+    RELEASED_DATE = Time.utc(2021, 2, 9)
   end
 
   module_function

data/rroonga.gemspec

@@ -17,6 +17,7 @@
 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
 
 require "English"
+require_relative "rroonga-build"
 
 base_dir = File.dirname(__FILE__)
 ext_dir = File.join(base_dir, "ext", "groonga")
@@ -82,9 +83,10 @@ Gem::Specification.new do |s|
 
   s.required_ruby_version = ">= 1.9.3"
 
-  s.add_runtime_dependency("pkg-config")
   s.add_runtime_dependency("groonga-client", ">= 0.0.3")
   s.add_runtime_dependency("json")
+  s.add_runtime_dependency("native-package-installer")
+  s.add_runtime_dependency("pkg-config")
   s.add_development_dependency("test-unit", [">= 3.0.0"])
   s.add_development_dependency("rake")
   s.add_development_dependency("bundler")
@@ -92,6 +94,7 @@ Gem::Specification.new do |s|
   s.add_development_dependency("packnga", [">= 1.0.0"])
   s.add_development_dependency("kramdown")
 
-  s.metadata["msys2_mingw_dependencies"] = "groonga>=10.0.1"
+  required_groonga_version = RroongaBuild::RequiredGroongaVersion::STRING
+  s.metadata["msys2_mingw_dependencies"] = "groonga>=#{required_groonga_version}"
 end
 

data/test/groonga-test-utils.rb

@@ -140,6 +140,9 @@ module GroongaTestUtils
   end
 
   def teardown_log_path
+    Groonga::Logger.path = nil
+    Groonga::QueryLogger.path = nil
+
     return unless @dump_log
     if @log_path.exist?(log_path)
       header = "--- log: #{@log_path} ---"

data/test/run-test.rb

@@ -37,7 +37,7 @@ end
 require "test-unit"
 require "test/unit/priority"
 
-Test::Unit::Priority.enable
+Test::Unit::Priority.enable unless ENV["CI"]
 
 
 groonga_command_dir = File.join(base_dir, "..", "groonga-command")

data/test/test-index-column.rb

@@ -1,6 +1,4 @@
-# -*- coding: utf-8 -*-
-#
-# Copyright (C) 2009-2016  Kouhei Sutou <kou@clear-code.com>
+# Copyright (C) 2009-2021  Sutou Kouhei <kou@clear-code.com>
 # Copyright (C) 2016  Masafumi Yokoyama <yokoyama@clear-code.com>
 #
 # This library is free software; you can redistribute it and/or
@@ -203,6 +201,8 @@ class IndexColumnTest < Test::Unit::TestCase
   end
 
   def test_reindex
+    check_mecab_availability
+
     Groonga::Schema.define do |schema|
       schema.create_table("Memos", :type => :array) do |table|
         table.short_text("title")

data/test/test-logger.rb

@@ -39,6 +39,8 @@ class LoggerTest < Test::Unit::TestCase
       FileUtils.mv(@log_path, "#{@log_path}.old")
     end
     assert_false(@log_path.exist?)
+    # Reopen log uses debug level since Groonga 11.0.1.
+    Groonga::Logger.max_level = :debug
     Groonga::Logger.reopen
     assert_true(@log_path.exist?)
   end

data/test/test-ractor.rb

@@ -0,0 +1,65 @@
+# Copyright (C) 2021  Sutou Kouhei <kou@clear-code.com>
+#
+# This library is free software; you can redistribute it and/or
+# modify it under the terms of the GNU Lesser General Public
+# License version 2.1 as published by the Free Software Foundation.
+#
+# This library is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+# Lesser General Public License for more details.
+#
+# You should have received a copy of the GNU Lesser General Public
+# License along with this library; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
+
+class RactorTest < Test::Unit::TestCase
+  include GroongaTestUtils
+
+  setup
+  def need_ractor
+    omit("Ractor is needed") unless defined?(Ractor)
+  end
+
+  setup :setup_database
+
+  setup
+  def setup_tables
+    Groonga::Schema.define do |schema|
+      schema.create_table("Comments") do |table|
+        table.text("content")
+      end
+
+      schema.create_table("Terms",
+                          type: :patricia_trie,
+                          default_tokenizer: "TokenNgram",
+                          normalizer: "NormalizerNFKC130") do |table|
+        table.index("Comments.content", with_position: true)
+      end
+    end
+  end
+
+  setup
+  def setup_records
+    comments = Groonga["Comments"]
+    comments.add(content: "Hello World")
+    comments.add(content: "Groonga is fast!")
+    comments.add(content: "Rroonga is the Groonga bindings")
+  end
+
+  test "select" do
+    ractor = Ractor.new(@database_path) do |database_path|
+      Groonga::Context.open(encoding: nil) do |context|
+        context.open_database(database_path) do
+          comments = context["Comments"]
+          matched_comments = comments.select do |comment|
+            comment.content.match("Groonga")
+          end
+          matched_comments.collect(&:content)
+        end
+      end
+    end
+    assert_equal(["Groonga is fast!", "Rroonga is the Groonga bindings"],
+                 ractor.take)
+  end
+end

data/test/test-remote.rb

@@ -26,6 +26,7 @@ class RemoteTest < Test::Unit::TestCase
     else
       package_config = PKGConfig.package_config("groonga")
       groonga = package_config.variable("groonga")
+      groonga = normalize_groonga_path(groonga)
       groonga = "groonga" unless File.exist?(groonga)
     end
 
@@ -51,6 +52,19 @@ class RemoteTest < Test::Unit::TestCase
     end
   end
 
+  def normalize_groonga_path(groonga)
+    return groonga unless groonga
+    return groonga unless Object.const_defined?(:RubyInstaller)
+
+    msys2_installation = RubyInstaller::Runtime.msys2_installation
+    mingw_prefix = msys2_installation.mingw_prefix
+    mingw_bin_path = "#{mingw_prefix}/bin/"
+    mingw_bin_path_windows = "#{msys2_installation.mingw_bin_path}\\"
+    groonga.gsub(/\A#{Regexp.escape(mingw_bin_path)}/) do
+      mingw_bin_path_windows
+    end
+  end
+
   teardown
   def teardown_remote_connection
     if @process_id
@@ -78,6 +92,8 @@ class RemoteTest < Test::Unit::TestCase
     id, result = _context.receive
     assert_equal(0, id)
     values = JSON.load(result)
+    values.delete("apache_arrow")
+    values.delete("features")
     assert_equal([
                    "alloc_count",
                    "cache_hit_rate",

data/test/test-table-arrow.rb

@@ -22,6 +22,15 @@ class TableArrowTest < Test::Unit::TestCase
     omit("Apache Arrow support is required") unless context.support_arrow?
   end
 
+  def open_temporary_file(extension)
+    tempfile = Tempfile.new(["table-arrow", extension])
+    begin
+      yield(tempfile)
+    ensure
+      tempfile.close!
+    end
+  end
+
   def assert_dump_load(type, n_records)
     Groonga::Schema.define do |schema|
       schema.create_table("Source") do |table|
@@ -42,9 +51,10 @@ class TableArrowTest < Test::Unit::TestCase
       source.add(:data => data)
     end
 
-    tempfile = Tempfile.new(["table-arrow", ".arrow"])
-    source.dump_arrow(tempfile.path)
-    destination.load_arrow(tempfile.path)
+    open_temporary_file(".arrow") do |tempfile|
+      source.dump_arrow(tempfile.path)
+      destination.load_arrow(tempfile.path)
+    end
 
     assert_equal(expected,
                  destination.collect(&:attributes))
@@ -153,9 +163,10 @@ class TableArrowTest < Test::Unit::TestCase
       source.add(:data1 => data1, :data2 => data2)
     end
 
-    tempfile = Tempfile.new(["table-arrow", ".arrow"])
-    source.dump_arrow(tempfile.path, :columns => source.columns[0, 1])
-    destination.load_arrow(tempfile.path)
+    open_temporary_file(".arrow") do |tempfile|
+      source.dump_arrow(tempfile.path, columns: source.columns[0, 1])
+      destination.load_arrow(tempfile.path)
+    end
 
     assert_equal(expected,
                  destination.collect(&:attributes))
@@ -183,9 +194,10 @@ class TableArrowTest < Test::Unit::TestCase
       source.add(:data1 => data1, :data2 => data2)
     end
 
-    tempfile = Tempfile.new(["table-arrow", ".arrow"])
-    source.dump_arrow(tempfile.path, :column_names => ["data1"])
-    destination.load_arrow(tempfile.path)
+    open_temporary_file(".arrow") do |tempfile|
+      source.dump_arrow(tempfile.path, column_names: ["data1"])
+      destination.load_arrow(tempfile.path)
+    end
 
     assert_equal(expected,
                  destination.collect(&:attributes))