rr 3.0.3 → 3.0.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4ae999de4b35d2e97dd9805d858a1b573cf8201e8bc4a72c57ab2277ba30400e
-  data.tar.gz: 807039ad92e52e43aaad160042ef82e4513ef79d4eb6724c0c4a6c29ffc22b93
+  metadata.gz: 7690f50ed3d2cb136611f0fe21955d6b29fc8a58be9dabcb7e342034dad13b66
+  data.tar.gz: c3ec0e439daecf5d736042cdd78e550c8e178fd3160bde8d47a1109c9552a68d
 SHA512:
-  metadata.gz: 20c952e868437e27e4904e8e1297844e7f6c301f30ae5b8e8ed22915c5eca4817dec14dd2a8185ed3e154a83b89f3f0789baba6edd38d42a3889bfb2f45bd46c
-  data.tar.gz: f8750bae03dd96e49c7b0d129685ea9c2be4a35d4dee7cdebf6054c6ba99917eed9ba93fe504c2c0241d37c4b8eb2fd37d91afe76d2b3cd9290868f8ee58b9db
+  metadata.gz: ccc4cab0df8cc92fd7e568ed36b392244ede5ef8ec908b01b15ac2d41eaf7d5cd3a8bb9c63f394894e43697d3baf6f326e643337b0286b3b0f02fcd38c11e2e7
+  data.tar.gz: ec16ec1798ed218454263a8bdb3facc5b2b66270ac35aaec3ef683d64cfb58350e223274a938c970a296719c05d163041bf8627651b95268f7cf52dc956792f7

data/CHANGES.md

@@ -1,5 +1,50 @@
 # Changelog
 
+## 3.0.7 - 2021-08-17
+
+### Fixes
+
+  * Minitest + Active Support integration: Fixed a bug that `stub` in
+    `setup {...}` is ignored.
+    [GitHub#87][Reported by Boris]
+
+### Thanks
+
+  * Boris
+
+## 3.0.6 - 2021-08-07
+
+### Improvements
+
+  * `assert_received`: Added support for keyword arguments.
+    [GitHub#86][Reported by imadoki]
+
+### Thanks
+
+  * imadoki
+
+## 3.0.5 - 2021-06-26
+
+### Improvements
+
+  * Improved keyword arguments support on Ruby 2.7.
+    [GitHub#85][Patch by akira yamada]
+
+### Thanks
+
+  * akira yamada
+
+## 3.0.4 - 2021-06-23
+
+### Fixes
+
+  * Fix inverted condition in keyword arguments related code.
+    [GitHub#84][Patch by akira yamada]
+
+### Thanks
+
+  * akira yamada
+
 ## 3.0.3 - 2021-06-22
 
 ### Improvements

data/lib/rr/double_definitions/double_definition_create_blank_slate.rb

@@ -22,6 +22,7 @@ module RR
         def method_missing(method_name, *args, &block)
           @double_definition_create.call(method_name, args, {}, &block)
         end
+        ruby2_keywords(:method_missing) if respond_to?(:ruby2_keywords, true)
       end
 
       def __double_definition_create__

data/lib/rr/double_definitions/strategies/strategy.rb

@@ -36,8 +36,6 @@ module RR
           def permissive_argument
             if args.empty? and kwargs.empty?
               definition.with_any_args
-            elsif kwargs.empty?
-              definition.with(*args)
             else
               definition.with(*args, **kwargs)
             end

data/lib/rr/injections/double_injection.rb

@@ -137,25 +137,15 @@ module RR
         id = BoundObjects.size
         BoundObjects[id] = subject_class
 
-        if KeywordArguments.fully_supported? && KeywordArguments.accept_kwargs?(subject_class, method_name)
-          subject_class.class_eval(<<-RUBY, __FILE__, __LINE__ + 1)
-            def #{method_name}(*args, **kwargs, &block)
-              ::RR::Injections::DoubleInjection::BoundObjects[#{id}].class_eval do
-                remove_method(:#{method_name})
-              end
-              method_missing(:#{method_name}, *args, **kwargs, &block)
-            end
-          RUBY
-        else
-          subject_class.class_eval(<<-RUBY, __FILE__, __LINE__ + 1)
-            def #{method_name}(*args, &block)
-              ::RR::Injections::DoubleInjection::BoundObjects[#{id}].class_eval do
-                remove_method(:#{method_name})
-              end
-              method_missing(:#{method_name}, *args, &block)
+        subject_class.class_eval(<<-RUBY, __FILE__, __LINE__ + 1)
+          def #{method_name}(*args, &block)
+            ::RR::Injections::DoubleInjection::BoundObjects[#{id}].class_eval do
+              remove_method(:#{method_name})
             end
-          RUBY
-        end
+            method_missing(:#{method_name}, *args, &block)
+          end
+          ruby2_keywords(:#{method_name}) if respond_to?(:ruby2_keywords, true)
+        RUBY
         self
       end
 
@@ -163,7 +153,7 @@ module RR
         id = BoundObjects.size
         BoundObjects[id] = subject_class
 
-        if KeywordArguments.fully_supported? && KeywordArguments.accept_kwargs?(subject_class, method_name)
+        if KeywordArguments.fully_supported?
           subject_class.class_eval(<<-RUBY, __FILE__, __LINE__ + 1)
             def #{method_name}(*args, **kwargs, &block)
               arguments = MethodArguments.new(args, kwargs, block)
@@ -192,6 +182,7 @@ module RR
                 arguments.block
               )
             end
+            ruby2_keywords(:#{method_name}) if respond_to?(:ruby2_keywords, true)
           RUBY
         end
         self

data/lib/rr/injections/method_missing_injection.rb

@@ -106,6 +106,7 @@ module RR
                 ).call
               end
             end
+            ruby2_keywords(:method_missing) if respond_to?(:ruby2_keywords, true)
           METHOD
         end
       end

data/lib/rr/integrations/minitest_4.rb

@@ -39,10 +39,21 @@ module RR
           include RR::DSL
           include Mixin
 
+          if defined?(::ActiveSupport::TestCase)
+            is_active_support_test_case = lambda do |target|
+              false
+            end
+          else
+            is_active_support_test_case = lambda do |target|
+              target.is_a?(::ActiveSupport::TestCase)
+            end
+          end
+
           unless instance_methods.any? { |method_name| method_name.to_sym == :setup_with_rr }
             alias_method :setup_without_rr, :setup
             define_method(:setup_with_rr) do
               setup_without_rr
+              return is_active_support_test_case.call(self)
               RR.reset
               RR.trim_backtrace = true
               RR.overridden_error_class = assertion_error_class
@@ -52,7 +63,7 @@ module RR
             alias_method :teardown_without_rr, :teardown
             define_method(:teardown_with_rr) do
               begin
-                RR.verify
+                RR.verify if is_active_support_test_case.call(self)
               ensure
                 teardown_without_rr
               end

data/lib/rr/keyword_arguments.rb

@@ -1,7 +1,7 @@
 module RR
   module KeywordArguments
     class << self
-      if (RUBY_VERSION <=> "2.7.0") >= 0
+      if (RUBY_VERSION <=> "3.0.0") >= 0
         def fully_supported?
           true
         end
@@ -10,12 +10,6 @@ module RR
           false
         end
       end
-
-      def accept_kwargs?(subject_class, method_name)
-        subject_class.instance_method(method_name).parameters.any? { |t, _| t == :key || t == :keyrest }
-      rescue NameError
-        true
-      end
     end
   end
 end

data/lib/rr/method_dispatches/method_dispatch.rb

@@ -31,7 +31,7 @@ module RR
 
       def call_original_method
         if subject_has_original_method?
-          if KeywordArguments.fully_supported? && !kwargs.empty?
+          if KeywordArguments.fully_supported?
             subject.__send__(original_method_alias_name, *args, **kwargs, &block)
           else
             subject.__send__(original_method_alias_name, *args, &block)
@@ -53,7 +53,7 @@ module RR
           call_original_method
         else
           if implementation
-            if KeywordArguments.fully_supported? && kwargs.empty?
+            if KeywordArguments.fully_supported?
               implementation.call(*args, **kwargs, &block)
             else
               implementation.call(*args, &block)

data/lib/rr/method_dispatches/method_missing_dispatch.rb

@@ -52,7 +52,7 @@ module RR
           if double_injection = Injections::DoubleInjection.find(subject_class, method_name)
             double_injection.bind_method
             # The DoubleInjection takes care of calling double.method_call
-            if KeywordArguments.fully_supported? && !kwargs.empty?
+            if KeywordArguments.fully_supported?
               subject.__send__(method_name, *args, **kwargs, &block)
             else
               subject.__send__(method_name, *args, &block)

data/lib/rr/space.rb

@@ -22,6 +22,7 @@ module RR
         def method_missing(method_name, *args, &block)
           instance.__send__(method_name, *args, &block)
         end
+        ruby2_keywords(:method_missing) if respond_to?(:ruby2_keywords, true)
       end
     end
 

data/lib/rr/spy_verification.rb

@@ -1,9 +1,9 @@
 module RR
   class SpyVerification
-    def initialize(subject, method_name, args)
+    def initialize(subject, method_name, args, kwargs)
       @subject = subject
       @method_name = method_name.to_sym
-      set_argument_expectation_for_args(args)
+      set_argument_expectation_for_args(args, kwargs)
       @ordered = false
       once
     end
@@ -44,9 +44,17 @@ module RR
   protected
     attr_writer :times_matcher
 
-    def set_argument_expectation_for_args(args)
-      # with_no_args and with actually set @argument_expectation
-      args.empty? ? with_no_args : with(*args)
+    def set_argument_expectation_for_args(args, kwargs)
+      if args.empty? and kwargs.empty?
+        # with_no_args and with actually set @argument_expectation
+        with_no_args
+      else
+        if KeywordArguments.fully_supported?
+          with(*args, **kwargs)
+        else
+          with(*args)
+        end
+      end
     end
 
     def install_method_callback(return_value_block)

data/lib/rr/spy_verification_proxy.rb

@@ -5,9 +5,16 @@ module RR
     def initialize(subject)
       @subject = subject
     end
-  
-    def method_missing(method_name, *args, &block)
-      SpyVerification.new(@subject, method_name, args)
-    end  
+
+    if KeywordArguments.fully_supported?
+      def method_missing(method_name, *args, **kwargs, &block)
+        SpyVerification.new(@subject, method_name, args, kwargs)
+      end
+    else
+      def method_missing(method_name, *args, &block)
+        SpyVerification.new(@subject, method_name, args, {})
+      end
+      ruby2_keywords(:method_missing) if respond_to?(:ruby2_keywords, true)
+    end
   end
-end
+end

data/lib/rr/version.rb

@@ -1,4 +1,4 @@
 module RR
-  VERSION = '3.0.3'.freeze
+  VERSION = '3.0.7'.freeze
   def self.version; VERSION; end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rr
 version: !ruby/object:Gem::Version
-  version: 3.0.3
+  version: 3.0.7
 platform: ruby
 authors:
 - Kouhei Sutou
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-06-22 00:00:00.000000000 Z
+date: 2021-08-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler