rr 0.4.3 → 0.4.4

data/spec/rr/double/double_injection_bind_spec.rb

@@ -3,27 +3,23 @@ require "spec/spec_helper"
 module RR
   describe DoubleInjection, "#bind with an existing method" do
     before do
-      @space = Space.new
       @object = Object.new
       @method_name = :foobar
       def @object.foobar;
         :original_foobar;
       end
-      @original_method = @object.method(:foobar)
+      @original_method = @object.method(@method_name)
       @object.methods.should include(@method_name.to_s)
-      @double_insertion = DoubleInjection.new(@space, @object, @method_name)
+      @double_injection = DoubleInjection.new(@object, @method_name)
     end
 
-    it "overrides the original method with the double_insertion's dispatching methods" do
+    it "overrides the original method with the double_injection's dispatching methods" do
       @object.respond_to?(:__rr__foobar).should == false
-      @double_insertion.bind
+      @double_injection.bind
       @object.respond_to?(:__rr__foobar).should == true
 
       rr_foobar_called = false
-      (
-      class << @object;
-        self;
-      end).class_eval do
+      (class << @object; self; end).class_eval do
         define_method :__rr__foobar do
           rr_foobar_called = true
         end
@@ -35,7 +31,7 @@ module RR
     end
 
     it "stores original method in __rr__original_method_name" do
-      @double_insertion.bind
+      @double_injection.bind
       @object.respond_to?(:__rr__original_foobar).should == true
       @object.method(:__rr__original_foobar).should == @original_method
     end
@@ -43,23 +39,19 @@ module RR
 
   describe DoubleInjection, "#bind without an existing method" do
     before do
-      @space = Space.new
       @object = Object.new
       @method_name = :foobar
       @object.methods.should_not include(@method_name.to_s)
-      @double_insertion = DoubleInjection.new(@space, @object, @method_name)
+      @double_injection = DoubleInjection.new(@object, @method_name)
     end
 
-    it "overrides the original method with the double_insertion's dispatching methods" do
+    it "creates a new method with the double_injection's dispatching methods" do
       @object.respond_to?(:__rr__foobar).should == false
-      @double_insertion.bind
+      @double_injection.bind
       @object.respond_to?(:__rr__foobar).should == true
 
       rr_foobar_called = false
-      (
-      class << @object;
-        self;
-      end).class_eval do
+      (class << @object; self; end).class_eval do
         define_method :__rr__foobar do
           rr_foobar_called = true
         end
@@ -70,9 +62,44 @@ module RR
       rr_foobar_called.should == true
     end
 
-    it "stores original method in __rr__original_method_name" do
-      @double_insertion.bind
+    it "does not create method __rr__original_method_name" do
+      @double_injection.bind
       @object.respond_to?(:__rr__original_foobar).should == false
     end
   end
+
+  describe DoubleInjection, "#bind with ==" do
+    before do
+      @object = Object.new
+      @method_name = :'=='
+      @object.should respond_to(@method_name)
+      @original_method = @object.method(@method_name)
+      @object.methods.should include(@method_name.to_s)
+      @double_injection = DoubleInjection.new(@object, @method_name)
+    end
+
+    it "overrides the original method with the double_injection's dispatching methods" do
+      @object.respond_to?(:"__rr__#{@method_name}").should == false
+      @double_injection.bind
+      @object.respond_to?(:"__rr__#{@method_name}").should == true
+
+      override_called = false
+      method_name = @method_name
+      (class << @object; self; end).class_eval do
+        define_method :"__rr__#{method_name}" do
+          override_called = true
+        end
+      end
+
+      override_called.should == false
+      @object == 1
+      override_called.should == true
+    end
+
+    it "stores original method in __rr__original_method_name" do
+      @double_injection.bind
+      @object.respond_to?(:"__rr__original_#{@method_name}").should == true
+      @object.method(:"__rr__original_#{@method_name}").should == @original_method
+    end
+  end
 end

data/spec/rr/double/double_injection_dispatching_spec.rb

@@ -6,7 +6,7 @@ module RR
       @space = Space.new
       @object = Object.new
       @object.methods.should_not include(method_name.to_s)
-      @double_insertion = @space.double_insertion(@object, method_name)
+      @double_injection = @space.double_injection(@object, method_name)
     end
 
     describe "normal methods" do
@@ -22,7 +22,7 @@ module RR
               yield(a, b)
             end
           end
-          double = @space.double(@double_insertion)
+          double = @space.double(@double_injection)
           double.with(1, 2).implemented_by(method_fixture.method(:method_with_block))
           @object.foobar(1, 2) {|a, b| [b, a]}.should == [2, 1]
         end
@@ -30,11 +30,11 @@ module RR
 
       describe "where there are no doubles with duplicate ArgumentExpectations" do
         it "dispatches to Double that have an exact match" do
-          double1_with_exact_match = @space.double(@double_insertion)
+          double1_with_exact_match = @space.double(@double_injection)
           double1_with_exact_match.with(:exact_match_1).returns {:return_1}
-          double_with_no_match = @space.double(@double_insertion)
+          double_with_no_match = @space.double(@double_injection)
           double_with_no_match.with("nothing that matches").returns {:no_match}
-          double2_with_exact_match = @space.double(@double_insertion)
+          double2_with_exact_match = @space.double(@double_injection)
           double2_with_exact_match.with(:exact_match_2).returns {:return_2}
 
           @object.foobar(:exact_match_1).should == :return_1
@@ -42,9 +42,9 @@ module RR
         end
 
         it "dispatches to Double that have a wildcard match" do
-          double_with_wildcard_match = @space.double(@double_insertion)
+          double_with_wildcard_match = @space.double(@double_injection)
           double_with_wildcard_match.with_any_args.returns {:wild_card_value}
-          double_with_no_match = @space.double(@double_insertion)
+          double_with_no_match = @space.double(@double_injection)
           double_with_no_match.with("nothing that matches").returns {:no_match}
 
           @object.foobar(:wildcard_match_1).should == :wild_card_value
@@ -54,18 +54,24 @@ module RR
 
       describe "where there are doubles" do
         it "raises DoubleNotFoundError error when arguments do not match a double" do
-          double_1 = @space.double(@double_insertion)
+          double_1 = @space.double(@double_injection)
           double_1.with(1, 2)
 
-          double_2 = @space.double(@double_insertion)
+          double_2 = @space.double(@double_injection)
           double_2.with(3)
 
-          proc {@object.foobar(:arg1, :arg2)}.should raise_error(
-          Errors::DoubleNotFoundError,
-          "Unexpected method invocation foobar(:arg1, :arg2), expected\n" <<
-          "- foobar(1, 2)\n" <<
-          "- foobar(3)"
-          )
+          error = nil
+          begin
+            @object.foobar(:arg1, :arg2)
+            viotated "Error should have been raised"
+          rescue Errors::DoubleNotFoundError => e
+            error = e
+          end
+          error.message.should include("On object #<Object")
+          expected_double_message_part = "unexpected method invocation foobar(:arg1, :arg2), expected\n" <<
+            "- foobar(1, 2)\n" <<
+            "- foobar(3)"
+          error.message.should include(expected_double_message_part)
         end
       end
 
@@ -102,7 +108,7 @@ module RR
         end
 
         def double(*arguments, &return_value)
-          double = @space.double(@double_insertion)
+          double = @space.double(@double_injection)
           double.with(*arguments).any_number_of_times.returns(&return_value)
           double.should_not be_terminal
           double
@@ -144,7 +150,7 @@ module RR
         end
 
         def double(*arguments, &return_value)
-          double = @space.double(@double_insertion)
+          double = @space.double(@double_injection)
           double.with(*arguments).once.returns(&return_value)
           double.should be_terminal
           double
@@ -186,7 +192,7 @@ module RR
         end
 
         def double(&return_value)
-          double = @space.double(@double_insertion)
+          double = @space.double(@double_injection)
           double.with_any_args.once.returns(&return_value)
           double.should be_terminal
           double
@@ -200,7 +206,7 @@ module RR
       end
 
       it "executes the block" do
-        double = @space.double(@double_insertion)
+        double = @space.double(@double_injection)
         double.with(1, 2) {:return_value}
         @object.foobar!(1, 2).should == :return_value
       end
@@ -212,7 +218,7 @@ module RR
       end
 
       it "executes the block" do
-        double = @space.double(@double_insertion)
+        double = @space.double(@double_injection)
         double.with(1, 2) {:return_value}
         @object.foobar?(1, 2).should == :return_value
       end

data/spec/rr/double/double_injection_has_original_method_spec.rb

@@ -3,22 +3,21 @@ require "spec/spec_helper"
 module RR
   describe DoubleInjection, "#object_has_original_method?" do
     before do
-      @space = Space.new
       @object = Object.new
       @method_name = :to_s
-      @double_insertion = DoubleInjection.new(@space, @object, @method_name)
-      class << @double_insertion
+      @double_injection = DoubleInjection.new(@object, @method_name)
+      class << @double_injection
         public :original_method_name
       end
     end
 
     it "returns true when method is still in object" do
-      @double_insertion.bind
-      @double_insertion.object_has_original_method?.should be_true
+      @double_injection.bind
+      @double_injection.object_has_original_method?.should be_true
     end
 
     it "returns true when respond_to is true and methods include method" do
-      @double_insertion.bind
+      @double_injection.bind
       def @object.methods
         [:__rr_original_to_s]
       end
@@ -26,11 +25,11 @@ module RR
         true
       end
 
-      @double_insertion.object_has_original_method?.should be_true
+      @double_injection.object_has_original_method?.should be_true
     end
 
     it "returns true when respond_to is true and methods do not include method" do
-      @double_insertion.bind
+      @double_injection.bind
       def @object.methods
         []
       end
@@ -38,11 +37,11 @@ module RR
         true
       end
 
-      @double_insertion.object_has_original_method?.should be_true
+      @double_injection.object_has_original_method?.should be_true
     end
 
     it "returns false when respond_to is false and methods do not include method" do
-      @double_insertion.bind
+      @double_injection.bind
       def @object.methods
         []
       end
@@ -50,7 +49,7 @@ module RR
         false
       end
 
-      @double_insertion.object_has_original_method?.should be_false
+      @double_injection.object_has_original_method?.should be_false
     end
   end
 end

data/spec/rr/double/double_injection_register_scenario_spec.rb

@@ -7,18 +7,18 @@ module RR
       @object = Object.new
       @method_name = :foobar
       @object.methods.should_not include(@method_name.to_s)
-      @double_insertion = DoubleInjection.new(@space, @object, @method_name)
-      def @double_insertion.doubles
+      @double_injection = DoubleInjection.new(@object, @method_name)
+      def @double_injection.doubles
         @doubles
       end
     end
 
     it "adds the double to the doubles list" do
-      double = Double.new(@space, @double_insertion, @space.double_definition)
+      double = Double.new(@space, @double_injection, @space.double_definition)
 
-      @double_insertion.doubles.should_not include(double)
-      @double_insertion.register_double double
-      @double_insertion.doubles.should include(double)
+      @double_injection.doubles.should_not include(double)
+      @double_injection.register_double double
+      @double_injection.doubles.should include(double)
     end
   end
 end

data/spec/rr/double/double_injection_reset_spec.rb

@@ -3,10 +3,10 @@ require "spec/spec_helper"
 module RR
   describe DoubleInjection, "#reset", :shared => true do
     it "cleans up by removing the __rr__method" do
-      @double_insertion.bind
+      @double_injection.bind
       @object.methods.should include("__rr__foobar")
 
-      @double_insertion.reset
+      @double_injection.reset
       @object.methods.should_not include("__rr__foobar")
     end
   end
@@ -15,18 +15,17 @@ module RR
     it_should_behave_like "RR::DoubleInjection#reset"
 
     before do
-      @space = Space.new
       @object = Object.new
       @method_name = :foobar
       @object.methods.should_not include(@method_name.to_s)
-      @double_insertion = DoubleInjection.new(@space, @object, @method_name)
+      @double_injection = DoubleInjection.new(@object, @method_name)
     end
 
     it "removes the method" do
-      @double_insertion.bind
+      @double_injection.bind
       @object.methods.should include(@method_name.to_s)
 
-      @double_insertion.reset
+      @double_injection.reset
       @object.methods.should_not include(@method_name.to_s)
       proc {@object.foobar}.should raise_error(NoMethodError)
     end
@@ -36,7 +35,6 @@ module RR
     it_should_behave_like "RR::DoubleInjection#reset"
 
     before do
-      @space = Space.new
       @object = Object.new
       @method_name = :foobar
       def @object.foobar
@@ -44,14 +42,14 @@ module RR
       end
       @object.methods.should include(@method_name.to_s)
       @original_method = @object.method(@method_name)
-      @double_insertion = DoubleInjection.new(@space, @object, @method_name)
+      @double_injection = DoubleInjection.new(@object, @method_name)
 
-      @double_insertion.bind
+      @double_injection.bind
       @object.methods.should include(@method_name.to_s)
     end
 
     it "rebind original method" do
-      @double_insertion.reset
+      @double_injection.reset
       @object.methods.should include(@method_name.to_s)
       @object.foobar.should == :original_foobar
     end
@@ -61,7 +59,6 @@ module RR
     it_should_behave_like "RR::DoubleInjection#reset"
 
     before do
-      @space = Space.new
       @object = Object.new
       @method_name = :foobar
       def @object.foobar
@@ -69,14 +66,14 @@ module RR
       end
       @object.methods.should include(@method_name.to_s)
       @original_method = @object.method(@method_name)
-      @double_insertion = DoubleInjection.new(@space, @object, @method_name)
+      @double_injection = DoubleInjection.new(@object, @method_name)
 
-      @double_insertion.bind
+      @double_injection.bind
       @object.methods.should include(@method_name.to_s)
     end
 
     it "rebinds original method with block" do
-      @double_insertion.reset
+      @double_injection.reset
       @object.methods.should include(@method_name.to_s)
 
       original_argument = nil

data/spec/rr/double/double_injection_spec.rb

@@ -3,8 +3,8 @@ require "spec/spec_helper"
 module RR
   describe DoubleInjection, :shared => true do
     it "sets up object and method_name" do
-      @double_insertion.object.should === @object
-      @double_insertion.method_name.should == @method_name.to_sym
+      @double_injection.object.should === @object
+      @double_injection.method_name.should == @method_name.to_sym
     end
   end
 
@@ -12,11 +12,10 @@ module RR
     it_should_behave_like "RR::DoubleInjection"
 
     before do
-      @space = Space.new
       @object = Object.new
       @method_name = :foobar
       @object.methods.should_not include(@method_name.to_s)
-      @double_insertion = DoubleInjection.new(@space, @object, @method_name)
+      @double_injection = DoubleInjection.new(@object, @method_name)
     end
   end
 
@@ -24,11 +23,10 @@ module RR
     it_should_behave_like "RR::DoubleInjection"
 
     before do
-      @space = Space.new
       @object = Object.new
       @method_name = 'foobar'
       @object.methods.should_not include(@method_name)
-      @double_insertion = DoubleInjection.new(@space, @object, @method_name)
+      @double_injection = DoubleInjection.new(@object, @method_name)
     end
   end
 
@@ -36,15 +34,14 @@ module RR
     it_should_behave_like "RR::DoubleInjection"
 
     before do
-      @space = Space.new
       @object = Object.new
       @method_name = :foobar
       @object.methods.should_not include(@method_name.to_s)
-      @double_insertion = DoubleInjection.new(@space, @object, @method_name)
+      @double_injection = DoubleInjection.new(@object, @method_name)
     end
 
     it "object does not have original method" do
-      @double_insertion.object_has_original_method?.should be_false
+      @double_injection.object_has_original_method?.should be_false
     end
   end
 
@@ -52,15 +49,24 @@ module RR
     it_should_behave_like "RR::DoubleInjection"
 
     before do
-      @space = Space.new
       @object = Object.new
       @method_name = :to_s
       @object.methods.should include(@method_name.to_s)
-      @double_insertion = DoubleInjection.new(@space, @object, @method_name)
+      @double_injection = DoubleInjection.new(@object, @method_name)
     end
 
     it "has a original_method" do
-      @double_insertion.object_has_original_method?.should be_true
+      @double_injection.object_has_original_method?.should be_true
     end
   end
+
+  describe DoubleInjection, "#initialize where method_name is ==" do
+    it_should_behave_like "RR::DoubleInjection"
+
+    before do
+      @object = Object.new
+      @method_name = '=='
+      @double_injection = DoubleInjection.new(@object, @method_name)
+    end
+  end  
 end