rpx_now 0.6.11 → 0.6.12

data/CHANGELOG

@@ -1,3 +1,6 @@
+0.6.12
+-----
+ * url encode obstrusive popup code token-url
 0.6.0
 -----
  * removed optional api key as parameter: RPXNow.user_data(token, api_key, options) --> RPXNow.user_data(token, options), you may use :apiKey=>... instead

data/README.markdown

@@ -128,6 +128,7 @@ __[rpx_now_gem mailing list](http://groups.google.com/group/rpx_now_gem)__
  - [Amunds](http://github.com/Amunds)
  - [DBA](http://github.com/DBA)
  - [dbalatero](http://github.com/dbalatero)
+ - [Paul Gallagher](http://tardate.blogspot.com/)
  - [jackdempsey](http://jackndempsey.blogspot.com)
  - [Patrick Reagan (reagent)](http://sneaq.net)
  - [Joris Trooster (trooster)](http://www.interstroom.nl)

data/VERSION

@@ -1 +1 @@
-0.6.11
+0.6.12

data/lib/rpx_now.rb

@@ -1,5 +1,6 @@
 require 'rpx_now/api'
 require 'rpx_now/contacts_collection'
+require 'cgi'
 
 module RPXNow
   extend self
@@ -105,7 +106,7 @@ module RPXNow
 
   def self.embed_params(url, options)
     {
-      :token_url => url,
+      :token_url => CGI::escape( url ),
       :language_preference => options[:language],
       :flags => options[:flags],
       :default_provider => options[:default_provider]

data/rpx_now.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{rpx_now}
-  s.version = "0.6.11"
+  s.version = "0.6.12"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Michael Grosser"]
-  s.date = %q{2009-11-22}
+  s.date = %q{2010-01-16}
   s.email = %q{grosser.michael@gmail.com}
   s.extra_rdoc_files = [
     "README.markdown"

data/spec/rpx_now/api_spec.rb

@@ -3,7 +3,7 @@ require 'spec/spec_helper'
 describe RPXNow::Api do
   describe 'ssl cert' do
     it "has an absolute path" do
-      RPXNow::Api::SSL_CERT[0..0].should == '/' #start with '/'
+      RPXNow::Api::SSL_CERT[0..0].should == File.expand_path( RPXNow::Api::SSL_CERT )[0..0] # start with '/' on *nix, drive letter on win
     end
 
     it "exists" do

data/spec/rpx_now_spec.rb

@@ -112,9 +112,20 @@ describe RPXNow do
       options.should == {:xxx => 1}
     end
 
+    describe 'obstrusive' do
+      it "does not encode token_url for popup" do
+        expected = %Q(RPXNOW.token_url = 'http://fake.domain.com/')
+        RPXNow.popup_code('sign on', 'subdomain', 'http://fake.domain.com/').should include(expected)
+      end
+      it "encodes token_url for unobtrusive fallback link" do
+        expected = %Q(<a class="rpxnow" href="https://subdomain.rpxnow.com/openid/v2/signin?token_url=http%3A%2F%2Ffake.domain.com%2F">sign on</a>)
+        RPXNow.popup_code('sign on', 'subdomain', 'http://fake.domain.com/').should include(expected)
+      end
+    end
+    
     describe 'unobstrusive' do
-      it "can build an unobtrusive widget" do
-        expected = %Q(<a class="rpxnow" href="https://subdomain.rpxnow.com/openid/v2/signin?token_url=http://fake.domain.com/">sign on</a>)
+      it "can build an unobtrusive widget with encoded token_url" do
+        expected = %Q(<a class="rpxnow" href="https://subdomain.rpxnow.com/openid/v2/signin?token_url=http%3A%2F%2Ffake.domain.com%2F">sign on</a>)
         actual = RPXNow.popup_code('sign on', 'subdomain', 'http://fake.domain.com/', :unobtrusive => true)
         actual.should == expected
       end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: rpx_now
 version: !ruby/object:Gem::Version 
-  version: 0.6.11
+  version: 0.6.12
 platform: ruby
 authors: 
 - Michael Grosser
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-11-22 00:00:00 +01:00
+date: 2010-01-16 00:00:00 +01:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency