rpush 4.1.1 → 4.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f974d91d6caa8c660383285d254a61dbb001fd7a4000540cc76b798f77b09d9f
-  data.tar.gz: 3d4fe2bfc3b354b6c25cc47a5a81f0f40e6a3a6b38ac9750fac1c117555e379f
+  metadata.gz: 91aa7f4768e10352a77935b5ac2fbf8dd8c992de2267718c15621d1a50b7a890
+  data.tar.gz: bd90e3daaac2067e15848a5616b01e3e76aa51d62e177b3307a7147488fccbe6
 SHA512:
-  metadata.gz: 6a4d532a9c05739a246454c0194552a84270a4f3dc864f7279cb3ca2671e1fe02bc624ecad001083aa5745c21fd428af04b8aa4833581def109e77a6a5df7207
-  data.tar.gz: 6b1311abb89a2d78e4aa447521815177a6cc7b546665b636685fe600c8219d35833ccc79fae892496b6488f3b444b886395700b09fdb3c76268ecd55e0878ab3
+  metadata.gz: 3efd360c52d048188749ad07de23b0aec1590f306ecd735eeb676fa7026273429a97c2719caf050a72d91ef533005f99adb0499b7c3f6aa5269a5143d6643c72
+  data.tar.gz: c7b3d1acbb95bf1e298851f3cdbd5b17833dc90aa621dd5482578e0400266e11d87580578087cd402e0449f69f076bcf621db200f175b8393c59277f23ff8482

data/CHANGELOG.md

@@ -1,5 +1,29 @@
 # Changelog
 
+## Unreleased
+
+Nothing so far.
+
+## 4.2.0 (2019-12-13)
+
+[Full Changelog](https://github.com/rpush/rpush/compare/v4.1.1...v4.2.0)
+
+**Merged pull requests:**
+
+- Fix Rails 6.1 related deprecation warnings [\#541](https://github.com/rpush/rpush/pull/541) ([dsantosmerino](https://github.com/dsantosmerino))
+- GCM notification incorrectly mixes data into notification hashes [\#535](https://github.com/rpush/rpush/pull/535) ([mkon](https://github.com/mkon))
+- handle priority in WNS [\#533](https://github.com/rpush/rpush/pull/533) ([Fivell](https://github.com/Fivell))
+- Update development apns urls to match documentation [\#524](https://github.com/rpush/rpush/pull/524) ([jhottenstein](https://github.com/jhottenstein))
+- Update README to remove incorrect info [\#523](https://github.com/rpush/rpush/pull/523) ([sharang-d](https://github.com/sharang-d))
+- Fix and improve Travis setup [\#520](https://github.com/rpush/rpush/pull/520) ([aried3r](https://github.com/aried3r))
+- Explicitly use Rails 6.0.0 [\#519](https://github.com/rpush/rpush/pull/519) ([jsantos](https://github.com/jsantos))
+- Stale bot config change [\#515](https://github.com/rpush/rpush/pull/515) ([aried3r](https://github.com/aried3r))
+- Add stale bot configuration. [\#514](https://github.com/rpush/rpush/pull/514) ([drn](https://github.com/drn))
+- Correctly use feedback_enabled. [\#511](https://github.com/rpush/rpush/pull/511) ([kirbycool](https://github.com/kirbycool))
+- Update apns_http2.rb [\#510](https://github.com/rpush/rpush/pull/510) ([mldoscar](https://github.com/mldoscar))
+- Add `mutable_content` support for GCM [\#506](https://github.com/rpush/rpush/pull/506) ([hon3st](https://github.com/hon3st))
+- Add support for critical alerts [\#502](https://github.com/rpush/rpush/pull/502) ([servn](https://github.com/servn))
+
 ## 4.1.1 (2019-05-13)
 
 ### Added

data/README.md

@@ -21,7 +21,7 @@ Rpush aims to be the *de facto* gem for sending push notifications in Ruby. Its
 
 #### Feature Highlights
 
-* Use [**ActiveRecord**](https://github.com/rpush/rpush/wiki/Using-ActiveRecord) or [**Redis**](https://github.com/rpush/rpush/wiki/Using-Redis) for storage. **Note:** Redis support for Rails 5.2 is not yet working if you're using Modis, see [this issue](https://github.com/ileitch/modis/issues/13).
+* Use [**ActiveRecord**](https://github.com/rpush/rpush/wiki/Using-ActiveRecord) or [**Redis**](https://github.com/rpush/rpush/wiki/Using-Redis) for storage.
 * Plugins for [**Bugsnag**](https://github.com/rpush/rpush-plugin-bugsnag),
 [**Sentry**](https://github.com/rpush/rpush-plugin-sentry), [**StatsD**](https://github.com/rpush/rpush-plugin-statsd) or [write your own](https://github.com/rpush/rpush/wiki/Writing-a-Plugin).
 * Seamless integration with your projects, including **Rails**.

data/lib/generators/rpush_migration_generator.rb

@@ -52,6 +52,7 @@ class RpushMigrationGenerator < Rails::Generators::Base
     add_rpush_migration('rpush_3_3_1_updates')
     add_rpush_migration('rpush_4_1_0_updates')
     add_rpush_migration('rpush_4_1_1_updates')
+    add_rpush_migration('rpush_4_2_0_updates')
   end
 
   protected

data/lib/generators/templates/rpush_4_2_0_updates.rb

@@ -0,0 +1,10 @@
+class Rpush420Updates < ActiveRecord::VERSION::MAJOR >= 5 ? ActiveRecord::Migration["#{ActiveRecord::VERSION::MAJOR}.#{ActiveRecord::VERSION::MINOR}"] : ActiveRecord::Migration
+  def self.up
+    add_column :rpush_notifications, :sound_is_json, :boolean, null: true, default: false
+  end
+
+  def self.down
+    remove_column :rpush_notifications, :sound_is_json
+  end
+end
+

data/lib/rpush/client/active_model/gcm/notification.rb

@@ -35,7 +35,7 @@ module Rpush
             end
           end
 
-          def as_json(options = nil)
+          def as_json(options = nil) # rubocop:disable Metrics/PerceivedComplexity
             json = {
                 'registration_ids' => registration_ids,
                 'delay_while_idle' => delay_while_idle,
@@ -43,6 +43,7 @@ module Rpush
             }
             json['collapse_key'] = collapse_key if collapse_key
             json['content_available'] = content_available if content_available
+            json['mutable_content'] = mutable_content if mutable_content
             json['dry_run'] = dry_run if dry_run
             json['notification'] = notification if notification
             json['priority'] = priority_for_notification if priority

data/lib/rpush/client/active_model/wns/notification.rb

@@ -3,6 +3,13 @@ module Rpush
     module ActiveModel
       module Wns
         module Notification
+          WNS_PRIORITY_HIGH = 1
+          WNS_PRIORITY_MEDIUM = 2
+          WNS_PRIORITY_LOW = 3
+          WNS_PRIORITY_VERY_LOW = 4
+
+          WNS_PRIORITIES = [WNS_PRIORITY_HIGH, WNS_PRIORITY_MEDIUM, WNS_PRIORITY_LOW, WNS_PRIORITY_VERY_LOW]
+
           module InstanceMethods
             def alert=(value)
               return unless value
@@ -23,6 +30,7 @@ module Rpush
               validates :uri, presence: true
               validates :uri, format: { with: %r{https?://[\S]+} }
               validates :data, presence: true, unless: :skip_data_validation?
+              validates :priority, inclusion: { in: WNS_PRIORITIES }, allow_nil: true
             end
           end
         end

data/lib/rpush/client/active_record/apns/notification.rb

@@ -33,6 +33,34 @@ module Rpush
               end
             end
           end
+
+          def sound=(sound)
+            if sound.is_a?(Hash)
+              write_attribute(:sound, multi_json_dump(sound))
+              self.sound_is_json = true if has_attribute?(:sound_is_json)
+            else
+              write_attribute(:sound, sound)
+              self.sound_is_json = false if has_attribute?(:sound_is_json)
+            end
+          end
+
+          def sound
+            string_or_json = read_attribute(:sound)
+
+            if has_attribute?(:sound_is_json)
+              if sound_is_json?
+                multi_json_load(string_or_json)
+              else
+                string_or_json
+              end
+            else
+              begin
+                multi_json_load(string_or_json)
+              rescue StandardError
+                string_or_json
+              end
+            end
+          end
         end
       end
     end

data/lib/rpush/client/active_record/app.rb

@@ -6,7 +6,7 @@ module Rpush
 
         has_many :notifications, class_name: 'Rpush::Client::ActiveRecord::Notification', dependent: :destroy
 
-        validates :name, presence: true, uniqueness: { scope: [:type, :environment] }
+        validates :name, presence: true, uniqueness: { scope: [:type, :environment], case_sensitive: true }
       end
     end
   end

data/lib/rpush/client/active_record/notification.rb

@@ -21,7 +21,7 @@ module Rpush
         def notification=(attrs)
           return unless attrs
           fail ArgumentError, 'must be a Hash' unless attrs.is_a?(Hash)
-          write_attribute(:notification, multi_json_dump(attrs.merge(data || {})))
+          write_attribute(:notification, multi_json_dump(attrs.merge(notification || {})))
         end
 
         def registration_ids=(ids)

data/lib/rpush/client/redis/notification.rb

@@ -20,7 +20,7 @@ module Rpush
 
         attribute :badge, :integer
         attribute :device_token, :string
-        attribute :sound, :string, default: 'default'
+        attribute :sound, [:string, :hash], strict: false, default: 'default'
         attribute :alert, [:string, :hash], strict: false
         attribute :data, :hash
         attribute :expiry, :integer, default: 1.day.to_i
@@ -34,6 +34,7 @@ module Rpush
         attribute :error_description, :string
         attribute :deliver_after, :timestamp
         attribute :alert_is_json, :boolean
+        attribute :sound_is_json, :boolean
         attribute :app_id, :integer
         attribute :collapse_key, :string
         attribute :delay_while_idle, :boolean

data/lib/rpush/daemon/apns/feedback_receiver.rb

@@ -24,6 +24,7 @@ module Rpush
 
         def start
           return if Rpush.config.push
+          return unless @app.feedback_enabled
           Rpush.logger.info("[#{@app.name}] Starting feedback receiver... ", true)
 
           @thread = Thread.new do

data/lib/rpush/daemon/dispatcher/apns_http2.rb

@@ -2,11 +2,13 @@ module Rpush
   module Daemon
     module Dispatcher
       class ApnsHttp2
+        include Loggable
+        include Reflectable
 
         URLS = {
           production: 'https://api.push.apple.com:443',
-          development: 'https://api.development.push.apple.com:443',
-          sandbox: 'https://api.development.push.apple.com:443'
+          development: 'https://api.sandbox.push.apple.com:443',
+          sandbox: 'https://api.sandbox.push.apple.com:443'
         }
 
         DEFAULT_TIMEOUT = 60

data/lib/rpush/daemon/dispatcher/apnsp8_http2.rb

@@ -7,7 +7,8 @@ module Rpush
 
         URLS = {
           production: 'https://api.push.apple.com',
-          development: 'https://api.development.push.apple.com'
+          development: 'https://api.sandbox.push.apple.com',
+          sandbox: 'https://api.sandbox.push.apple.com'
         }
 
         DEFAULT_TIMEOUT = 60

data/lib/rpush/daemon/signal_handler.rb

@@ -29,7 +29,7 @@ module Rpush
 
       def self.start_handler(read_io)
         @thread = Thread.new do
-          while readable_io = IO.select([read_io]) # rubocop:disable AssignmentInCondition
+          while readable_io = IO.select([read_io]) # rubocop:disable Lint/AssignmentInCondition
             signal = readable_io.first[0].gets.strip
 
             begin

data/lib/rpush/daemon/store/active_record.rb

@@ -183,7 +183,7 @@ module Rpush
 
         private
 
-        def create_gcm_like_notification(notification, attrs, data, registration_ids, deliver_after, app) # rubocop:disable ParameterLists
+        def create_gcm_like_notification(notification, attrs, data, registration_ids, deliver_after, app) # rubocop:disable Metrics/ParameterLists
           with_database_reconnect_and_retry do
             notification.assign_attributes(attrs)
             notification.data = data

data/lib/rpush/daemon/store/redis.rb

@@ -138,7 +138,7 @@ module Rpush
           nil
         end
 
-        def create_gcm_like_notification(notification, attrs, data, registration_ids, deliver_after, app) # rubocop:disable ParameterLists
+        def create_gcm_like_notification(notification, attrs, data, registration_ids, deliver_after, app) # rubocop:disable Metrics/ParameterLists
           notification.assign_attributes(attrs)
           notification.data = data
           notification.registration_ids = registration_ids

data/lib/rpush/daemon/wns/badge_request.rb

@@ -4,14 +4,19 @@ module Rpush
       class BadgeRequest
         def self.create(notification, access_token)
           body = BadgeRequestPayload.new(notification).to_xml
-          uri  = URI.parse(notification.uri)
-          post = Net::HTTP::Post.new(
-            uri.request_uri,
+          uri = URI.parse(notification.uri)
+          headers = {
             "Content-Length" => body.length.to_s,
             "Content-Type" => "text/xml",
             "X-WNS-Type" => "wns/badge",
             "X-WNS-RequestForStatus" => "true",
             "Authorization" => "Bearer #{access_token}"
+          }
+          headers['X-WNS-PRIORITY'] = notification.priority.to_s if notification.priority
+
+          post = Net::HTTP::Post.new(
+            uri.request_uri,
+            headers
           )
           post.body = body
           post

data/lib/rpush/daemon/wns/raw_request.rb

@@ -5,14 +5,21 @@ module Rpush
         def self.create(notification, access_token)
           body = notification.data.to_json
           uri = URI.parse(notification.uri)
-          post = Net::HTTP::Post.new(
-            uri.request_uri,
+          headers = {
             "Content-Length" => body.length.to_s,
             "Content-Type" => "application/octet-stream",
             "X-WNS-Type" => "wns/raw",
             "X-WNS-RequestForStatus" => "true",
             "Authorization" => "Bearer #{access_token}"
+          }
+
+          headers['X-WNS-PRIORITY'] = notification.priority.to_s if notification.priority
+
+          post = Net::HTTP::Post.new(
+            uri.request_uri,
+            headers
           )
+
           post.body = body
           post
         end

data/lib/rpush/daemon/wns/toast_request.rb

@@ -5,13 +5,17 @@ module Rpush
         def self.create(notification, access_token)
           body = ToastRequestPayload.new(notification).to_xml
           uri  = URI.parse(notification.uri)
-          post = Net::HTTP::Post.new(
-            uri.request_uri,
+          headers = {
             "Content-Length" => body.length.to_s,
             "Content-Type" => "text/xml",
             "X-WNS-Type" => "wns/toast",
             "X-WNS-RequestForStatus" => "true",
             "Authorization" => "Bearer #{access_token}"
+          }
+          headers['X-WNS-PRIORITY'] = notification.priority.to_s if notification.priority
+          post = Net::HTTP::Post.new(
+            uri.request_uri,
+            headers
           )
           post.body = body
           post

data/lib/rpush/version.rb

@@ -1,8 +1,8 @@
 module Rpush
   module VERSION
     MAJOR = 4
-    MINOR = 1
-    TINY = 1
+    MINOR = 2
+    TINY = 0
     PRE = nil
 
     STRING = [MAJOR, MINOR, TINY, PRE].compact.join(".").freeze

data/spec/.rubocop.yml

@@ -1,4 +1,4 @@
 inherit_from: ../.rubocop.yml
 
-RescueModifier:
+Style/RescueModifier:
   Enabled: false

data/spec/support/active_record_setup.rb

@@ -41,6 +41,7 @@ require 'generators/templates/rpush_3_3_0_updates'
 require 'generators/templates/rpush_3_3_1_updates'
 require 'generators/templates/rpush_4_1_0_updates'
 require 'generators/templates/rpush_4_1_1_updates'
+require 'generators/templates/rpush_4_2_0_updates'
 
 migrations = [
   AddRpush,
@@ -57,7 +58,8 @@ migrations = [
   Rpush330Updates,
   Rpush331Updates,
   Rpush410Updates,
-  Rpush411Updates
+  Rpush411Updates,
+  Rpush420Updates
 ]
 
 unless ENV['TRAVIS']

data/spec/unit/client/active_record/apns/notification_spec.rb

@@ -82,8 +82,8 @@ describe Rpush::Client::ActiveRecord::Apns::Notification, "as_json" do
   end
 
   it "should include the sound if present" do
-    notification = Rpush::Client::ActiveRecord::Apns::Notification.new(alert: "my_sound.aiff")
-    expect(notification.as_json["aps"]["alert"]).to eq "my_sound.aiff"
+    notification = Rpush::Client::ActiveRecord::Apns::Notification.new(sound: "my_sound.aiff")
+    expect(notification.as_json["aps"]["sound"]).to eq "my_sound.aiff"
   end
 
   it "should not include the sound key if the sound is not present" do
@@ -91,6 +91,11 @@ describe Rpush::Client::ActiveRecord::Apns::Notification, "as_json" do
     expect(notification.as_json["aps"].key?("sound")).to be_falsey
   end
 
+  it "should encode the sound as JSON if it is a Hash" do
+    notification = Rpush::Client::ActiveRecord::Apns::Notification.new(sound: { 'name' => "my_sound.aiff", 'critical' => 1, 'volume' => 0.5 })
+    expect(notification.as_json["aps"]["sound"]).to eq('name' => "my_sound.aiff", 'critical' => 1, 'volume' => 0.5)
+  end
+
   it "should include attributes for the device" do
     notification = Rpush::Client::ActiveRecord::Apns::Notification.new
     notification.data = { omg: :lol, wtf: :dunno }

data/spec/unit/client/active_record/gcm/notification_spec.rb

@@ -37,6 +37,11 @@ describe Rpush::Client::ActiveRecord::Gcm::Notification do
     expect(notification.as_json['content_available']).to eq true
   end
 
+  it 'includes mutable_content in the payload' do
+    notification.mutable_content = true
+    expect(notification.as_json['mutable_content']).to eq true
+  end
+
   it 'sets the priority to high when set to high' do
     notification.priority = 'high'
     expect(notification.as_json['priority']).to eq 'high'

data/spec/unit/client/active_record/notification_spec.rb

@@ -18,4 +18,11 @@ describe Rpush::Client::ActiveRecord::Notification do
     expect(notification.app).to be_valid
     expect(notification).to be_valid
   end
+
+  it 'does not mix notification and data payloads' do
+    notification.data = { key: 'this is data' }
+    notification.notification = { key: 'this is notification' }
+    expect(notification.data).to eq('key' => 'this is data')
+    expect(notification.notification).to eq('key' => 'this is notification')
+  end
 end if active_record?

data/spec/unit/daemon/apns/feedback_receiver_spec.rb

@@ -7,7 +7,16 @@ describe Rpush::Daemon::Apns::FeedbackReceiver, 'check_for_feedback' do
   let(:frequency) { 60 }
   let(:certificate) { double }
   let(:password) { double }
-  let(:app) { double(name: 'my_app', password: password, certificate: certificate, environment: 'production') }
+  let(:feedback_enabled) { true }
+  let(:app) do
+    double(
+      name: 'my_app',
+      password: password,
+      certificate: certificate,
+      feedback_enabled: feedback_enabled,
+      environment: 'production'
+    )
+  end
   let(:connection) { double(connect: nil, read: nil, close: nil) }
   let(:logger) { double(error: nil, info: nil) }
   let(:receiver) { Rpush::Daemon::Apns::FeedbackReceiver.new(app) }
@@ -93,6 +102,15 @@ describe Rpush::Daemon::Apns::FeedbackReceiver, 'check_for_feedback' do
       expect(receiver).to receive(:check_for_feedback).at_least(:once)
       receiver.start
     end
+
+    context 'with feedback_enabled false' do
+      let(:feedback_enabled) { false }
+
+      it 'does not check for feedback when started' do
+        expect(receiver).not_to receive(:check_for_feedback)
+        receiver.start
+      end
+    end
   end
 
   describe 'stop' do

data/spec/unit/daemon/gcm/delivery_spec.rb

@@ -40,7 +40,7 @@ describe Rpush::Daemon::Gcm::Delivery do
     end
 
     it 'creates a new notification for the unavailable devices' do
-      notification.update_attributes(registration_ids: %w(id_0 id_1 id_2), data: { 'one' => 1 }, collapse_key: 'thing', delay_while_idle: true)
+      notification.update(registration_ids: %w(id_0 id_1 id_2), data: { 'one' => 1 }, collapse_key: 'thing', delay_while_idle: true)
       allow(response).to receive_messages(header: { 'retry-after' => 10 })
       attrs = { 'collapse_key' => 'thing', 'delay_while_idle' => true, 'app_id' => app.id }
       expect(store).to receive(:create_gcm_notification).with(attrs, notification.data,

data/spec/unit/daemon/store/active_record_spec.rb

@@ -69,27 +69,27 @@ describe Rpush::Daemon::Store::ActiveRecord do
     end
 
     it 'loads an undelivered notification without deliver_after set' do
-      notification.update_attributes!(delivered: false, deliver_after: nil)
+      notification.update!(delivered: false, deliver_after: nil)
       expect(store.deliverable_notifications(Rpush.config.batch_size)).to eq [notification]
     end
 
     it 'loads an notification with a deliver_after time in the past' do
-      notification.update_attributes!(delivered: false, deliver_after: 1.hour.ago)
+      notification.update!(delivered: false, deliver_after: 1.hour.ago)
       expect(store.deliverable_notifications(Rpush.config.batch_size)).to eq [notification]
     end
 
     it 'does not load an notification with a deliver_after time in the future' do
-      notification.update_attributes!(delivered: false, deliver_after: 1.hour.from_now)
+      notification.update!(delivered: false, deliver_after: 1.hour.from_now)
       expect(store.deliverable_notifications(Rpush.config.batch_size)).to be_empty
     end
 
     it 'does not load a previously delivered notification' do
-      notification.update_attributes!(delivered: true, delivered_at: time)
+      notification.update!(delivered: true, delivered_at: time)
       expect(store.deliverable_notifications(Rpush.config.batch_size)).to be_empty
     end
 
     it "does not enqueue a notification that has previously failed delivery" do
-      notification.update_attributes!(delivered: false, failed: true)
+      notification.update!(delivered: false, failed: true)
       expect(store.deliverable_notifications(Rpush.config.batch_size)).to be_empty
     end
   end

data/spec/unit/daemon/store/redis_spec.rb

@@ -51,12 +51,12 @@ describe Rpush::Daemon::Store::Redis do
     end
 
     it 'loads an undelivered notification without deliver_after set' do
-      notification.update_attributes!(delivered: false, deliver_after: nil)
+      notification.update!(delivered: false, deliver_after: nil)
       expect(store.deliverable_notifications(Rpush.config.batch_size)).to eq [notification]
     end
 
     it 'loads an notification with a deliver_after time in the past' do
-      notification.update_attributes!(delivered: false, deliver_after: 1.hour.ago)
+      notification.update!(delivered: false, deliver_after: 1.hour.ago)
       expect(store.deliverable_notifications(Rpush.config.batch_size)).to eq [notification]
     end
 

data/spec/unit/daemon/wns/post_request_spec.rb

@@ -30,6 +30,8 @@ describe Rpush::Daemon::Wns::PostRequest do
       expect(request.body).to include('<toast>')
       expect(request.body).to include('MyApp')
       expect(request.body).to include('Example notification')
+      # no priority header
+      expect { request.fetch('X-WNS-PRIORITY') }.to raise_error(KeyError)
     end
 
     context 'with launch' do
@@ -55,6 +57,29 @@ describe Rpush::Daemon::Wns::PostRequest do
       end
     end
 
+    context 'with priority' do
+      let(:notification) do
+        Rpush::Wns::Notification.create!(
+          app: app,
+          data: {
+            title: "MyApp",
+            body: "Example notification"
+          },
+          uri: "http://some.example/",
+          priority: 1
+        )
+      end
+
+      it 'creates a request characteristic for toast notification with priority' do
+        request = Rpush::Daemon::Wns::PostRequest.create(notification, 'token')
+        expect(request['X-WNS-Type']).to eq('wns/toast')
+        expect(request['Content-Type']).to eq('text/xml')
+        expect(request['X-WNS-PRIORITY']).to eq('1')
+        expect(request.body).to include('MyApp')
+        expect(request.body).to include('Example notification')
+      end
+    end
+
     context 'with sound' do
       let(:notification) do
         Rpush::Wns::Notification.create!(
@@ -95,6 +120,25 @@ describe Rpush::Daemon::Wns::PostRequest do
       expect(request['Content-Type']).to eq('application/octet-stream')
       expect(request.body).to eq("{\"foo\":\"foo\",\"bar\":\"bar\"}")
     end
+
+    context 'with priority' do
+      let(:notification) do
+        Rpush::Wns::RawNotification.create!(
+          app: app,
+          data: { foo: 'foo', bar: 'bar' },
+          uri: "http://some.example/",
+          priority: 3
+        )
+      end
+
+      it 'creates a request characteristic for raw notification with priority' do
+        request = Rpush::Daemon::Wns::PostRequest.create(notification, 'token')
+        expect(request['X-WNS-Type']).to eq('wns/raw')
+        expect(request['X-WNS-PRIORITY']).to eq('3')
+        expect(request['Content-Type']).to eq('application/octet-stream')
+        expect(request.body).to eq("{\"foo\":\"foo\",\"bar\":\"bar\"}")
+      end
+    end
   end
 
   context 'BadgeNotification' do
@@ -113,5 +157,25 @@ describe Rpush::Daemon::Wns::PostRequest do
       expect(request.body).to include('<badge')
       expect(request.body).to include('42')
     end
+
+    context 'with priority' do
+      let(:notification) do
+        Rpush::Wns::BadgeNotification.create!(
+          app: app,
+          uri: "http://some.example/",
+          badge: 42,
+          priority: 4
+        )
+      end
+
+      it 'creates a request characteristic for badge notification with priority' do
+        request = Rpush::Daemon::Wns::PostRequest.create(notification, 'token')
+        expect(request['X-WNS-Type']).to eq('wns/badge')
+        expect(request['X-WNS-PRIORITY']).to eq('4')
+        expect(request['Content-Type']).to eq('text/xml')
+        expect(request.body).to include('<badge')
+        expect(request.body).to include('42')
+      end
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rpush
 version: !ruby/object:Gem::Version
-  version: 4.1.1
+  version: 4.2.0
 platform: ruby
 authors:
 - Ian Leitch
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-05-13 00:00:00.000000000 Z
+date: 2019-12-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json
@@ -392,6 +392,7 @@ files:
 - lib/generators/templates/rpush_3_3_1_updates.rb
 - lib/generators/templates/rpush_4_1_0_updates.rb
 - lib/generators/templates/rpush_4_1_1_updates.rb
+- lib/generators/templates/rpush_4_2_0_updates.rb
 - lib/rpush.rb
 - lib/rpush/apns_feedback.rb
 - lib/rpush/cli.rb
@@ -610,7 +611,10 @@ files:
 homepage: https://github.com/rpush/rpush
 licenses:
 - MIT
-metadata: {}
+metadata:
+  bug_tracker_uri: https://github.com/rpush/rpush/issues
+  changelog_uri: https://github.com/rpush/rpush/blob/master/CHANGELOG.md
+  source_code_uri: https://github.com/rpush/rpush
 post_install_message: |
   When upgrading, don't forget to run `bundle exec rpush init` to get all the latest migrations.
 
@@ -630,7 +634,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.0.4
 signing_key: 
 specification_version: 4
 summary: The push notification service for Ruby.