rpush 2.3.0 → 2.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: cb54c6c92d5ad11dd4f3d170572f99b3006946fd
-  data.tar.gz: 28d949f1e16204e0d0e60dfe2605df73dd21787d
+  metadata.gz: 0da1cac03ae3688486b3d3a35f9adf1aff283bed
+  data.tar.gz: 3710bfdf83a7fd76a790a42d4ee95278ed07f7e2
 SHA512:
-  metadata.gz: 9d6652491605ad6a2952313df88ee9c2282a3b3613f6ee03d8d92fb54f93117c0404742a78f684ebb01efdd734d434de2c9179a3c2e42a2ecbef36460370027a
-  data.tar.gz: 9112453e724420282a58c33a5c43175d02226987d335e9189e3830465e1692fe5ac18ea91c5cd39c092f43b6279afa9db92bcb11d51f0ec8919b512949502f9a
+  metadata.gz: e84ccee43191d9876c30f4df293299dc8c4d08de3ad96882aec3eb7fc0302217d32de0b1bede2faa296d686a9fa4c451ebb8a27a0560f664dcb5d578765465ae
+  data.tar.gz: 6cd9310c439cb97f8eab52456303d94b3c2c43872498a7c361f6343031b545476c2200707b1645f462de2b151fe585b6b476234edf7864a6875fe3c69a4156e6

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+## 2.3.1 (Jan 24, 2015)
+  * Fix CPU thrashing while waiting for an APNs connection be established (#119).
+
 ## 2.3.0 (Jan 19, 2015)
   * Add 'version' CLI command.
   * Rpush::Wpns::Notification now supports setting the 'data' attribute.

data/lib/rpush/daemon/dispatcher/apns_tcp.rb

@@ -23,7 +23,7 @@ module Rpush
           super
           @dispatch_mutex = Mutex.new
           @stop_error_receiver = false
-          start_error_receiver
+          @connection.on_connect { start_error_receiver }
         end
 
         def dispatch(payload)
@@ -70,6 +70,8 @@ module Rpush
 
           tuple = @connection.read(ERROR_TUPLE_BYTES)
           @dispatch_mutex.synchronize { handle_error_response(tuple) }
+        rescue StandardError => e
+          log_error(e)
         end
 
         def handle_error_response(tuple)

data/lib/rpush/daemon/tcp_connection.rb

@@ -26,13 +26,29 @@ module Rpush
         @certificate = app.certificate
         @password = app.password
         @connected = false
+        @connection_callbacks = []
         touch
       end
 
+      def on_connect(&blk)
+        raise 'already connected' if @connected
+        @connection_callbacks << blk
+      end
+
       def connect
         @ssl_context = setup_ssl_context
         @tcp_socket, @ssl_socket = connect_socket
         @connected = true
+
+        @connection_callbacks.each do |blk|
+          begin
+            blk.call
+          rescue StandardError => e
+            log_error(e)
+          end
+        end
+
+        @connection_callbacks.clear
       end
 
       def close

data/lib/rpush/version.rb

@@ -1,3 +1,3 @@
 module Rpush
-  VERSION = '2.3.0'
+  VERSION = '2.3.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rpush
 version: !ruby/object:Gem::Version
-  version: 2.3.0
+  version: 2.3.1
 platform: ruby
 authors:
 - Ian Leitch
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-20 00:00:00.000000000 Z
+date: 2015-01-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json