rpush 2.1.0 → 2.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bcc9513fb56f7be786d23e453cce23438c9ea9aa
-  data.tar.gz: cf5b79d6e9306478a509680494924b2e99335683
+  metadata.gz: ade9eddd89766399d488b8d364041c517911c0cc
+  data.tar.gz: 3ee953452451b0ea1318de7f52e090ab58bd6439
 SHA512:
-  metadata.gz: a88119dfb66901691ec8d508f63f448b43d6387e7299b8c503c27ad04b3051056d9b51f2b593021163da1c1a072bd4ddc6cc006caceaa877947c2874095a7c8b
-  data.tar.gz: 8f636b57c346bfe27d16955876a47fa0c9def6a9c64bffd192c46474033bb5ef4885d8edea067d0e2c7ae10a64a87061f6e066e051001a1ed4db9cd43ac823fd
+  metadata.gz: 9f10cb58e8a84f852a43bd9d2b7b7bea5df1d8f3bed8638297601960a9365254e4605376f340f78dcc3c1e0296269a31b97554705f588642cc1dc481ec905d22
+  data.tar.gz: ed5f267363e0b76deaf60811109c8e6fe9ef63e95f35c8e4bc266edd46efc4f4c1900e2a47116a92ff1463a761b5533c085c1f166f04c6a2acbffae4ef31c39c

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 2.2.0 (Oct 7, 2014)
+  * Numerous command-line fixes, sorry folks!
+  * Add 'rpush push' command-line command for one-off use.
+
 ## 2.1.0 (Oct 4, 2014)
   * Bump APNs max payload size to 2048 for iOS 8.
   * Add 'category' for iOS 8.

data/README.md

@@ -167,11 +167,13 @@ See [Configuration](https://github.com/rpush/rpush/wiki/Configuration) for a lis
 
 ### Updating Rpush
 
-You should run `rails init` after upgrading Rpush to check for configuration and migration changes.
+You should run `rpush init` after upgrading Rpush to check for configuration and migration changes.
 
 ### Wiki
 
 ### General
+* [Using Redis](https://github.com/rpush/rpush/wiki/Using-Redis)
+* [Using ActiveRecord](https://github.com/rpush/rpush/wiki/Using-ActiveRecord)
 * [Configuration](https://github.com/rpush/rpush/wiki/Configuration)
 * [Moving from Rapns](https://github.com/rpush/rpush/wiki/Moving-from-Rapns-to-Rpush)
 * [Deploying to Heroku](https://github.com/rpush/rpush/wiki/Heroku)

data/lib/rpush/cli.rb

@@ -16,23 +16,16 @@ module Rpush
     end
 
     class_option :config, type: :string, aliases: '-c', default: default_config_path
-    class_option :rails_env, type: :string, aliases: '-e', default: 'development'
+    class_option 'rails-env', type: :string, aliases: '-e', default: 'development'
 
     option :foreground, type: :boolean, aliases: '-f', default: false
     option 'pid-file', type: :string, aliases: '-p'
     desc 'start', 'Start Rpush'
     def start
+      underscore_option_names
       check_ruby_version
+      configure_rpush
 
-      if detect_rails? && options[:rails_env]
-        STDOUT.write "* Booting Rails '#{options[:rails_env]}' environment... "
-        STDOUT.flush
-        ENV['RAILS_ENV'] = options[:rails_env]
-        load 'config/environment.rb'
-        puts green('✔')
-      end
-
-      load_config
       require 'rpush/daemon'
       Rpush::Daemon.start
     end
@@ -40,9 +33,10 @@ module Rpush
     desc 'stop', 'Stop Rpush'
     option 'pid-file', type: :string, aliases: '-p'
     def stop
+      underscore_option_names
       check_ruby_version
-      load_config
-      ensure_pid_file
+      configure_rpush
+      ensure_pid_file_set
 
       if File.exist?(Rpush.config.pid_file)
         pid = File.read(Rpush.config.pid_file).strip.to_i
@@ -67,8 +61,9 @@ module Rpush
     end
 
     desc 'init', 'Initialize Rpush into the current directory.'
-    option 'active-record', type: :boolean, desc: 'Install ActiveRecord migrations.'
+    option 'active-record', type: :boolean, desc: 'Install ActiveRecord migrations'
     def init
+      underscore_option_names
       check_ruby_version
       require 'rails/generators'
 
@@ -76,9 +71,9 @@ module Rpush
       $RPUSH_CONFIG_PATH = default_config_path # rubocop:disable Style/GlobalVars
       Rails::Generators.invoke('rpush_config')
 
-      install_migrations = options['active-record']
+      install_migrations = options['active_record']
 
-      unless options.key?('active-record')
+      unless options.key?('active_record')
         has_answer = false
         until has_answer
           STDOUT.write "\n* #{green('Install ActiveRecord migrations?')} [y/n]: "
@@ -90,7 +85,7 @@ module Rpush
         install_migrations = answer == 'y'
       end
 
-      Rails::Generators.invoke('rpush_migration') if install_migrations
+      Rails::Generators.invoke('rpush_migration', ['--force']) if install_migrations
 
       puts "\n* #{green('Next steps:')}"
       puts "  - Run 'db:migrate'." if install_migrations
@@ -99,24 +94,38 @@ module Rpush
       puts "  - Run 'rpush help' for commands and options."
     end
 
-    private
+    desc 'push', 'Deliver all pending notifications and then exit'
+    def push
+      underscore_option_names
+      check_ruby_version
+      configure_rpush
+      Rpush.config.foreground = true
 
-    def detect_rails?
-      self.class.detect_rails?
+      Rpush.push
     end
 
-    def default_config_path
-      self.class.default_config_path
+    private
+
+    def configure_rpush
+      load_rails_environment || load_standalone
     end
 
-    def ensure_pid_file
-      return  if Rpush.config.pid_file.blank?
+    def load_rails_environment
+      if detect_rails? && options['rails_env']
+        STDOUT.write "* Booting Rails '#{options[:rails_env]}' environment... "
+        STDOUT.flush
+        ENV['RAILS_ENV'] = options['rails_env']
+        load 'config/environment.rb'
+        Rpush.config.update(options)
+        puts green('✔')
 
-      STDERR.puts(red('ERROR: ') + 'config.pid_file is not set.')
-      exit 1
+        return true
+      end
+
+      false
     end
 
-    def load_config
+    def load_standalone
       if !File.exist?(options[:config])
         STDERR.puts(red('ERROR: ') + "#{options[:config]} does not exist. Please run 'rpush init' to generate it or specify the --config option.")
         exit 1
@@ -126,8 +135,40 @@ module Rpush
       end
     end
 
+    def detect_rails?
+      self.class.detect_rails?
+    end
+
+    def default_config_path
+      self.class.default_config_path
+    end
+
+    def ensure_pid_file_set
+      return unless Rpush.config.pid_file.blank?
+
+      STDERR.puts(red('ERROR: ') + 'config.pid_file is not set.')
+      exit 1
+    end
+
     def check_ruby_version
-      STDERR.puts(yellow('WARNING: ') + "You are using an old and unsupported version of Ruby.") if RUBY_VERSION <= '1.9.3'
+      STDERR.puts(yellow('WARNING: ') + "You are using an old and unsupported version of Ruby.") if RUBY_VERSION <= '1.9.3' && RUBY_ENGINE == 'ruby'
+    end
+
+    def underscore_option_names
+      # Underscore option names so that they map directly to Configuration options.
+      new_options = options.dup
+
+      options.each do |k, v|
+        new_k = k.to_s.tr('-', '_')
+
+        if k != new_k
+          new_options.delete(k)
+          new_options[new_k] = v
+        end
+      end
+
+      new_options.freeze
+      self.options = new_options
     end
   end
 end

data/lib/rpush/configuration.rb

@@ -1,3 +1,5 @@
+require 'pathname'
+
 module Rpush
   def self.config
     @config ||= Rpush::Configuration.new

data/lib/rpush/push.rb

@@ -10,6 +10,7 @@ module Rpush
     Rpush::Daemon.initialize_store
     Rpush::Daemon::Synchronizer.sync
     Rpush::Daemon::Feeder.start
+    # TODO: Wait until there are no more notifications.
     Rpush::Daemon::AppRunner.stop
   end
 end

data/lib/rpush/version.rb

@@ -1,3 +1,3 @@
 module Rpush
-  VERSION = '2.1.0'
+  VERSION = '2.2.0'
 end

data/lib/tasks/test.rake

@@ -1,46 +1,62 @@
-namespace :test do
-  task :build_rails do
-    require 'fileutils'
-
-    def cmd(str, clean_env = true)
-      puts "* #{str}"
-      retval = clean_env ? Bundler.with_clean_env { `#{str}` } : `#{str}`
-      puts retval.strip
-      retval
-    end
+require 'fileutils'
+
+def cmd(str, clean_env = true)
+  puts "* #{str}"
+  retval = clean_env ? Bundler.with_clean_env { `#{str}` } : `#{str}`
+  puts retval.strip
+  retval
+end
 
-    rpush_root = Dir.pwd
-    path = '/tmp/rails_test'
-    cmd("rm -rf #{path}")
-    FileUtils.mkdir_p(path)
-    pwd = Dir.pwd
+task :build_rails do
+  rpush_root = Dir.pwd
+  path = '/tmp/rpush/rails_test'
+  cmd("rm -rf #{path}")
+  FileUtils.mkdir_p(path)
+  pwd = Dir.pwd
 
-    cmd("bundle exec rails --version", false)
-    cmd("bundle exec rails new #{path} --skip-bundle", false)
+  cmd("bundle exec rails --version", false)
+  cmd("bundle exec rails new #{path} --skip-bundle", false)
 
-    begin
-      Dir.chdir(path)
-      cmd('echo "gem \'rake\'" >> Gemfile')
-      cmd('echo "gem \'pg\'" >> Gemfile')
-      cmd("echo \"gem 'rpush', :path => '#{rpush_root}'\" >> Gemfile")
-      cmd('bundle install')
+  begin
+    Dir.chdir(path)
+    cmd('echo "gem \'rake\'" >> Gemfile')
+    cmd('echo "gem \'pg\'" >> Gemfile')
+    cmd("echo \"gem 'rpush', :path => '#{rpush_root}'\" >> Gemfile")
+    cmd('bundle install')
 
-      File.open('config/database.yml', 'w') do |fd|
-        fd.write(<<-YML)
+    File.open('config/database.yml', 'w') do |fd|
+      fd.write(<<-YML)
 development:
-  adapter: postgresql
-  database: rpush_rails_test
-  pool: 5
-  timeout: 5000
-        YML
-      end
-
-      cmd('bundle exec rails g rpush')
-      cmd('bundle exec rake db:migrate')
-    ensure
-      Dir.chdir(pwd)
+adapter: postgresql
+database: rpush_rails_test
+pool: 5
+timeout: 5000
+      YML
     end
+  ensure
+    Dir.chdir(pwd)
+  end
 
-    puts "Built into #{path}"
+  puts "Built into #{path}"
+end
+
+task :build_standalone do
+  rpush_root = Dir.pwd
+  path = '/tmp/rpush/standalone_test'
+  cmd("rm -rf #{path}")
+  FileUtils.mkdir_p(path)
+  pwd = Dir.pwd
+
+  begin
+    Dir.chdir(path)
+    cmd('echo "source \'https://rubygems.org\'" >> Gemfile')
+    cmd('echo "gem \'rake\'" >> Gemfile')
+    cmd('echo "gem \'rpush-redis\'" >> Gemfile')
+    cmd("echo \"gem 'rpush', :path => '#{rpush_root}'\" >> Gemfile")
+    cmd('bundle install')
+  ensure
+    Dir.chdir(pwd)
   end
+
+  puts "Built into #{path}"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rpush
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.2.0
 platform: ruby
 authors:
 - Ian Leitch
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-05 00:00:00.000000000 Z
+date: 2014-10-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json
@@ -299,7 +299,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.2
 signing_key: 
 specification_version: 4
 summary: The push notification service for Ruby.