rpub 0.4.0 → 0.5.0

data/spec/rpub/chapter_spec.rb

@@ -1,81 +1,146 @@
-require 'spec_helper'
-
 describe Rpub::Chapter do
   let(:subject) { described_class.new('foo', 1, 'document') }
 
-  its(:content) { should == 'foo' }
-  its(:number)  { should == 1 }
-  its(:layout)  { should == 'document' }
+  describe '#content' do
+    subject { super().content }
+    it { is_expected.to eq('foo') }
+  end
+
+  describe '#number' do
+    subject { super().number }
+    it { is_expected.to eq(1) }
+  end
+
+  describe '#layout' do
+    subject { super().layout }
+    it { is_expected.to eq('document') }
+  end
 
   describe '#uid' do
     it 'should change when content changes' do
-      subject.uid.should_not == described_class.new('bar', 1, 'bar').uid
+      expect(subject.uid).to_not eql(described_class.new('bar', 1, 'bar').uid)
     end
 
     it 'should change when layout changes' do
-      subject.uid.should_not == described_class.new('foo', 1, 'qux').uid
+      expect(subject.uid).to_not eql(described_class.new('foo', 1, 'qux').uid)
     end
 
     it 'should change when content changes' do
-      subject.uid.should_not == described_class.new('foo', 2, 'bar').uid
+      expect(subject.uid).to_not eql(described_class.new('foo', 2, 'bar').uid)
     end
   end
 
   describe '#xml_id' do
-    its(:xml_id) { should == 'chapter-1' }
+    describe '#xml_id' do
+      subject { super().xml_id }
+      it { is_expected.to eq('chapter-1') }
+    end
   end
 
   describe '#filename' do
-    its(:filename) { should == 'chapter-1-untitled.html' }
+    describe '#filename' do
+      subject { super().filename }
+      it { is_expected.to eq('chapter-1-untitled.html') }
+    end
   end
 
   describe '#outline' do
     context 'when there are no headings' do
       let(:subject) { described_class.new('foo', 1, 'document') }
-      its(:outline) { should have(0).elements }
-      its(:outline) { should be_empty }
+
+      describe '#outline' do
+        subject { super().outline }
+
+        it 'has no elements' do
+          expect(subject.size).to eq(0)
+        end
+      end
+
+      describe '#outline' do
+        subject { super().outline }
+        it { is_expected.to be_empty }
+      end
     end
 
     context 'when there are headings' do
       let(:subject) { described_class.new('# foo', 1, 'document') }
-      its(:outline) { should have(1).elements }
+
+      describe '#outline' do
+        subject { super().outline }
+
+        it 'has 1 element' do
+          expect(subject.size).to eq(1)
+        end
+      end
 
       context 'a single heading entry' do
         let(:subject) { described_class.new('# foo', 1, 'document').outline.first }
-        its(:level)   { should == 1 }
-        its(:text)    { should == 'foo' }
-        its(:html_id) { should == 'foo' }
+
+        describe '#level' do
+          subject { super().level }
+          it { is_expected.to eq(1) }
+        end
+
+        describe '#text' do
+          subject { super().text }
+          it { is_expected.to eq('foo') }
+        end
+
+        describe '#html_id' do
+          subject { super().html_id }
+          it { is_expected.to eq('foo') }
+        end
       end
     end
   end
 
   describe '#title' do
     context 'without a suitable markdown title' do
-      its(:title) { should == 'untitled' }
+      describe '#title' do
+        subject { super().title }
+        it { is_expected.to eq('untitled') }
+      end
     end
 
     context 'with a markdown heading' do
       let(:subject) { described_class.new('# My Title', 1, 'bar') }
-      its(:title) { should == 'My Title' }
+
+      describe '#title' do
+        subject { super().title }
+        it { is_expected.to eq('My Title') }
+      end
     end
   end
 
   describe 'markdown parsing' do
     let(:subject) { described_class.new('foo', 1, nil) }
-    its(:to_html) { should == "<p>foo</p>\n" }
+
+    describe '#to_html' do
+      subject { super().to_html }
+      it { is_expected.to eq("<p>foo</p>\n") }
+    end
   end
 
   describe '#images' do
     let(:subject) { described_class.new('![alt](foo.png)', 1, 'document') }
 
-    it { should have(1).images }
-    its('images.first') { should == 'foo.png' }
+    it 'has 1 image' do
+      expect(subject.images.size).to eq(1)
+    end
+
+    describe '#images' do
+      subject { super().images }
+      describe '#first' do
+        subject { super().first }
+        it { is_expected.to eq('foo.png') }
+      end
+    end
   end
 
   describe '#outline' do
     let(:subject) { described_class.new("# foo\n\nbla bla bla \n\n## bar\n\n# baz", 1, nil) }
     it 'should list headings in order' do
-      subject.outline.map(&:text).should == %w[foo bar baz]
+      expect(subject.outline.map(&:text)).to eql(%w[foo bar baz])
     end
   end
 end

data/spec/rpub/epub/container_spec.rb

@@ -1,8 +1,6 @@
-require 'spec_helper'
-
 describe Rpub::Epub::Container do
   let(:subject) { described_class.new.render }
-  it { should have_xpath('/xmlns:container') }
-  it { should have_xpath('/xmlns:container[@version="1.0"]') }
-  it { should have_xpath('/xmlns:container/xmlns:rootfiles/xmlns:rootfile[@media-type="application/oebps-package+xml"]') }
+  it { is_expected.to have_xpath('/xmlns:container') }
+  it { is_expected.to have_xpath('/xmlns:container[@version="1.0"]') }
+  it { is_expected.to have_xpath('/xmlns:container/xmlns:rootfiles/xmlns:rootfile[@media-type="application/oebps-package+xml"]') }
 end

data/spec/rpub/epub/content_spec.rb

@@ -1,21 +1,25 @@
-require 'spec_helper'
-
 describe Rpub::Epub::Content do
+  let(:config) do
+    OpenStruct.new({
+      'creator'     => 'anonymous',
+      'title'       => 'title',
+      'language'    => 'en',
+      'publisher'   => 'none',
+      'description' => 'foo bar',
+      'subject'     => 'baz qux',
+      'rights'      => 'copyright',
+      'cover_image' => 'image.jpg'
+    })
+  end
   let(:book) do
     double('book', {
-      :creator     => 'anonymous',
-      :title       => 'title',
-      :language    => 'en',
-      :publisher   => 'none',
-      :description => 'foo bar',
-      :subject     => 'baz qux',
-      :rights      => 'copyright',
-      :uid         => 'abcd',
-      :has_cover?  => false,
-      :has_fonts?  => false,
-      :has_toc?    => false,
-      :images      => [],
-      :chapters    => []
+      :config      =>  config,
+      :uid         =>  'abcd',
+      :has_cover?  =>  false,
+      :has_fonts?  =>  false,
+      :has_toc?    =>  false,
+      :images      =>  [],
+      :chapters    =>  []
     })
   end
   let(:subject) { described_class.new(book).render }
@@ -24,53 +28,70 @@ describe Rpub::Epub::Content do
     attr = options.inject('') do |str, (k, v)|
       str << "[@#{k}=\"#{v}\"]"
     end
-    it { should have_xpath(%Q{/xmlns:package/xmlns:metadata/dc:#{name}[text()="#{value}"]#{attr}}, 'dc' => 'http://purl.org/dc/elements/1.1/', 'xmlns' => 'http://www.idpf.org/2007/opf') }
+    it { is_expected.to have_xpath(%Q{/xmlns:package/xmlns:metadata/dc:#{name}[text()="#{value}"]#{attr}}, 'dc' => 'http://purl.org/dc/elements/1.1/', 'xmlns' => 'http://www.idpf.org/2007/opf') }
   end
 
   context 'with an empty book' do
 
-    it { should have_xpath('/xmlns:package[@unique-identifier="BookId"][@version="2.0"]') }
-    it { should have_xpath('/xmlns:package[@unique-identifier="BookId"][@version="2.0"]') }
+    it { is_expected.to have_xpath('/xmlns:package[@unique-identifier="BookId"][@version="2.0"]') }
+    it { is_expected.to have_xpath('/xmlns:package[@unique-identifier="BookId"][@version="2.0"]') }
 
-    it_should_have_metadata 'title', "title"
-    it_should_have_metadata 'creator', "anonymous", 'xmlns:role' => 'aut'
-    it_should_have_metadata 'publisher', "none"
-    it_should_have_metadata 'subject', "baz qux"
-    it_should_have_metadata 'identifier', "abcd", :id => 'BookId'
-    it_should_have_metadata 'rights', "copyright"
+    it_should_have_metadata 'title',       "title"
+    it_should_have_metadata 'creator',     "anonymous", 'xmlns:role' => 'aut'
+    it_should_have_metadata 'publisher',   "none"
+    it_should_have_metadata 'subject',     "baz qux"
+    it_should_have_metadata 'identifier',  "abcd",      :id => 'BookId'
+    it_should_have_metadata 'rights',      "copyright"
     it_should_have_metadata 'description', "foo bar"
   end
 
   context 'when the book has a cover' do
-    before { book.stub! :has_cover? => true, :cover_image => 'foo.jpg' }
-    it { should have_xpath('/xmlns:package/xmlns:manifest/xmlns:item[@id="cover"][@href="cover.html"][@media-type="application/xhtml+xml"]') }
-    it { should have_xpath('/xmlns:package/xmlns:manifest/xmlns:item[@id="cover-image"][@href="foo.jpg"][@media-type="image/jpeg"]') }
-    it { should have_xpath('/xmlns:package/xmlns:metadata/xmlns:meta[@name="cover"][@content="cover-image"]') }
-    it { should have_xpath('/xmlns:package/xmlns:guide/xmlns:reference[@type="cover"][@title="Cover"][@href="cover.html"]') }
-    it { should have_xpath('/xmlns:package/xmlns:spine[@toc="ncx"]/xmlns:itemref[@idref="cover"][@linear="no"]') }
+    before do
+      allow(book).to receive(:has_cover?).and_return(true)
+      allow(config).to receive(:cover_image).and_return('foo.jpg')
+    end
+
+    it { is_expected.to have_xpath('/xmlns:package/xmlns:manifest/xmlns:item[@id="cover"][@href="cover.html"][@media-type="application/xhtml+xml"]') }
+    it { is_expected.to have_xpath('/xmlns:package/xmlns:manifest/xmlns:item[@id="cover-image"][@href="foo.jpg"][@media-type="image/jpeg"]') }
+    it { is_expected.to have_xpath('/xmlns:package/xmlns:metadata/xmlns:meta[@name="cover"][@content="cover-image"]') }
+    it { is_expected.to have_xpath('/xmlns:package/xmlns:guide/xmlns:reference[@type="cover"][@title="Cover"][@href="cover.html"]') }
+    it { is_expected.to have_xpath('/xmlns:package/xmlns:spine[@toc="ncx"]/xmlns:itemref[@idref="cover"][@linear="no"]') }
   end
 
   context 'when the book has embedded fonts' do
-    before { book.stub! :has_fonts? => true, :fonts => ['font.otf'] }
-    it { should have_xpath('/xmlns:package/xmlns:manifest/xmlns:item[@id="font.otf"][@href="font.otf"][@media-type="font/opentype"]') }
+    before do
+      allow(book).to receive(:has_fonts?).and_return(true)
+      allow(book).to receive(:fonts).and_return(['font.otf'])
+    end
+
+    it { is_expected.to have_xpath('/xmlns:package/xmlns:manifest/xmlns:item[@id="font.otf"][@href="font.otf"][@media-type="font/opentype"]') }
   end
 
   context 'when the book has a ToC' do
-    before { book.stub! :has_toc? => true }
-    it { should have_xpath('/xmlns:package/xmlns:manifest/xmlns:item[@id="toc"][@href="toc.html"][@media-type="application/xhtml+xml"]') }
-    it { should have_xpath('/xmlns:package/xmlns:guide/xmlns:reference[@type="toc"][@title="Table of Contents"][@href="toc.html"]') }
+    before do
+      allow(book).to receive(:has_toc?).and_return(true)
+    end
+
+    it { is_expected.to have_xpath('/xmlns:package/xmlns:manifest/xmlns:item[@id="toc"][@href="toc.html"][@media-type="application/xhtml+xml"]') }
+    it { is_expected.to have_xpath('/xmlns:package/xmlns:guide/xmlns:reference[@type="toc"][@title="Table of Contents"][@href="toc.html"]') }
   end
 
   context 'when the book has images' do
-    before { book.stub! :images => ['foo.png', 'bar.gif'] }
-    it { should have_xpath('/xmlns:package/xmlns:manifest/xmlns:item[@id="foo.png"][@href="foo.png"][@media-type="image/png"]') }
-    it { should have_xpath('/xmlns:package/xmlns:manifest/xmlns:item[@id="bar.gif"][@href="bar.gif"][@media-type="image/gif"]') }
+    before do
+      allow(book).to receive(:images).and_return(['foo.png', 'bar.gif'])
+    end
+
+    it { is_expected.to have_xpath('/xmlns:package/xmlns:manifest/xmlns:item[@id="foo.png"][@href="foo.png"][@media-type="image/png"]') }
+    it { is_expected.to have_xpath('/xmlns:package/xmlns:manifest/xmlns:item[@id="bar.gif"][@href="bar.gif"][@media-type="image/gif"]') }
   end
 
   context 'when the book has chapters' do
     let(:chapter) { double('chapter', :filename => 'chapter.html', :xml_id => 'chapter1') }
-    before { book.stub! :chapters => [chapter] }
-    it { should have_xpath('/xmlns:package/xmlns:manifest/xmlns:item[@id="chapter1"][@href="chapter.html"][@media-type="application/xhtml+xml"]') }
-    it { should have_xpath('/xmlns:package/xmlns:spine[@toc="ncx"]/xmlns:itemref[@idref="chapter1"]') }
+    before do
+      allow(book).to receive(:chapters).and_return([chapter])
+    end
+
+    it { is_expected.to have_xpath('/xmlns:package/xmlns:manifest/xmlns:item[@id="chapter1"][@href="chapter.html"][@media-type="application/xhtml+xml"]') }
+    it { is_expected.to have_xpath('/xmlns:package/xmlns:spine[@toc="ncx"]/xmlns:itemref[@idref="chapter1"]') }
   end
 end

data/spec/rpub/epub/cover_spec.rb

@@ -1,9 +1,7 @@
-require 'spec_helper'
-
 describe Rpub::Epub::Cover do
-  let(:book)    { double('book', :cover_image => 'cover.jpg', :title => 'title') }
+  let(:book)    { double('book', :config => double('config', :cover_image => 'cover.jpg', :title => 'title')) }
   let(:subject) { described_class.new(book).render }
 
-  it { should have_xpath('/xmlns:html/xmlns:head/xmlns:title[text()="Cover"]') }
-  it { should have_xpath('/xmlns:html/xmlns:body/xmlns:div/xmlns:img[@src="cover.jpg"][@alt="title"]') }
+  it { is_expected.to have_xpath('/xmlns:html/xmlns:head/xmlns:title[text()="Cover"]') }
+  it { is_expected.to have_xpath('/xmlns:html/xmlns:body/xmlns:div/xmlns:img[@src="cover.jpg"][@alt="title"]') }
 end

data/spec/rpub/epub/html_toc_spec.rb

@@ -1,19 +1,19 @@
-require 'spec_helper'
-
 describe Rpub::Epub::HtmlToc do
   let(:outline) { [] }
-  let(:book)    { double('book', :outline => outline) }
+  let(:book)    { double('book', :outline => outline, :config => config) }
+  let(:config)  { OpenStruct.new({ 'max_level' => 1 }) }
   let(:subject) { described_class.new(book).render }
 
-  it { should have_xpath('/div/h1[text()="Table of Contents"]') }
-  it { should have_xpath('/div/div[@class="toc"]') }
+  it { is_expected.to have_xpath('/div/h1[text()="Table of Contents"]') }
+  it { is_expected.to have_xpath('/div/div[@class="toc"]') }
 
   context 'without headings in the outline' do
-    it { should_not have_xpath('//a') }
+    it { is_expected.not_to have_xpath('//a') }
   end
 
   context 'with heading in the outline' do
-    let(:outline) { [['foo.html', [double('heading', :text => 'link', :html_id => 'bar', :level => 1)]]] }
-    it { should have_xpath('/div/div/div[@class="level-1"]/a[@href="foo.html#bar"][text()="link"]') }
+    let(:outline) { [['foo.html', [double('heading 1', :text => 'link 1', :html_id => 'bar', :level => 1), double('heading 2', :text => 'link 2', :html_id => 'bar', :level => 2)]]] }
+    it { is_expected.to have_xpath('/div/div/div[@class="level-1"]/a[@href="foo.html#bar"][text()="link 1"]') }
+    it { is_expected.not_to have_xpath('/div/div/div[@class="level-1"]/a[@href="foo.html#bar"][text()="link 2"]') }
   end
 end

data/spec/rpub/epub/toc_spec.rb

@@ -1,20 +1,18 @@
-require 'spec_helper'
-
 describe Rpub::Epub::Toc do
   let(:chapters) { [] }
-  let(:config)   { {} }
-  let(:book)     { double('book', :uid => 'foo', :title => 'title', :chapters => chapters, :config => config) }
+  let(:config)   { OpenStruct.new({ 'title' => 'title' }) }
+  let(:book)     { double('book', :uid => 'foo', :chapters => chapters, :config => config) }
   let(:subject)  { described_class.new(book).render }
 
-  it { should have_xpath('/xmlns:ncx') }
-  it { should have_xpath('/xmlns:ncx/xmlns:head/xmlns:meta[@name="dtb:uid"][@content="foo"]') }
-  it { should have_xpath('/xmlns:ncx/xmlns:head/xmlns:meta[@name="dtb:depth"][@content="2"]') }
-  it { should have_xpath('/xmlns:ncx/xmlns:head/xmlns:meta[@name="dtb:totalPageCount"][@content="0"]') }
-  it { should have_xpath('/xmlns:ncx/xmlns:head/xmlns:meta[@name="dtb:maxPageNumber"][@content="0"]') }
-  it { should have_xpath('/xmlns:ncx/xmlns:docTitle/xmlns:text[text()="title"]') }
+  it { is_expected.to have_xpath('/xmlns:ncx') }
+  it { is_expected.to have_xpath('/xmlns:ncx/xmlns:head/xmlns:meta[@name="dtb:uid"][@content="foo"]') }
+  it { is_expected.to have_xpath('/xmlns:ncx/xmlns:head/xmlns:meta[@name="dtb:depth"][@content="2"]') }
+  it { is_expected.to have_xpath('/xmlns:ncx/xmlns:head/xmlns:meta[@name="dtb:totalPageCount"][@content="0"]') }
+  it { is_expected.to have_xpath('/xmlns:ncx/xmlns:head/xmlns:meta[@name="dtb:maxPageNumber"][@content="0"]') }
+  it { is_expected.to have_xpath('/xmlns:ncx/xmlns:docTitle/xmlns:text[text()="title"]') }
 
   context 'without chapters' do
-    it { should_not have_xpath('/xmlns:ncx/xmlns:navMap/xmlns:navPoint') }
+    it { is_expected.not_to have_xpath('/xmlns:ncx/xmlns:navMap/xmlns:navPoint') }
   end
 
   context 'with chapters' do
@@ -22,19 +20,19 @@ describe Rpub::Epub::Toc do
     let(:heading2) { double('heading', :children => [], :value => double('value', :options => { :level => 2, :raw_text => 'chapter title 2' }), :attr => { :id => 'bar' }) }
     let(:toc)      { double('toc', :children => [heading1])}
     let(:chapters) { [double('chapter', :title => 'chapter title', :filename => 'filename', :xml_id => 'id', :toc => toc)] }
-    it { should have_xpath('/xmlns:ncx/xmlns:navMap/xmlns:navPoint[@id="foo"]') }
-    it { should have_xpath('/xmlns:ncx/xmlns:navMap/xmlns:navPoint/xmlns:navLabel/xmlns:text[text()="chapter title"]') }
-    it { should have_xpath('/xmlns:ncx/xmlns:navMap/xmlns:navPoint/xmlns:content[@src="filename#foo"]') }
-    it { should have_xpath('/xmlns:ncx/xmlns:navMap/xmlns:navPoint/xmlns:navPoint[@id="bar"]') }
-    it { should have_xpath('/xmlns:ncx/xmlns:navMap/xmlns:navPoint/xmlns:navPoint/xmlns:navLabel/xmlns:text[text()="chapter title 2"]') }
-    it { should have_xpath('/xmlns:ncx/xmlns:navMap/xmlns:navPoint/xmlns:navPoint/xmlns:content[@src="filename#bar"]') }
+    it { is_expected.to have_xpath('/xmlns:ncx/xmlns:navMap/xmlns:navPoint[@id="foo"]') }
+    it { is_expected.to have_xpath('/xmlns:ncx/xmlns:navMap/xmlns:navPoint/xmlns:navLabel/xmlns:text[text()="chapter title"]') }
+    it { is_expected.to have_xpath('/xmlns:ncx/xmlns:navMap/xmlns:navPoint/xmlns:content[@src="filename#foo"]') }
+    it { is_expected.to have_xpath('/xmlns:ncx/xmlns:navMap/xmlns:navPoint/xmlns:navPoint[@id="bar"]') }
+    it { is_expected.to have_xpath('/xmlns:ncx/xmlns:navMap/xmlns:navPoint/xmlns:navPoint/xmlns:navLabel/xmlns:text[text()="chapter title 2"]') }
+    it { is_expected.to have_xpath('/xmlns:ncx/xmlns:navMap/xmlns:navPoint/xmlns:navPoint/xmlns:content[@src="filename#bar"]') }
 
     context 'with low max_level' do
-      let(:config) { { :max_level => 1 } }
-      it { should have_xpath('/xmlns:ncx/xmlns:navMap/xmlns:navPoint[@id="foo"]') }
-      it { should have_xpath('/xmlns:ncx/xmlns:navMap/xmlns:navPoint/xmlns:navLabel/xmlns:text[text()="chapter title"]') }
-      it { should have_xpath('/xmlns:ncx/xmlns:navMap/xmlns:navPoint/xmlns:content[@src="filename#foo"]') }
-      it { should_not have_xpath('/xmlns:ncx/xmlns:navMap/xmlns:navPoint/xmlns:navPoint') }
+      let(:config) { OpenStruct.new({ 'title' => 'title', 'max_level' => 1 }) }
+      it { is_expected.to have_xpath('/xmlns:ncx/xmlns:navMap/xmlns:navPoint[@id="foo"]') }
+      it { is_expected.to have_xpath('/xmlns:ncx/xmlns:navMap/xmlns:navPoint/xmlns:navLabel/xmlns:text[text()="chapter title"]') }
+      it { is_expected.to have_xpath('/xmlns:ncx/xmlns:navMap/xmlns:navPoint/xmlns:content[@src="filename#foo"]') }
+      it { is_expected.not_to have_xpath('/xmlns:ncx/xmlns:navMap/xmlns:navPoint/xmlns:navPoint') }
     end
   end
 end

data/spec/rpub_spec.rb

@@ -1,7 +1,5 @@
-require 'spec_helper'
-
 describe Rpub do
   it 'should define a version number' do
-    Rpub::VERSION.should =~ /\d+\.\d+\.\d+/
+    expect(Rpub::VERSION).to match(/\d+\.\d+\.\d+/)
   end
 end

data/spec/spec_helper.rb

@@ -3,11 +3,39 @@ if RUBY_VERSION >= '1.9' && ENV.has_key?('COVERAGE')
   SimpleCov.start
 end
 
+if ENV.has_key?('TRAVIS')
+  require 'coveralls'
+  Coveralls.wear!
+end
+
 require 'rpub'
 require 'nokogiri'
 
 FIXTURES_DIRECTORY = File.expand_path('../fixtures', __FILE__)
 
+RSpec.configure do |config|
+  config.filter_run :focus
+  config.run_all_when_everything_filtered = true
+
+  if config.files_to_run.one?
+    config.default_formatter = 'doc'
+  else
+    config.profile_examples = 10
+  end
+
+  config.order = :random
+  Kernel.srand config.seed
+
+  config.expect_with :rspec do |expectations|
+    expectations.syntax = :expect
+  end
+
+  config.mock_with :rspec do |mocks|
+    mocks.syntax = :expect
+    mocks.verify_partial_doubles = true
+  end
+end
+
 RSpec::Matchers.define :remove_file do |filename|
   match do |block|
     before = File.exist?(filename)