rpromise 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f827fadaed28b188d96a603fd46c933e06f52e6f
-  data.tar.gz: b76fde2e1c6388e4ca470e4eb8a0a28f779fa9cd
+  metadata.gz: 71a0304c401834de12b087ed0616ad637b7ad3a6
+  data.tar.gz: b38e756b3ccb4dcc60dbdffe866987f29ad34314
 SHA512:
-  metadata.gz: b8b692957a78f776851bb84e5071304b7dd4a9666a9d8b44dd5254e336e7be3ebd82344ac60d98029961ca2cbcbe205ae97e04517d657a9a2c197a65f0e449cc
-  data.tar.gz: e968d06a23ee237efa58935cb4e5b80130c86821c52f2ab1f2cd2055f2fa8c8e87b4103e798eea821eaea5971eedb24d1e11f68f33312d7b9244c0293ed7fd4b
+  metadata.gz: 6b09464f4d17c111bafae20fcbdcff7d000b8edcf715e1bbb320ebb07e84c4bb14b0e2d1b53b5000bb079aadb00c8e3aa2ab14ded7f89a2d4e45b23a4f7f8486
+  data.tar.gz: f2f7a02741c54b6e7452131b9fc4d54bb5d1b652f1a29f1fa9a483e894aa60baffa061c450f55d13ed0a96ba2499ef34bd9d94aa19993ba55c0d711e5e9f66bb

data/lib/rpromise/version.rb

@@ -1,3 +1,3 @@
 class Rpromise
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

data/lib/rpromise.rb

@@ -17,12 +17,11 @@ class Rpromise
     @thread = Thread.new do
       begin
         yield(method(:resolve!), method(:reject!))
-      rescue Exception => e
+      rescue => e
         reject!(e)
       end
     end
-  rescue Exception => e
-    reject!(e)
+    @thread.abort_on_exception = true
   end
 
   def then(on_resolved = nil, on_rejected = nil)

data/spec/lib/rpromise_spec.rb

@@ -5,6 +5,7 @@ describe ::Rpromise do
   let(:n) { 0 }
   subject(:promise) do
     described_class.new do |resolve, reject|
+      sleep(0.1)
     end
   end
 
@@ -14,6 +15,7 @@ describe ::Rpromise do
     it 'uses the resolve! method as callback' do
       lock = true
       p = described_class.new do |resolve, reject|
+        sleep(0.1)
         resolve.call('hi')
         lock = false
       end
@@ -24,6 +26,7 @@ describe ::Rpromise do
     it 'uses the reject! method as callback' do
       lock = true
       p = described_class.new do |resolve, reject|
+        sleep(0.1)
         reject.call('hi')
         lock = false
       end
@@ -57,6 +60,7 @@ describe ::Rpromise do
 
       before(:each) do
         @promise = described_class.new do |resolve, reject|
+          sleep(0.1)
           resolve.call(value)
         end
       end
@@ -104,6 +108,7 @@ describe ::Rpromise do
           @promise.then(lambda do |v|
             return described_class.new do |resolve, reject|
               thread2 = Thread.new do
+                sleep(0.1)
                 resolve.call('Hello world!')
               end
             end
@@ -136,6 +141,7 @@ describe ::Rpromise do
         lambda_error = nil
         lock = true
         p = described_class.new do |resolve, reject|
+          sleep(0.1)
           reject.call(error)
         end
         p.then(nil, lambda do |e|
@@ -145,10 +151,12 @@ describe ::Rpromise do
         loop { break unless lock }
         expect(lambda_error).to eq error
       end
+
       it 'handles raised exceptions within the promise' do
         lambda_error = nil
         lock = true
         p = described_class.new do |resolve, reject|
+          sleep(0.1)
           raise 'Oops'
         end
         p.then(nil, lambda do |e|
@@ -159,8 +167,24 @@ describe ::Rpromise do
         expect(lambda_error).to be_kind_of RuntimeError
         expect(lambda_error.message).to eq 'Oops'
       end
-      xit 'handles raised exceptions within resolve!'
-      xit 'handles raised exceptions within handle!'
+
+      it 'handles raised exceptions within resolve!' do
+        lambda_error = nil
+        lock = true
+        p = described_class.new do |resolve, reject|
+          sleep(0.1)
+          resolve.call(true)
+        end
+        # Skip the lambda argument to generate an error
+        p.then(lambda do
+          lock = false
+        end, lambda do |err|
+          lambda_error = err
+          lock = false
+        end)
+        loop { break unless lock }
+        expect(lambda_error).to be_kind_of ArgumentError
+      end
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rpromise
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Samuel Molinari