rpam2 4.0.0 → 4.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e5c4a544a01935abef0fcad198c54eac69eadf13f911ac9d232e12b0febe345a
-  data.tar.gz: 141df1f03c8fc332f68b8c7ef397a9040d2ba91c3ac4c4fd2639e41f3dc9f775
+  metadata.gz: 4de60837bda2784d6e3520925472e446f731837e7b411c80f830965ca49569c5
+  data.tar.gz: 27a46170ba7fba4f51258a10d2880d43dc8fd39552b99b6fc42620f12ba759c4
 SHA512:
-  metadata.gz: 8d629dd561e80ad197493349953319477d7c7fd2d785dfdb2d30adf8b1c2ce4c6e6105b2ac73df18b3fb65dcdcb3087b3ba9464a5b1ae1a91e4aeba3cf402bda
-  data.tar.gz: 8bc5288e360b0e6778f10b719b5d11f12a05a649f08b7ac41225ff29431e60e57193b33c3aa7b0349d5e0ec6cd864d0265f270fc05a6c35e995c3f69d936810f
+  metadata.gz: 02b2fc48fa2cf0605dc5aa2afde93c64d7326a2aa0e15cf41bb21e0f1f0e4ed3fecb79063e641cb79f60c7923cd811274984d07b8d6d7e04ef346b145e746d6b
+  data.tar.gz: 73b2c944a0d37715966cf22e4ec03bcb0db2a6184d03d847dd956456016b2f5415f7c38a92d9e785f8e9edb66114404e709ea8665e9720f17b4d0eec90713acb

data/ext/rpam2/extconf.rb

@@ -1,6 +1,7 @@
 require 'mkmf'
 
-pam_installed = have_library("pam","pam_start") and  have_header("security/pam_appl.h")
+# use "and" here to have both errors in error case, helps admins to fix it faster
+pam_installed = have_library("pam","pam_start") and have_header("security/pam_appl.h")
 #pam_installed = false
 
 

data/ext/rpam2/rpam2.c

@@ -195,9 +195,6 @@ static VALUE method_authpam(VALUE self, VALUE servicename, VALUE username, VALUE
     unsigned int result = 0;
     struct pam_conv auth_c = {0,0};
 
-    Check_Type(username, T_STRING);
-    Check_Type(password, T_STRING);
-
     result = pam_start(rpam_default_servicename, StringValueCStr(username), &auth_c, &pamh);
     if (result != PAM_SUCCESS) {
         rb_warn("INIT: %s", pam_strerror(pamh, result));
@@ -223,8 +220,6 @@ static VALUE method_accountpam(VALUE self, VALUE servicename, VALUE username) {
     unsigned int result=0;
     struct pam_conv auth_c = {0,0};
 
-    Check_Type(username, T_STRING);
-
     result = pam_start(rpam_default_servicename, StringValueCStr(username), &auth_c, &pamh);
     if (result != PAM_SUCCESS) {
         rb_warn("INIT: %s", pam_strerror(pamh, result));
@@ -251,10 +246,6 @@ static VALUE method_getenvpam(VALUE self, VALUE servicename, VALUE username, VAL
     unsigned int result = 0;
     struct pam_conv auth_c = {0,0};
 
-    Check_Type(username, T_STRING);
-    Check_Type(password, T_STRING);
-    Check_Type(envname, T_STRING);
-
     result = pam_start(rpam_default_servicename, StringValueCStr(username), &auth_c, &pamh);
     if (result != PAM_SUCCESS) {
         rb_warn("INIT: %s", pam_strerror(pamh, result));

data/lib/rpam2.rb

@@ -52,31 +52,39 @@ module Rpam2
 
     private
 
-    def fake_compare(servicename, username)
+    def use_fake?(servicename)
       return false unless self.fake_data
       self.fake_data.fetch(:servicenames, Set.new).include?(servicename)
     end
 
     def _auth(servicename, username, password, ruser, rhost)
-      return _authc(servicename, username, password, ruser, rhost) unless fake_compare(servicename, username)
+      raise TypeError unless username.is_a? String
+      raise TypeError unless password.is_a? String
+      return _authc(servicename, username, password, ruser, rhost) unless use_fake?(servicename)
       self.fake_data[:password] == password && self.fake_data.fetch(:usernames, Set.new).include?(username)
     end
 
     def _account(servicename, username)
-      return _accountc(servicename, username) unless self.fake_data && self.fake_data.fetch(:servicenames, Set.new).include?(servicename)
+      raise TypeError unless username.is_a? String
+      return _accountc(servicename, username) unless use_fake?(servicename)
       self.fake_data.fetch(:usernames, Set.new).include?(username)
     end
 
     def _getenv(servicename, username, password, opensession, varname, ruser, rhost)
-      return _getenvc(servicename, username, password, opensession, varname, ruser, rhost) unless fake_compare(servicename, username)
+      raise TypeError unless username.is_a? String
+      raise TypeError unless password.is_a? String
+      raise TypeError unless varname.is_a? String
+      return _getenvc(servicename, username, password, opensession, varname, ruser, rhost) unless use_fake?(servicename)
       return nil unless self.fake_data.fetch(:usernames, Set.new).include?(username)
-      return nil if self.fake_data[:env].blank? || self.fake_data[:password] != password
+      return nil unless self.fake_data[:env] && self.fake_data[:password] == password
       self.fake_data[:env].fetch(varname, nil)
     end
 
     def _listenv(servicename, username, password, opensession, ruser, rhost)
-      return _listenvc(servicename, username, password, opensession, ruser, rhost) unless fake_compare(servicename, username)
-      return nil unless self.fake_data[:password] == password &&  self.fake_data.fetch(:usernames, Set.new).include?(username)
+      raise TypeError unless username.is_a? String
+      raise TypeError unless password.is_a? String
+      return _listenvc(servicename, username, password, opensession, ruser, rhost) unless use_fake?(servicename)
+      return nil unless self.fake_data[:password] == password && self.fake_data.fetch(:usernames, Set.new).include?(username)
       self.fake_data.fetch(:env, {})
     end
   end

data/rpam2.gemspec

@@ -1,7 +1,7 @@
 Gem::Specification.new do |s|
   s.name = "rpam2"
-  s.version = "4.0.0"
-  s.date = "2017-10-10"
+  s.version = "4.0.1"
+  s.date = "2018-03-23"
   s.summary = "PAM integration with ruby."
   s.email = "devkral@web.de"
   s.description = "Ruby PAM (Pluggable Authentication Modules) integration"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rpam2
 version: !ruby/object:Gem::Version
-  version: 4.0.0
+  version: 4.0.1
 platform: ruby
 authors:
 - Alexander Kaftan
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-10 00:00:00.000000000 Z
+date: 2018-03-23 00:00:00.000000000 Z
 dependencies: []
 description: Ruby PAM (Pluggable Authentication Modules) integration
 email: devkral@web.de