royw-imdb 0.1.4 → 0.1.5

data/VERSION.yml

@@ -1,4 +1,4 @@
 --- 
 :minor: 1
-:patch: 4
+:patch: 5
 :major: 0

data/lib/imdb/imdb_profile.rb

@@ -161,9 +161,9 @@ class ImdbProfile
   # 5) released years plus/minus a year
   # 6) no years
   def self.lookup(titles, media_years, production_years, released_years)
-    media_years = media_years.collect{|y| y > 0 ? y : nil}.uniq.compact unless media_years.blank?
-    production_years = production_years.collect{|y| y > 0 ? y : nil}.uniq.compact unless production_years.blank?
-    released_years = released_years.collect{|y| y > 0 ? y : nil}.uniq.compact unless released_years.blank?
+    media_years = media_years.compact.collect{|y| y.to_i > 0 ? y : nil}.uniq.compact unless media_years.blank?
+    production_years = production_years.compact.collect{|y| y.to_i > 0 ? y : nil}.uniq.compact unless production_years.blank?
+    released_years = released_years.compact.collect{|y| y.to_i > 0 ? y : nil}.uniq.compact unless released_years.blank?
     idents = []
     year_sets = []
     year_sets << media_years unless media_years.blank?

data/spec/imdb_profile_spec.rb

@@ -173,6 +173,51 @@ describe "ImdbProfile" do
     profile.should be_nil
   end
 
+  it "should handle media year == nil" do
+    profile = ImdbProfile.first(:titles => ['National Treasure: Book of Secrets'], :media_years => [nil])
+    profile.should_not == nil
+  end
+
+  it "should handle media year == 0" do
+    profile = ImdbProfile.first(:titles => ['National Treasure: Book of Secrets'], :media_years => [0])
+    profile.should_not == nil
+  end
+
+  it "should handle media year == '0'" do
+    profile = ImdbProfile.first(:titles => ['National Treasure: Book of Secrets'], :media_years => ['0'])
+    profile.should_not == nil
+  end
+
+  it "should handle production year == nil" do
+    profile = ImdbProfile.first(:titles => ['National Treasure: Book of Secrets'], :production_years => [nil])
+    profile.should_not == nil
+  end
+
+  it "should handle media production == 0" do
+    profile = ImdbProfile.first(:titles => ['National Treasure: Book of Secrets'], :production_years => [0])
+    profile.should_not == nil
+  end
+
+  it "should handle production year == '0'" do
+    profile = ImdbProfile.first(:titles => ['National Treasure: Book of Secrets'], :production_years => ['0'])
+    profile.should_not == nil
+  end
+
+  it "should handle released year == nil" do
+    profile = ImdbProfile.first(:titles => ['National Treasure: Book of Secrets'], :released_years => [nil])
+    profile.should_not == nil
+  end
+
+  it "should handle released year == 0" do
+    profile = ImdbProfile.first(:titles => ['National Treasure: Book of Secrets'], :released_years => [0])
+    profile.should_not == nil
+  end
+
+  it "should handle released year == '0'" do
+    profile = ImdbProfile.first(:titles => ['National Treasure: Book of Secrets'], :released_years => ['0'])
+    profile.should_not == nil
+  end
+
   def get_temp_filename
     outfile = Tempfile.new('imdb_profile_spec', TMPDIR)
     filespec = outfile.path

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: royw-imdb
 version: !ruby/object:Gem::Version 
-  version: 0.1.4
+  version: 0.1.5
 platform: ruby
 authors: 
 - Roy Wright