royw-imdb 0.0.8 → 0.0.9

data/README

@@ -59,7 +59,12 @@ ImdbSearch searches that match on AKA title movies
 
 ImdbSearch searches that match on AKA title but without search_aka enabled movies
 - should have multiple movies
-- should have 2 movies from 1998
+- should have no movies from 1998 because title is an aka
+
+ImdbSearch searches that match on AKA title "Open Season" movies
+- should have multiple movies
+- should find id tt0400717
+- should have only one movie from 2006
 
 ImdbMovie Indiana Jones and the Last Crusade
 - should query IMDB url
@@ -72,6 +77,6 @@ String unescape_html
 String strip_tags
 - should strip HTML tags
 
-Finished in 5.222681 seconds
+Finished in 19.495014 seconds
 
-53 examples, 0 failures
+56 examples, 0 failures

data/lib/imdb/imdb_movie.rb

@@ -5,8 +5,8 @@ class ImdbMovie
 
   def initialize(id, title = nil)
     @id = id
-#     @url = "http://www.imdb.com/title/tt#{@id}/"
-    @url = sprintf(ImdbMovie::url_format, @id.to_s)
+    @url = "http://www.imdb.com/title/tt#{@id}/"
+#     @url = sprintf(ImdbMovie::url_format, @id.to_s)
     @title = title
   end
 
@@ -14,9 +14,9 @@ class ImdbMovie
   # should return the path to the cached html file
   # Note, the returned String should have one '%s'
   # which will replaced by sprintf with @id.to_s
-  def self.url_format
-    'http://www.imdb.com/title/tt%s/'
-  end
+#   def self.url_format
+#     'http://www.imdb.com/title/tt%s/'
+#   end
 
   # this is intended to be stubed by rspec where it
   # should return true.
@@ -192,9 +192,18 @@ class ImdbMovie
   def document
     attempts = 0
     begin
-      html = open(self.url).read
+      if ImdbMovie::use_html_cache
+        begin
+          filespec = self.url.gsub(/^http:\//, 'spec/samples').gsub(/\/$/, '.html')
+          html = open(filespec).read
+        rescue Exception
+          html = open(self.url).read
+          cache_html_files(html)
+        end
+      else
+        html = open(self.url).read
+      end
       @document ||= Hpricot(html)
-      cache_html_files(html) if ImdbMovie::use_html_cache
     rescue Exception => e
       attempts += 1
       if attempts > MAX_ATTEMPTS
@@ -212,7 +221,7 @@ class ImdbMovie
     begin
       filespec = self.url.gsub(/^http:\//, 'spec/samples').gsub(/\/$/, '.html')
       unless File.exist?(filespec)
-        puts filespec
+        puts "caching #{filespec}"
         File.mkdirs(File.dirname(filespec))
         File.open(filespec, 'w') { |f| f.puts html }
       end

data/lib/imdb/imdb_search.rb

@@ -17,22 +17,17 @@ class ImdbSearch
   # and the release year.
   def find_id(options={})
     id = nil
-    found_movies = self.movies
-    unless found_movies.nil?
-      desired_movies = found_movies.select do |m|
-        aka = m.also_known_as
-        result = imdb_compare_titles(m.title, aka, @query) && !m.video_game? && !m.release_year.nil?
-        if result
-          unless options[:years].nil?
-            result = options[:years].include?(m.release_year.to_i)
-          end
-        end
-        result
-      end
-      ids = desired_movies.collect{|m| m.id}.uniq.compact
-      if ids.length == 1
-        id = "tt#{ids[0]}"
+    found_movies = self.movies.select do |m|
+      result = true
+      unless options[:years].nil?
+        result = options[:years].include?(m.release_year.to_i)
       end
+      result
+    end
+#     p found_movies.collect{|m| [m.id, m.title, m.year]}
+    ids = found_movies.collect{|m| m.id}.uniq.compact
+    if ids.length == 1
+      id = "tt#{ids[0]}"
     end
     id
   end
@@ -93,14 +88,18 @@ class ImdbSearch
 
     films = ids_and_titles.map do |id_and_title|
       ImdbMovie.new(id_and_title[0], id_and_title[1])
-    end.uniq
+    end.uniq.compact
 
-    if films.length > 1 && @search_akas
-      films = films.select do |m|
-        aka = m.also_known_as
-        imdb_compare_titles(m.title, aka, @query) && !m.video_game?
+    if films.length > 1
+      same_title_films = films.select do |m|
+        aka = (@search_akas ? m.also_known_as : [])
+        !m.video_game? && imdb_compare_titles(m.title, aka, @query)
+      end
+      if same_title_films.size > 0
+        films = same_title_films
       end
     end
+
     films
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: royw-imdb
 version: !ruby/object:Gem::Version 
-  version: 0.0.8
+  version: 0.0.9
 platform: ruby
 authors: 
 - Sergio Gil
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-03-21 00:00:00 -07:00
+date: 2009-03-26 00:00:00 -07:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency