royw-dvdprofiler2xbmc 0.1.2 → 0.1.4

data/spec/imdb_info_spec.rb

@@ -0,0 +1,61 @@
+require File.dirname(__FILE__) + '/spec_helper.rb'
+
+require 'tempfile'
+
+# Time to add your specs!
+# http://rspec.info/
+
+describe "ImdbInfo" do
+
+  before(:all) do
+    logger = Log4r::Logger.new('dvdprofiler2xbmc')
+    logger.outputters = Log4r::StdoutOutputter.new(:console)
+    Log4r::Outputter[:console].formatter  = Log4r::PatternFormatter.new(:pattern => "%m")
+    logger.level = Log4r::WARN
+    AppConfig.default
+    AppConfig[:logger] = logger
+    AppConfig.load
+    File.mkdirs(TMPDIR)
+  end
+
+#   before(:each) do
+#     filespec = File.expand_path(File.join(File.dirname(__FILE__), 'samples/Die Hard - 1988.nfo'))
+#     @xbmc_info = XbmcInfo.new(filespec)
+#   end
+#
+#   after(:all) do
+#     Dir.glob(File.join(TMPDIR,'xbmcinfo_*')).each { |filename| File.delete(filename) }
+#   end
+
+  describe "Finder" do
+    it "should find a profile" do
+      info = ImdbInfo.find(:imdb_id => 'tt0465234')
+      info.should_not be_nil
+    end
+
+    it "should return nil if profile not found" do
+      info = ImdbInfo.find(:title => 'should not find this title')
+      info.should be_nil
+    end
+  end
+
+  describe "Attributes" do
+    it "should generate xbmc_info" do
+      info = ImdbInfo.find(:imdb_id => 'tt0465234')
+      info.to_xbmc_info.length.should > 0
+    end
+
+    it "should generate valid xbmc_info" do
+      info = ImdbInfo.find(:imdb_id => 'tt0465234')
+      xbmc_info = info.to_xbmc_info
+      xbmc_info['title'].should == "National Treasure: Book of Secrets"
+    end
+
+    it "should return imdb id when profile has one" do
+      info = ImdbInfo.find(:imdb_id => 'tt0465234')
+      info.imdb_id.should == 'tt0465234'
+    end
+  end
+
+end
+

data/spec/media_files_spec.rb

@@ -0,0 +1,103 @@
+require File.dirname(__FILE__) + '/spec_helper.rb'
+
+require 'tempfile'
+
+describe "MediaFiles" do
+
+  before(:all) do
+    logger = Log4r::Logger.new('dvdprofiler2xbmc')
+    logger.outputters = Log4r::StdoutOutputter.new(:console)
+    Log4r::Outputter[:console].formatter  = Log4r::PatternFormatter.new(:pattern => "%m")
+    logger.level = Log4r::WARN
+    AppConfig.default
+    AppConfig[:logger] = logger
+#     AppConfig.load
+    File.mkdirs(TMPDIR)
+    @titles = [
+        'Alexander the Great',
+        'Anastasia',
+        'About a Boy',
+        'Gung Ho',
+        'Hot Shots',
+        'Meltdown',
+        'Oklahoma!',
+        'The Man From Snowy River',
+        'Rooster Cogburn (...and the Lady)',
+        'Call Me The Rise And Fall of Heidi Fleiss',
+        'batteries not included',
+        'Flyboys',
+        "Captain Corelli's Mandolin",
+      ]
+  end
+
+  after(:each) do
+    dup_dir = File.join(TMPDIR, 'dups')
+    if File.exist?(dup_dir)
+      Dir.glob(File.join(dup_dir, "*.m4v")).each { |filename| File.delete(filename) }
+      Dir.delete(dup_dir)
+    end
+    Dir.glob(File.join(TMPDIR, "*.m4v")).each { |filename| File.delete(filename) }
+  end
+
+  describe "Finders" do
+    it "should find the correct number of titles using relative directory paths" do
+      @titles.each {|title| File.touch(File.join(TMPDIR, "#{title}.m4v"))}
+      media_files = MediaFiles.new([TMPDIR])
+      media_files.titles.length.should == @titles.length
+    end
+
+    it "should find the correct number of titles using absolute directory paths" do
+      @titles.each {|title| File.touch(File.join(TMPDIR, "#{title}.m4v"))}
+      media_files = MediaFiles.new([File.expand_path(TMPDIR)])
+      media_files.titles.length.should == @titles.length
+    end
+
+    it "should find the correct number of media files using relative directory paths" do
+      @titles.each {|title| File.touch(File.join(TMPDIR, "#{title}.m4v"))}
+      media_files = MediaFiles.new([TMPDIR])
+      media_files.medias.length.should == @titles.length
+    end
+
+    it "should find the correct number of media files using absolute directory paths" do
+      @titles.each {|title| File.touch(File.join(TMPDIR, "#{title}.m4v"))}
+      media_files = MediaFiles.new([File.expand_path(TMPDIR)])
+      media_files.medias.length.should == @titles.length
+    end
+
+    it "should find all of the titles according to the titles hash" do
+      @titles.each {|title| File.touch(File.join(TMPDIR, "#{title}.m4v"))}
+      media_files = MediaFiles.new([TMPDIR])
+      (media_files.titles.keys.sort - @titles.sort).empty?.should be_true
+    end
+
+    it "should find all of the media files according to the medias array" do
+      @titles.each {|title| File.touch(File.join(TMPDIR, "#{title}.m4v"))}
+      media_files = MediaFiles.new([TMPDIR])
+      (media_files.medias.collect{|media| media.title}.sort - @titles.sort).empty?.should be_true
+    end
+  end
+
+  describe "Duplicates" do
+    it "should not find any duplicate titles when there are none" do
+      @titles.each {|title| File.touch(File.join(TMPDIR, "#{title}.m4v"))}
+      media_files = MediaFiles.new([File.expand_path(TMPDIR)])
+      media_files.duplicate_titles.length.should == 0
+    end
+
+    # nfo_controller.execute has not been ran, so the only information
+    # in each media instance is what was gathered from the filename.
+    # So this means filenames with years will not match against identical
+    # titles but without years.
+    # So the only way we can test is against identical filenames in multiple
+    # directories.
+    it "should find duplicate titles when there are some" do
+      @titles.each {|title| File.touch(File.join(TMPDIR, "#{title}.m4v"))}
+      File.mkdirs(File.join(TMPDIR, 'dups'))
+      duplicate_titles = @titles[0..(@titles.length/3)]
+      duplicate_titles.each {|title| File.touch(File.join(TMPDIR, 'dups', "#{title}.m4v"))}
+      media_files = MediaFiles.new([File.expand_path(TMPDIR)])
+      media_files.duplicate_titles.length.should == duplicate_titles.length
+    end
+  end
+
+end

data/spec/media_spec.rb

@@ -13,9 +13,9 @@ describe "Media" do
     AppConfig[:logger] = logger
     AppConfig.load
     File.mkdirs(TMPDIR)
-    AppConfig[:logger].warn { "\nMedia Specs" }
   end
 
+  describe "Media filename parsing" do
     # "movie title - yyyy.ext"
     # "movie title (yyyy).ext"
     # "movie title.ext"
@@ -23,64 +23,67 @@ describe "Media" do
     # "movie title (yyyy).partN.ext"
     # "movie title.partN.ext"
 
-  it 'should parse "movie title.m4v"' do
-    result = Media.parse('movie title.m4v')
-    result.should == {:title => 'movie title', :extension => 'm4v'}
+    it 'should parse "movie title.m4v"' do
+      result = Media.parse('movie title.m4v')
+      result.should == {:title => 'movie title', :extension => 'm4v'}
+    end
+
+    it 'should parse "movie title - 1999.m4v"' do
+      result = Media.parse('movie title - 1999.m4v')
+      result.should == {:title => 'movie title', :year => '1999', :extension => 'm4v'}
+    end
+
+    it 'should parse "movie title-1999.m4v"' do
+      result = Media.parse('movie title-1999.m4v')
+      result.should == {:title => 'movie title', :year => '1999', :extension => 'm4v'}
+    end
+
+    it 'should parse "movie title (1999).m4v"' do
+      result = Media.parse('movie title (1999).m4v')
+      result.should == {:title => 'movie title', :year => '1999', :extension => 'm4v'}
+    end
+
+    it 'should parse "movie title ( 1999 ) .m4v"' do
+      result = Media.parse('movie title ( 1999 ) .m4v')
+      result.should == {:title => 'movie title', :year => '1999', :extension => 'm4v'}
+    end
+
+    it 'should parse "movie title.cd1.m4v"' do
+      result = Media.parse('movie title.cd1.m4v')
+      result.should == {:title => 'movie title', :part => 'cd1', :extension => 'm4v'}
+    end
+
+    it 'should parse "movie title - 1999.cd1.m4v"' do
+      result = Media.parse('movie title - 1999.cd1.m4v')
+      result.should == {:title => 'movie title', :year => '1999', :part => 'cd1', :extension => 'm4v'}
+    end
+
+    it 'should parse "movie title-1999.cd1.m4v"' do
+      result = Media.parse('movie title-1999.cd1.m4v')
+      result.should == {:title => 'movie title', :year => '1999', :part => 'cd1', :extension => 'm4v'}
+    end
+
+    it 'should parse "movie title (1999).cd1.m4v"' do
+      result = Media.parse('movie title (1999).cd1.m4v')
+      result.should == {:title => 'movie title', :year => '1999', :part => 'cd1', :extension => 'm4v'}
+    end
+
+    it 'should parse "movie title ( 1999 ) .cd1.m4v"' do
+      result = Media.parse('movie title ( 1999 ) .cd1.m4v')
+      result.should == {:title => 'movie title', :year => '1999', :part => 'cd1', :extension => 'm4v'}
+    end
   end
 
-  it 'should parse "movie title - 1999.m4v"' do
-    result = Media.parse('movie title - 1999.m4v')
-    result.should == {:title => 'movie title', :year => '1999', :extension => 'm4v'}
-  end
-
-  it 'should parse "movie title-1999.m4v"' do
-    result = Media.parse('movie title-1999.m4v')
-    result.should == {:title => 'movie title', :year => '1999', :extension => 'm4v'}
-  end
-
-  it 'should parse "movie title (1999).m4v"' do
-    result = Media.parse('movie title (1999).m4v')
-    result.should == {:title => 'movie title', :year => '1999', :extension => 'm4v'}
-  end
-
-  it 'should parse "movie title ( 1999 ) .m4v"' do
-    result = Media.parse('movie title ( 1999 ) .m4v')
-    result.should == {:title => 'movie title', :year => '1999', :extension => 'm4v'}
-  end
-
-  it 'should parse "movie title.cd1.m4v"' do
-    result = Media.parse('movie title.cd1.m4v')
-    result.should == {:title => 'movie title', :part => 'cd1', :extension => 'm4v'}
-  end
-
-  it 'should parse "movie title - 1999.cd1.m4v"' do
-    result = Media.parse('movie title - 1999.cd1.m4v')
-    result.should == {:title => 'movie title', :year => '1999', :part => 'cd1', :extension => 'm4v'}
-  end
-
-  it 'should parse "movie title-1999.cd1.m4v"' do
-    result = Media.parse('movie title-1999.cd1.m4v')
-    result.should == {:title => 'movie title', :year => '1999', :part => 'cd1', :extension => 'm4v'}
-  end
-
-  it 'should parse "movie title (1999).cd1.m4v"' do
-    result = Media.parse('movie title (1999).cd1.m4v')
-    result.should == {:title => 'movie title', :year => '1999', :part => 'cd1', :extension => 'm4v'}
-  end
-
-  it 'should parse "movie title ( 1999 ) .cd1.m4v"' do
-    result = Media.parse('movie title ( 1999 ) .cd1.m4v')
-    result.should == {:title => 'movie title', :year => '1999', :part => 'cd1', :extension => 'm4v'}
-  end
-
-  it 'should generate path_to(:nfo)' do
-    media = Media.new(File.join(File.dirname(__FILE__), 'samples'), 'The Egg and I.dummy')
-    media.path_to(:nfo).should == File.expand_path('spec/samples/The Egg and I.nfo')
-  end
+  describe "NFO filename generation" do
+    it 'should generate path_to(:nfo)' do
+      media = Media.new(File.join(File.dirname(__FILE__), 'samples'), 'The Egg and I.dummy')
+      media.path_to(:nfo).should == File.expand_path('spec/samples/The Egg and I.nfo')
+    end
 
-  it 'should generate path_to(:nfo) for multipart media' do
-    media = Media.new(File.join(File.dirname(__FILE__), 'samples'), 'Ma and Pa Kettle.cd1.dummy')
-    media.path_to(:nfo).should == File.expand_path('spec/samples/Ma and Pa Kettle.nfo')
+    it 'should generate path_to(:nfo) for multipart media' do
+      media = Media.new(File.join(File.dirname(__FILE__), 'samples'), 'Ma and Pa Kettle.cd1.dummy')
+      media.path_to(:nfo).should == File.expand_path('spec/samples/Ma and Pa Kettle.nfo')
+    end
   end
 
 end

data/spec/nfo_controller_spec.rb

@@ -19,8 +19,6 @@ describe "NfoController" do
 
     DvdprofilerProfile.collection_filespec = File.join(SAMPLES_DIR, 'Collection.xml')
     File.mkdirs(TMPDIR)
-
-    AppConfig[:logger].warn { "\nNfoController Specs" }
   end
 
   before(:each) do
@@ -29,7 +27,6 @@ describe "NfoController" do
       filespec = @media.path_to(extension)
       File.delete(filespec) if File.exist?(filespec)
     end
-#     AppConfig[:logger].info { "media path => " + @media.media_path }
   end
 
   after(:each) do
@@ -44,83 +41,85 @@ describe "NfoController" do
     end
   end
 
+  describe "Update" do
+    it "should update" do
+      NfoController.update(@media).should be_true
+    end
 
-  it "should use certifications if mpaa not available" do
-    NfoController.update(@media)
-    filespec = @media.path_to(:nfo)
-    xml = open(filespec).read
-    hash = XmlSimple.xml_in(xml)
-    hash['mpaa'].should == ['Approved']
-  end
-
-  it "should update" do
-    NfoController.update(@media).should be_true
-  end
+    it "should use certifications if mpaa not available" do
+      NfoController.update(@media)
+      filespec = @media.path_to(:nfo)
+      xml = open(filespec).read
+      hash = XmlSimple.xml_in(xml)
+      hash['mpaa'].should == ['Approved']
+    end
 
-  it "should generate populated nfo file on update" do
-    NfoController.update(@media)
-    filespec = @media.path_to(:nfo)
-    xml = open(filespec).read
-    hash = XmlSimple.xml_in(xml)
-    hash['runtime'].should == ['108 min']
-  end
+    it "should generate populated nfo file on update" do
+      NfoController.update(@media)
+      filespec = @media.path_to(:nfo)
+      xml = open(filespec).read
+      hash = XmlSimple.xml_in(xml)
+      hash['runtime'].should == ['108 min']
+    end
 
-  it "should generate populated imdb.xml file on update" do
-    NfoController.update(@media)
-    filespec = @media.path_to(:imdb_xml)
-    xml = open(filespec).read
-    hash = XmlSimple.xml_in(xml)
-    hash['length'].should == ['108 min']
-  end
+    it "should generate populated imdb.xml file on update" do
+      NfoController.update(@media)
+      filespec = @media.path_to(:imdb_xml)
+      xml = open(filespec).read
+      hash = XmlSimple.xml_in(xml)
+      hash['length'].should == ['108 min']
+    end
 
-  it "should generate populated tmdb.xml file on update" do
-    NfoController.update(@media)
-    filespec = @media.path_to(:tmdb_xml)
-    xml = open(filespec).read
-    hash = XmlSimple.xml_in(xml)
-    hash.should be_empty
-  end
+    it "should generate populated tmdb.xml file on update" do
+      NfoController.update(@media)
+      filespec = @media.path_to(:tmdb_xml)
+      xml = open(filespec).read
+      hash = XmlSimple.xml_in(xml)
+      hash.should be_empty
+    end
 
-  it "should handle different movies with the same title" do
-    FileUtils.touch(File.join(TMPDIR, 'Sabrina - 1954.dummy'))
-    media1 = Media.new(TMPDIR, 'Sabrina - 1954.dummy')
-    controller1 = NfoController.new(media1)
-    controller1.update
-    FileUtils.touch(File.join(TMPDIR, 'Sabrina - 1995.dummy'))
-    media2 = Media.new(TMPDIR, 'Sabrina - 1995.dummy')
-    controller2 = NfoController.new(media2)
-    controller2.update
-    controller1.imdb_id.should_not == controller2.imdb_id
+    it "should handle different movies with the same title" do
+      FileUtils.touch(File.join(TMPDIR, 'Sabrina - 1954.dummy'))
+      media1 = Media.new(TMPDIR, 'Sabrina - 1954.dummy')
+      controller1 = NfoController.new(media1)
+      controller1.update
+      FileUtils.touch(File.join(TMPDIR, 'Sabrina - 1995.dummy'))
+      media2 = Media.new(TMPDIR, 'Sabrina - 1995.dummy')
+      controller2 = NfoController.new(media2)
+      controller2.update
+      controller1.imdb_id.should_not == controller2.imdb_id
+    end
   end
 
-  it "should handle all movies in Collection.xml" do
-    imdb_exceptions = [
-      'Pearl Harbor Payback Appointment in Tokyo',
-      'Rodeo Racketeers John Wayne Young Duke Series',
-      'The Adventures of Indiana Jones The Complete DVD Movie Collection',
-      'The Great American Western Volume 6',
-      'The Mummy Collector s Set',
-      'Mexico Whitetails'
-    ]
-    profiles = DvdprofilerProfile.all
-    titles = profiles.collect do |profile|
-      info = DvdprofilerInfo.new(profile)
-      "#{profile.title.remove_punctuation} - #{info.year}"
-    end
-    buf = []
-    titles.sort.each do |title|
-      filename = "#{title}.m4v"
-      FileUtils.touch(File.join(TMPDIR, filename))
-      media = Media.new(TMPDIR, filename)
-      controller = NfoController.new(media)
-#       debugger if title =~ /Mexico/
-      controller.update
-      buf << "Missing ISBN for #{title}" if controller.isbn.blank?
-      buf << "Missing IMDB ID for #{controller.info['title']}" if controller.imdb_id.blank? && !imdb_exceptions.include?(media.title)
-      buf << "Unexpected IMDB ID for #{controller.info['title']}" if !controller.imdb_id.blank? && imdb_exceptions.include?(media.title)
+  describe "Problem media titles" do
+    it "should handle all movies in Collection.xml" do
+      imdb_exceptions = [
+        'Pearl Harbor Payback Appointment in Tokyo',
+        'Rodeo Racketeers John Wayne Young Duke Series',
+        'The Adventures of Indiana Jones The Complete DVD Movie Collection',
+        'The Great American Western Volume 6',
+        'The Mummy Collector s Set',
+        'Mexico Whitetails'
+      ]
+      profiles = DvdprofilerProfile.all
+      titles = profiles.collect do |profile|
+        info = DvdprofilerInfo.new(profile)
+        "#{profile.title.remove_punctuation} - #{info.year}"
+      end
+      buf = []
+      titles.sort.each do |title|
+        filename = "#{title}.m4v"
+        FileUtils.touch(File.join(TMPDIR, filename))
+        media = Media.new(TMPDIR, filename)
+        controller = NfoController.new(media)
+        controller.update
+        buf << "Missing ISBN for #{title}" if controller.isbn.blank?
+        buf << "Missing IMDB ID for #{controller.info['title']}" if controller.imdb_id.blank? && !imdb_exceptions.include?(media.title)
+        buf << "Unexpected IMDB ID for #{controller.info['title']}" if !controller.imdb_id.blank? && imdb_exceptions.include?(media.title)
+      end
+      puts buf.join("\n") unless buf.empty?
+      buf.empty?.should be_true
     end
-    puts buf.join("\n") unless buf.empty?
-    buf.empty?.should be_true
   end
 
 end