rox-rollout 4.7.3 → 5.0.0

data/lib/rox/core/notifications/notification_listener.rb

@@ -1,4 +1,4 @@
-require "em-eventsource"
+require 'em-eventsource'
 
 module Rox
   module Core
@@ -15,7 +15,7 @@ module Rox
       end
 
       def start
-        sse_url = @listen_url.chomp('/') + '/' + @app_key
+        sse_url = "#{@listen_url.chomp('/')}/#{@app_key}"
         @thread = Thread.new do
           EM.run do
             source = EventMachine::EventSource.new(sse_url)
@@ -37,9 +37,9 @@ module Rox
       end
 
       def stop
-        @thread.terminate unless @thread.nil?
+        @thread&.terminate
         @thread = nil
       end
     end
   end
-end
+end

data/lib/rox/core/properties/custom_property.rb

@@ -15,4 +15,4 @@ module Rox
       end
     end
   end
-end
+end

data/lib/rox/core/properties/custom_property_type.rb

@@ -15,4 +15,4 @@ module Rox
       SEMVER = CustomPropertyType.new('semver', 'Semver')
     end
   end
-end
+end

data/lib/rox/core/properties/device_property.rb

@@ -4,8 +4,8 @@ module Rox
   module Core
     class DeviceProperty < CustomProperty
       def initialize(name, type, value = nil)
-        super('rox.' + name, type, value)
+        super("rox.#{name}", type, value)
       end
     end
   end
-end
+end

data/lib/rox/core/properties/property_factory.rb

@@ -0,0 +1,132 @@
+require 'securerandom'
+require 'rox/server/rox_options'
+require 'rox/server/client/sdk_settings'
+require 'rox/server/client/server_properties'
+require 'rox/core/properties/device_property'
+require 'rox/core/properties/custom_property'
+require 'rox/core/properties/custom_property_type'
+require 'rox/core/consts/property_type'
+
+module Rox
+  module Core
+    # Consolidates creation of all the internal properties
+    class PropertyFactory
+      def initialize(server_properties)
+        @server_properties = server_properties
+      end
+
+      def platform
+        property = Rox::Core::PropertyType::PLATFORM
+        type = Rox::Core::CustomPropertyType::STRING
+
+        Rox::Core::DeviceProperty.new(
+          property.name,
+          type,
+          @server_properties.get(property)
+        )
+      end
+
+      def app_release
+        property = Rox::Core::PropertyType::APP_RELEASE
+        type = Rox::Core::CustomPropertyType::SEMVER
+
+        Rox::Core::DeviceProperty.new(
+          property.name,
+          type,
+          @server_properties.get(property)
+        )
+      end
+
+      def distinct_id
+        property = Rox::Core::PropertyType::DISTINCT_ID
+        type = Rox::Core::CustomPropertyType::STRING
+
+        Rox::Core::DeviceProperty.new(
+          property.name,
+          type
+        ) do |_|
+          SecureRandom.uuid
+        end
+      end
+
+      def internal_real_platform
+        property = Rox::Core::PropertyType::PLATFORM
+        type = Rox::Core::CustomPropertyType::STRING
+
+        Rox::Core::DeviceProperty.new(
+          'internal.realPlatform',
+          type,
+          @server_properties.get(property)
+        )
+      end
+
+      def internal_custom_platform
+        property = Rox::Core::PropertyType::PLATFORM
+        type = Rox::Core::CustomPropertyType::STRING
+
+        Rox::Core::DeviceProperty.new(
+          'internal.customPlatform',
+          type,
+          @server_properties.get(property)
+        )
+      end
+
+      def internal_app_key
+        type = Rox::Core::CustomPropertyType::STRING
+
+        Rox::Core::DeviceProperty.new(
+          'internal.appKey',
+          type,
+          @server_properties.rollout_key
+        )
+      end
+
+      def internal_distinct_id
+        type = Rox::Core::CustomPropertyType::STRING
+
+        Rox::Core::DeviceProperty.new(
+          "internal.#{Rox::Core::PropertyType::DISTINCT_ID.name}",
+          type
+        ) do
+          SecureRandom.uuid
+        end
+      end
+
+      def internal_lib_version
+        type = Rox::Core::CustomPropertyType::SEMVER
+
+        Rox::Core::DeviceProperty.new(
+          'internal.lib_version',
+          type,
+          @server_properties.lib_version
+        )
+      end
+
+      def internal_api_version
+        property = Rox::Core::PropertyType::API_VERSION
+        type = Rox::Core::CustomPropertyType::SEMVER
+
+        Rox::Core::DeviceProperty.new(
+          'internal.api_version',
+          type,
+          property
+        )
+      end
+
+      # rubocop:disable Metrics/MethodLength
+      def all_properties
+        [
+          platform,
+          app_release,
+          distinct_id,
+          internal_real_platform,
+          internal_custom_platform,
+          internal_app_key,
+          internal_distinct_id,
+          internal_lib_version,
+          internal_api_version
+        ]
+      end
+    end
+  end
+end

data/lib/rox/core/register/registerer.rb

@@ -7,25 +7,26 @@ module Rox
         @mutex = Mutex.new
       end
 
-      def register_instance(container, ns)
-        raise ArgumentError, 'A namespace cannot be null' if ns.nil?
+      def register_instance(container, namespace)
+        raise ArgumentError, 'A namespace cannot be null' if namespace.nil?
 
         @mutex.synchronize do
-          raise ArgumentError, "A container with the given namespace (#{ns}) has already been registered" if @namespaces.include?(ns)
+          if @namespaces.include?(namespace)
+            raise ArgumentError,
+                  "A container with the given namespace (#{namespace}) has already been registered"
+          end
         end
 
-        @namespaces << ns
+        @namespaces << namespace
 
-        container.instance_variables().each do |attribute_name|
+        container.instance_variables.each do |attribute_name|
           begin
             value = container.instance_variable_get(attribute_name)
-            if value != nil && value.is_a?(Variant)
-              var_name = attribute_name.to_s();
-              # removing the attribute starting @ (if [always] exists)
-              if (var_name[0] == '@')
-                var_name[0] = '';
-              end
-              @flag_repository.add_flag(value, ns == '' ? var_name : "#{ns}.#{var_name}")
+            if !value.nil? && value.is_a?(RoxString)
+              var_name = attribute_name.to_s
+            # removing the attribute starting @ (if [always] exists)
+              var_name[0] = '' if var_name[0] == '@'
+              @flag_repository.add_flag(value, namespace == '' ? var_name : "#{namespace}.#{var_name}")
             end
           rescue StandardError
             next

data/lib/rox/core/reporting/error_reporter.rb

@@ -13,6 +13,7 @@ module Rox
 
       def report(message, ex)
         return if @device_properties.rollout_environment == 'LOCAL'
+        return if @device_properties.rox_options.self_managed?
 
         Logging.logger.error("Error report: #{message}", ex)
 
@@ -33,8 +34,8 @@ module Rox
         begin
           @request.send_post(ErrorReporter::BUGSNAG_NOTIFY_URL, payload)
           Logging.logger.debug('Bugsnag error report was sent')
-        rescue StandardError => ex
-          Logging.logger.error('Failed to send bugsnag error ', ex)
+        rescue StandardError => e
+          Logging.logger.error('Failed to send bugsnag error ', e)
         end
       end
 
@@ -49,13 +50,13 @@ module Rox
 
       def add_metadata(message, ev)
         inner_data = {
-            'message' => message,
-            'deviceId' => @device_properties.distinct_id,
-            'buid' => @buid.to_s
+          'message' => message,
+          'deviceId' => @device_properties.distinct_id,
+          'buid' => @buid.to_s
         }
 
         metadata = {
-            'data' => inner_data
+          'data' => inner_data
         }
 
         ev['metaData'] = metadata
@@ -88,15 +89,15 @@ module Rox
 
       def add_notifier(payload)
         notifier = {
-            'name' => 'Rollout Ruby SDK',
-            'version' => @device_properties.lib_version
+          'name' => 'Rollout Ruby SDK',
+          'version' => @device_properties.lib_version
         }
         payload['notifier'] = notifier
       end
 
       def add_user(id, rollout_key, ev)
         user = {
-            id => rollout_key
+          id => rollout_key
         }
         ev['user'] = user
       end
@@ -121,13 +122,13 @@ module Rox
 
       def add_app(ev)
         app = {
-            'releaseStage' => @device_properties.rollout_environment,
-            'version' => @device_properties.lib_version
+          'releaseStage' => @device_properties.rollout_environment,
+          'version' => @device_properties.lib_version
         }
         ev['app'] = app
       end
 
-      STACK_TRACE_LINE_REGEX = /^((?:[a-zA-Z]:)?[^:]+):(\d+)(?::in `([^']+)')?$/
+      STACK_TRACE_LINE_REGEX = /^((?:[a-zA-Z]:)?[^:]+):(\d+)(?::in `([^']+)')?$/.freeze
 
       def parse_stack_trace(stack_trace)
         stack = []
@@ -149,4 +150,4 @@ module Rox
       end
     end
   end
-end
+end

data/lib/rox/core/repositories/experiment_repository.rb

@@ -5,9 +5,7 @@ module Rox
         @experiments = []
       end
 
-      def experiments=(experiments)
-        @experiments = experiments
-      end
+      attr_writer :experiments
 
       def experiment_by_flag(flag_name)
         @experiments.detect { |e| e.flags.include?(flag_name) }
@@ -18,4 +16,4 @@ module Rox
       end
     end
   end
-end
+end

data/lib/rox/core/repositories/flag_repository.rb

@@ -2,29 +2,29 @@ module Rox
   module Core
     class FlagRepository
       def initialize
-        @variants = {}
+        @strings = {}
         @flag_added_handlers = []
         @mutex = Mutex.new
         @handlers_mutex = Mutex.new
       end
 
-      def add_flag(variant, name)
-        variant.name = name if variant.name.nil? || variant.name.empty?
+      def add_flag(string, name)
+        string.name = name if string.name.nil? || string.name.empty?
         @mutex.synchronize do
-          @variants[name] = variant
+          @strings[name] = string
         end
-        raise_flag_added_event(variant)
+        raise_flag_added_event(string)
       end
 
       def flag(name)
         @mutex.synchronize do
-          return @variants[name]
+          return @strings[name]
         end
       end
 
       def all_flags
         @mutex.synchronize do
-          return @variants.values
+          return @strings.values
         end
       end
 

data/lib/rox/core/repositories/roxx/experiments_extensions.rb

@@ -11,13 +11,13 @@ module Rox
       end
 
       def extend
-        @parser.add_operator('mergeSeed') do |parser, stack, context|
+        @parser.add_operator('mergeSeed') do |_parser, stack, _context|
           seed1 = stack.pop
           seed2 = stack.pop
           stack.push("#{seed1}.#{seed2}")
         end
 
-        @parser.add_operator('isInPercentage') do |parser, stack, context|
+        @parser.add_operator('isInPercentage') do |_parser, stack, _context|
           percentage = stack.pop
           seed = stack.pop
 
@@ -27,7 +27,7 @@ module Rox
           stack.push(bucket <= percentage)
         end
 
-        @parser.add_operator('isInPercentageRange') do |parser, stack, context|
+        @parser.add_operator('isInPercentageRange') do |_parser, stack, _context|
           percentage_low = stack.pop
           percentage_high = stack.pop
           seed = stack.pop
@@ -42,17 +42,17 @@ module Rox
         @parser.add_operator('flagValue') do |parser, stack, context|
           feature_flag_identifier = stack.pop
           result = Flag::FLAG_FALSE_VALUE
-          variant = @flags_repository.flag(feature_flag_identifier)
+          string = @flags_repository.flag(feature_flag_identifier)
 
-          if !variant.nil?
-            result = variant.value(context)
-          else
+          if string.nil?
             flags_experiment = @experiment_repository.experiment_by_flag(feature_flag_identifier)
 
             if !flags_experiment.nil? && !flags_experiment.condition.nil? && !flags_experiment.condition.empty?
               experiment_eval_result = parser.evaluate_expression(flags_experiment.condition, context).string_value
               result = experiment_eval_result if !experiment_eval_result.nil? && !experiment_eval_result.empty?
             end
+          else
+            result = string.value(context)
           end
 
           stack.push(result)
@@ -79,4 +79,4 @@ module Rox
       end
     end
   end
-end
+end

data/lib/rox/core/repositories/roxx/properties_extensions.rb

@@ -1,26 +1,51 @@
 require 'rox/core/roxx/token_type'
+require 'rox/core/error_handling/exception_trigger'
+require 'rox/core/error_handling/userspace_handler_exception'
 
 module Rox
   module Core
     class PropertiesExtensions
-      def initialize(parser, properties_repository)
+      def initialize(parser, properties_repository, dynamic_property_rule_handler = nil)
         @parser = parser
         @properties_repository = properties_repository
+        @dynamic_property_rule_handler = dynamic_property_rule_handler
       end
 
       def extend
-        @parser.add_operator('property') do |parser, stack, context|
+        @parser.add_operator('property') do |_parser, stack, context|
           prop_name = stack.pop.to_s
           property = @properties_repository.custom_property(prop_name)
+          value = get_value(prop_name, property, context)
 
-          if property.nil?
-            stack.push(TokenType::UNDEFINED)
+          stack.push(value.nil? ? TokenType::UNDEFINED : value)
+        end
+      end
+
+      private
+
+      def get_value(prop_name, property, context)
+        if property.nil?
+          if @dynamic_property_rule_handler.nil?
+            TokenType::UNDEFINED
           else
-            value = property.value(context)
-            stack.push(value.nil? ? TokenType::UNDEFINED : value)
+            get_value_from_dynamic_property_rule_handler(prop_name, context)
           end
+        else
+          get_value_from_property(property, context)
         end
       end
+
+      def get_value_from_dynamic_property_rule_handler(prop_name, context)
+        @dynamic_property_rule_handler.call(prop_name, context)
+      rescue StandardError => e
+        raise Rox::Core::UserspaceHandlerException, handler, ExceptionTrigger::DYNAMIC_PROPERTIES_RULE, e
+      end
+
+      def get_value_from_property(property, context)
+        property.value(context)
+      rescue StandardError => e
+        raise Rox::Core::UserspaceHandlerException, handler, ExceptionTrigger::CUSTOM_PROPERTY_GENERATOR, e
+      end
     end
   end
-end
+end