rox-rollout 4.1.0 → 5.0.0

data/lib/rox/core/entities/default_flag_values.rb

@@ -0,0 +1,10 @@
+module Rox
+  module Core
+    class DefaultFlagValues
+      STRING = ''
+      INT = 0
+      FLOAT = 0.0
+      BOOLEAN = false
+    end
+  end
+end

data/lib/rox/core/entities/flag.rb

@@ -1,20 +1,35 @@
-require 'rox/core/entities/variant'
+require 'rox/core/entities/rox_string'
+require 'rox/core/entities/default_flag_values'
 
 module Rox
   module Core
-    class Flag < Variant
+    class Flag < RoxString
       FLAG_TRUE_VALUE = 'true'.freeze
       FLAG_FALSE_VALUE = 'false'.freeze
 
-      def initialize(default_value = false)
-        super(default_value ? Flag::FLAG_TRUE_VALUE : Flag::FLAG_FALSE_VALUE, [Flag::FLAG_FALSE_VALUE, Flag::FLAG_TRUE_VALUE])
+      def initialize(default_value = DefaultFlagValues::BOOLEAN)
+        super(default_value ? Flag::FLAG_TRUE_VALUE : Flag::FLAG_FALSE_VALUE, [Flag::FLAG_FALSE_VALUE,
+                                                                               Flag::FLAG_TRUE_VALUE])
       end
 
       def enabled?(context)
-        value(context) == Flag::FLAG_TRUE_VALUE
+        merged_context = MergedContext.new(@parser&.global_context, context)
+        value = internal_enabled?(merged_context)
+        if [true, false].include? value
+          send_impressions(value, merged_context)
+          return value
+        end
+
+        send_impressions(DefaultFlagValues::BOOLEAN, merged_context)
+        DefaultFlagValues.BOOLEAN
+      end
+
+      def value(context = nil)
+        merged_context = MergedContext.new(@parser&.global_context, context)
+        internal_value(merged_context, false)
       end
 
-      def internal_enabled?(context, nil_instead_of_default)
+      def internal_enabled?(context, nil_instead_of_default = false)
         val = internal_value(context, nil_instead_of_default)
         nil_instead_of_default && val.nil? ? nil : (val == Flag::FLAG_TRUE_VALUE)
       end
@@ -28,4 +43,4 @@ module Rox
       end
     end
   end
-end
+end

data/lib/rox/core/entities/flag_setter.rb

@@ -7,9 +7,9 @@ module Rox
         @experiment_repository = experiment_repository
         @impression_invoker = impression_invoker
 
-        @flag_repository.register_flag_added_handler do |variant|
-          exp = @experiment_repository.experiment_by_flag(variant.name)
-          set_flag_data(variant, exp)
+        @flag_repository.register_flag_added_handler do |string|
+          exp = @experiment_repository.experiment_by_flag(string.name)
+          set_flag_data(string, exp)
         end
       end
 
@@ -31,9 +31,9 @@ module Rox
         end
       end
 
-      def set_flag_data(variant, experiment = nil)
-        variant.set_for_evaluation(@parser, experiment, @impression_invoker)
+      def set_flag_data(string, experiment = nil)
+        string.set_for_evaluation(@parser, experiment, @impression_invoker)
       end
     end
   end
-end
+end

data/lib/rox/core/entities/rox_double.rb

@@ -0,0 +1,11 @@
+require 'rox/core/entities/rox_string'
+
+module Rox
+  module Core
+    class RoxDouble < RoxString
+      def value(context = nil)
+        internal_value(context, false, Float)
+      end
+    end
+  end
+end

data/lib/rox/core/entities/rox_int.rb

@@ -0,0 +1,11 @@
+require 'rox/core/entities/rox_string'
+
+module Rox
+  module Core
+    class RoxInt < RoxString
+      def value(context = nil)
+        internal_value(context, false, Integer)
+      end
+    end
+  end
+end

data/lib/rox/core/entities/{variant.rb → rox_string.rb}

@@ -4,22 +4,31 @@ require 'rox/core/impression/models/reporting_value'
 
 module Rox
   module Core
-    class Variant
-      attr_accessor :default_value, :options, :name, :context, :condition, :parser, :impression_invoker, :client_experiment
+    class RoxString
+      attr_accessor :default_value, :options, :name, :condition, :parser, :impression_invoker,
+                    :client_experiment
 
       def initialize(default_value, options = [])
         @default_value = default_value
         @options = options.clone
+        raise ArgumentError, 'options should be an array' unless options.is_a?(Array)
+        if options.length > 0 && options.any? { |x| x.class != default_value.class }
+          raise ArgumentError, 'options should be the same type as default value'
+        end
         @options << default_value unless options.include?(default_value)
 
         @condition = nil
         @parser = nil
-        @context = nil
         @impression_invoker = nil
         @client_experiment = nil
         @name = nil
       end
 
+      def send_impressions(return_value, merged_context)
+        reporting_value = ReportingValue.new(@name, return_value, @client_experiment)
+        @impression_invoker&.invoke(reporting_value, @client_experiment, merged_context)
+      end
+
       def set_for_evaluation(parser, experiment, impression_invoker)
         if experiment.nil?
           @client_experiment = nil
@@ -37,24 +46,22 @@ module Rox
         internal_value(context, false)
       end
 
-      def internal_value(context, nil_instead_of_default)
+      def internal_value(context, nil_instead_of_default, evaluated_type = String)
         return_value = nil_instead_of_default ? nil : @default_value
-        merged_context = MergedContext.new(@context, context)
+        merged_context = MergedContext.new(@parser&.global_context, context)
 
-        if !@parser.nil? && !@condition.nil? && !@condition.empty?
+        unless @parser.nil? || @condition.nil? || @condition.empty?
           evaluation_result = @parser.evaluate_expression(@condition, merged_context)
           unless evaluation_result.nil?
-            value = evaluation_result.string_value
-            if !value.nil? && !value.empty?
-              return_value = value
-            end
+            value = evaluated_type == String ? evaluation_result.string_value : evaluation_result.value
+            is_empty = value.is_a?(String) && value.empty?
+            return_value = value if !value.nil? && !is_empty
           end
         end
 
-        @impression_invoker.invoke(ReportingValue.new(@name, return_value), @client_experiment, merged_context) if @impression_invoker != nil
-
+        send_impressions(return_value, merged_context)
         return_value
       end
     end
   end
-end
+end

data/lib/rox/core/error_handling/exception_trigger.rb

@@ -0,0 +1,10 @@
+module Rox
+  module Core
+    module ExceptionTrigger
+      DYNAMIC_PROPERTIES_RULE = 1
+      CONFIGURATION_FETCHED_HANDLER = 2
+      IMPRESSION_HANDLER = 3
+      CUSTOM_PROPERTY_GENERATOR = 4
+    end
+  end
+end

data/lib/rox/core/error_handling/userspace_handler_exception.rb

@@ -0,0 +1,12 @@
+module Rox
+  module Core
+    class UserspaceHandlerException < StandardError
+      def initialize(exception_source, exception_trigger, exception)
+        @exception_source = exception_source
+        @exception_trigger = exception_trigger
+        @exception = exception
+        super('user unhandled exception in roxx expression')
+      end
+    end
+  end
+end

data/lib/rox/core/error_handling/userspace_unhandled_error_invoker.rb

@@ -0,0 +1,41 @@
+require 'rox/core/logging/logging'
+
+module Rox
+  module Core
+    class UserspaceUnhandledErrorInvoker
+      def initialize(user_unhandler_error_handler = nil)
+        @user_unhandler_error_handler = user_unhandler_error_handler
+      end
+
+      def invoke(exception_source, exception_trigger, exception)
+        unless @user_unhandler_error_handler
+          Logging.logger.error("User Unhandled Error Occurred, no fallback handler was set, exception ignored: #{exception}")
+          return
+        end
+
+        begin
+          userspace_unhandled_error_args = UserspaceUnhandledErrorArgs.new(exception_source, exception_trigger, exception)
+          @user_unhandler_error_handler.call(userspace_unhandled_error_args)
+        rescue StandardError => e
+          Logging.logger.error("User Unhandled Error Handler itself threw an exception. original exception: #{e}")
+        end
+      end
+
+      def handler=(handler)
+        @user_unhandler_error_handler = handler
+      end
+    end
+
+    class UserspaceUnhandledErrorArgs
+      def initialize(exception_source = nil, exception_trigger = nil, exception = nil)
+        @exception_source = exception_source
+        @exception_trigger = exception_trigger
+        @exception = exception
+      end
+
+      def to_s
+        "UserspaceUnhandledErrorArgs(#{@exception_source}, #{@exception_trigger}, #{@exception})"
+      end
+    end
+  end
+end

data/lib/rox/core/impression/impression_args.rb

@@ -1,5 +1,5 @@
 module Rox
   module Core
-    ImpressionArgs = Struct.new(:reporting_value, :experiment, :context)
+    ImpressionArgs = Struct.new(:reporting_value, :context)
   end
-end
+end

data/lib/rox/core/impression/impression_invoker.rb

@@ -1,23 +1,54 @@
 require 'rox/core/impression/impression_args'
+require 'rox/core/logging/logging'
+require 'rox/core/error_handling/exception_trigger'
+require 'rox/core/consts/property_type'
 
 module Rox
   module Core
     class ImpressionInvoker
-      def initialize(internal_flags, custom_property_repository, device_properties, analytics_client, is_roxy)
+      def initialize(internal_flags, custom_property_repository, device_properties, analytics_client, is_roxy, user_unhandled_error_invoker)
         @internal_flags = internal_flags
         @custom_property_repository = custom_property_repository
         @device_properties = device_properties
         @analytics_client = analytics_client
         @is_roxy = is_roxy
+        @user_unhandled_error_invoker = user_unhandled_error_invoker
 
         @impression_handlers = []
         @mutex = Mutex.new
       end
 
-      def invoke(reporting_value, client_experiment, context)
-        # TODO: Implement analytics logic
+      def invoke(reporting_value, stickiness_property, context)
+        begin
+          analytics_enabled = @internal_flags.enabled?('rox.internal.analytics')
+          if analytics_enabled && !@is_roxy
+            prop = @custom_property_repository.custom_property(stickiness_property) || @custom_property_repository.custom_property("rox.#{Rox::Core::PropertyType::DISTINCT_ID.name}")
+            distinct_id = '(null_distinct_id'
+            unless prop.nil?
+              prop_value = prop.value(context)
+              distinct_id = prop_value if prop_value.instance_of?(String)
+            end
 
-        raise_impression_event(ImpressionArgs.new(reporting_value, client_experiment, context))
+            event_time = (Time.now.to_f * 1000.0).to_i
+            begin
+              event_time = ENV['rox.analytics.ms'].to_i
+            rescue StandardError
+            end
+
+            @analytics_client.track({
+                                      flag: reporting_value.name,
+                                      value: reporting_value.value,
+                                      distinctId: distinct_id,
+                                      experimentVersion: '0',
+                                      type: 'IMPRESSION',
+                                      time: event_time
+                                    })
+          end
+        rescue StandardError => ex
+          Logging.logger.error('Failed to send analytics', ex)
+        end
+
+        raise_impression_event(ImpressionArgs.new(reporting_value, context))
       end
 
       def register_impression_handler(&block)
@@ -32,10 +63,13 @@ module Rox
           handlers = @impression_handlers.clone
         end
 
-        handlers.each do |handler|
-          handler.call(args)
+        begin
+          handlers.each { |handler| handler.call(args) }
+        rescue StandardError => e
+          user_unhandled_error_invoker.invoke(handler, ExceptionTrigger::IMPRESSION_HANDLER, e)
+          Logging.logger.error('Impresssion handler exception', ex)
         end
       end
     end
   end
-end
+end

data/lib/rox/core/impression/models/experiment.rb

@@ -11,4 +11,4 @@ module Rox
       end
     end
   end
-end
+end

data/lib/rox/core/impression/models/reporting_value.rb

@@ -1,5 +1,13 @@
 module Rox
   module Core
-    ReportingValue = Struct.new(:name, :value)
+    class ReportingValue
+      attr_reader :name, :value, :targeting
+
+      def initialize(name, value, experiment = nil)
+        @name = name
+        @value = value
+        @targeting = !experiment.nil?
+      end
+    end
   end
-end
+end

data/lib/rox/core/logging/logging.rb

@@ -5,8 +5,8 @@ module Rox
     class Logging
       @logger = nil
 
-      def self.logger=(logger)
-        @logger = logger
+      class << self
+        attr_writer :logger
       end
 
       def self.logger
@@ -14,4 +14,4 @@ module Rox
       end
     end
   end
-end
+end

data/lib/rox/core/logging/no_op_logger.rb

@@ -8,4 +8,4 @@ module Rox
       def warn(message, ex = nil); end
     end
   end
-end
+end

data/lib/rox/core/network/configuration_fetch_result.rb

@@ -2,4 +2,4 @@ module Rox
   module Core
     ConfigurationFetchResult = Struct.new(:data, :source)
   end
-end
+end

data/lib/rox/core/network/configuration_fetcher.rb

@@ -9,18 +9,18 @@ module Rox
         source = ConfigurationSource::CDN
         begin
           fetch_result = fetch_from_cdn
-          return ConfigurationFetchResult.new(fetch_result.text, source) if fetch_result.success_status_code?
-
-          if [403, 404].include?(fetch_result.status_code)
+          if fetch_result.success?
+            return ConfigurationFetchResult.new(fetch_result.text, source)
+          else
             write_fetch_error_to_log_and_invoke_fetch_handler(source, fetch_result, false, ConfigurationSource::API)
             source = ConfigurationSource::API
             fetch_result = fetch_from_api
-            return ConfigurationFetchResult.new(fetch_result.text, source) if fetch_result.success_status_code?
+            return ConfigurationFetchResult.new(fetch_result.text, source) if fetch_result.success?
           end
 
           write_fetch_error_to_log_and_invoke_fetch_handler(source, fetch_result)
-        rescue StandardError => ex
-          write_fetch_exception_to_log_and_invoke_fetch_handler(source, ex)
+        rescue StandardError => e
+          write_fetch_exception_to_log_and_invoke_fetch_handler(source, e)
         end
 
         nil
@@ -31,8 +31,9 @@ module Rox
       end
 
       def fetch_from_api
-        @request.send_get(@request_configuration_builder.build_for_api)
+        api_request = @request_configuration_builder.build_for_api
+        @request.send_post(api_request.url, api_request.query_params)
       end
     end
   end
-end
+end

data/lib/rox/core/network/configuration_fetcher_base.rb

@@ -22,4 +22,4 @@ module Rox
       end
     end
   end
-end
+end

data/lib/rox/core/network/configuration_fetcher_roxy.rb

@@ -9,13 +9,13 @@ module Rox
         source = ConfigurationSource::ROXY
         begin
           fetch_roxy = fetch_from_roxy
-          if fetch_roxy.success_status_code?
+          if fetch_roxy.success?
             return ConfigurationFetchResult.new(fetch_roxy.text, source)
           else
             write_fetch_error_to_log_and_invoke_fetch_handler(source, fetch_roxy)
           end
-        rescue StandardError => ex
-          write_fetch_exception_to_log_and_invoke_fetch_handler(source, ex)
+        rescue StandardError => e
+          write_fetch_exception_to_log_and_invoke_fetch_handler(source, e)
         end
 
         nil
@@ -26,4 +26,4 @@ module Rox
       end
     end
   end
-end
+end