rows_controller 2.1.0 → 2.1.2

data/gemfiles/rails_5.2.gemfile

@@ -0,0 +1,17 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rails", "~> 5.2.0"
+
+group :test do
+  gem "rails-controller-testing"
+  gem "observr"
+  gem "simplecov", require: false
+  gem "minitest"
+  gem "capybara"
+  gem "sqlite3"
+  gem "slim"
+end
+
+gemspec path: "../"

data/lib/rows/version.rb

@@ -1,3 +1,3 @@
 module Rows
-  VERSION = '2.1.0'
+  VERSION = '2.1.2'
 end

data/rows_controller.gemspec

@@ -0,0 +1,25 @@
+lib = File.expand_path('../lib', __FILE__)
+$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
+require "rows/version"
+
+Gem::Specification.new do |s|
+  s.name        = 'rows_controller'
+  s.version     = Rows::VERSION
+  s.summary     = 'RowsController DRYs your controllers.'
+  s.description = 'YourController < RowsController ( < ApplicationController).'
+  s.authors     = ['Dittmar Krall']
+  s.email       = ['dittmar.krall@matique.de']
+  s.homepage    = 'http://matique.de'
+
+  s.license     = 'MIT'
+  s.platform    = Gem::Platform::RUBY
+
+  s.files         = `git ls-files -z`.split("\x0")
+  s.test_files    = s.files.grep(%r{^(test|spec|features)/})
+  s.require_paths = ['lib']
+
+  s.add_development_dependency 'bundler', '~> 1'
+  s.add_development_dependency 'rake', '~> 12'
+  s.add_development_dependency 'appraisal', '~> 2'
+#  s.add_development_dependency 'combustion', '~> 0'
+end

data/script/rails

@@ -0,0 +1,8 @@
+#!/usr/bin/env ruby
+# This command will automatically be run when you run "rails" with Rails 3 gems installed from the root of your application.
+
+ENGINE_ROOT = File.expand_path('../..', __FILE__)
+ENGINE_PATH = File.expand_path('../../lib/rows/engine', __FILE__)
+
+require 'rails/all'
+require 'rails/engine/commands'

data/test/.watchr

@@ -0,0 +1,61 @@
+HH = '#' * 22  unless defined?(HH)
+H = '#' * 5    unless defined?(H)
+
+def usage
+  puts <<-EOS
+  Ctrl-\\ or ctrl-4   Running all tests
+  Ctrl-C             Exit
+  EOS
+end
+
+def run(cmd)
+  puts "#{HH} #{Time.now} #{HH}"
+  puts "#{H} #{cmd}"
+  system "/usr/bin/time --format '#{HH} Elapsed time %E' #{cmd}"
+end
+
+def run_it(type, file)
+  case type
+#  when 'test';  run %Q{ruby -I"lib:test" -rubygems #{file}}
+  when 'test';  run %Q{rails test #{file}}
+  when 'spec';  run %Q{rspec -X #{file}}
+  else;         puts "#{H} unknown type: #{type}, file: #{file}"
+  end
+end
+
+def run_all_tests
+  puts "\n#{HH} Running all tests #{HH}\n"
+#  system "spring stop"
+  %w{test spec}.each { |dir| run "rails #{dir}"  if  File.exists?(dir) }
+end
+
+def run_matching_files(base)
+  base = base.split('_').first
+  %w{test spec}.each { |type|
+    files = Dir["#{type}/**/*.rb"].select { |file| file =~ /#{base}_.*\.rb/ }
+    run_it type, files.join(' ')  unless files.empty?
+  }
+end
+
+%w{test spec}.each { |type|
+  watch("#{type}/#{type}_helper\.rb") { run_all_tests }
+  watch("#{type}/.*/*_#{type}\.rb")   { |match| run_it type, match[0] }
+  watch("#{type}/data/(.*)\.rb") { |match|
+    m1 = match[1]
+    run_matching_files("#{type}/#{m1}/#{m1}_#{type}.rb")
+  }
+}
+%w{rb erb haml slim}.each { |type|
+  watch("app/.*/(.*)\.#{type}") { |match|
+    run_matching_files(match[1])
+  }
+}
+Dir['**/*.rb'].find_all{ |x| !(x =~ /_test\.rb$/) }.each { |name|
+  watch(name)  { run_all_tests }
+}
+
+# Ctrl-\ or ctrl-4
+    Signal.trap('QUIT') { run_all_tests }
+# Ctrl-C
+    Signal.trap('INT')  { abort("Interrupted\n") }
+usage

data/test/controllers/order/items_controller_test.rb

@@ -0,0 +1,64 @@
+# mostly generated by Rails
+
+require 'test_helper'
+
+class Order::ItemsControllerTest < ActionController::TestCase
+  fixtures :all
+
+  def setup
+    @order_item = order_items(:one)
+  end
+
+  test 'checking model_...' do
+    get :index
+    assert_equal Order::Item,    @controller.send(:model_class)
+    assert_equal 'Order::Item',  @controller.send(:model_name)
+    assert_equal 'order_item',   @controller.send(:model_symbol)
+    assert_equal 'order_items',  @controller.send(:model_symbol_plural)
+  end
+
+  test "should get index" do
+    get :index
+    assert_response :success
+    assert_not_nil assigns(:order_items)
+  end
+
+  test "should get new" do
+    get :new
+    assert_response :success
+  end
+
+  test "should create order_item" do
+    assert_difference('Order::Item.count') do
+      post :create, params: { order_item: { price: @order_item.price } }
+    end
+
+##    assert_redirected_to order_item_path(assigns(:order_item))
+    assert_redirected_to edit_order_item_path(assigns(:order_item))
+  end
+
+  test "should show order_item" do
+    get :show, params: { id: @order_item }
+    assert_response :success
+  end
+
+  test "should get edit" do
+    get :edit, params: { id: @order_item }
+    assert_response :success
+  end
+
+  test "should update order_item" do
+    put :update, params: { id: @order_item,
+		order_item: { price: @order_item.price } }
+##    assert_redirected_to order_item_path(assigns(:order_item))
+    assert_redirected_to edit_order_item_path(assigns(:order_item))
+  end
+
+  test "should destroy order_item" do
+    assert_difference('Order::Item.count', -1) do
+      delete :destroy, params: { id: @order_item }
+    end
+
+    assert_redirected_to order_items_path
+  end
+end

data/test/controllers/orders_test.rb

@@ -0,0 +1,83 @@
+require 'test_helper'
+
+class OrdersControllerTest < ActionController::TestCase
+#class OrdersControllerTest < ActionDispatch::IntegrationTest
+#class OrdersControllerTest < ActiveSupport::TestCase
+  fixtures :all
+
+  def setup
+    @order = orders(:one)
+  end
+
+  %i{ index new }.each do |action|
+    test "renders the '#{action}' template" do
+      get action
+      assert_response :success
+      assert_template "rows/#{action}"
+      assert_match(/Order/, response.body)
+    end
+  end
+
+  %i{ edit show }.each do |action|
+    test "renders the '#{action}' template" do
+      get action, params: { id: @order.id }
+      assert_response :success
+      assert_template "rows/#{action}"
+      assert_match(/Order/, response.body)
+    end
+  end
+
+  test 'checking resource' do
+    get :show, params: { id: @order.id }
+    assert_equal @order, @controller.send(:resource)
+    assert_equal @order, assigns(:order)
+    assert_equal @order, assigns(:row)
+  end
+
+  test 'checking resources' do
+    get :index
+    assert_kind_of Array, @controller.send(:resources).to_a
+    assert_kind_of Array, assigns(:orders).to_a
+    assert_kind_of Array, assigns(:rows).to_a
+    assert_equal Order.all, assigns(:orders)
+  end
+
+  test 'checking model_class' do
+    get :show, params: { id: @order.id }
+    assert_equal Order,    @controller.send(:model_class)
+    assert_equal 'Order',  @controller.send(:model_name)
+    assert_equal 'order',  @controller.send(:model_symbol)
+    assert_equal 'orders', @controller.send(:model_symbol_plural)
+  end
+
+  test "should create order #2" do
+    assert_difference('Order.count') do
+      post :create, params: { commit: 'OK', order: { name: @order.name } }
+    end
+  end
+
+  test 'should update' do
+    put :update, params: { id: @order.id, order: {name: 'name'} }
+    assert response
+    assert_redirected_to(action: :edit)
+  end
+
+  test 'should update #2' do
+    put :update, params: {id: @order.id, commit: 'OK', order: {name: 'name'}}
+    assert response
+    assert_redirected_to(action: :index)
+  end
+
+  test 'should not update' do
+    put :update, params: { id: @order.id, order: {name: 'error'} }
+    assert_response :success
+    assert_template 'rows/edit'
+  end
+
+  test 'should not create' do
+    post :create, params: { id: @order.id, order: {name: 'error'} }
+    assert_response :success
+    assert_template 'rows/new'
+  end
+
+end

data/test/controllers/rows_controller_test.rb

@@ -0,0 +1,52 @@
+require 'test_helper'
+
+class RowsControllerTest < ActionController::TestCase
+  test 'respond resource' do
+    test_response %i{ resource resources set_resource set_resources }
+  end
+
+  test 'respond model' do
+    test_response %i{ model_class }
+  end
+
+  test 'respond resource format' do
+    test_response %i{ resource_format }
+  end
+
+
+  test 'respond action' do
+    test_response %i{ index new create show edit update destroy }
+  end
+
+  test 'coverage resource_format' do
+    assert_equal 'abc', @controller.send(:resource_format, 'abc')
+  end
+
+  test 'available public methods' do
+    list = %i{create destroy edit index new show update}
+    assert_equal list.sort, @controller.public_methods(false).sort
+  end
+
+  test 'exposed resource private methods' do
+    list = %i{resource resource_format resources set_resource set_resources}
+    assert_equal list.sort, filter(@controller.public_methods, 'resource')
+  end
+
+  test 'exposed model_ private methods' do
+    list = %i{model_class model_name model_symbol model_symbol_plural}
+    got = filter(@controller.public_methods, 'model_')
+    assert_equal list.sort, (list & got).sort
+  end
+
+ private
+  def filter(x, criteria)
+    x.map(&:to_s).sort.find_all { |y| y =~ /#{criteria}/ }.map(&:to_sym).sort
+  end
+
+  def test_response(list)
+    list.each { |x|
+      assert @controller.respond_to?(x), "controller don't respond to #{x}"
+    }
+  end
+
+end

data/test/controllers/rows_ext_controller_test.rb

@@ -0,0 +1,25 @@
+require 'test_helper'
+
+class OrdersControllerTest < ActionController::TestCase
+#class OrdersControllerTest < ActionDispatch::IntegrationTest
+#class OrdersControllerTest < ActiveSupport::TestCase
+
+  test 'respond to :copy' do
+    assert @controller.respond_to?(:copy)
+    order = Order.create :name => 'name'
+#    n = Order.all.length
+    Order.all.length
+
+    put :copy, params: { id: order.id }
+    assert_response :success
+    assert_template 'rows/new'
+    assert_match(/New Order/, response.body)
+  end
+
+  test 'coverage: multi deletion' do
+    delete :multi_deletion
+    assert response
+    assert_redirected_to orders_url
+  end
+
+end

data/test/dummy3/Rakefile

@@ -0,0 +1,6 @@
+# Add your own tasks in files placed in lib/tasks ending in .rake,
+# for example lib/tasks/capistrano.rake, and they will automatically be available to Rake.
+
+require File.expand_path('../config/application', __FILE__)
+
+Dummy::Application.load_tasks

data/test/dummy3/app/controllers/application_controller.rb

@@ -0,0 +1,3 @@
+class ApplicationController < ActionController::Base
+  protect_from_forgery
+end

data/test/dummy3/app/controllers/order/items_controller.rb

@@ -0,0 +1,8 @@
+class Order::ItemsController < RowsController
+
+ private
+  def resource_whitelist
+    %i{ price }
+  end
+
+end

data/test/dummy3/app/controllers/orders_controller.rb

@@ -0,0 +1,8 @@
+class OrdersController < RowsExtController
+
+ private
+  def resource_whitelist
+    %i{ name }
+  end
+
+end

data/test/dummy3/app/models/order.rb

@@ -0,0 +1,14 @@
+class Order < ActiveRecord::Base
+  attr_accessible :name
+
+  before_save :err
+
+ protected
+  def err
+    return true  unless name == 'error'
+
+    self.errors.add :base, 'panic'
+    return false
+  end
+
+end

data/test/dummy3/app/models/order/item.rb

@@ -0,0 +1,4 @@
+class Order::Item < ActiveRecord::Base
+  attr_accessible :price
+
+end

data/test/dummy3/app/views/layouts/application.html.erb

@@ -0,0 +1,12 @@
+<!DOCTYPE html>
+<html>
+<head>
+  <title>Dummy</title>
+  <%= csrf_meta_tags %>
+</head>
+<body>
+
+<%= yield %>
+
+</body>
+</html>

data/test/dummy3/app/views/order/items/_form.html.erb

@@ -0,0 +1,8 @@
+<%
+ # This is a typical form
+ # Requires f
+%>
+<div class="field">
+  <%= f.label :price %><br />
+  <%= f.text_field :price %>
+</div>

data/test/dummy3/app/views/orders/_form.html.erb

@@ -0,0 +1,8 @@
+<%
+ # This is a typical form
+ # Requires f
+%>
+<div class="field">
+  <%= f.label :name %><br />
+  <%= f.text_field :name %>
+</div>

data/test/dummy3/config.ru

@@ -0,0 +1,4 @@
+# This file is used by Rack-based servers to start the application.
+
+require ::File.expand_path('../config/environment',  __FILE__)
+run Dummy::Application