roverjoe 0.0.10

data/lib/roverjoe/remote_property.rb

@@ -0,0 +1,28 @@
+module RoverJoe
+
+  class RemoteProperty 
+
+    attr_accessor :api_request_class, :id
+
+    def initialize( params )
+      @api_request_class = params.delete( :api_request_class ) || RoverJoe::Request 
+      @id = params.delete( :id ) 
+      raise ArgumentError, ":id should not be blank" if @id.nil? or @id == ''
+    end
+
+    def star_rating
+      raise RuntimeError, "'starRating' not found in #{response.keys} for RemoteProperty #{id}." unless response.keys.include?( 'starRating' )
+      response['starRating']
+    end
+
+    def response
+      @response ||= request.execute
+    end
+
+    def request
+      @request ||= api_request_class.new( :propertyinformation, :PropertyNumber => self.id )
+    end
+
+  end
+
+end

data/lib/roverjoe/request.rb

@@ -0,0 +1,60 @@
+module RoverJoe
+
+  require 'httparty'
+  require 'addressable/uri'
+
+  class Request
+
+    attr_accessor :request_type, :request_params, :httparty_response
+
+    def initialize( request_type, request_params = {} )
+      self.request_type, self.request_params = request_type, request_params
+    end
+
+    def execute
+      if response.error_status?
+        message = "Hostelworld API returned Error(s): #{response.errors.to_json} on request #{request_type.inspect} with parameters #{request_params.inspect}"
+        raise PropertyInactiveError, message if response.property_inactive?
+        raise RuntimeError,          message
+      end
+      response.result
+    end
+
+    private
+
+    def response
+      @response ||= quota_handler.run do
+
+        httparty_get = retry_handler.run( request_type, request_params ) do
+          HTTParty.get( uri.to_s )
+        end
+        Response.new( httparty_get.parsed_response, httparty_get )
+
+      end
+    end
+
+    def uri
+      full_params = RoverJoe.configuration.request_params.merge(request_params)
+      format = full_params.delete('format')
+      uri = Addressable::URI.parse( "#{RoverJoe.configuration.request_uri}#{request_type}.#{format}").tap { |u| u.query_values = full_params}
+    end
+
+    def quota_handler
+      self.class.quota_handler
+    end
+
+    def retry_handler
+      self.class.retry_handler
+    end
+
+    def self.retry_handler
+      @retry_handler ||= RetryHandler.new
+    end
+
+    def self.quota_handler
+      @quota_handler ||= QuotaHandler.new
+    end
+
+  end
+
+end

data/lib/roverjoe/response.rb

@@ -0,0 +1,64 @@
+module RoverJoe
+
+  class Response
+
+    QUOTA_EXCEEDED_ERROR_CODE = '526'
+    PROPERTY_INACTIVE_ERROR_CODE = '2027'
+
+    attr_reader :parsed_response, :httparty_response
+
+    def initialize( parsed_response, httparty_response )
+      raise ArgumentError, "Unable to process response \"#{parsed_response.inspect}\" from the Hostelworld API" unless parsed_response.respond_to?( '[]' )
+      @parsed_response = parsed_response
+      @httparty_response = httparty_response
+    end
+
+    def calls_remaining
+      api['callsremaining'].to_i
+    end
+
+    def error_status?
+      unless api.respond_to?(:[])
+        RoverJoe.logger.error "RoverJoe::Response#errors: Hostelworld API result is not in expected format. Key 'api' in parsed response is either missing or not itself a hash."
+        abort_with_diagnostics
+      end
+      api['status'] == 'Error'
+    end
+
+
+    def abort_with_diagnostics 
+      RoverJoe.logger.warn  "RoverJoe::Response: Hostelworld parsed response      : #{parsed_response.inspect[0..600]}"
+      RoverJoe.logger.warn  "RoverJoe::Response: Hostelworld raw response body    : #{httparty_response.body[0..600]}"
+      RoverJoe.logger.warn  "RoverJoe::Response: Hostelworld raw response headers : #{httparty_response.headers.inspect}"
+      raise RuntimeError, "Hostelworld API result is not in expected format, see log for details. Response begins: #{parsed_response.to_s[0..200]}"
+    end
+
+    def result
+      @parsed_response['result']
+    end
+
+    def errors
+      unless result.respond_to?(:[])
+        RoverJoe.logger.error "RoverJoe::Response#errors: Hostelworld API result is not in expected format. Key 'result' in parsed response is either missing or not itself a hash."
+        abort_with_diagnostics
+      end
+      result['errors']
+    end
+
+    def quota_exceeded?
+      error_status? && errors.respond_to?(:has_key?) && errors.has_key?(QUOTA_EXCEEDED_ERROR_CODE)
+    end
+
+    def property_inactive?
+      error_status? && errors.respond_to?(:has_key?) && errors.has_key?(PROPERTY_INACTIVE_ERROR_CODE)
+    end
+
+    private
+
+    def api
+      @parsed_response['api']
+    end
+
+  end
+
+end

data/lib/roverjoe/retry_handler.rb

@@ -0,0 +1,56 @@
+module RoverJoe
+
+  class RetryHandler
+
+    def run( *request ) 
+
+      reset_retry_counters
+
+      begin
+
+        yield
+
+      rescue Errno::ECONNRESET => e
+
+        log_request_exception( e, *request ) 
+        retry unless excessive_retries?( :conn_reset_peer )
+        abort_on_excess( *request ) 
+
+      rescue Errno::ETIMEDOUT => e
+
+        log_request_exception( e, *request ) 
+        retry unless excessive_retries?( :timed_out )
+        abort_on_excess( *request ) 
+
+      rescue Timeout::Error => e
+
+        log_request_exception( e, *request ) 
+        retry unless excessive_retries?( :timed_out )
+        abort_on_excess( *request ) 
+
+      end
+
+    end
+
+    def log_request_exception( exception, *request )
+      RoverJoe.logger.warn( "Hostelworld API: Exception #{exception.class.name} \"#{exception}\" processing request #{request.inspect}" )
+    end
+
+    def abort_on_excess( *request )
+      message = "Hostelworld API: Aborting request after excessive retries processing request #{request.inspect}"
+      RoverJoe.logger.error message
+      raise ExcessiveRetries, message
+    end
+
+    def excessive_retries?( kind_of_error )
+      @retry_counter[ kind_of_error ] += 1
+      @retry_counter[ kind_of_error ] > 10
+    end
+
+    def reset_retry_counters
+      @retry_counter = Hash.new( 0 )
+    end
+
+  end
+
+end

data/lib/roverjoe/version.rb

@@ -0,0 +1,3 @@
+module RoverJoe
+  VERSION = "0.0.10"
+end

data/roverjoe.gemspec

@@ -0,0 +1,32 @@
+require File.expand_path("../lib/roverjoe/version", __FILE__)
+
+Gem::Specification.new do |s|
+  s.name        = "roverjoe"
+  s.version     = RoverJoe::VERSION
+  s.platform    = Gem::Platform::RUBY
+  s.authors     = ["Andy Roberts"]
+  s.email       = ["andy.roberts@lonelyplanet.com"]
+  s.homepage    = "http://github.com/lonelyplanet/roverjoe"
+  s.summary     = "Ruby wrapper for the Hostelworld API"
+  s.description = "Ruby wrapper for the Hostelworld API"
+
+  s.required_rubygems_version = ">= 1.3.6"
+
+  # lol - required for validation
+  s.rubyforge_project         = "roverjoe"
+
+  s.files         = `git ls-files`.split("\n")
+  s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
+  s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
+  s.require_paths = ["lib"]
+
+  s.add_dependency 'addressable'
+  s.add_dependency 'httparty'
+
+  s.add_development_dependency 'cucumber'
+  s.add_development_dependency 'rspec'
+  s.add_development_dependency 'guard'
+  s.add_development_dependency 'guard-rspec'
+  s.add_development_dependency 'guard-cucumber'
+  s.add_development_dependency 'webmock'
+end

data/spec/fixtures/configurations/consumer_key_only.yml

@@ -0,0 +1,2 @@
+params: 
+  consumer_key: 'lonelyplanet.com'

data/spec/fixtures/configurations/consumer_signature_only.yml

@@ -0,0 +1,2 @@
+params: 
+  consumer_signature: 'somethingsecret'

data/spec/fixtures/hostelworld_api/real_propertyinformation_json.txt

@@ -0,0 +1 @@
+{"api":{"status":"Success","callsremaining":58,"version":"1.1.35.2"},"result":{"propertyNumber":"640","propertyName":"Flying Pig Uptown","address1":"Vossiusstraat 46","address2":"","geo":{"latitude":"52.3604797","longitude":"4.8783588"},"city":"Amsterdam","CityNO":"15","country":"Netherlands","CountryNO":"148","description":"As the original Flying Pig hostel, we can't wait to welcome you again! \r\n\r\nWe're located perfectly central in-between the museum and fashion district, the park and Leidseplein, where the best concert-halls, clubs, bars and coffee shops are and most locals go out. You'll get that real Amsterdam feel and are still close enough to the red light district, which is only a 15-minute walk.\r\n\r\nThe Pig has been world-famous for its laidback atmosphere, with a hostel bar that everyone keeps talking about and friendly, helpful staff. We have a guest kitchen and a bar with indoor smoking area where you'll meet lots of people. This lively bar has theme nights, the cheapest beer in town and daily drinks specials! \r\n\r\nEvery bed in our dorms has a reading light, with single and queen-size bunk beds and free individual lockers in the rooms (bring your own padlock or buy one at reception for \u20ac3). There's a shower and toilet in most of the rooms. Our private rooms have a little fridge and TV.\r\n\r\nThere's free breakfast, linen and internet; one price covers all! The Flying Pig Uptown provides a free buffet-style breakfast, free use of our reception safe for small valuables, free luggage storage, Internet, Skype and Wi-Fi, a book exchange, free movies to watch and munchy food for sale! You can even borrow some skates for free.\r\n\r\nThis spring and summer you can enjoy Amsterdam's famous green grass in the beautiful Vondelpark, right outside the Flying Pig Uptown, for drinks, smokes and picnics. Check out the free musical and cultural performances on the park stage or play games with your (new) friends in your bare feet.\r\n\r\nIf you're in for some culture, the Van Gogh museum and the Rijksmuseum (with the 'Nachtwacht') are just around the corner, same as the beautiful Concert Building and the 'I Amsterdam' letters. Do you want to explore the Red Light District, some historic sites or Chinatown? Just take a stroll - everything is within walking distance. Public transport is close by, too.\r\n\r\nBut there's always more: go shopping at one of the local markets (such as the Albert Cuijp in the Pijp area) or the 'Nine Little Streets', drink a beer at the Amsterdam Heineken Museum or have a wild night out in the so-called pop temple the Paradiso, within crawling-home distance. You can borrow some free hostel skates and share a smoke, drink and a blanket with your (newly made) friends on the green grass of the famous Vondelpark. Laugh your head off at one of the comedy clubs on the Leidseplein or visit other local areas of the city.\r\n\r\nAt reception you can buy Pig merchandise and tickets to several events. We have free walking tours, a daily updated Amsterdam agenda, a free detailed map of Amsterdam and discounts on several things to do in Amsterdam. You get 50% off entrance to the Winston Kingdom club with your Flying Pig key card. We also offer a shuttle bus between Amsterdam and the Beach hostel.\r\n\r\nWe're open 24hrs with night security and no curfews or lockout. Access is by keycard.\r\n\r\nPlease note that the Flying Pig has an age restriction; we welcome guests from above 18 to the eternal young at heart! \r\n\r\nPlease read our Things To Note below. We only accept groups of up to 10 people through Hostelworld.","averageRating":86,"propertyType":"HOSTEL","currency":"EUR","conditions":"Please bring this confirmation with you for check-in. \r\nOur office handles all email cancellations (Mon-Fri 9am-5pm). Urgent cancellations or changes for the current weekend must therefore be done by phone directly with the hostel (+31 20 400 41 87) at least 24hrs before arrival date (write down the date and hour of cancelling and the name of the person you spoke to).\r\nNon-urgent cancellations and changes will need to be done by email to info@flyingpig.nl. Please provide the reservation details in your email. Only when you receive a personal reply with the confirmation of your cancellation can you be sure that your cancellation has been processed by us. No-shows will be charged for a single night's accommodation.\r\nThe 10% web deposit is always non-refundable.\r\nWe authorize all credit cards on the day of arrival for the amount of the first night. This is an authorization only and will be released shortly after.\r\nThe Flying Pig has an age restriction; we welcome guests from above 18 to the eternal young at heart!\r\nGroups of more than 10 people must contact us before booking.","directions":"From Schiphol airport to Amsterdam Central Station:\r\nThe easiest way into Amsterdam from Schiphol Airport is by train. Trains between Schiphol and Central Station depart about every 10 minutes between 6am and 1am, and once every hour between 1am and 6am. A one-way ticket will cost you \u20ac3.20 from a vending machine; you'll need some coins though. Trains to Amsterdam Central Station generally depart from platform 1 or 2. \r\n\r\nTo get to the Flying Pig Uptown from Central Station:\r\nTake tram 2 or 5 and get off at the Rijksmuseum (Hobbemastraat), one stop past the famous Leidseplein bar area. Walk back 150m in the direction the tram came from and turn left into the Vossiusstraat; we're at number 46.","email":"headoffice@flyingpig.nl","tel":"+31 20 428 49 34","locatedNear":"Located near Leidseplein (party square), Coffee shops, Van Gogh museum, Rembrandt museum, Stedelijk museum, Albert Cuyp market and Vondel Park.","notes":"It is not allowed to bring your own sleeping bag or pillow. Our beds are ready-made for you. We have a 24hr cancellation policy. Late cancellations and no-shows shall be charged the equivalent of one night's stay. The 10% deposit is not refundable in case of cancellations. We do our best to accommodate you (together with your friends) in the dorm of your choice. However, due to the nature of our business, room arrangements and price may be slightly different. We authorize all credit cards on the day of arrival for the amount of the first night. This is an authorization only and will be released shortly after.","starRating":4,"creationdate":"2000-01-01","shortintro":"As the original Flying Pig hostel, we can't wait to welcome you again! \r\n\r\nWe're located perfectly central in-between the museum and fashion district, the park and Leidseplein, where the best concert-halls, clubs, bars and coffee shops are and most locals go out. You'll get that real Amsterdam feel","signupsource":"","active":"1","province":"","cancellationPolicy":"1","propertyImages":[{"imageSize":"max","imageURL":"http:\/\/u.hwstatic.com\/propertyimages\/6\/640\/1.jpg","imageWidth":"333","imageHeight":"333"},{"imageSize":"max","imageURL":"http:\/\/u.hwstatic.com\/propertyimages\/6\/640\/2.jpg","imageWidth":"323","imageHeight":"431"},{"imageSize":"max","imageURL":"http:\/\/u.hwstatic.com\/propertyimages\/6\/640\/3.jpg","imageWidth":"250","imageHeight":"250"},{"imageSize":"max","imageURL":"http:\/\/u.hwstatic.com\/propertyimages\/6\/640\/4.jpg","imageWidth":"444","imageHeight":"296"},{"imageSize":"max","imageURL":"http:\/\/u.hwstatic.com\/propertyimages\/6\/640\/5.jpg","imageWidth":"453","imageHeight":"340"},{"imageSize":"max","imageURL":"http:\/\/u.hwstatic.com\/propertyimages\/6\/640\/6.jpg","imageWidth":"438","imageHeight":"329"},{"imageSize":"max","imageURL":"http:\/\/u.hwstatic.com\/propertyimages\/6\/640\/7.jpg","imageWidth":"414","imageHeight":"311"},{"imageSize":"max","imageURL":"http:\/\/u.hwstatic.com\/propertyimages\/6\/640\/8.jpg","imageWidth":"450","imageHeight":"600"},{"imageSize":"large","imageURL":"http:\/\/u.hwstatic.com\/propertyimages\/6\/640\/1_l.jpg","imageWidth":250,"imageHeight":163},{"imageSize":"large","imageURL":"http:\/\/u.hwstatic.com\/propertyimages\/6\/640\/2_l.jpg","imageWidth":250,"imageHeight":163},{"imageSize":"large","imageURL":"http:\/\/u.hwstatic.com\/propertyimages\/6\/640\/3_l.jpg","imageWidth":250,"imageHeight":163},{"imageSize":"large","imageURL":"http:\/\/u.hwstatic.com\/propertyimages\/6\/640\/4_l.jpg","imageWidth":250,"imageHeight":163},{"imageSize":"large","imageURL":"http:\/\/u.hwstatic.com\/propertyimages\/6\/640\/5_l.jpg","imageWidth":250,"imageHeight":163},{"imageSize":"large","imageURL":"http:\/\/u.hwstatic.com\/propertyimages\/6\/640\/6_l.jpg","imageWidth":250,"imageHeight":163},{"imageSize":"large","imageURL":"http:\/\/u.hwstatic.com\/propertyimages\/6\/640\/7_l.jpg","imageWidth":250,"imageHeight":163},{"imageSize":"large","imageURL":"http:\/\/u.hwstatic.com\/propertyimages\/6\/640\/8_l.jpg","imageWidth":250,"imageHeight":163},{"imageSize":"small","imageURL":"http:\/\/u.hwstatic.com\/propertyimages\/6\/640\/1_s.jpg","imageWidth":150,"imageHeight":100},{"imageSize":"small","imageURL":"http:\/\/u.hwstatic.com\/propertyimages\/6\/640\/2_s.jpg","imageWidth":150,"imageHeight":100},{"imageSize":"small","imageURL":"http:\/\/u.hwstatic.com\/propertyimages\/6\/640\/3_s.jpg","imageWidth":150,"imageHeight":100},{"imageSize":"small","imageURL":"http:\/\/u.hwstatic.com\/propertyimages\/6\/640\/4_s.jpg","imageWidth":150,"imageHeight":100},{"imageSize":"small","imageURL":"http:\/\/u.hwstatic.com\/propertyimages\/6\/640\/5_s.jpg","imageWidth":150,"imageHeight":100},{"imageSize":"small","imageURL":"http:\/\/u.hwstatic.com\/propertyimages\/6\/640\/6_s.jpg","imageWidth":150,"imageHeight":100},{"imageSize":"small","imageURL":"http:\/\/u.hwstatic.com\/propertyimages\/6\/640\/7_s.jpg","imageWidth":150,"imageHeight":100},{"imageSize":"small","imageURL":"http:\/\/u.hwstatic.com\/propertyimages\/6\/640\/8_s.jpg","imageWidth":150,"imageHeight":100}],"facilities":["24 Hour Reception","24 Hour Security","Air Conditioning","Bar","Bicycle Hire","Breakfast Included","Cafe","Card Phones","Common Room","Free Internet Access","Internet Access","Key Card Access","Kitchen","Linen Included","Lockers","Luggage Storage","Reading Light","Towels for hire"],"checkInTime":{"earliest":0,"latest":23}}}

data/spec/integration/configuration_spec.rb

@@ -0,0 +1,35 @@
+require 'spec_helper'
+
+describe RoverJoe do
+  describe 'Configuration integration.' do
+
+    describe 'from file that sets consumer key only' do
+      before(:all) { RoverJoe.configure_from_file( configuration_file_fixture( 'consumer_key_only.yml' ) ) }
+
+      it 'sets the consumer key to the value from the file' do
+        RoverJoe.configuration.request_params['consumer_key'].should == 'lonelyplanet.com'
+        RoverJoe.configuration.consumer_key.should == 'lonelyplanet.com'
+      end
+
+      it 'sets the consumer signature to the default' do
+        RoverJoe.configuration.request_params['consumer_signature'].should == 'you-forgot-to-configure-consumer-signature'
+        RoverJoe.configuration.consumer_signature.should == 'you-forgot-to-configure-consumer-signature'
+      end
+    end
+
+    describe 'from file that sets consumer signature only' do
+      before(:all) { RoverJoe.configure_from_file( configuration_file_fixture( 'consumer_signature_only.yml' ) ) }
+
+      it 'sets the consumer signature to the value from the file' do
+        RoverJoe.configuration.request_params['consumer_signature'].should == 'somethingsecret'
+        RoverJoe.configuration.consumer_signature.should == 'somethingsecret'
+      end
+
+      it 'sets the consumer key to the default' do
+        RoverJoe.configuration.request_params['consumer_key'].should == 'you-forgot-to-configure-consumer-key'
+        RoverJoe.configuration.consumer_key.should == 'you-forgot-to-configure-consumer-key'
+      end
+    end
+
+  end
+end

data/spec/integration/star_ratings_spec.rb

@@ -0,0 +1,61 @@
+require 'spec_helper'
+
+describe RoverJoe do
+  describe 'Star ratings integration.' do
+    before(:all) do
+      RoverJoe.reset_configuration
+      RoverJoe.configure do |c|
+        c.consumer_key = 'lonelyplanet.com'
+        c.consumer_signature = 'asecretsignature'
+      end
+    end
+
+    let( :hostel ) { RoverJoe::RemoteProperty.new( :id => 4898797 ) }
+
+    context 'When API gives' do
+      describe 'normal repsonse' do
+
+        it 'remote property returns a star rating' do
+          hostelworld_api_propertyinformation_stub( hostel.id ).
+            to_return(:status => 200, :body => response_content, :headers => {content_type: 'application/json'})
+          hostel.star_rating.should == 4
+        end
+      end
+
+      describe 'quota exceed response, followed by normal repsonse' do
+        it 'remote property returns a star rating' do
+          quota_response = { 'api' => { 'status' => 'Error', 'callsremaining' => '0'}, 'result' => { 'errors' => { '526' => 'you ran out'  }   } }.to_json
+          hostelworld_api_propertyinformation_stub( hostel.id ).
+            to_return( [
+                          { :status => 200, :body => quota_response, :headers => {content_type: 'application/json'} } ,
+                          { :status => 200, :body => response_content, :headers => {content_type: 'application/json'} }
+            ] )
+          hostel.star_rating.should == 4
+        end
+      end
+
+      describe 'timeout responses, followed by normal repsonse' do
+        it 'remote property returns a star rating' do
+          quota_response = { 'api' => { 'status' => 'Error', 'callsremaining' => '0'}, 'result' => { 'errors' => { '526' => 'you ran out'  }   } }.to_json
+          hostelworld_api_propertyinformation_stub( hostel.id ).
+            to_raise( Errno::ETIMEDOUT ).then.
+            to_raise( TimeoutError ).then.
+            to_raise( Timeout::Error ).then.
+            to_return( { :status => 200, :body => response_content, :headers => {content_type: 'application/json'} } )
+          hostel.star_rating.should == 4
+        end
+      end
+
+      describe 'connection reset by peer response, followed by normal repsonse' do
+        it 'remote property returns a star rating' do
+          quota_response = { 'api' => { 'status' => 'Error', 'callsremaining' => '0'}, 'result' => { 'errors' => { '526' => 'you ran out'  }   } }.to_json
+          hostelworld_api_propertyinformation_stub( hostel.id ).
+            to_raise( Errno::ECONNRESET ).then.
+            to_return( { :status => 200, :body => response_content, :headers => {content_type: 'application/json'} } )
+          hostel.star_rating.should == 4
+        end
+      end
+    end
+
+  end
+end

data/spec/lib/roverjoe/configuration_spec.rb

@@ -0,0 +1,55 @@
+require 'spec_helper'
+
+module RoverJoe
+  describe Configuration do
+
+    %w{ logger request_uri consumer_key consumer_signature }.each do |attribute|
+      let( :some_value ) { double( 'some value' ).as_null_object }
+
+      it "retains new values for #{attribute}" do
+        subject.send( attribute + '=' , some_value ) 
+        subject.send( attribute ).should === some_value
+      end
+    end
+
+    let( :some_request_params ) do
+      %w{ consumer_key consumer_signature format Language}.inject({}) { |result,attrib| result[attrib] = double.as_null_object ; result }
+    end
+
+    it 'retains new values for request_params' do
+        subject.request_params = some_request_params
+        subject.request_params.should === some_request_params
+    end
+
+    %w{ consumer_key consumer_signature }.each do |attribute|
+      let( :some_value ) { double( 'some value' ).as_null_object }
+
+      it "request_params['#{attribute}'] is set by #{attribute}=" do
+        subject.send( attribute + '=' , some_value ) 
+        subject.request_params[attribute].should === some_value
+      end
+    end
+
+    context 'when initialized' do 
+
+      let (:null_logger) { double( 'null logger' ) }
+
+      %w{ request_params request_uri consumer_key consumer_signature }.each do |attribute|
+        it "has a default #{attribute}" do
+          subject.send(attribute).should_not be_nil
+        end
+      end
+      %w{ consumer_signature consumer_key format Language }.each do |key|
+        it "has a default request_params['#{key}']" do
+          subject.request_params[key].should_not be_nil
+        end
+      end
+      it 'has a default logger set to a new NullLogger' do
+        NullLogger.should_receive(:new).and_return( null_logger )
+        subject.logger.should === null_logger
+      end
+
+    end
+
+  end
+end

data/spec/lib/roverjoe/quota_handler_spec.rb

@@ -0,0 +1,48 @@
+require 'spec_helper'
+
+module RoverJoe
+  describe QuotaHandler do
+
+    describe '#run' do
+
+      let( :block_result ) { double('block result').as_null_object } 
+      let( :some_block   ) { Proc.new { block_result } }
+
+      it 'returns the result of the yield' do
+        block_result.stub!(:quota_exceeded?).and_return(false)
+        subject.run( &some_block ).should == block_result
+      end
+
+      context 'when the quota is exceeded first time, but not the second time' do 
+        it 'returns the result of the yield' do
+          block_result.stub!(:quota_exceeded?).and_return(true,false)
+          subject.stub!(:sleep) # we don't want to wait 400 seconds in the test
+          subject.run( &some_block ).should == block_result
+        end
+
+        context 'and an after_delay callback is defined' do
+          let( :mock_object ) { double( 'mock object ') }
+          before(:each) { RoverJoe.configuration.after_delay { |delay| mock_object.mock_method(delay) } }
+
+          it 'calls the callback with the delay' do
+            block_result.stub!(:quota_exceeded?).and_return(true,false)
+            mock_object.should_receive(:mock_method).with( instance_of(Float) )
+            subject.stub!(:sleep) # we don't want to wait 400 seconds in the test
+            subject.run( &some_block ).should == block_result
+          end
+        end
+      end
+
+      context 'when the quota is exceeded forever' do 
+        it 'throws an exception' do
+          block_result.stub!(:quota_exceeded?).and_return(true)
+          subject.stub!(:sleep) # we don't want to wait 400 seconds in the test
+          lambda{ subject.run( &some_block ) }.should raise_error
+        end
+      end
+
+
+    end
+
+  end
+end