routing-filter 0.0.1 → 0.1.0

data/spec/generation_spec.rb

@@ -1,367 +0,0 @@
-require File.dirname(__FILE__) + '/spec_helper.rb'
-
-describe 'RoutingFilter', 'url generation' do
-  include RoutingFilterHelpers
-
-  before :each do
-    setup_environment :locale, :pagination
-
-    @site = Site.new
-    @section = Section.new
-    @article = Article.new
-  end
-
-  describe "named route url_helpers" do
-    describe "a not nested resource" do
-      it 'does not change the section_path when given page option equals 1' do
-        section_path(:id => 1, :page => 1).should == '/en/sections/1'
-      end
-
-      it 'appends the pages segments to section_path when given page option does not equal 1' do
-        section_path(:id => 1, :page => 2).should == '/en/sections/1/pages/2'
-      end
-
-      it 'prepends the current locale to section_path' do
-        I18n.locale = :de
-        section_path(:id => 1).should == '/de/sections/1'
-      end
-
-      it 'prepends a given locale param to section_path' do
-        I18n.locale = :de
-        section_path(:id => 1, :locale => :fi).should == '/fi/sections/1'
-      end
-
-      it 'does not prepend a locale to section_path if given locale is false' do
-        section_path(:id => 1, :locale => false).should == '/sections/1'
-      end
-
-      it 'works on section_path with both a locale and page option' do
-        section_path(:id => 1, :locale => :fi, :page => 2).should == '/fi/sections/1/pages/2'
-      end
-
-      it 'should not prepend an invalid locale to section_path' do
-        section_path(:id => 1, :locale => :aa).should == '/sections/1'
-      end
-
-      it 'should prepend a longer locale to section_path' do
-        section_path(:id => 1, :locale => 'en-US').should == '/en-US/sections/1'
-      end
-
-      it 'should not prepend the default locale when configured not to' do
-        RoutingFilter::Locale.include_default_locale = false
-        section_path(:id => 1, :locale => :en).should == '/sections/1'
-      end
-    end
-
-    describe "a nested resource" do
-      it 'does not change the section_article_path when given page option equals 1' do
-        section_article_path(:section_id => 1, :id => 1, :page => 1).should == '/en/sections/1/articles/1'
-      end
-
-      it 'appends the pages segments to section_article_path when given page option does not equal 1' do
-        section_article_path(:section_id => 1, :id => 1, :page => 2).should == '/en/sections/1/articles/1/pages/2'
-      end
-
-      it 'prepends the current locale to section_article_path' do
-        I18n.locale = :de
-        section_article_path(:section_id => 1, :id => 1).should == '/de/sections/1/articles/1'
-      end
-
-      it 'prepends a given locale param to section_article_path' do
-        I18n.locale = :de
-        section_article_path(:section_id => 1, :id => 1, :locale => :fi).should == '/fi/sections/1/articles/1'
-      end
-
-      it 'does not prepend a locale to section_article_path if given locale is false' do
-        section_article_path(:section_id => 1, :id => 1, :locale => false).should == '/sections/1/articles/1'
-      end
-
-      it 'works on section_article_path with both a locale and page option' do
-        section_article_path(:section_id => 1, :id => 1, :locale => :fi, :page => 2).should == '/fi/sections/1/articles/1/pages/2'
-      end
-
-      it 'should not prepend an invalid locale to section_article_path' do
-        section_article_path(:section_id => 1, :id => 1, :locale => :aa).should == '/sections/1/articles/1'
-      end
-
-      it 'should prepend a longer locale to section_article_path' do
-        section_article_path(:section_id => 1, :id => 1, :locale => 'en-US').should == '/en-US/sections/1/articles/1'
-      end
-
-      it 'should not prepend the default locale when configured not to' do
-        RoutingFilter::Locale.include_default_locale = false
-        section_article_path(:section_id => 1, :id => 1, :locale => :en).should == '/sections/1/articles/1'
-      end
-    end
-  end
-
-  describe 'when used with named route url_helper with "optimized" generation blocks' do
-    describe "a not nested resource" do
-      it 'does not change the section_path when given page option equals 1' do
-        section_path(1, :page => 1).should == '/en/sections/1'
-      end
-
-      it 'appends the pages segments to section_path when given page option does not equal 1' do
-        section_path(1, :page => 2).should == '/en/sections/1/pages/2'
-      end
-
-      it 'prepends the current locale to section_path' do
-        I18n.locale = :de
-        section_path(1).should == '/de/sections/1'
-      end
-
-      it 'prepends a given locale param to section_path' do
-        I18n.locale = :de
-        section_path(1, :locale => :fi).should == '/fi/sections/1'
-      end
-
-      it 'does not prepend a locale to section_path if given locale is false' do
-        section_path(1, :locale => false).should == '/sections/1'
-      end
-
-      it 'works for section_path with both a locale and page option' do
-        section_path(1, :locale => :fi, :page => 2).should == '/fi/sections/1/pages/2'
-      end
-
-      it 'should not prepend an invalid locale to section_path' do
-        section_path(1, :locale => :aa).should == '/sections/1'
-      end
-
-      it 'should prepend a longer locale to section_path' do
-        section_path(1, :locale => 'en-US').should == '/en-US/sections/1'
-      end
-
-      it 'should not prepend the default locale when configured not to' do
-        RoutingFilter::Locale.include_default_locale = false
-        section_path(1, :locale => :en).should == '/sections/1'
-      end
-    end
-
-    describe "a nested resource" do
-      it 'does not change the section_article_path when given page option equals 1' do
-        section_article_path(1, 1, :page => 1).should == '/en/sections/1/articles/1'
-      end
-
-      it 'appends the pages segments to section_article_path when given page option does not equal 1' do
-        section_article_path(1, 1, :page => 2).should == '/en/sections/1/articles/1/pages/2'
-      end
-
-      it 'prepends the current locale to section_article_path' do
-        I18n.locale = :de
-        section_article_path(1, 1).should == '/de/sections/1/articles/1'
-      end
-
-      it 'prepends a given locale param to section_article_path' do
-        I18n.locale = :de
-        section_article_path(1, 1, :locale => :fi).should == '/fi/sections/1/articles/1'
-      end
-
-      it 'does not prepend a locale to section_article_path if given locale is false' do
-        section_article_path(1, 1, :locale => false).should == '/sections/1/articles/1'
-      end
-
-      it 'works for section_article_path with both a locale and page option' do
-        section_article_path(1, 1, :locale => :fi, :page => 2).should == '/fi/sections/1/articles/1/pages/2'
-      end
-
-      it 'should not prepend an invalid locale to section_article_path' do
-        section_article_path(1, 1, :locale => :aa).should == '/sections/1/articles/1'
-      end
-
-      it 'should prepend a longer locale to section_article_path' do
-        section_article_path(1, 1, :locale => 'en-US').should == '/en-US/sections/1/articles/1'
-      end
-
-      it 'should not prepend the default locale when configured not to' do
-        RoutingFilter::Locale.include_default_locale = false
-        section_article_path(1, 1, :locale => :en).should == '/sections/1/articles/1'
-      end
-    end
-  end
-
-  describe 'when used with a polymorphic_path' do
-    describe "a not nested resource" do
-      it 'does not change the section_path when given page option equals 1' do
-        section_path(@section, :page => 1).should == '/en/sections/1'
-      end
-
-      it 'appends the pages segments to section_path when given page option does not equal 1' do
-        section_path(@section, :page => 2).should == '/en/sections/1/pages/2'
-      end
-
-      it 'prepends the current locale to section_path' do
-        I18n.locale = :de
-        section_path(@section).should == '/de/sections/1'
-      end
-
-      it 'prepends a given locale param to section_path' do
-        I18n.locale = :de
-        section_path(@section, :locale => :fi).should == '/fi/sections/1'
-      end
-
-      it 'does not prepend a locale to section_path if given locale is false' do
-        section_path(@section, :locale => false).should == '/sections/1'
-      end
-
-      it 'works for section_path with both a locale and page option' do
-        section_path(@section, :locale => :fi, :page => 2).should == '/fi/sections/1/pages/2'
-      end
-
-      it 'should not prepend an invalid locale to section_path' do
-        section_path(@section, :locale => :aa).should == '/sections/1'
-      end
-
-      it 'should prepend a longer locale to section_path' do
-        section_path(@section, :locale => 'en-US').should == '/en-US/sections/1'
-      end
-
-      it 'should not prepend the default locale when configured not to' do
-        RoutingFilter::Locale.include_default_locale = false
-        section_path(@section, :locale => :en).should == '/sections/1'
-      end
-    end
-
-    describe "a nested resource" do
-      it 'does not change the section_article_path when given page option equals 1' do
-        section_article_path(@section, @article, :page => 1).should == '/en/sections/1/articles/1'
-      end
-
-      it 'appends the pages segments to section_article_path when given page option does not equal 1' do
-        section_article_path(@section, @article, :page => 2).should == '/en/sections/1/articles/1/pages/2'
-      end
-
-      it 'prepends the current locale to section_article_path' do
-        I18n.locale = :de
-        section_article_path(@section, @article).should == '/de/sections/1/articles/1'
-      end
-
-      it 'prepends a given locale param to section_article_path' do
-        I18n.locale = :de
-        section_article_path(@section, @article, :locale => :fi).should == '/fi/sections/1/articles/1'
-      end
-
-      it 'does not prepend a locale to section_article_path if given locale is false' do
-        section_article_path(@section, @article, :locale => false).should == '/sections/1/articles/1'
-      end
-
-      it 'works for section_article_path with both a locale and page option' do
-        section_article_path(@section, @article, :locale => :fi, :page => 2).should == '/fi/sections/1/articles/1/pages/2'
-      end
-
-      it 'should not prepend an invalid locale to section_article_path' do
-        section_article_path(@section, @article, :locale => :aa).should == '/sections/1/articles/1'
-      end
-
-      it 'should prepend a longer locale to section_article_path' do
-        section_article_path(@section, @article, :locale => 'en-US').should == '/en-US/sections/1/articles/1'
-      end
-
-      it 'should not prepend the default locale when configured not to' do
-        RoutingFilter::Locale.include_default_locale = false
-        section_article_path(@section, @article, :locale => :en).should == '/sections/1/articles/1'
-      end
-    end
-  end
-
-  describe 'when used with url_for and an ActivRecord instance' do
-    describe "a not nested resource" do
-      it 'does not change the url_for result when given page option equals 1' do
-        params = @section_params.update :id => @section, :page => 1
-        url_for(params).should == 'http://test.host/en/sections/1'
-      end
-
-      it 'appends the pages segments to url_for result when given page option does not equal 1' do
-        params = @section_params.update :id => @section, :page => 2
-        url_for(params).should == 'http://test.host/en/sections/1/pages/2'
-      end
-
-      it 'prepends the current locale to url_for result' do
-        I18n.locale = :de
-        params = @section_params.update :id => @section
-        url_for(params).should == 'http://test.host/de/sections/1'
-      end
-
-      it 'prepends a given locale param url_for result' do
-        I18n.locale = :de
-        params = @section_params.update :id => @section, :locale => :fi
-        url_for(params).should == 'http://test.host/fi/sections/1'
-      end
-
-      it 'does not prepend a locale to url_for result if given locale is false' do
-        params = @section_params.update :id => @section, :locale => false
-        url_for(params).should == 'http://test.host/sections/1'
-      end
-
-      it 'works for url_for result with both a locale and page option' do
-        params = @section_params.update :id => @section, :locale => :fi, :page => 2
-        url_for(params).should == 'http://test.host/fi/sections/1/pages/2'
-      end
-
-      it 'should not prepend an invalid locale to section_path' do
-        params = @section_params.update :id => @section, :locale => :aa
-        url_for(params).should == 'http://test.host/sections/1'
-      end
-
-      it 'should prepend a longer locale to section_path' do
-        params = @section_params.update :id => @section, :locale => 'en-US'
-        url_for(params).should == 'http://test.host/en-US/sections/1'
-      end
-
-      it 'should not prepend the default locale when configured not to' do
-        RoutingFilter::Locale.include_default_locale = false
-        params = @section_params.update :id => @section, :locale => :en
-        url_for(params).should == 'http://test.host/sections/1'
-      end
-    end
-
-    describe "a nested resource" do
-      it 'does not change the url_for result when given page option equals 1' do
-        params = @article_params.update :section_id => @section, :id => @article, :page => 1
-        url_for(params).should == 'http://test.host/en/sections/1/articles/1'
-      end
-
-      it 'appends the pages segments to url_for result when given page option does not equal 1' do
-        params = @article_params.update :section_id => @section, :id => @article, :page => 2
-        url_for(params).should == 'http://test.host/en/sections/1/articles/1/pages/2'
-      end
-
-      it 'prepends the current locale to url_for result' do
-        I18n.locale = :de
-        params = @article_params.update :section_id => @section, :id => @article
-        url_for(params).should == 'http://test.host/de/sections/1/articles/1'
-      end
-
-      it 'prepends a given locale param to url_for result' do
-        I18n.locale = :de
-        params = @article_params.update :section_id => @section, :id => @article, :locale => :fi
-        url_for(params).should == 'http://test.host/fi/sections/1/articles/1'
-      end
-
-      it 'does not prepend a locale to url_for result if given locale is false' do
-        params = @article_params.update :section_id => @section, :id => @article, :locale => false
-        url_for(params).should == 'http://test.host/sections/1/articles/1'
-      end
-
-      it 'works for url_for result with both a locale and page option' do
-        params = @article_params.update :section_id => @section, :id => @article, :locale => :fi, :page => 2
-        url_for(params).should == 'http://test.host/fi/sections/1/articles/1/pages/2'
-      end
-
-      it 'should not prepend an invalid locale to url_for result' do
-        params = @article_params.update :section_id => @section, :id => @article, :locale => :aa
-        url_for(params).should == 'http://test.host/sections/1/articles/1'
-      end
-
-      it 'should prepend a longer locale to section_article_path' do
-        params = @article_params.update :section_id => @section, :id => @article, :locale => 'en-US'
-        url_for(params).should == 'http://test.host/en-US/sections/1/articles/1'
-      end
-
-      it 'should not prepend the default locale when configured not to' do
-        RoutingFilter::Locale.include_default_locale = false
-        params = @article_params.update :section_id => @section, :id => @article, :locale => :en
-        url_for(params).should == 'http://test.host/sections/1/articles/1'
-      end
-    end
-  end
-end

data/spec/pagination_extension_spec.rb

@@ -1,19 +0,0 @@
-require File.dirname(__FILE__) + '/spec_helper.rb'
-
-describe 'RoutingFilter::Pagination' do
-  include RoutingFilterHelpers
-
-  before :each do
-    setup_environment(:pagination)
-  end
-
-  describe 'url generation' do
-    it 'appends the segments /pages/:page to the generated path' do
-      section_path(1, :page => 2).should == '/sections/1/pages/2'
-    end
-
-    it 'appends the segments /pages/:page to the generated path excluding http get params' do
-      section_path(1, :page => 2, :foo => 'bar').should == '/sections/1/pages/2?foo=bar'
-    end
-  end
-end

data/spec/recognition_spec.rb

@@ -1,76 +0,0 @@
-require File.dirname(__FILE__) + '/spec_helper.rb'
-
-describe 'RoutingFilter', 'url recognition' do
-  include RoutingFilterHelpers
-
-  before :each do
-    setup_environment :locale, :pagination
-  end
-
-  it 'recognizes the path /de/sections/1 and sets the :locale param' do
-    should_recognize_path '/de/sections/1', @section_params.update(:locale => 'de')
-  end
-
-  it 'recognizes the path /sections/1/pages/1 and sets the :page param' do
-    should_recognize_path '/sections/1/pages/1', @section_params.update(:page => 1)
-  end
-
-  it 'recognizes the path /de/sections/1/pages/1 and sets the :locale param' do
-    should_recognize_path '/de/sections/1/pages/1', @section_params.update(:locale => 'de', :page => 1)
-  end
-
-  it 'recognizes the path /sections/1/articles/1 and sets the :locale param' do
-    should_recognize_path '/sections/1/articles/1', @article_params
-  end
-
-  it 'recognizes the path /de/sections/1/articles/1 and sets the :locale param' do
-    should_recognize_path '/de/sections/1/articles/1', @article_params.update(:locale => 'de')
-  end
-
-  it 'recognizes the path /de/sections/1/articles/1/pages/1 and sets the :locale param' do
-    should_recognize_path '/de/sections/1/articles/1/pages/1', @article_params.update(:locale => 'de', :page => 1)
-  end
-
-  it 'recognizes the path /sections/1 and does not set a :locale param' do
-    should_recognize_path '/sections/1', @section_params
-  end
-
-  it 'recognizes the path /sections/1 and does not set a :page param' do
-    should_recognize_path '/sections/1', @section_params
-  end
-
-  # Test that routing errors are thrown for invalid locales
-  it 'does not recognizes the path /aa/sections/1 and does not set a :locale param' do
-    begin
-      should_recognize_path '/aa/sections/1', @section_params.update(:locale => 'aa')
-      false
-    rescue ActionController::RoutingError
-      true
-    end
-  end
-
-  it 'recognizes the path /en-US/sections/1 and sets a :locale param' do
-    should_recognize_path '/en-US/sections/1', @section_params.update(:locale => 'en-US')
-  end
-
-  it 'recognizes the path /sections/1/articles/1 and does not set a :locale param' do
-    should_recognize_path '/sections/1/articles/1', @article_params
-  end
-
-  it 'recognizes the path /sections/1/articles/1 and does not set a :page param' do
-    should_recognize_path '/sections/1/articles/1', @article_params
-  end
-
-  it 'invalid locale: does not recognize the path /aa/sections/1/articles/1 and does not set a :locale param' do
-    lambda { @set.recognize_path('/aa/sections/1/articles/1', {}) }.should raise_error(ActionController::RoutingError)
-  end
-
-  it 'recognizes the path /en-US/sections/1/articles/1 and sets a :locale param' do
-    should_recognize_path '/en-US/sections/1/articles/1', @article_params.update(:locale => 'en-US')
-  end
-
-  it 'unescapes the path for the filters' do
-    @set.should_receive(:recognize_path_without_filtering).with('/sections/motörhead', 'test')
-    @set.recognize_path('/sections/mot%C3%B6rhead', 'test')
-  end
-end

data/spec/routing_filter_spec.rb

@@ -1,114 +0,0 @@
-require File.dirname(__FILE__) + '/spec_helper.rb'
-
-describe 'RoutingFilter' do
-  include RoutingFilterHelpers
-
-  before :each do
-    setup_environment :locale, :pagination
-  end
-
-  def recognize_path(path = '/de/sections/1', options = {})
-    @set.recognize_path(path, options)
-  end
-
-  it 'installs filters to the route set' do
-    @locale_filter.should be_instance_of(RoutingFilter::Locale)
-    @pagination_filter.should be_instance_of(RoutingFilter::Pagination)
-  end
-
-  it 'calls the first filter for route recognition' do
-    @locale_filter.should_receive(:around_recognize).and_return :foo => :bar
-    recognize_path.should == { :foo => :bar }
-  end
-
-  it 'calls the second filter for route recognition' do
-    @pagination_filter.should_receive(:around_recognize).and_return :foo => :bar
-    recognize_path.should == { :foo => :bar, :locale => 'de' }
-  end
-
-  it 'calls the first filter for url generation' do
-    @locale_filter.should_receive(:around_generate).and_return '/en/sections/1?page=2'
-    url_for(:controller => 'sections', :action => 'show', :section_id => 1)
-  end
-
-  it 'calls the second filter for url generation' do
-    @pagination_filter.should_receive(:around_generate).and_return '/sections/1?page=2'
-    url_for(:controller => 'sections', :action => 'show', :section_id => 1)
-  end
-
-  it 'calls the first filter for named route url_helper' do
-    @locale_filter.should_receive(:around_generate).and_return '/en/sections/1'
-    section_path(:section_id => 1)
-  end
-
-  it 'calls the filter for named route url_helper with "optimized" generation blocks' do
-    # at_least(1) since the inline code comments in ActionController::Routing::RouteSet::NamedRouteCollection#define_url_helper also call us (as of http://github.com/rails/rails/commit/a2270ef2594b97891994848138614657363f2806)
-    @locale_filter.should_receive(:around_generate).at_least(1).and_return '/en/sections/1'
-    section_path(1)
-  end
-
-  it 'calls the filter for named route polymorphic_path' do
-    # at_least(1) since the inline code comments in ActionController::Routing::RouteSet::NamedRouteCollection#define_url_helper also call us (as of http://github.com/rails/rails/commit/a2270ef2594b97891994848138614657363f2806)
-    @locale_filter.should_receive(:around_generate).at_least(1).and_return '/en/sections/1'
-    section_path(Section.new)
-  end
-
-  # When filters are set up in the order:
-  #
-  #   map.filter :locale
-  #   map.filter :pagination
-  #
-  # Then #around_recognize should be first called on the locale filter and then
-  # on the pagination filter. Whereas #around_generate should be first called
-  # on the pagination filter and then on the locale filter. Right?
-
-  it 'calls #around_recognize in the expected order' do
-    params = { :id => "1", :page => 2, :controller => "sections", :action => "show" }
-    @pagination_filter.stub!(:around_recognize).and_return({ :page => 2, :controller => "sections", :action => "show" })
-
-    recognize_path('/de/sections/1/pages/2')[:locale].should == "de"
-    recognize_path('/de/sections/1/pages/2')[:page].should == 2
-  end
-
-  it 'calls #around_generate in the expected order' do
-    @locale_filter.stub!(:around_generate).and_return('de/sections/1')
-    section_path(1, :page => 2).should == "de/sections/1/pages/2"
-  end
-
-  it 'does not call deactivated filters' do
-    with_deactivated_filters(RoutingFilter::Locale) do
-      @locale_filter.should_not_receive(:around_generate)
-      section_path(Section.new)
-    end
-  end
-
-  it 'still calls successors of deactivated filters' do
-    with_deactivated_filters(RoutingFilter::Locale) do
-      @pagination_filter.should_receive(:around_recognize).and_return :foo => :bar
-      recognize_path('/sections/1').should == { :foo => :bar }
-    end
-  end
-
-  # chain
-
-  it 'adds filters in the order they are registered' do
-    @set.filters[0].should == @locale_filter
-    @set.filters[1].should == @pagination_filter
-  end
-
-  it 'returns the previous filter as a predecessor of a filter' do
-    @set.filters.predecessor(@pagination_filter).should == @locale_filter
-  end
-
-  it 'returns the nil as a predecessor of the first filter' do
-    @set.filters.successor(@pagination_filter).should be_nil
-  end
-
-  it 'returns the next filter as a successor of a filter' do
-    @set.filters.successor(@locale_filter).should == @pagination_filter
-  end
-
-  it 'returns the nil as a successor of the last filter' do
-    @set.filters.successor(@pagination_filter).should be_nil
-  end
-end

data/spec/spec.opts

@@ -1,4 +0,0 @@
---colour
---format progress
---loadby mtime
---reverse