routemaster-drain 3.6.8 → 3.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 431caa4e0158fa1ac795d6feeaa81b96c8e2fe4e
-  data.tar.gz: cceb454d55e593655e39131e7f127a7592101368
+SHA256:
+  metadata.gz: 91d53145809f5384fe911262c83306264381e1915ce6b6aef4a7de3299fd8eee
+  data.tar.gz: 2a7860c5a46d018aa7e10d82aad853066e5daf5851b6deba44e900985c7218c3
 SHA512:
-  metadata.gz: f6b4be9f06e085159e29bf2b53bbf171acb04fece4f740482cb28915545788ef77bd94290d85e024fac0b96d1183c5e54e95a0a27ba6496725ea06e119d6c127
-  data.tar.gz: 677d45ad6541d7301132e90f2e9516131d2c0559ddda86c61b9c2c4270a405202974f26096030fe082019331e3ce786767d64aa6f7d13d5a34b9a30745e8c2dd
+  metadata.gz: 4119a30f7b34f48fcca01432718968523f71ebc9b298c78b6aa1d162c48108db631622ce94ec1859c5715642aa554f009b216cdf016b5391945722302a45ae42
+  data.tar.gz: fa0f8e231efdc36f2bf1f88e0a6a8f9cc14ae3b494761756317cc1924b8f8e505f2e6ca3651132a2e3e2bcddc313071b66523d4626308c324fa8722556ab6ebc

data/.circleci/config.yml

@@ -3,7 +3,6 @@
 
 version: 2
 jobs:
-
   build_2.5_rails_5:
     docker:
       - image: circleci/ruby:2.4.1
@@ -19,9 +18,9 @@ jobs:
 
       - restore_cache:
           keys: 
-            - v2-bundle-2.5.0-rails_5-{{ .Branch }}
-            - v2-bundle-2.5.0-rails_5
-            - v2-bundle-2.5.0
+            - v3-bundle-2.5.0-rails_5-{{ .Branch }}
+            - v3-bundle-2.5.0-rails_5
+            - v3-bundle-2.5.0
 
       - run: 
           name: Install dependencies
@@ -36,22 +35,65 @@ jobs:
             bundle exec rspec
 
       - save_cache:
-          key: v2-bundle-2.5.0-rails_5-{{ .Branch }}
+          key: v3-bundle-2.5.0-rails_5-{{ .Branch }}
           paths:
             - ~/project/vendor/bundle
       - save_cache:
-          key: v2-bundle-2.5.0-rails_5
+          key: v3-bundle-2.5.0-rails_5
           paths:
             - ~/project/vendor/bundle
       - save_cache:
-          key: v2-bundle-2.5.0
+          key: v3-bundle-2.5.0
           paths:
             - ~/project/vendor/bundle
 
+  build_2.7_rails_6:
+    docker:
+      - image: circleci/ruby:2.7.4
+      - image: redis:6-alpine
+    steps:
+      - checkout
+
+      - run:
+          name: Install bundler
+          command: |
+            gem install bundler -v '~> 2' ;
+            bundle config --local gemfile $PWD/gemfiles/rails_6.gemfile
+
+      - restore_cache:
+          keys: 
+            - bundle-2.7.4-rails_6-{{ .Branch }}
+            - bundle-2.7.4-rails_6
+            - bundle-2.7.4
+
+      - run: 
+          name: Install dependencies
+          command: |
+            bundle install --jobs=3 --retry=3 --path=$PWD/vendor/bundle
+
+      - run:
+          name: Run test suite
+          command: |
+            unset RACK_ENV &&
+            unset RAILS_ENV &&
+            bundle exec rspec
+
+      - save_cache:
+          key: bundle-2.7.4-rails_6-{{ .Branch }}
+          paths:
+            - ~/project/vendor/bundle
+      - save_cache:
+          key: bundle-2.7.4-rails_6
+          paths:
+            - ~/project/vendor/bundle
+      - save_cache:
+          key: bundle-2.7.4
+          paths:
+            - ~/project/vendor/bundle
 
 workflows:
   version: 2
   test:
     jobs:
       - build_2.5_rails_5
-    
+      - build_2.7_rails_6

data/CHANGELOG.md

@@ -2,6 +2,12 @@
 
 _A description of your awesome changes here!_
 
+### 3.7.0
+
+Features:
+
+- Adds circuit breaker to PATCH PUT POST requests (#66)
+
 ### 3.6.8
 
 Features:

data/gemfiles/rails_6.gemfile

@@ -0,0 +1,24 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "psych", :require => false
+gem "bundler", :require => false
+gem "rake", :require => false
+gem "webmock", :require => false
+gem "rack-test", :require => false
+gem "dotenv", :require => false
+gem "simplecov", :require => false
+gem "codecov", :require => false
+gem "resque", :require => false
+gem "sidekiq", :require => false
+gem "guard-rspec", :require => false
+gem "pry", :require => false
+gem "byebug", :require => false
+gem "rspec", :require => false
+gem "appraisal", :require => false
+gem "dogstatsd", :require => false
+gem "fork_break", :require => false
+gem "rails", "~> 6.0"
+
+gemspec :path => "../"

data/lib/routemaster/api_client.rb

@@ -99,11 +99,13 @@ module Routemaster
     private
 
     def patch_post_or_put(type, url, body, headers)
-      _wrapped_response _request(
-        type,
-        url: url,
-        body: body,
-        headers: headers)
+      APIClientCircuit.new(url).call do
+        _wrapped_response _request(
+          type,
+          url: url,
+          body: body,
+          headers: headers)
+      end
     end
 
     def _assert_uri(url)

data/lib/routemaster/api_client_circuit.rb

@@ -25,7 +25,6 @@ module Routemaster
       ENV.fetch('ROUTEMASTER_ENABLE_API_CLIENT_CIRCUIT', 'NO') =~ /\A(YES|TRUE|ON|1)\Z/i
     end
 
-
     def circuit
       Circuitbox.circuit(@circuit_name, {
         sleep_window: configuration_setting(@circuit_name, 'ROUTEMASTER_CIRCUIT_BREAKER_SLEEP_WINDOW', 60).to_i,

data/lib/routemaster/drain.rb

@@ -1,5 +1,5 @@
 module Routemaster
   module Drain
-    VERSION = '3.6.8'.freeze
+    VERSION = '3.7.0'.freeze
   end
 end

data/spec/core_ext/forwardable_spec.rb

@@ -1,17 +1,19 @@
 require 'core_ext/forwardable'
 
-describe Forwardable do
-  class Foo
-    extend Forwardable
+if RUBY_VERSION == '2.4.0'
+  describe Forwardable do
+    class Foo
+      extend Forwardable
 
-    def initialize
-      @bar = :bar
-    end
+      def initialize
+        @bar = :bar
+      end
 
-    def_delegator :@bar, :to_s, :qux
-  end
+      def_delegator :@bar, :to_s, :qux
+    end
 
-  it 'expect delegation to work' do
-    expect(Foo.new.qux).to eq 'bar'
+    it 'expect delegation to work' do
+      expect(Foo.new.qux).to eq 'bar'
+    end
   end
 end

data/spec/routemaster/api_client_circuit_spec.rb

@@ -12,7 +12,10 @@ describe Routemaster::APIClientCircuit do
   context "when enabled" do
     before do
       sb_req
-      allow_any_instance_of(described_class).to receive(:enabled?){ true }
+      allow(ENV).to receive(:fetch).and_call_original
+      allow(ENV)
+        .to receive(:fetch)
+        .with('ROUTEMASTER_ENABLE_API_CLIENT_CIRCUIT', 'NO').and_return('YES')
     end
 
     let(:url){ 'http://example.com/foobar' }

data/spec/routemaster/api_client_spec.rb

@@ -109,10 +109,38 @@ describe Routemaster::APIClient do
     end
   end
 
+  shared_examples 'a circuit breaker wrapped request' do
+    let(:fetcher) { described_class.new(retry_attempts: 0) }
+    let(:url)     { 'https://circuit.example.com/circuit/132' }
+    let(:method)  { :get }
+
+    before do
+      allow(ENV).to receive(:fetch).and_call_original
+      allow(ENV)
+        .to receive(:fetch)
+        .with('ROUTEMASTER_ENABLE_API_CLIENT_CIRCUIT', 'NO').and_return('YES')
+      allow(ENV)
+        .to receive(:fetch)
+        .with('ROUTEMASTER_CIRCUIT_BREAKER_ERROR_THRESHOLD', 50).and_return('1')
+      allow(ENV)
+        .to receive(:fetch)
+        .with('ROUTEMASTER_CIRCUIT_BREAKER_VOLUME_THRESHOLD', 50).and_return('1')
+
+      stub_request(method, url).to_timeout
+    end
+
+    it 'trips after the second request' do
+      5.times { expect { subject }.to raise_error StandardError }
+      expect(a_request(method, url)).to have_been_made.at_most_times(2)
+    end
+  end
+
   describe '#get' do
     subject { fetcher.get(url, headers: headers) }
+
     it_behaves_like 'a GET requester'
     it_behaves_like 'a wrappable response'
+    it_behaves_like 'a circuit breaker wrapped request'
   end
 
   describe '#fget' do
@@ -183,6 +211,9 @@ describe Routemaster::APIClient do
     end
 
     it_behaves_like 'a wrappable response'
+    it_behaves_like 'a circuit breaker wrapped request' do
+      let(:method) { :post }
+    end
   end
 
   describe '#put' do
@@ -206,6 +237,9 @@ describe Routemaster::APIClient do
       end
 
       it_behaves_like 'a wrappable response'
+      it_behaves_like 'a circuit breaker wrapped request' do
+        let(:method) { :put }
+      end
     end
 
     context 'when request times out' do
@@ -282,6 +316,9 @@ describe Routemaster::APIClient do
       end
 
       it_behaves_like 'a wrappable response'
+      it_behaves_like 'a circuit breaker wrapped request' do
+        let(:method) { :patch }
+      end
     end
 
     context 'when request times out' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: routemaster-drain
 version: !ruby/object:Gem::Version
-  version: 3.6.8
+  version: 3.7.0
 platform: ruby
 authors:
 - Julien Letessier
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-07-21 00:00:00.000000000 Z
+date: 2021-12-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable
@@ -164,7 +164,7 @@ dependencies:
     - - '='
       - !ruby/object:Gem::Version
         version: 1.0.0
-description: 
+description:
 email:
 - julien.letessier@gmail.com
 executables: []
@@ -193,6 +193,7 @@ files:
 - gemfiles/rails_3.gemfile
 - gemfiles/rails_4.gemfile
 - gemfiles/rails_5.gemfile
+- gemfiles/rails_6.gemfile
 - lib/core_ext/forwardable.rb
 - lib/routemaster/api_client.rb
 - lib/routemaster/api_client_circuit.rb
@@ -285,7 +286,7 @@ homepage: http://github.com/deliveroo/routemaster-drain
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -300,9 +301,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.11
-signing_key: 
+rubygems_version: 3.0.9
+signing_key:
 specification_version: 4
 summary: Event receiver for the Routemaster bus
 test_files: