routemaster-drain 2.2.2 → 2.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1f2f159625c82cda6149dd385d892605cbbc5381
-  data.tar.gz: 4355b7da645ddcaed97629f458ea056e037f1c1f
+  metadata.gz: 1fd71f8707bbb1dcb850a267cd9d34c739848464
+  data.tar.gz: ac8e9c641add1bf27d1eee9f96d7299d6ce7f686
 SHA512:
-  metadata.gz: 38adf1dbf83ed92e88ba395cb0cd1cded85c9146d9efafe112d290171663ff7f2794440eb56173e1ea20d05ff30c0353320a834a5d0d6c826294d841028fe4da
-  data.tar.gz: 45eac309ef2f3be2339b967b5f46075f1e314a2e07bfe32a1a6b125c4035697872071e4301c644011e4570e61b7676678187a25696e9e4bac18b2b66132ad04e
+  metadata.gz: 7a248eb16c4595c21ea88f19331fd61e47e4a63b5a2a30eae0617201f4a4c854e5fc5baf8de632ab4b4ae72e2d1fa015b25305ffcdd9e988c71d4daff818adca
+  data.tar.gz: b1b5d6c5ca784b7dbd21f14a63640c78c7f1fa422fe492f0aaa9a4d2b4d84cbc93b2c701194ded0bf96f74a3a771fc6ce50eabd307ed3bc73dd3f1182ac32fb6

data/CHANGELOG.md

@@ -1,10 +1,15 @@
+### 2.3.0 (2017-01-16)
+
+- Add #has? method on HateoasResponse of identifying resource without invocation
+- Fix 404 breaking CacheAndSweep job run
+
 ### 2.2.2 (2017-01-10)
 
 - Fix logging for error responses:
   For unsuccessful responses rescue the raised error and
   send increment signal to metrics backend
 - Add Telemetry support for requests and responses
-- Add support for PATCH requests. 
+- Add support for PATCH requests.
   Invalidate cached response (if any) on PATCH
 
 ### 2.0.0 (2016-12-14)

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    routemaster-drain (2.2.2)
+    routemaster-drain (2.3.0)
       faraday (>= 0.9.0)
       faraday_middleware
       hashie

data/gemfiles/rails_3.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ../
   specs:
-    routemaster-drain (2.2.1)
+    routemaster-drain (2.3.0)
       faraday (>= 0.9.0)
       faraday_middleware
       hashie
@@ -61,7 +61,7 @@ GEM
     docile (1.1.5)
     dotenv (2.1.1)
     erubis (2.7.0)
-    faraday (0.10.0)
+    faraday (0.10.1)
       multipart-post (>= 1.2, < 3)
     faraday_middleware (0.10.1)
       faraday (>= 0.7.4, < 1.0)

data/gemfiles/rails_4.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ../
   specs:
-    routemaster-drain (2.2.1)
+    routemaster-drain (2.3.0)
       faraday (>= 0.9.0)
       faraday_middleware
       hashie
@@ -58,7 +58,7 @@ GEM
     docile (1.1.5)
     dotenv (2.1.1)
     erubis (2.7.0)
-    faraday (0.10.0)
+    faraday (0.10.1)
       multipart-post (>= 1.2, < 3)
     faraday_middleware (0.10.1)
       faraday (>= 0.7.4, < 1.0)

data/gemfiles/rails_5.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ../
   specs:
-    routemaster-drain (2.2.1)
+    routemaster-drain (2.3.0)
       faraday (>= 0.9.0)
       faraday_middleware
       hashie
@@ -71,7 +71,7 @@ GEM
     docile (1.1.5)
     dotenv (2.1.1)
     erubis (2.7.0)
-    faraday (0.10.0)
+    faraday (0.10.1)
       multipart-post (>= 1.2, < 3)
     faraday_middleware (0.10.1)
       faraday (>= 0.7.4, < 1.0)

data/lib/routemaster/drain.rb

@@ -1,5 +1,5 @@
 module Routemaster
   module Drain
-    VERSION = '2.2.2'
+    VERSION = '2.3.0'
   end
 end

data/lib/routemaster/jobs/cache_and_sweep.rb

@@ -8,7 +8,10 @@ module Routemaster
     class CacheAndSweep
       def perform(url)
         Dirty::Map.new.sweep_one(url) do
-          Cache.new.get(url)
+          begin
+            Cache.new.get(url)
+          rescue Errors::ResourceNotFound
+          end
         end
       end
     end

data/lib/routemaster/responses/hateoas_response.rb

@@ -41,6 +41,10 @@ module Routemaster
         body.reject { |key, _| ['_links'].include?(key) }
       end
 
+      def has?(link)
+        _links.has_key?(link.to_s)
+      end
+
       private
 
       def _links

data/spec/routemaster/jobs/cache_and_sweep_spec.rb

@@ -0,0 +1,26 @@
+require 'routemaster/jobs/cache_and_sweep'
+require 'spec_helper'
+
+RSpec.describe Routemaster::Jobs::CacheAndSweep do
+  subject { described_class.new }
+
+  context 'when there is an ResourceNotFound error' do
+    before do
+      expect_any_instance_of(Routemaster::Cache).to receive(:get).and_raise(Routemaster::Errors::ResourceNotFound.new(""))
+    end
+
+    it 'does not bubble up the error' do
+      expect { subject.perform('url') }.to_not raise_error
+    end
+  end
+
+  context 'when there is any other error' do
+    before do
+      expect_any_instance_of(Routemaster::Cache).to receive(:get).and_raise("boom")
+    end
+
+    it 'does bubble up the error' do
+      expect { subject.perform('url') }.to raise_error("boom")
+    end
+  end
+end

data/spec/routemaster/responses/hateoas_response_spec.rb

@@ -44,6 +44,16 @@ module Routemaster
             expect(subject.body_without_links).to eq({ 'foo' => 'bar' })
           end
         end
+
+        describe '#has?' do
+          it 'returns true for an existing link' do
+            expect(subject.has?(:resource_a)).to be_truthy
+          end
+
+          it 'returns false for a non existing link' do
+            expect(subject.has?(:other_resource)).to be_falsy
+          end
+        end
       end
     end
   end

data/spec/spec_helper.rb

@@ -2,6 +2,9 @@ require 'simplecov'
 SimpleCov.start
 
 require 'byebug'
+require 'sidekiq/testing'
+require 'dotenv'
+Dotenv.overload('.env.test')
 
 # This file was generated by the `rspec --init` command. Conventionally, all
 # specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: routemaster-drain
 version: !ruby/object:Gem::Version
-  version: 2.2.2
+  version: 2.3.0
 platform: ruby
 authors:
 - Julien Letessier
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-01-10 00:00:00.000000000 Z
+date: 2017-01-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -196,6 +196,7 @@ files:
 - spec/routemaster/jobs/backends/backend_examples.rb
 - spec/routemaster/jobs/backends/resque_spec.rb
 - spec/routemaster/jobs/backends/sidekiq_spec.rb
+- spec/routemaster/jobs/cache_and_sweep_spec.rb
 - spec/routemaster/jobs/client_spec.rb
 - spec/routemaster/middleware/authenticate_spec.rb
 - spec/routemaster/middleware/cache_spec.rb
@@ -252,6 +253,7 @@ test_files:
 - spec/routemaster/jobs/backends/backend_examples.rb
 - spec/routemaster/jobs/backends/resque_spec.rb
 - spec/routemaster/jobs/backends/sidekiq_spec.rb
+- spec/routemaster/jobs/cache_and_sweep_spec.rb
 - spec/routemaster/jobs/client_spec.rb
 - spec/routemaster/middleware/authenticate_spec.rb
 - spec/routemaster/middleware/cache_spec.rb