route_translator 3.2.4 → 4.0.0

data/test/integration/routing_test.rb

@@ -0,0 +1,22 @@
+#encoding: utf-8
+require File.expand_path('../../test_helper', __FILE__)
+
+class RoutingTest < integration_test_suite_parent_class
+
+  include RouteTranslator::ConfigurationHelper
+
+  def test_set_locale_from_params
+    config_default_locale_settings 'en'
+
+    get '/es/dummy'
+    assert_equal 'es', @response.body
+    assert_response :success
+  end
+
+  def test_mounted_apps_work_with_correct_path
+    get '/dummy_mounted_app'
+    assert_equal "Good", @response.body
+    assert_response :success
+  end
+
+end

data/test/integration/thread_safety_test.rb

@@ -0,0 +1,16 @@
+#encoding: utf-8
+require File.expand_path('../../test_helper', __FILE__)
+
+class ThreadSafetyTest < integration_test_suite_parent_class
+
+  include RouteTranslator::ConfigurationHelper
+
+  def test_i18n_locale_thread_safe
+    config_default_locale_settings 'en'
+    get '/es/dummy'
+    assert_equal 'es', @response.body
+
+    assert_equal :en, I18n.locale
+  end
+
+end

data/test/routing_test.rb

@@ -1,31 +1,29 @@
 #encoding: utf-8
-require File.expand_path(File.join(File.dirname(__FILE__), 'test_helper'))
+require File.expand_path('../test_helper', __FILE__)
 
 class PeopleController < ActionController::Base;  end
 class ProductsController < ActionController::Base;  end
 
 class TranslateRoutesTest < ActionController::TestCase
+
   include ActionDispatch::Assertions::RoutingAssertions
-  include RouteTranslator::TestHelper
+  include RouteTranslator::AssertionHelper
+  include RouteTranslator::ConfigurationHelper
+  include RouteTranslator::I18nHelper
+  include RouteTranslator::RoutesHelper
 
   def setup
+    setup_config
+    setup_i18n
     @routes = ActionDispatch::Routing::RouteSet.new
-    I18n.backend = I18n::Backend::Simple.new
-    I18n.load_path = [ File.expand_path('../locales/routes.yml', __FILE__) ]
-    I18n.reload!
   end
 
   def teardown
-    config_force_locale false
-    config_hide_locale false
-    config_generate_unlocalized_routes false
-    config_default_locale_settings("en")
-    config_generate_unnamed_unlocalized_routes false
-    config_host_locales({})
+    teardown_i18n
+    teardown_config
   end
 
   def test_unnamed_root_route
-    config_default_locale_settings 'en'
     draw_routes do
       localized do
         root :to => 'people#index'
@@ -141,8 +139,6 @@ class TranslateRoutesTest < ActionController::TestCase
   end
 
   def test_unnamed_untranslated_route
-    config_default_locale_settings 'en'
-
     draw_routes do
       localized do
         get 'foo', :to => 'people#index'
@@ -169,7 +165,6 @@ class TranslateRoutesTest < ActionController::TestCase
   end
 
   def test_unnamed_translated_route_on_non_default_locale
-    config_default_locale_settings 'en'
     draw_routes do
       localized do
         get 'people', :to => 'people#index'
@@ -181,8 +176,6 @@ class TranslateRoutesTest < ActionController::TestCase
   end
 
   def test_named_translated_route_with_prefix_must_have_locale_as_static_segment
-    config_default_locale_settings 'en'
-
     draw_routes do
       localized do
         get 'people', :to => 'people#index'
@@ -259,12 +252,9 @@ class TranslateRoutesTest < ActionController::TestCase
       end
     end
 
-    config_default_locale_settings 'en'
-
     assert_routing '/people', :controller => 'people', :action => 'index', :locale => 'en'
     assert_routing '/es/gente', :controller => 'people', :action => 'index', :locale => 'es'
 
-
     assert_helpers_include :people_en, :people_es, :people
   end
 
@@ -309,8 +299,6 @@ class TranslateRoutesTest < ActionController::TestCase
   end
 
   def test_i18n_based_translations_setting_locales
-    config_default_locale_settings 'en'
-
     draw_routes do
       localized do
         get 'people', :to => 'people#index', :as => 'people'
@@ -325,21 +313,24 @@ class TranslateRoutesTest < ActionController::TestCase
   end
 
   def test_translations_depend_on_available_locales
-    config_default_locale_settings 'en'
+    available_locales = I18n.available_locales
+    begin
+      I18n.available_locales = [:es, :en, :fr]
 
-    I18n.stub(:available_locales, [:es, :en, :fr]) do
       draw_routes do
         localized do
           get 'people', :to => 'people#index', :as => 'people'
         end
       end
-    end
 
-    assert_routing '/fr/people', :controller => 'people', :action => 'index', :locale => 'fr'
-    assert_routing '/es/gente', :controller => 'people', :action => 'index', :locale => 'es'
-    assert_routing '/people', :controller => 'people', :action => 'index', :locale => 'en'
+      assert_routing '/fr/people', :controller => 'people', :action => 'index', :locale => 'fr'
+      assert_routing '/es/gente', :controller => 'people', :action => 'index', :locale => 'es'
+      assert_routing '/people', :controller => 'people', :action => 'index', :locale => 'en'
 
-    assert_helpers_include :people_fr, :people_en, :people_es, :people
+      assert_helpers_include :people_fr, :people_en, :people_es, :people
+    ensure
+      I18n.available_locales = available_locales
+    end
   end
 
   def test_2_localized_blocks
@@ -371,8 +362,6 @@ class TranslateRoutesTest < ActionController::TestCase
   end
 
   def test_force_locale
-    I18n.locale = 'en'
-    config_default_locale_settings 'en'
     config_force_locale true
 
     draw_routes do
@@ -385,14 +374,13 @@ class TranslateRoutesTest < ActionController::TestCase
     assert_unrecognized_route '/people', :controller => 'people', :action => 'index'
     assert_equal '/en/people', @routes.url_helpers.people_en_path
     assert_equal '/en/people', @routes.url_helpers.people_path
-    I18n.locale = 'es'
-    # The dynamic route maps to the current locale
-    assert_equal '/es/gente', @routes.url_helpers.people_path
+    I18n.with_locale :es do
+      # The dynamic route maps to the current locale
+      assert_equal '/es/gente', @routes.url_helpers.people_path
+    end
   end
 
   def test_generate_unlocalized_routes
-    I18n.locale = 'en'
-    config_default_locale_settings 'en'
     config_generate_unlocalized_routes true
 
     draw_routes do
@@ -405,14 +393,14 @@ class TranslateRoutesTest < ActionController::TestCase
     assert_routing '/people', :controller => 'people', :action => 'index'
     assert_equal '/en/people', @routes.url_helpers.people_en_path
     assert_equal '/people', @routes.url_helpers.people_path
-    I18n.locale = 'es'
-    # The dynamic route maps to the default locale, not the current
-    assert_equal '/people', @routes.url_helpers.people_path
+
+    I18n.with_locale :es do
+      # The dynamic route maps to the default locale, not the current
+      assert_equal '/people', @routes.url_helpers.people_path
+    end
   end
 
   def test_generate_unnamed_unlocalized_routes
-    I18n.locale = 'en'
-    config_default_locale_settings 'en'
     config_generate_unnamed_unlocalized_routes true
 
     draw_routes do
@@ -426,28 +414,48 @@ class TranslateRoutesTest < ActionController::TestCase
     assert_equal '/en/people', @routes.url_helpers.people_en_path
     assert_equal '/en/people', @routes.url_helpers.people_path
 
-    I18n.locale = 'es'
-    # The dynamic route maps to the current locale
-    assert_equal '/es/gente', @routes.url_helpers.people_path
+    I18n.with_locale :es do
+      # The dynamic route maps to the current locale
+      assert_equal '/es/gente', @routes.url_helpers.people_path
+    end
   end
 
   def test_blank_localized_routes
-    I18n.locale = 'en'
-    config_default_locale_settings 'en'
-
     draw_routes do
       localized do
         get 'people/blank', :to => 'people#index', :as => 'people'
       end
     end
 
-    I18n.locale = 'en'
-    assert_routing '/people/blank', :controller => 'people', :action => 'index', :locale => 'en'
-    assert_equal '/people/blank', @routes.url_helpers.people_en_path
+    I18n.with_locale :en do
+      assert_routing '/people/blank', :controller => 'people', :action => 'index', :locale => 'en'
+      assert_equal '/people/blank', @routes.url_helpers.people_en_path
+    end
 
-    I18n.locale = 'es'
-    assert_routing '/es/gente', :controller => 'people', :action => 'index', :locale => 'es'
-    assert_equal '/es/gente', @routes.url_helpers.people_es_path
+    I18n.with_locale :es do
+      assert_routing '/es/gente', :controller => 'people', :action => 'index', :locale => 'es'
+      assert_equal '/es/gente', @routes.url_helpers.people_es_path
+    end
+  end
+
+  def test_path_helper_arguments
+    config_default_locale_settings 'es'
+    I18n.with_locale :es do
+      config_host_locales({ '*.es' => 'es', '*.com' => 'en' })
+
+      draw_routes do
+        localized do
+          resources :products
+        end
+      end
+
+      assert_equal '/productos',                           @routes.url_helpers.products_path
+      assert_equal '/productos/some_product',              @routes.url_helpers.product_path('some_product')
+      assert_equal '/productos/some_product?some=param',   @routes.url_helpers.product_path('some_product', :some => 'param')
+      assert_equal '/en/products',                         @routes.url_helpers.products_path(:locale => 'en')
+      assert_equal '/en/products/some_product',            @routes.url_helpers.product_path('some_product', :locale => 'en')
+      assert_equal '/en/products/some_product?some=param', @routes.url_helpers.product_path('some_product', :locale => 'en', :some => 'param')
+    end
   end
 
   def test_dont_add_locale_to_routes_if_local_param_present
@@ -467,7 +475,6 @@ class TranslateRoutesTest < ActionController::TestCase
   end
 
   def test_config_hide_locale
-    config_default_locale_settings 'en'
     config_hide_locale true
 
     draw_routes do
@@ -510,17 +517,40 @@ class TranslateRoutesTest < ActionController::TestCase
   def test_action_view_gets_locale_suffix_helper
     ActionView::Base.instance_methods.include?('locale_suffix')
   end
+
+  # See https://github.com/enriclluelles/route_translator/issues/69
+  def test_no_side_effects
+    draw_routes do
+      localized do
+        resources :people
+      end
+
+      scope "(:locale)", :locale => /(en|es)/ do
+        get '*id' => 'products#show', :as => 'product'
+      end
+    end
+
+    assert_routing '/es/gente', :controller => 'people', :action => 'index', :locale => 'es'
+    assert_routing '/people', :controller => 'people', :action => 'index', :locale => 'en'
+
+    assert_routing '/es/path/to/a/product', :controller => 'products', :action => 'show', :locale => 'es', :id => 'path/to/a/product'
+    assert_routing '/path/to/another/product', :controller => 'products', :action => 'show', :id => 'path/to/another/product'
+  end
+
 end
 
 class ProductsControllerTest < ActionController::TestCase
+
+  include RouteTranslator::ConfigurationHelper
+  include RouteTranslator::I18nHelper
   include ActionDispatch::Assertions::RoutingAssertions
-  include RouteTranslator::TestHelper
+  include RouteTranslator::RoutesHelper
 
   def setup
+    setup_config
+    setup_i18n
+
     @routes = ActionDispatch::Routing::RouteSet.new
-    I18n.backend = I18n::Backend::Simple.new
-    I18n.load_path = [ File.expand_path('../locales/routes.yml', __FILE__) ]
-    I18n.reload!
 
     config_default_locale_settings 'es'
     config_host_locales({:es => 'es'})
@@ -533,19 +563,17 @@ class ProductsControllerTest < ActionController::TestCase
   end
 
   def teardown
-    config_force_locale false
-    config_hide_locale false
-    config_generate_unlocalized_routes false
-    config_default_locale_settings("en")
-    config_generate_unnamed_unlocalized_routes false
-    config_host_locales({})
+    teardown_i18n
+    teardown_config
   end
 
   def test_url_helpers_are_included
     #doing it this way because assert_nothing_raised doesn't work on all rails versions
+    controller = ProductsController.new
+    controller.request = OpenStruct.new(:host => 'example.com') # mocking request
     %w(product_path product_url product_es_path product_es_url product_native_es_path product_native_es_url).each do |method|
       begin
-        send(method)
+        controller.send(method)
       rescue Exception => e
         raise e if e.is_a?(NameError) #swallow anything that isn't a NameError
       end

data/test/support/assertion_helper.rb

@@ -0,0 +1,27 @@
+
+module RouteTranslator
+  module AssertionHelper
+
+    def assert_helpers_include(*helpers)
+      controller = ActionController::Base.new
+      view = ActionView::Base.new
+      helpers.each do |helper|
+        ['url', 'path'].each do |suffix|
+          [controller, view].each { |obj| assert_respond_to obj, "#{helper}_#{suffix}".to_sym }
+        end
+      end
+    end
+
+    # Hack for compatibility between Rails 4 and Rails 3
+    def assert_unrecognized_route(route_path, options)
+      assert_raise ActionController::RoutingError do
+        begin
+          assert_routing route_path, options
+        rescue Minitest::Assertion => m
+          raise ActionController::RoutingError.new("")
+        end
+      end
+    end
+
+  end
+end

data/test/support/configuration_helper.rb

@@ -0,0 +1,51 @@
+
+module RouteTranslator
+  module ConfigurationHelper
+
+    def config_reset
+      config_force_locale false
+      config_hide_locale false
+      config_generate_unlocalized_routes false
+      config_generate_unnamed_unlocalized_routes false
+      config_host_locales(host_locales_config_hash)
+
+      config_default_locale_settings(:en)
+    end
+
+    alias :setup_config :config_reset
+    alias :teardown_config :config_reset
+
+    def config_default_locale_settings(locale)
+      I18n.default_locale = locale
+    end
+
+    def config_force_locale(boolean)
+      RouteTranslator.config.force_locale = boolean
+    end
+
+    def config_hide_locale(boolean)
+      RouteTranslator.config.hide_locale = boolean
+    end
+
+    def config_generate_unlocalized_routes(boolean)
+      RouteTranslator.config.generate_unlocalized_routes = boolean
+    end
+
+    def config_generate_unnamed_unlocalized_routes(boolean)
+      RouteTranslator.config.generate_unnamed_unlocalized_routes = boolean
+    end
+
+    def config_host_locales(hash)
+      RouteTranslator.config.host_locales = hash
+    end
+
+    def host_locales_config_hash
+      if RUBY_VERSION < '1.9'
+        ::ActiveSupport::OrderedHash.new
+      else
+        ::Hash.new
+      end
+    end
+
+  end
+end

data/test/support/i18n_helper.rb

@@ -0,0 +1,24 @@
+
+module RouteTranslator
+  module I18nHelper
+
+    def setup_i18n
+      @i18n_backend   = I18n.backend
+      @i18n_load_path = I18n.load_path
+
+      I18n.locale     = I18n.default_locale
+      I18n.backend    = I18n::Backend::Simple.new
+      I18n.load_path  = [ File.expand_path('../../locales/routes.yml', __FILE__) ]
+
+      I18n.reload!
+    end
+
+    def teardown_i18n
+      I18n.backend    = @i18n_backend
+      I18n.load_path  = @i18n_load_path
+
+      I18n.reload!
+    end
+
+  end
+end