route_translator 16.0.1 → 16.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a47bd0c7cfd26fdd5874b1bfd7c56236c4c371f9ba21387256f8e95ee6942dc7
-  data.tar.gz: fd3faf20805afd09e770705d8110612e1c7d68de652149a3bfb38ddd179d035d
+  metadata.gz: ce208e97dd68df337f8bd665d8e922f7a1bd0560757ac722e44c51caeabb5d35
+  data.tar.gz: c78dd9a7520d839c5066afe290dafe7d1fa6166473de0567109c5c74b613b19b
 SHA512:
-  metadata.gz: 4e5c88d328fdf31d1cc173c92d4d2c5a95048f1ba2d6113e9845a992b1263f2ce47e71b706192a24485dc49257a3f38a5c225b0176af95a5fed78c56a14d4018
-  data.tar.gz: 72b6b0f9613be540c41f1fe7570c0e5773e870a929c33783d9762a7122a2f530f01a8d49d7abc778e821d601fea697cf9813a07b0c7858638687a1317b03e6a4
+  metadata.gz: 7798fd662c28bb906c3ad125b61d616e5894557623657a8bda16ab6b0a54b2fea202fd36f214d2a4b51704ddeeba41ea1785747d892c6ba5f1cf3d08b66821e7
+  data.tar.gz: c26787fa838f3a1a315fb46b5168c34ecb720cfb09521f5d0783f27834ace2f41bbcea989eaf4fe59489b2b1ba959d7396b3db4e1ff19e93067d8420e19b07d3

data/CHANGELOG.md

@@ -1,5 +1,14 @@
 # Changelog
 
+## 16.2.0 / 2026-07-29
+
+* [ENHANCEMENT] Short-circuit host locale detection by checking `available_locales.include?` before the regex match, avoiding unnecessary regex compilation and matching for unavailable locales.
+
+## 16.1.0 / 2026-07-28
+
+* [ENHANCEMENT] Speed up drawing localized routes. `Translator.translate_name` asked the route set for `named_routes.names` (a freshly allocated array of every name defined so far) and scanned it linearly, once per route per locale. It now uses the `NamedRouteCollection#key?` hash lookup.
+* [ENHANCEMENT] Speed up drawing localized routes. `Translator::RouteHelpers.add` fetched `named_route_collection.helper_names` on every route, allocating an array of every helper defined so far and scanning it, to guard a `push` that could not take effect. `helper_names` builds a fresh array on every call, so the push was discarded, and it returns Strings while the pushed value is a Symbol, so the `include?` guard never matched either. Removing both leaves behavior unchanged.
+
 ## 16.0.1 / 2026-04-05
 
 * [ENHANCEMENT] Optimize host locale detection ([#354](https://github.com/enriclluelles/route_translator/pull/354))

data/README.md

@@ -273,7 +273,7 @@ end
 | `disable_fallback` | Create routes only for locales that have translations. For example, if we have `/examples` and a translation is not provided for `es`, the route helper of `examples_es` will not be created. Useful when one uses this with a locale route constraint, so non-`es` routes can return a `404` on a Spanish website | `false` |
 | `force_locale` |  Force the locale to be added to all generated route paths, even for the default locale |  `false` |
 | `generate_unlocalized_routes` | Add translated routes without deleting original unlocalized versions. **Note:** Autosets `force_locale` to `true` | `false` |
-| `generate_unnamed_unlocalized_routes` | Add the behavior of `force_locale`, but with a named default route which behaves as if `generate_unlocalized_routes` was `true`. `root_path` will redirect to `/en` or `/es`, depending on the value of `I18n.locale` | `false` |
+| `generate_unnamed_unlocalized_routes` | Adds per-locale named routes plus the original unlocalized mapping as an unnamed action route; it does not redirect. Like `force_locale`, it still shows the locale segment even for the default locale (for example, `/en/...`). Flat helpers (`people_path`) still dispatch to the per-locale variant via `I18n.locale`. Safe for legacy bare paths; avoid in multi-locale SEO setups unless you handle canonical URLs or redirects yourself, since both bare and locale-prefixed paths serve the same action. See [#110](https://github.com/enriclluelles/route_translator/issues/110) | `false` |
 | `hide_locale` | Force the locale to be hidden on generated route paths | `false` |
 | `host_locales` | Set `I18n.locale` based on `request.host`. Useful for apps accepting requests from more than one domain. The key is a host pattern (supports wildcards for domains, subdomains, and TLDs), and the value is the locale symbol or string to use. See below for more details and examples. | `{}` |
 | `locale_param_key` | The param key used to set the locale to the newly generated routes | `:locale` |
@@ -321,6 +321,11 @@ This is to avoid odd behaviour brought about by route conflicts and because `hos
 
 NOTE: locale from parameters has priority over the one from hosts.
 
+**Security note:** Host patterns are treated as trusted configuration.
+Never pass user input into `host_locales` keys — the wildcard `*` is
+translated to a non-greedy `.*?` regex, which can expose your application
+to ReDoS if an attacker controls the pattern.
+
 ### Translations for similar routes with different namespaces
 
 If you have routes that (partially) share names in one locale, but must be translated differently in another locale, for example:

data/lib/route_translator/host.rb

@@ -9,6 +9,10 @@ module RouteTranslator
         @lambdas ||= {}
       end
 
+      # Host patterns come from configuration, not user input.
+      # Treating them as trusted avoids a ReDoS vector — the
+      # gsub introduces non-greedy `.*?` wildcards, which are
+      # safe against backtracking only under that assumption.
       def regex_for(host_string)
         escaped = Regexp.escape(host_string).gsub(/\\\*|\\\./, '\\*' => '.*?', '\\.' => '\.?')
         Regexp.new("^#{escaped}$", Regexp::IGNORECASE)
@@ -21,7 +25,7 @@ module RouteTranslator
       available_locales = I18n.available_locales
 
       RouteTranslator.config.host_locales.find do |pattern, locale|
-        host&.match?(regex_for(pattern)) && available_locales.include?(locale&.to_sym)
+        available_locales.include?(locale&.to_sym) && host&.match?(regex_for(pattern))
       end&.last&.to_sym
     end
 

data/lib/route_translator/translator/route_helpers.rb

@@ -15,14 +15,10 @@ module RouteTranslator
       #   I18n.locale = :fr
       #   people_path -> people_fr_path
       def add(old_name, named_route_collection)
-        helper_list = named_route_collection.helper_names
-
         %w[path url].each do |suffix|
           helper_container = named_route_collection.send(:"#{suffix}_helpers_module")
           new_helper_name = :"#{old_name}_#{suffix}"
 
-          helper_list.push(new_helper_name) unless helper_list.include?(new_helper_name)
-
           helper_container.__send__(:define_method, new_helper_name) do |*args|
             __send__(Translator.route_name_for(args, old_name, suffix, self), *args)
           end

data/lib/route_translator/translator.rb

@@ -14,12 +14,12 @@ module RouteTranslator
         args_hash&.fetch(:locale, nil)
       end
 
-      def translate_name(name, locale, named_routes_names)
+      def translate_name(name, locale, named_routes)
         return if name.blank?
 
         translated_name = "#{name}_#{locale.to_s.underscore}"
 
-        translated_name if named_routes_names.exclude?(translated_name.to_sym)
+        translated_name unless named_routes.key?(translated_name)
       end
 
       def translate_options(options, locale)
@@ -67,7 +67,7 @@ module RouteTranslator
         translated_path = translate_path(route.path, locale, route.scope)
         next unless translated_path
 
-        translated_name                = translate_name(route.name, locale, route.route_set.named_routes.names)
+        translated_name                = translate_name(route.name, locale, route.route_set.named_routes)
         translated_options_constraints = translate_options_constraints(route.options_constraints, locale)
         translated_options             = translate_options(route.options, locale)
 

data/lib/route_translator/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RouteTranslator
-  VERSION = '16.0.1'
+  VERSION = '16.2.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: route_translator
 version: !ruby/object:Gem::Version
-  version: 16.0.1
+  version: 16.2.0
 platform: ruby
 authors:
 - Geremia Taglialatela
@@ -90,7 +90,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.9
+rubygems_version: 4.0.16
 specification_version: 4
 summary: Translate your Rails routes in a simple manner
 test_files: []